On Tue, Oct 18, 2016 at 11:30:29PM +0200, Pierre-Yves Kerbrat wrote:
> This patch fixes the following:
> - fix 2 block comments
> - add missing spaces around operators
> - remove unnecessary kzalloc fail message
> - fix line over 80 char
> ...
When you find yourself listing all of the different th
On Wed, Oct 19, 2016 at 01:34:44AM +0530, Shyam Saini wrote:
> On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote:
> > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote:
> > >
> > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote:
> > > >
> > > > On Mon, Oct 17, 2016 at 10:10:08PM +0530,
On Tue, Oct 18, 2016 at 06:46:05PM +, Thomas Weißschuh wrote:
> Signed-off-by: Thomas Weißschuh
I can't take patches without any changelog text, sorry.
And your subject doesn't make much sense either :(
thanks,
greg k-h
___
devel mailing list
de.
On Tue, Oct 18, 2016 at 02:03:31PM -0400, Ryan Swan wrote:
> sparse produced
> warning: incorrect type in argument 2 (different address spaces)
> expected void const volatile [noderef] *src
> got struct slic_stats *stats
>
> casting argument 2 to what is expected by memcpy_fromio() fixed this
>
>
On Wed, Oct 19, 2016 at 11:43:28AM +0800, Weibing Zhang wrote:
> Remove unnecessary header files and netlink related code as the daemons
> do not use netlink to communicate with the kernel now.
> Fix a compile warning in snprintf.
> Pthread is also not needed.
>
> Signed-off-by: Weibing Zhang
Br
The link flag pthread is not needed.
Signed-off-by: Weibing Zhang
---
tools/hv/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/hv/Makefile b/tools/hv/Makefile
index a8c4644..0d1e61b 100644
--- a/tools/hv/Makefile
+++ b/tools/hv/Makefile
@@ -1,9 +1,8 @@
# Mak
hv_kvp_daemon.c: In function ‘kvp_mac_to_if_name’:
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wformat-security]
snprintf(dev_id, sizeof(dev_id), kvp_net_dir);
^
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wfo
Remove unnecessary header files and netlink related code as the daemons
do not use netlink to communicate with the kernel now.
Signed-off-by: Weibing Zhang
---
tools/hv/hv_fcopy_daemon.c | 7 ---
tools/hv/hv_kvp_daemon.c | 7 ---
2 files changed, 14 deletions(-)
diff --git a/tools/hv/
taos_get_lux() calls mutex_trylock(). If the lock could not be acquired,
then chip->als_cur_info.lux is returned. The issue is that this value
is updated while the mutex is held and could cause a half written value
to be returned to the caller. This patch changes the call to
mutex_trylock() with mu
The return values from taos_chip_on() and taos_chip_off() was not
checked in several places. This patch adds proper error checking to
these function calls.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 25 ++---
1 file changed, 18 insertions(+), 7 dele
The sysfs attributes modifies variables that are accessed elsewhere when
a mutex is locked. Add locking to the sysfs *_store() functions to avoid
a possible race condition when measurements are taken.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 24 ++
Change the following functions to only have a single exit point:
taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
taos_gain_store(), taos_gain_available_show(), taos_luxtable_store()
and taos_probe().
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 96
Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
macros to create the device attributes.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c | 117 ++--
1 file changed, 57 insertions(+), 60 deletions(-)
diff --git a/drivers/stagi
taos_gain_store() and taos_als_calibrate() both have a code path where
-1 was returned. This patch changes the code so that a proper error code
is returned to make the code consistent with the error paths that are
present within those same functions.
Signed-off-by: Brian Masney
---
drivers/stagi
illuminance0_calibbias_store(), illuminance0_input_target_store(), and
illuminance0_calibrate_store() did not return an error code when
an invalid value was passed in. The input was checked to see if the
input was valid, however the caller would not be notified that an
invalid value was passed in.
> Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> macros to create the device attributes.
great that you work on cleaning this up!
the patch does a bit more than is claimed, it also renames stuff;
eventually, a proper prefix ('tsl2583_') should be used...
maybe you can un
On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> Change the following functions to only have a single exit point:
> taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
> taos_gain_store(), taos_gain_available_show(), taos_luxtable_store()
> and taos_probe().
>
What's the point o
On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote:
> @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct
> device *dev,
> goto luxable_store_done;
> }
>
> - if (chip->taos_chip_status == TSL258X_CHIP_WORKING)
> - taos_chip_off(i
What does illuminance0_ mean? Can we remove that?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch makes locking in visorchannel_signalempty statically deterministic.
As a result this patch fixes the sparse warning:
Context imbalance in 'visorchannel_signalempty' - different lock contexts for
basic block.
The logic of the locking code doesn't change but the layout of the original
c
On Wed, Oct 19, 2016 at 06:32:09AM -0400, Brian Masney wrote:
> @@ -778,6 +796,8 @@ static ssize_t illuminance0_lux_table_store(struct device
> *dev,
> goto luxable_store_done;
> }
>
> + mutex_lock(&chip->als_mutex);
> +
> if (chip->taos_chip_status == TSL258X_CHIP_
I appologize for laughing, but I am still secretly amused in my heart.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> > Change the following functions to only have a single exit point:
> > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(),
> > taos_gain_store(), taos_gain_available_s
Fix size field of arpc message request by using the header size and not
the pointer size.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/greybus/es2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index 8eab
On Wed, Oct 19, 2016 at 02:22:49PM +0300, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 06:32:08AM -0400, Brian Masney wrote:
> > @@ -775,14 +778,20 @@ static ssize_t illuminance0_lux_table_store(struct
> > device *dev,
> > goto luxable_store_done;
> > }
> >
> > - if (chip->ta
On Wed, Oct 19, 2016 at 01:44:25PM +0100, Rui Miguel Silva wrote:
> Fix size field of arpc message request by using the header size and not
> the pointer size.
>
> Signed-off-by: Rui Miguel Silva
Good catch, Rui. Guess the firmware is missing some sanity checks.
Reviewed-by: Johan Hovold
Than
On Wed, Oct 19, 2016 at 08:38:16AM -0400, Brian Masney wrote:
> On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote:
> > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> > > Change the following functions to only have a single exit point:
> > > taos_i2c_read(), taos_als_cal
Hello everyone,
This is a series of tests to exercise the sync kernel infrastructure. It is
meant to be a test suite for the work Gustavo has been doing to destage it.
These tests were originally part of a battery of tests shipping with
Android's libsync that were rewritten to use the new userspa
These tests are based on the libsync test suite from Android.
This commit lays the ground for future tests, as well as includes
tests for a variety of basic allocation commands.
Signed-off-by: Emilio López
---
tools/testing/selftests/Makefile | 1 +
tools/testing/selftests/sync/.gitig
These tests are based on the libsync test suite from Android.
This commit includes tests for basic fence creation.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
tools/testing/selftests/sync/sync_fence.c | 132 ++
tools/testing/self
These tests are based on the libsync test suite from Android.
This commit includes tests for basic merge operations.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
tools/testing/selftests/sync/sync_merge.c | 60 +++
tools/testing/sel
This test is based on the libsync test suite from Android.
This commit includes a stress test that invokes operations
in parallel.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
.../selftests/sync/sync_stress_parallelism.c | 111
These tests are based on the libsync test suite from Android.
This commit includes tests for waiting on fences.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile| 1 +
tools/testing/selftests/sync/sync_test.c | 1 +
tools/testing/selftests/sync/sync_wait.c | 91
On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote:
> Ok, I'll rework my patch series to stick with the direct returns. I
> personally prefer that approach. I was using the gotos since I thought
> that was standard convention in the kernel.
>
It *should* but "goto unlock;" When you can
This test is based on the libsync test suite from Android.
This commit includes a stress test that replicates a
consumer/producer pattern.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
.../testing/selftests/sync/sync_stress_consumer.c | 185
This test is based on the libsync test suite from Android.
This commit includes a test to stress merge operations.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile| 1 +
tools/testing/selftests/sync/sync_stress_merge.c | 115 +++
tools/testi
On Wed, Oct 19, 2016 at 03:54:23PM +0300, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote:
> > Ok, I'll rework my patch series to stick with the direct returns. I
> > personally prefer that approach. I was using the gotos since I thought
> > that was standard con
On Wed, Oct 19, 2016 at 12:47:13PM +0200, Peter Meerwald-Stadler wrote:
>
> > Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> > macros to create the device attributes.
>
> great that you work on cleaning this up!
>
> the patch does a bit more than is claimed, it also renames
On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> What does illuminance0_ mean? Can we remove that?
I left the names of the existing sysfs attributes intact to not break
any existing users of the driver. I'm not sure why the original author
named it that way.
Brian
__
On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> > What does illuminance0_ mean? Can we remove that?
>
> I left the names of the existing sysfs attributes intact to not break
> any existing users of the driver. I'm no
From: Wei Yongjun
Fix to return a negative error code from the es2_arpc_in_enable() error
handling case instead of 0, as done elsewhere in this function.
Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
APBridgeA RPC")
Signed-off-by: Wei Yongjun
---
drivers/staging/greybus/es
On Wed, Oct 19, 2016 at 01:17:53PM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
>
On 19-10-16, 13:44, Rui Miguel Silva wrote:
> Fix size field of arpc message request by using the header size and not
> the pointer size.
>
> Signed-off-by: Rui Miguel Silva
> ---
> drivers/staging/greybus/es2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/st
Fix in commit 880988348270 ("hv_netvsc: set nvdev link after populating
chn_table") turns out to be incomplete. A crash in
netvsc_get_next_send_section() is observed on mtu change when the device
is under load. The race I identified is: if we get to netvsc_send() after
we set net_device_ctx->nvdev
On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
> APBridgeA
> -Original Message-
> From: Weibing Zhang [mailto:atheism.zh...@gmail.com]
> Sent: Tuesday, October 18, 2016 8:43 PM
> To: KY Srinivasan ; Haiyang Zhang
>
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Weibing
> Zhang
> Subject: [PATCH] tools: hv: clean up code, remo
This simple one-line function used only once, and precvframe always not NULL.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 8
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/stag
These definitions does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
index 662
skb_pull used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 8
drivers/staging/rtl8188eu/include/rtw_recv.h | 17 -
2 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/dri
Typecasting here is unnecessary.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 10 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++-
To replace rx_tail with pkt->tail.
Now pkt->tail is equal to rx_tail and pkt->len is equal to len.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/inc
rx_end replaced with pkt->tail.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 3 ---
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 2 +-
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
4 fi
In accordance with the KISS principle.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
b/drivers/staging/rtl8188eu/os_dep/us
This function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_xmit.c| 18 --
drivers/staging/rtl8188eu/include/rtw_xmit.h | 1 -
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8
These messages are redundant.
Also break rtw_usb_if1_init function if HalData allocation failed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 +---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 4 +---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
Value of this variable always is 0.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +---
drivers/staging/rtl8188eu/hal/odm.c| 3 +--
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 19 ---
drivers/staging/rtl8188eu/hal/phy.c
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl818
This function is unused.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 17 -
drivers/staging/rtl8188eu/include/ieee80211.h | 3 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
b/drivers/stagin
Return value of this function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
len replaced with pkt->len.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 14 +++---
drivers/staging/rtl8188eu/core/rtw_recv.c| 23 +--
drivers/staging/rtl8188eu/core/rtw_security.c| 6 +++---
drivers/staging/rtl8188eu
fw_state member of mlme_priv
never obtain WIFI_MP_STATE value.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 5 ---
drivers/staging/rtl8188eu/core/rtw_recv.c | 42 +-
drivers
Also SCAN_RESULT_TYPE enum removed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 188 ---
1 file changed, 188 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h
b/drivers/staging/rtl8188eu/include/rtw_mlme.h
index d2
rx_data replaced with pkt->data.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 38 -
drivers/staging/rtl8188eu/core/rtw_recv.c| 54
drivers/staging/rtl8188eu/core/rtw_security.c| 6 +--
drivers/staging/rtl
To replace rx_data with pkt->data.
Now pkt->data is equal to rx_data.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
inde
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl818
These functions are unused.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h
b/drivers/staging/rtl8188eu/include/rtw_mlme.h
index 47a3f2d..d27b2ad 100
skb_trim used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 8 +---
drivers/staging/rtl8188eu/include/rtw_recv.h | 16
2 files changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/driv
Value of rx_head used only to produce debug output.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++--
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
3 files changed, 2 insertions(+), 4 delet
is2t argument of this function is constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 101 +++-
1 file changed, 6 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/rtl8188eu/hal/phy.c
in
Value of this member does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 7 ---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 -
drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 -
3 files changed, 9 deletions(-)
diff --git a/drivers/staging/r
Remove is_path_a_on and is2t arguments.
These argument always are constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/rtl8188eu/hal
is2t is constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/rtl8188eu/hal/phy.c
index 6b70d09..93dbb395 100644
--- a/drivers
rx_end replaced with pkt->end.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 3 +--
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++--
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git
This function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 27 --
drivers/staging/rtl8188eu/include/ieee80211.h | 1 -
2 files changed, 28 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
b/dri
Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023.
This stripping procedure placed into new strip_iv_icv function.
Also strip_iv_icv used inside unprotect_frame.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 27 +++
drivers/
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl818
Driver does not use this definitions.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/wifi.h | 73
1 file changed, 73 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/include/wifi.h
index 9e08e68..
netdev_alloc_skb function
already set dev member of pkt_copy.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
i
is2t local variable always is false.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 57 +
1 file changed, 1 insertion(+), 56 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/rtl8188eu/hal/phy.c
index 8462
skb_put used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 17 -
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 2 +-
3 files changed, 2 insertions(+), 19 deletions(-)
di
Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023.
Calculate it locally.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 26 --
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 --
2 files changed, 20 insertions(+), 8 deletio
is_multicast_ether_addr used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 3 +--
drivers/staging/rtl8188eu/include/ieee80211.h | 11 ---
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
This member used only as local variable.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 --
drivers/staging/rtl8188eu/core/rtw_mlme.c | 11 +--
drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 -
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in cfg80211.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.
Replace CamelCase define to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 2 +-
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x
Replace CamelCase struct name and fields with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 6 +++---
drivers/staging/wlan-ng/prism2mgmt.c | 8
2 files changed, 7 insertions(+), 7 deletions(-)
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in hfa384x_usb.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/h
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wl
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wl
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wl
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wl
sizeof(var) instead of sizeof(struct XXX) is preferred.
It also fix the following checkpatch.pl script warning:
WARNING: line over 80 characters
Fix this two in prism2mgmt.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
1 file changed, 1 insertion(+),
This patchset fix CamelCases in hfa384x.h header file.
This file is free of CamelCases now.
Sergio Paracuellos (12):
staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint
staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data
staging: wlan-ng: avoid CamelCase: hfa384x_WPAData
This patchset fix CamelCases in hfa384x.h header file.
This file is free of CamelCases now.
This patch series are resent because an mix error in the previous sent.
Sergio Paracuellos (12):
staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint
staging: wlan-ng: avoid CamelCase: hfa384x_H
Replace CamelCase struct name and fields with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 6 +++---
drivers/staging/wlan-ng/prism2mgmt.c | 8
2 files changed, 7 insertions(+), 7 deletions(-)
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wl
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix them in p80211netdev.c
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/stag
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/stag
sizeof(*var) instead of sizeof(struct XXX) is preferred.
Fix it in p80211conv.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211conv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.c
b/drivers/staging/wlan-ng/p8
1 - 100 of 130 matches
Mail list logo
