On Mon, Sep 26, 2016 at 11:56:27AM -0300, Martin wrote:
> Fix coding style issue "multiple blank lines"
> detected by checkpatch.pl in threefish_block.c file.
>
> Signed-off-by: Martin
This Signed-off-by are like a legal document. Use first and last name.
Also fix your from header as well.
re
This patch fixes the following blank line issues:
CHECK: Please don't use multiple blank lines
CHECK: Please use a blank line after function/struct/union/enum declarations
+}
+RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup);
Signed-off-by: Yannis Damigos
---
drivers/staging/android/i
This patch fixes the following whitespace issue:
CHECK: spaces preferred around that '*' (ctx:VxV)
FILE: drivers/staging/android/ion/ion_of.c:91:
+sizeof(struct ion_platform_heap)*num_heaps,
Signed-off-by: Yannis Damigos
---
drivers/staging/android/ion/ion_of.c | 2 +
This patch fixes the following comparison with NULL issues:
CHECK: Comparison to NULL could be written "compatible[i].name"
+ for (i = 0; compatible[i].name != NULL; i++) {
CHECK: Comparison to NULL could be written "!compatible[i].name"
+ if (compatible[i].name == NULL)
Signed-off-b
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert
---
drivers/staging/greybus/manifest.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybu
On Mon, Sep 26, 2016 at 2:05 AM, Chase Metzger wrote:
> Removed braces for single line if statement.
>
> Signed-off-by: Chase Metzger
> ---
> drivers/staging/greybus/gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging
On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
wrote:
> Checkpatch printed a style ERROR concerning a missing space befire '('.
> This patch fix this issue.
>
> Signed-off-by: Quentin Lambert
> ---
> drivers/staging/greybus/manifest.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Sat, Sep 24, 2016 at 11:06 PM, Vaibhav Agarwal wrote:
> Currently, if info is null, the dev_err message is dereferencing an
> uninitialized module pointer. Instead, it should use codec->dev pointer
> in dev_err call and better align with other err msg in this function.
>
> Also, ret variable m
On 27/09/2016 11:31, Viresh Kumar wrote:
On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
wrote:
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert
---
drivers/staging/greybus/manifest.c |2 +-
1 file chan
Checkpatch printed a style ERROR concerning a missing space before '('.
This patch fixes this issue.
Signed-off-by: Quentin Lambert
Acked-by: Viresh Kumar
---
v2: fixes typos in commit message
drivers/staging/greybus/manifest.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/
On 27 September 2016 at 15:03, Quentin Lambert
wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
>>
>> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
>> wrote:
>>>
>>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>>> This patch fix this issue.
>>>
>>> Signed-off-b
On Tue, Sep 27, 2016 at 11:33:49AM +0200, Quentin Lambert wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
> >On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> > wrote:
> >>Checkpatch printed a style ERROR concerning a missing space befire '('.
> >>This patch fix this issue.
> >>
> >>Signed
You guys are sending good patches these days. You seem to have the
process down.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Sep 26, 2016 at 10:50:50AM -0400, James Simmons wrote:
> From: wang di
>
> The port to upstream dropped handling the LMV_MAGIC_V1
> case for ll_dir_getstripe. This adds it back.
>
> Signed-off-by: wang di
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
> Reviewed-on: http://r
On Mon, Sep 26, 2016 at 02:48:24PM -0300, Martin Alonso wrote:
> Fix coding style issue "spaces preferred around '+'
> detected by checkpatch.pl in dpc.c file.
>
> Signed-off-by: Martin Alonso
> ---
> drivers/staging/vt6656/dpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> d
On Mon, Sep 26, 2016 at 07:37:27PM -0500, Darryl T. Agostinelli wrote:
> checkpatch.pl repairs:
> corrected: statements should start on a tabstop
> corrected: block comments use * on subsequent lines
> corrected: use a blank line after function/struct/union/enum declarations
That's multiple differ
On Mon, Sep 26, 2016 at 06:39:15PM +0100, Ramiro Oliveira wrote:
> This patch corrects a misalligned * in a block comment warning found by
> checkpatch.pl
>
> Signed-off-by: Ramiro Oliveira
> ---
> drivers/staging/dgnc/dgnc_cls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does not
On Tue, Sep 27, 2016 at 01:10:04PM +0200, Greg KH wrote:
> On Mon, Sep 26, 2016 at 02:48:24PM -0300, Martin Alonso wrote:
> > Fix coding style issue "spaces preferred around '+'
> > detected by checkpatch.pl in dpc.c file.
> >
> > Signed-off-by: Martin Alonso
> > ---
> > drivers/staging/vt6656/d
On 9/27/2016 12:13 PM, Greg KH wrote:
> On Mon, Sep 26, 2016 at 06:39:15PM +0100, Ramiro Oliveira wrote:
>> This patch corrects a misalligned * in a block comment warning found by
>> checkpatch.pl
>>
>> Signed-off-by: Ramiro Oliveira
>> ---
>> drivers/staging/dgnc/dgnc_cls.c | 2 +-
>> 1 file ch
Change permissions from symbolic to octal.
Signed-off-by: Ramiro Oliveira
---
drivers/staging/android/lowmemorykiller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/lowmemorykiller.c
b/drivers/staging/android/lowmemorykiller.c
index 80d7adf..03
Hi,
El 27/09/16 a las 01:23, Michael Ellerman escribió:
Emilio López writes:
El 22/09/16 a las 06:43, Michael Ellerman escribió:
Emilio López writes:
Please don't include the *kernel* headers, they're really not meant to
be used in userspace programs :)
+CFLAGS += -I../../../../usr/includ
Larry Finger wrote:
> Only rtl8821ae implements WOWLAN; however, the other drivers may receive
> a call requesting information about this mode. The other drivers need to
> ignore the request rather than logging that the default branch of the
> switch statement has been reached.
>
> Reported by: J
On Mon, Sep 26, 2016 at 11:02:33AM -0700, Joe Perches wrote:
> On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> > Fix coding style issue "spaces preferred around '+'
> > detected by checkpatch.pl in dpc.c file.
> []
> > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc
This patch fixes the following checkpatch.pl warning in p80211netdev.h:
WARNING: do not add new typedefs
It applies for typedef p80211_frmrx_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
This patch fixes the following checkpatch.pl warning in p80211netdev.h:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.h
b/
This patchset fix all remaining warnings reported by checkpatch.pl script for
p80211netdev.h header file:
- WARNING: do not add new typedefs
- WARNING: line over 80 characters
Sergio Paracuellos (3):
staging: wlan-ng: avoid new typedef: netdevice_t
staging: wlan-ng: avoid new typedef: p80211_
This patch fixes the following checkpatch.pl warning in p80211netdev.h:
WARNING: do not add new typedefs
It applies for typedef netdevice_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211conv.c | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 38 +
Private functions in ks7010_sdio.c can be declared static.
Fixes sparse warnings 'was not declared. Should it be static?'.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/
On Mon, 2016-09-26 at 22:02 +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
[]
> diff --git a/drivers/staging/android/lowmemorykiller.c
> b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
> * not really modular, but th
Change the type and uses of rx_rate.
Signed-off-by: Martin Alonso
---
drivers/staging/vt6656/dpc.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
index 655f000..782b7d7 100644
--- a/drivers/staging/vt6656/d
As suggested by Joe Perches, rx_sts is not
used anywhere and could be removed.
Signed-off-by: Martin Alonso
---
drivers/staging/vt6656/dpc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
index c352c70..655f000 10
From: Tim Sell
Several implicit unsigned --> signed int conversions were corrected.
No runtime effects were observed here, nevertheless implicit conversions
between integral types can lead to unexpected behavior.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys
From: Tim Sell
Previously, the lines describing devices controlled by the visorinput,
visornic, and visorhba drivers (keyboard, mouse, ultravnic, sparvhba) would
be missing from the vbus channel header. This is important info that is
collected as part of s-Par livedumps, and can be examined via
From: Tim Sell
Example corrected output:
$ pwd
/sys/bus/visorbus/devices/visorbus1
$ cat client_bus_info
Client device / client driver info for s-Par Console partition
(vbus #1):
chipset visorchipsetkerne
During additional testing it was noticed that additional data was missing
from the s-Par livedump. This series corrects the problem.
Tim Sell (3):
staging: unisys: visorbus: fix sloppy unsigned/signed int conversions
staging: unisys: visorbus: fix vbus info generated for s-Par livedumps
stag
On Wed, Sep 14, 2016 at 07:10:01PM -0700, Long Li wrote:
> From: Long Li
>
> hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
> from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
> already removed before the call, so we don't need to resca
Fix two net drivers that declared enum constants that conflict with enum
constants in linux/leds.h
Create function that encapsulates actions taken during the adjust phy link step
of phy state changes.
Add support for led triggers on phy link state changes by adding
a config option. When set the c
During phy state machine state transitions some set of actions should
occur whenever the link state changes. These actions should be
encapsulated into a single function.
This patch adds the phy_adjust_link function, which is called whenever
phydev->adjust_link would have been called before. Action
From: Josh Cartwright
Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
create a set of led triggers for each instantiated PHY device. There is
one LED trigger per link-speed, per-phy.
This allows for a user to configure their system to allow a set of LEDs
to represent link state
Adding led support for phy causes namespace conflicts for some
phy drivers.
The rtl871 driver declared an enum for representing LED states. The enum
contains constant LED_OFF which conflicted with declaration found in
linux/leds.h. LED_OFF changed to LED_STATE_OFF
In order to avoid a possible futu
Adding led support for phy causes namespace conflicts for some
phy drivers.
The marvel skge driver declared an enum for representing the states of
Link LED Register. The enum contained constant LED_OFF which conflicted
with declartation found in linux/leds.h.
LED_OFF changed to LED_REG_OFF
Signed
Thanks for pointing that out.
If you don't mind, I will also add "Tested-by: Cathy Avery ".
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of Cathy Avery
> Sent: Friday, September 23, 2016 4:59 AM
> To: driverdev-devel@linuxdriverpro
> -Original Message-
> From: Bjorn Helgaas [mailto:helg...@kernel.org]
> Sent: Tuesday, September 27, 2016 12:30 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas ;
> de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Long Li
>
fixed use a blank line after function/struct/union/enum declarations
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtllib_tx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl8192e/rtllib_tx.c
index 43ca90d..78a3a
fixed statements should start on a tabstop
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtllib_tx.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl8192e/rtllib_tx.c
index 04
fixed block comments use * on subsequent lines
Signed-off-by: Darryl T. Agostinelli
---
drivers/staging/rtl8192e/rtllib_tx.c | 54 ++--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl8192e
On Tue, Sep 27, 2016 at 02:42:22PM -0400, David Kershner wrote:
> From: Tim Sell
>
> Previously, the lines describing devices controlled by the visorinput,
> visornic, and visorhba drivers (keyboard, mouse, ultravnic, sparvhba) would
> be missing from the vbus channel header. This is important i
47 matches
Mail list logo
