Re: [PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t

On Fri, Sep 23, 2016 at 03:45:21PM +0200, Sergio Paracuellos wrote: > This patch fixes the following checkpatch.pl warning in p80211types.h: > WARNING: do not add new typedefs > > It applies for typedef p80211pstrd_t > > Signed-off-by: Sergio Paracuellos This patch doesn't apply to the tree, so

[PATCH 2/3] staging: iio: isl29018: made error handling consistent

Changed the processing of IIO_CHAN_INFO_INT_TIME in isl29018_write_raw() to unlock the mutex and return at the end of the function if invalid input is passed in. This makes the error handling code consistent with the processing of IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_SCALE within the same fun

[PATCH 1/3] staging: iio: isl29018: remove unused variable and defines

Removes unused variable and associated #defines that was found using make W=1. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c index 76

[PATCH 3/3] staging: iio: isl29018: fix comparison between signed and unsigned integers

Fixes warning found by make W=2: warning: comparison between signed and unsigned integer expressions Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drive

[PATCH v2 10/17] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr6_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- drive

[PATCH v2 04/17] staging: wlan-ng: avoid new typedef: p80211pstr14_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr14_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH v2 03/17] staging: wlan-ng: avoid new typedef: p80211pstr6_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr6_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH v2 05/17] staging: wlan-ng: avoid new typedef: p80211pstr32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.h | 2 +- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 2 files changed,

[PATCH v2 00/17] staging: wlan-ng: fix some style issues in p80211types.h

This patchset fix some style issues reported by checkpatch.pl script. Changes V2: - Fix come patches because it doesn¡ t apply correctly to linux tree Sergio Paracuellos (17): staging: wlan-ng: avoid new typedef: p80211pstrd_t staging: wlan-ng: avoid new typedef: p80211pstr255_t staging: wl

[PATCH v2 14/17] staging: wlan-ng: avoid new typedef: p80211item_unk392_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk392_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++-- drivers/staging/wlan-ng/p80211netdev.c | 2 +- driver

[PATCH v2 02/17] staging: wlan-ng: avoid new typedef: p80211pstr255_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstr255_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH v2 11/17] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr14_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 2 +- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 2 file

[PATCH v2 13/17] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr255_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 01/17] staging: wlan-ng: avoid new typedef: p80211pstrd_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstrd_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 4 ++-- drivers/staging/wlan-ng/p80211types.h | 4 ++-- drivers/staging/wl

[PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211itemd_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 2 +- drivers/staging/wlan-ng/p80211types.h | 4 ++-- drivers/staging/wlan-n

[PATCH v2 06/17] staging: wlan-ng: avoid new typedef: p80211macarray_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211macarray_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH v2 07/17] staging: wlan-ng: avoid new typedef: p80211item_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 09/17] staging: wlan-ng: avoid new typedef: p80211item_uint32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_uint32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 8 +- drivers/staging/wlan-ng/p80211metastruct.h | 224

[PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_pstr32_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211metastruct.h | 8

[PATCH v2 17/17] staging: wlan-ng: fix block comments style errors

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211types.h | 135 +- 1 file changed, 68 insertions(+), 67 deletions(-)

[PATCH v2 16/17] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk4096_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 4 ++-- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 2 f

[PATCH v2 15/17] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t

This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211item_unk1024_t Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metastruct.h | 2 +- drivers/staging/wlan-ng/p80211types.h | 4 ++-- 2 fil

Re: [PATCH 1/3] staging: iio: isl29018: remove unused variable and defines

On 25/09/16 12:41, Brian Masney wrote: > Removes unused variable and associated #defines that was found using > make W=1. > > Signed-off-by: Brian Masney Hmm. Must have gotten left over from some refactoring that generates these strings on the fly. Applied to the togreg branch of iio.git - initi

Re: [PATCH 2/3] staging: iio: isl29018: made error handling consistent

On 25/09/16 12:41, Brian Masney wrote: > Changed the processing of IIO_CHAN_INFO_INT_TIME in isl29018_write_raw() > to unlock the mutex and return at the end of the function if invalid > input is passed in. This makes the error handling code consistent with > the processing of IIO_CHAN_INFO_CALIBSC

Re: [PATCH 3/3] staging: iio: isl29018: fix comparison between signed and unsigned integers

On 25/09/16 12:41, Brian Masney wrote: > Fixes warning found by make W=2: > warning: comparison between signed and unsigned integer expressions > > Signed-off-by: Brian Masney This one is pretty marginal on whether it is worth while given it is easy to verify that it doesn't matter in any of thes

[PATCH -next] staging: most: fix error return code in audio_probe_channel()

From: Wei Yongjun Fix to return a negative error code from the audio_set_hw_params() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/staging/most/aim-sound/sound.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH] [PATCH] staging: dgnc: Fix comment alignment

As reported by checkpatch. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 4e1e0dc6..aedca66 100644 --- a/drivers/staging/dgnc/dgnc_c

Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the audio_set_hw_params() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- > drivers/staging/most/aim-sound/

[PATCH 1/2] include: linux: iio: add IIO_DEVICE_ATTR_{RO, WO, RW} macros

Add three new macros: IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce the amount of boiler plate code that is needed for creating new attributes. This mimics the *_RO, *_WO, and *_RW macros that are found in include/linux/device.h and include/linux/sysfs.h. Signed-off-by: B

[PATCH 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/light/isl2901

Re: [PATCH 1/2] include: linux: iio: add IIO_DEVICE_ATTR_{RO, WO, RW} macros

On Sun, Sep 25, 2016 at 01:29:58PM -0400, Brian Masney wrote: > Add three new macros: IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and > IIO_DEVICE_ATTR_RW to reduce the amount of boiler plate code that > is needed for creating new attributes. This mimics the *_RO, *_WO, > and *_RW macros that are found

[PATCH v2 2/2] staging: iio: isl29018: use IIO_DEVICE_ATTR_{RO, RW} macros

Use the IIO_DEVICE_ATTR_RO and IIO_DEVICE_ATTR_RW macros to create the device attributes. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/light/isl2901

[PATCH v2 1/2] include: linux: iio: add IIO_ATTR_{RO, WO, RW} and IIO_DEVICE_ATTR_{RO, WO, RW} macros

Add new macros: IIO_ATTR_RO, IIO_ATTR_WO, IIO_ATTR_RW, IIO_DEVICE_ATTR_RO, IIO_DEVICE_ATTR_WO and IIO_DEVICE_ATTR_RW to reduce the amount of boiler plate code that is needed for creating new attributes. This mimics the *_RO, *_WO, and *_RW macros that are found in include/linux/device.h and include

[PATCH] staging: sm750fb: rename getChipType to sm750_get_chip_type

Rename CamelCased function getChipType to sm750_get_chip_type (prefex with sm750 in order to make the context of the function clear). This issue was found by checkpatch.pl Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 16 drivers/staging/sm750fb/ddk750

[PATCH] drivers/staging/greybus: gpio.c - Fixed a checkpatch generated warning

Removed braces for single line if statement. Signed-off-by: Chase Metzger --- drivers/staging/greybus/gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index ea8234a..5e06e42 100644 --- a/drivers/staging/g

[PATCH, TRIVIAL] Fixed block comment coding style

Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit. Please let me know of any feedback you have. Thanks, Gonçalo Salazar Signed-off-by: Gonçalo Salazar --- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH, TRIVIAL] Fixed block comment coding style

On 09/25/2016 04:18 PM, Gonçalo Salazar wrote: Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit. Please let me know of any feedback you have. Thanks, Gonçalo Salazar Your subject heeds to specify which driver is involved. In addition, fixes for st

[PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit. Resubmitted with updated subject. Please let me know of any feedback you have. Thanks, Gonçalo Salazar Signed-off-by: Gonçalo Salazar --- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1

Re: [PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

2016-09-23 21:15 GMT+09:00 Greg KH : > On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote: >> The channel array in board_t was initialized in dgnc_found_board() >> with NULL. But the channel is going to initialize in dgnc_tty_init() >> again. So the channel array doesn't need to set NULL

[PATCH 01/11 V2 RESEND] staging: dgnc: remove redundant initialization for channel array

The channel array in board_t was initialized in dgnc_found_board() with NULL. But the channel is going to initialize in dgnc_tty_init(). So the channel array doesn't need to set NULL for initailization. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some pat

[PATCH 02/11 RESEND] staging: dgnc: remove useless message buffer

There is a temporary message buffer for the boot message in dgnc_found_board() but the buffer was not used anywhere in dgnc driver. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. drivers/staging/dgnc/dgnc_driver.c | 2

[PATCH 03/11 V2 RESEND] staging: dgnc: missing NULL check for ioremap in dgnc_do_remap()

The ioremap() function can be failed, so it need to have error handling in dgnc_do_remap(). And also the return type of dgnc_do_remap() should be changed from "void" to "int" Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sen

[PATCH 04/11] staging: dgnc: kfree for board structure in dgnc_found_board()

The board structure should be freed when any function was failed in dgnc_found_board(). And the board strucure will be stored into dgnc_board array when the dgnc_found_board() function has no error. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches

[PATCH 05/11 V2 RESEND] staging: dgnc: move functions unrelated with dgnc_found_board()

The functions related with tty device initialization are needed to be moved from dgnc_found_board() to dgnc_init_one(). Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. V2: The subject line was cut off, I put it complete

[PATCH 06/11 RESEND] staging: dgnc: introduce the dgnc_tty_unregister()

The dgnc_tty_unregister() will be called when the dgnc_tty_register() is failed. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. drivers/staging/dgnc/dgnc_driver.c | 7 +-- drivers/staging/dgnc/dgnc_tty.c| 8 ++

[PATCH 08/11 RESEND] staging: dgnc: introduce the dgnc_free_irq()

The dgnc_free_irq() will free the requested IRQ from the dgnc_request_irq(). Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. drivers/staging/dgnc/dgnc_driver.c | 11 ++- 1 file changed, 10 insertions(+), 1 dele

[PATCH 07/11 V2 RESEND] staging: dgnc: rename dgnc_finalize_board_init() to dgnc_request_irq()

The dgnc_finalize_board_init() function has only job for requesting the IRQ. It should be renamed to dgnc_request_irq() Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. V2: The subject line was cut off, I put it complete

[PATCH 09/11 V2 RESEND] staging: dgnc: rename dgnc_tty_uninit() to dgnc_cleanup_tty()

The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all. And also the dgnc_cleanup_tty() is only called for exiting the module. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because I missed some patches when the V2 patches sent. V2: The subject line was cut off, I

[PATCH 10/11 RESEND] staging: dgnc: remove useless variables

The dgnc_major_serial_registered and dgnc_major_serial_registered do not need to use to check whether the tty driver is registered or not. These variables are used only in dgnc_cleanup_tty() function, This function will be called normally with initialized board structure. It means the dgnc_cleanup_

[PATCH 11/11 RESEND] staging: dgnc: introduce find_board_by_major()

It was used to get a board structure with dgnc_BoardsByMajor array. But this driver already has the array for managing initialized board as dgap_board[]. It can be used for searching the board structure by major number. Signed-off-by: Daeseok Youn --- RESEND: send the whole series again. Because

Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

On 09/25/2016 06:00 PM, Gonçalo Salazar wrote: Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit. Resubmitted with updated subject. Please let me know of any feedback you have. I missed this last time, but everything above the --- line goes into the

[PATCH] Staging: android: fixed permissions style issue

Fixed a coding style issue. Changed symbolic permissions to octal. Signed-off-by: Eric Salem --- drivers/staging/android/lowmemorykiller.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykil

Re: [PATCH] Staging: android: fixed permissions style issue

On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote: > Fixed a coding style issue. Changed symbolic permissions to octal. If you do these, please shorten the lines where possible. > diff --git a/drivers/staging/android/lowmemorykiller.c > b/drivers/staging/android/lowmemorykiller.c [] > @@ -204,

[PATCH v2] Staging: android: fixed permissions style issue

Fixed a coding style issue. Changed symbolic permissions to octal. Signed-off-by: Eric Salem --- drivers/staging/android/lowmemorykiller.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemoryki

[PATCH] staging: rtl8192e: fixed block comments should align the * on each line

Signed-off-by: Darryl T. Agostinelli --- drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c index 29cefb5..d437a8e 100644 --- a/dr