On Fri, Sep 23, 2016 at 06:46:55AM +0200, Sergio Paracuellos wrote:
> This patch fixes the following checkpatch.pl warning in p80211types.h:
> WARNING: do not add new typedefs
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/wlan-ng/cfg80211.c | 12 +-
> drivers/staging/wla
From: Yannis Damigos
This patch fixes the following comparison with NULL issues:
CHECK: Comparison to NULL could be written "compatible[i].name"
+ for (i = 0; compatible[i].name != NULL; i++) {
CHECK: Comparison to NULL could be written "!compatible[i].name"
+ if (compatible[i].name
From: Yannis Damigos
This patch removes the return statement of void function
WARNING: void function return statements are not generally useful
+ return;
+}
Signed-off-by: Yannis Damigos
---
drivers/staging/android/ion/ion_of.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/
From: Yannis Damigos
This patch fixes the following whitespace issues:
CHECK: Alignment should match open parenthesis
+int ion_parse_dt_heap_common(struct device_node *heap_node,
+ struct ion_platform_heap *heap,
CHECK: Alignment should match open parenthesis
+ pr_in
From: Yannis Damigos
This patch fixes the following blank line issues:
CHECK: Please don't use multiple blank lines
+
+
CHECK: Please use a blank line after function/struct/union/enum
declarations
+}
+RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup);
Signed-off-by: Yannis Damigos
---
From: Yannis Damigos
This patch fixes the following switch statement indentation issue:
ERROR: switch and case should be at the same indent
+ switch (heap->type) {
+ case ION_HEAP_TYPE_CARVEOUT:
+ case ION_HEAP_TYPE_CHUNK:
[...]
+ default:
Signed-
On Thu, 2016-09-22 at 20:01 +0200, Jannik Becher wrote:
> changed comparison "wlandev == NULL" to "!wlandev" to obtain the coding
> style.
Hello.
Please always use Greg KH's latest staging-next branch (or -next)
to make these sorts of changes. This one has already been done.
https://git.kernel.
On Fri, Sep 23, 2016 at 11:05:17AM +0300, giannis.dami...@gmail.com wrote:
> From: Yannis Damigos
>
> This patch removes the return statement of void function
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> Signed-off-by: Yannis Damigos
> ---
> d
On 23/09/16 06:37, Borislav Petkov wrote:
On Thu, Sep 22, 2016 at 08:23:36PM +0200, Paolo Bonzini wrote:
Unless this is part of some spec, it's easier if things are the same in
SME and SEV.
Yeah, I was pondering over how sprinkling sev_active checks might not be
so clean.
I'm wondering if we
On Fri, Sep 23, 2016 at 09:33:00PM +1200, Kai Huang wrote:
> How is this even possible? The spec clearly says under SEV only in long mode
> or PAE mode guest can control whether memory is encrypted via c-bit, and in
> other modes guest will be always in encrypted mode.
I was suggesting the hypervi
This patch removes the empty function rmem_ion_device_release
Signed-off-by: Yannis Damigos
---
drivers/staging/android/ion/ion_of.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.c
b/drivers/staging/android/ion/ion_of.c
index 49f052c..91c0642 10064
From: Colin Ian King
Currently, if info is null, the dev_err message is dereferencing an
uninitialized module pointer. Instead, initialize module before the
dev_err call to fix this issue.
Found using static analysis with cppcheck:
[drivers/staging/greybus/audio_topology.c:175]: (error)
Unini
Hi,
You seem to be missing the Reported-by tag.
That's xiaof...@redhat.com.
Cathy
On 09/14/2016 10:10 PM, Long Li wrote:
From: Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote:
> This patch removes the empty function rmem_ion_device_release
>
> Signed-off-by: Yannis Damigos
> ---
> drivers/staging/android/ion/ion_of.c | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/android/i
On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote:
> This patch allows to call the write() function for synchronous and
> isochronous channels with buffers of any size. The AIM simply waits for
> data to fill up the MOST buffer object according to the network interface
> controller sp
On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote:
> Rename CamelCased function getChipType to get_chip_type.
> This issue was found by checkpatch.pl
As this is a global function, can you rename it to something like
"sm750_get_chip_type()"? Having a driver-specific function called
get_c
On Thu, Sep 22, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote:
> This patchset fix several style warnings reported by checkpatch.pl script.
>
> Sergio Paracuellos (8):
> staging: rts5208: fix style warnings in rtsx.h
> staging: rts5208: fix style warnings in rtsx.c
> staging: rts5208: f
On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote:
> The channel array in board_t was initialized in dgnc_found_board()
> with NULL. But the channel is going to initialize in dgnc_tty_init()
> again. So the channel array doesn't need to set NULL
> for initailization in dgnc_found_board()
On Thu, Sep 22, 2016 at 10:38:13PM +0200, Christopher Pezley wrote:
> The preferred indentation for cases and switches has the cases at the same
> level as the switch.
Please wrap your changelog text at 72 columns like git tried to get you
to do :)
thanks,
greg k-h
_
On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.dami...@gmail.com wrote:
> From: Yannis Damigos
>
> This patch fixes the following whitespace issues:
>
> CHECK: Alignment should match open parenthesis
> +int ion_parse_dt_heap_common(struct device_node *heap_node,
> + struct
On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote:
> From: Yannis Damigos
>
> This patch fixes the following blank line issues:
>
> CHECK: Please don't use multiple blank lines
> +
> +
What does that mean with the + + lines?
>
> CHECK: Please use a blank line after fun
On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote:
> This patch removes the empty function rmem_ion_device_release
>
> Signed-off-by: Yannis Damigos
> ---
> drivers/staging/android/ion/ion_of.c | 7 ---
> 1 file changed, 7 deletions(-)
Please just resend the whole series for th
On Fri, 23 Sep 2016 14:08:51 +0200
Greg KH wrote:
> On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote:
> > This patch allows to call the write() function for synchronous and
> > isochronous channels with buffers of any size. The AIM simply waits
> > for data to fill up the MOST buff
We get 4 warnings when building kernel with W=1:
drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous
prototype for 'ion_carveout_allocate' [-Wmissing-prototypes]
drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no previous
prototype for 'ion_carveout_free' [-
This patch allows to call the write() function for synchronous and
isochronous channels with buffers of any size. The AIM simply waits for
data to fill up the MOST buffer object according to the network interface
controller specification for streaming channels, before it submits the
buffer to the H
On Fri, Sep 23, 2016 at 02:49:28PM +0200, Christian Gromm wrote:
> On Fri, 23 Sep 2016 14:08:51 +0200
> Greg KH wrote:
>
> > On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote:
> > > This patch allows to call the write() function for synchronous and
> > > isochronous channels with bu
We get 1 warning when building kernel with W=1:
drivers/staging/ks7010/ks_wlan_net.c:3520:5: warning: no previous prototype for
'ks_wlan_reset' [-Wmissing-prototypes]
In fact, these functions are unused in
ks_wlan_net.c, but should be removed.
So this patch removes the unused function.
Signed-o
We get 3 warnings when building kernel with W=1:
drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for
'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for
'ks_wlan_hw_sleep_wakeup_request' [-
On Fri, Sep 23, 2016 at 3:17 PM, Greg KH wrote:
> On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote:
>> From: Yannis Damigos
>>
>> This patch fixes the following blank line issues:
>>
>> CHECK: Please don't use multiple blank lines
>> +
>> +
>
> What does that mean with th
We get 5 warnings when building kernel with W=1:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:287:13: warning: no
previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations]
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:323:24: warning: no
previous declaration for
We get 2 warnings when building kernel with W=1:
drivers/staging/rtl8192u/r8192U_core.c:925:12: warning: no previous declaration
for 'ieeerate2rtlrate' [-Wmissing-declarations]
drivers/staging/rtl8192u/r8192U_core.c:958:12: warning: no previous declaration
for 'rtl8192_rate2rate' [-Wmissing-decla
On Fri, 23 Sep 2016 15:20:33 +0200
Greg KH wrote:
> On Fri, Sep 23, 2016 at 02:49:28PM +0200, Christian Gromm wrote:
> > On Fri, 23 Sep 2016 14:08:51 +0200
> > Greg KH wrote:
> >
> > > On Thu, Sep 22, 2016 at 11:37:07AM +0200, Christian Gromm wrote:
> > > > This patch allows to call the write()
We get 4 warnings when building kernel with W=1:
drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for
'fake_lm_check' [-Wmissing-prototypes]
drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for
'fake_vmewrite8' [-Wmissing-prototypes]
drivers/vme/bridges/vme
This patchset fix some style issues reported by checkpatch.pl script.
Sergio Paracuellos (20):
staging: wlan-ng: avoid new typedef: p80211enumpair_t
staging: wlan-ng: avoid new typedef: p80211enum_t
staging: wlan-ng: avoid new typedef: p80211pstr_t
staging: wlan-ng: avoid new typedef: p802
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/cfg80211.c | 12 +-
drivers/staging/wlan-ng/p80211metastruct.h | 248 ++---
drivers/staging/wlan-
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstr_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211enumpair_t.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211enum_t.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 44 +--
1 file changed, 22 insertions(+), 22
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstr6_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driv
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstrd_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211req.c | 4 ++--
drivers/staging/wlan-ng/p80211types.h | 4 ++--
drivers/staging/wl
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstr255_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dr
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstr14_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dri
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_uint32_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/cfg80211.c | 8 +-
drivers/staging/wlan-ng/p80211metastruct.h | 224
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211macarray_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dri
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_pstr32_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211metastruct.h | 8
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_pstr14_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metastruct.h | 2 +-
drivers/staging/wlan-ng/p80211types.h | 4 ++--
2 file
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_pstr6_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
drive
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_unk392_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
driver
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211itemd_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211req.c | 3 ++-
drivers/staging/wlan-ng/p80211types.h | 4 ++--
drivers/staging/wlan-
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211pstr32_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.h | 2 +-
drivers/staging/wlan-ng/p80211types.h | 6 +++---
2 files changed,
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_unk4096_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metastruct.h | 4 ++--
drivers/staging/wlan-ng/p80211types.h | 4 ++--
2 f
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 135 +-
1 file changed, 68 insertions(+), 67 deletions(-)
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_pstr255_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_unk1024_t
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211metastruct.h | 2 +-
drivers/staging/wlan-ng/p80211types.h | 4 ++--
2 fil
I believed I tested it but I found out that the CONFIG_OF_RESERVED_MEM
was not enabled in my config.
So it was not properly tested.
I will try to test it again.
Sorry,
Yannis
On Fri, Sep 23, 2016 at 3:06 PM, Greg KH wrote:
> On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote:
>> This
This patchset fix several style warnings reported by checkpatch.pl script.
Changes V2:
* Fix commit subject names to be more specific
Sergio Paracuellos (8):
staging: rts5208: avoid new typedef in rtsx.h: rtsx_dev_t
staging: rts5208: avoid symbolic permissions in rtsx.c
staging: rts5208:
This patch fixes the following checkpatch.pl warning in rtsx.h:
WARNING: do not add new typedefs
It also remove DELAY_PARA_T because code is not using it.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/rtsx.h | 4
drivers/staging/rts5208/rtsx_chip.h | 2 +-
2 files chan
This patch fixes the following checkpatch.pl warning in spi.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/spi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.
This patch fixes the following checkpatch.pl warning in rtsx_sys.h:
WARNING: do not add new typedefs
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/rtsx_sys.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_sys.h
b/drivers/staging/rts5208/rtsx_sy
This patch fixes the following checkpatch.pl warning in rtsx.h:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/rtsx.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx
This patch fixes the following checkpatch.pl warning in xd.c:
WARNING: else is not generally useful after a break or return
It also makes code more uniform with the new changes
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/xd.c | 38 ++
1 file
This patch fixes the following checkpatch.pl warning in rtsx.c:
WARNING: Symbolic permissions are not preferred.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/rtsx.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/
This patch fixes the following checkpatch.pl warning in sd.c:
WARNING: else is not generally useful after a break or return
It also makes code more uniform with the new changes
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/sd.c | 173 +++
This patch fixes the following checkpatch.pl warning in rtsx_chip.h:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos
---
drivers/staging/rts5208/rtsx_chip.h | 52 +++--
1 file changed, 27 insertions(+), 25 deletions(-
Fixes a comment coding style warning by adding 2 blank lines. Issue found by
checkpatch.
Signed-off-by: Sidhant Gupta
---
Changes since v1:
* Corrected name in `From: ` and `Signed-off-by: ` sections.
* Cc-ed mailing list.
* Made commit message more clear.
drivers/staging/greybus/arche-apb-ct
Mostly code formatting, unapologetically a stepping stone for a
potential refactoring with a knowledge seeking, following complete
disclosure, ultimate goal.
In case this fails, my backup plan is to have the world's record for the
quickest kernel patch dismissal, either way it's a win.
diff --gi
On Fri, Sep 23, 2016 at 04:28:11PM +0200, Marcel Xubuntu wrote:
> Mostly code formatting, unapologetically a stepping stone for a potential
> refactoring with a knowledge seeking, following complete disclosure,
> ultimate goal.
> In case this fails, my backup plan is to have the world's record for
On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote:
> On Fri, Sep 23, 2016 at 3:17 PM, Greg KH wrote:
> > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.dami...@gmail.com wrote:
> >> From: Yannis Damigos
> >>
> >> This patch fixes the following blank line issues:
> >>
> >> CHECK: P
On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
> From: Colin Ian King
>
> Currently, if info is null, the dev_err message is dereferencing an
> uninitialized module pointer. Instead, initialize module before the
> dev_err call to fix this issue.
>
> Found using static analysis with
On Fri, Sep 23, 2016 at 07:58:13PM +0530, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue found by
> checkpatch.
>
Please wrap your changelog text at 72 columns like git is trying to get
you to do...
thanks,
greg k-h
___
On Fri, Sep 23, 2016 at 03:45:18PM +0200, Sergio Paracuellos wrote:
> This patch fixes the following checkpatch.pl warning in p80211types.h:
> WARNING: do not add new typedefs
>
> Signed-off-by: Sergio Paracuellos
> ---
Was this patch part of this series? It didn't have a number, so I'm
droppin
On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for
> 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:120:6: warn
On 09/23/2016 06:13 AM, Baoyou Xie wrote:
We get 4 warnings when building kernel with W=1:
drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous
prototype for 'ion_carveout_allocate' [-Wmissing-prototypes]
drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no pr
Drop it, please. It seems I wrongly included the original patch too.
Sorry for inconvenience.
Thanks,
Sergio Paracuellos
El 2016年09月23日 a las 18:59, Greg KH escribió:
On Fri, Sep 23, 2016 at 03:45:18PM +0200, Sergio Paracuellos wrote:
This patch fixes the following checkpatch.pl warni
This patch fixes the alignment of an allocation flag block comment
and moves the comments before each #define.
Signed-off-by: Antti Keränen
---
In addition to fixing the alignment issue, this version of the patch moves
the comments from after the define lines to before the define lines.
drivers
On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently, if info is null, the dev_err message is dereferencing an
>> uninitialized module pointer. Instead, initialize module before the
>> de
On 23/09/16 19:20, Vaibhav Agarwal wrote:
> On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
> wrote:
>> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Currently, if info is null, the dev_err message is dereferencing an
>>> uninitialized module po
On 23 September 2016 at 14:38, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for
> 'fake_lm_check' [-Wmissing-prototypes]
> drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for
> 'fa
On 09/23/2016 11:03 AM, Antti Keränen wrote:
This patch fixes the alignment of an allocation flag block comment
and moves the comments before each #define.
Acked-by: Laura Abbott
Signed-off-by: Antti Keränen
---
In addition to fixing the alignment issue, this version of the patch moves
the
The preferred indentation for cases and switches has the cases at
the same level as the switch.
Signed-off-by: Christopher H. Pezley
---
drivers/staging/android/ion/ion_of.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/ion/ion_of.
On 09/23/2016 01:40 PM, Christopher Pezley wrote:
The preferred indentation for cases and switches has the cases at
the same level as the switch.
Please remember to tag your patches with v2 when sending the
next version to tell them apart (e.g. [PATCHv2])
Acked-by: Laura Abbott
Signed-off-
From: Imre Deak
Move the extern declaration to a header file common to all users of the
variable. This fixes the following sparse warning:
symbol 'ldlm_cancel_unused_locks_before_replay' was not declared.
Should it be static?
Signed-off-by: Imre Deak
---
drivers/staging/lustre/lustre/ldlm/ldlm
83 matches
Mail list logo
