Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing.

2016-09-20 Thread Shailendra Verma
This is of course wrong to call kfree() if memdup_user() fails, no memory was allocated and the error in the error-valued pointer should be returned. Reviewed-by: Ravikant Sharma Signed-off-by: Shailendra Verma --- drivers/staging/media/lirc/lirc_imon.c | 7 ++- drivers/staging/media/lirc/

Re: [PATCH 3/3] staging: greybus: use preferred kernel type u32

2016-09-20 Thread Chaehyun Lim
On Tue, Sep 20, 2016 at 3:29 PM, Greg KH wrote: > On Tue, Sep 20, 2016 at 09:47:31AM +0900, Chaehyun Lim wrote: >> As suggested by checkpatch.pl: >> >> CHECK: Prefer kernel type 'u32' over 'uint32_t' >> >> Signed-off-by: Chaehyun Lim >> --- >> drivers/staging/greybus/audio_codec.c | 6 +

Re: Staging: Media: Lirc - Fix possible ERR_PTR() dereferencing.

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 12:21:21PM +0530, Shailendra Verma wrote: > This is of course wrong to call kfree() if memdup_user() fails, > no memory was allocated and the error in the error-valued pointer > should be returned. > > Reviewed-by: Ravikant Sharma > Signed-off-by: Shailendra Verma Callin

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > exported so this pat

[PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

2016-09-20 Thread Brian Masney
Address warning from checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29018.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018

[PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address

2016-09-20 Thread Brian Masney
Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian Masney -

Re: [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 05:38:57AM -0400, Brian Masney wrote: > Address warning from checkpatch: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Brian Masney > --- > drivers/staging/iio/light/isl29018.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread Greg Kroah-Hartman
On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > > lustre_swab_[lmv|lov

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread Dan Carpenter
On Tue, Sep 20, 2016 at 01:05:00PM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > > Being over zealou

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread Greg Kroah-Hartman
On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > Being over zealous in removing unused EXPORT_SYMBOLs two functions > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > was done when porting to th

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread Greg Kroah-Hartman
On Tue, Sep 20, 2016 at 02:16:12PM +0300, Dan Carpenter wrote: > On Tue, Sep 20, 2016 at 01:05:00PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 19, 2

Re: [PATCH] staging: ks7010: clean function declaration in ks_hostif.c up

2016-09-20 Thread Greg KH
On Sun, Sep 18, 2016 at 07:07:50PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/ks7010/ks_wlan_net.c:3392:6: warning: no previous prototype > for 'send_packet_complete' [-Wmissing-prototypes] > > In fact, this function is declared in > drivers/stagi

Re: [PATCH 01/11] staging: most: hdm-dim2: fix channel configuration

2016-09-20 Thread Andrey Shvetsov
On Fri, Sep 16, 2016 at 02:44:37PM +0300, Dan Carpenter wrote: > On Thu, Sep 15, 2016 at 04:19:03PM +0200, Christian Gromm wrote: > > From: Andrey Shvetsov > > > > The DIM2 HDM checks the parameters passed to the function > > configure_channel() and adapts the buffer sizes of the configuration >

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread James Simmons
> > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > > was do

Re: [lustre-devel] [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread James Simmons
> > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > > > >

[PATCH 1/4] staging: unisys: visornic: remove prototypes

2016-09-20 Thread David Kershner
Remove unneeded prototypes from visornic_main.c Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 41 ++--- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c

[PATCH 3/4] staging: unisys: visornic: remove visornic_poll prototype

2016-09-20 Thread David Kershner
Remove visornic_poll prototype, because it is not needed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic

[PATCH 4/4] staging: unisys: visornic: remove poll_for_irq prototype

2016-09-20 Thread David Kershner
Remove poll_for_irq prototype not needed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main

[PATCH 2/4] staging: unisys: visornic: remove visornic debugfs protoyptes

2016-09-20 Thread David Kershner
Remove visornic debugfs prototypes, they are not needed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_

[PATCH 0/4] staging: unisys: visornic: remove prototypes

2016-09-20 Thread David Kershner
This patchset removes unneeded prototypes from the visornic driver. Some code was shuffled around to avoid needing the prototypes. David Kershner (4): staging: unisys: visornic: remove prototypes staging: unisys: visornic: remove visornic debugfs protoyptes staging: unisys: visornic: remove

Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

2016-09-20 Thread James Simmons
> On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > was done when po

[PATCH] staging: unisys: visorhba: remove prototypes for visorhba_main.c

2016-09-20 Thread David Kershner
Remove not needed prototypes in visorhba. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorhba/visorhba_main.c | 50 +++-- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/dr

[PATCH v2] staging: lustre: ptlrpc: re-export lustre_swab_lov_mds_md

2016-09-20 Thread James Simmons
Being over zealous in removing unused EXPORT_SYMBOLs the function lustre_swab_lov_mds_md exports were removed. They need to be exported so this patch restores those EXPORT_SYMBOLS. Same mistake was done when porting to the upstream client. v2 Remove exporting lustre_swab_lmv_mds_md since that is n

[PATCH 2/4] staging: unisys: include: remove unused spar_channel_client_acquire_os

2016-09-20 Thread David Kershner
The function spar_channel_client_acquire_os is not being used so remove it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 104 --- 1 file changed, 104 deletions(-) diff --git a/drivers/staging/unisys/include/chann

[PATCH 1/4] staging: unisys: include: remove unused function pathname_last_n_nodes

2016-09-20 Thread David Kershner
The function pathname_last_n_nodes is not used, get rid of it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 32 1 file changed, 32 deletions(-) diff --git a/drivers/staging/unisys/include/channel.h b/driver

[PATCH 3/4] staging: unisys: include: remove unused spar_channel_client_release_os

2016-09-20 Thread David Kershner
The function spar_channel_client_release_os is not being used so remove it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/unisys/include/channel.h b/dri

[PATCH 4/4] staging: unisys: include: remove unused ULTRA_CHANNELCLI_STRING

2016-09-20 Thread David Kershner
The inline ULTRA_CHANNELCLI_STRING is not being used so remove it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/unisys/include/channel.h b/drivers/stag

[PATCH 0/4] staging: unisys: include: remove unused functions

2016-09-20 Thread David Kershner
This patchset removes unused function from the include directories. David Kershner (4): staging: unisys: include: remove unused function pathname_last_n_nodes staging: unisys: include: remove unused spar_channel_client_acquire_os staging: unisys: include: remove unused spar_channel_client_re