Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

2016-09-13 Thread Julia Lawall
On Tue, 13 Sep 2016, Namrata A Shettar wrote: > This patch removes an unnecessary blank line that caused checkpatch issue. Actually, commit messages and subject lines should be written in the imperative. So you should say eg Remove unnecessary blank line instead of Removes unnecessary blank

Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

2016-09-13 Thread Peter Zijlstra
On Mon, Sep 12, 2016 at 08:44:09PM -0700, Arve Hjønnevåg wrote: > A previous attempt to fix this problem, changed the lock to use > rt_mutex instead of mutex, but this apparently did not work as well as > this patch. I believe the added overhead was noticeable, and it did > not work when the preem

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

2016-09-13 Thread Arnd Bergmann
On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote: > --- a/drivers/staging/comedi/comedi_pcmcia.c > +++ b/drivers/staging/comedi/comedi_pcmcia.c > @@ -18,7 +18,6 @@ > > #include > #include > - > #include "comedi_pcmcia.h" > > /** > I would argue that checkpatch is wr

Re: [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

2016-09-13 Thread Will Deacon
Hi Laura, On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote: > > arm64 may need to guarantee the caches are synced. Implement versions of > the kernel_force_cache API to allow this. > > Signed-off-by: Laura Abbott > --- > v3: Switch to calling cache operations directly instead of rel

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

2016-09-13 Thread Julia Lawall
On Tue, 13 Sep 2016, Arnd Bergmann wrote: > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote: > > --- a/drivers/staging/comedi/comedi_pcmcia.c > > +++ b/drivers/staging/comedi/comedi_pcmcia.c > > @@ -18,7 +18,6 @@ > > > > #include > > #include > > - > > #include "come

RE: [PATCH 2/2] pci-hyperv: properly handle device eject

2016-09-13 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of Long Li > Sent: Tuesday, September 13, 2016 7:54 > ... > A PCI_EJECT message can arrive at the same time we are calling > pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS > message, in this ca

Re: [RFC PATCH v1 01/28] kvm: svm: Add support for additional SVM NPF error codes

2016-09-13 Thread Borislav Petkov
On Mon, Aug 22, 2016 at 07:23:44PM -0400, Brijesh Singh wrote: > From: Tom Lendacky > > AMD hardware adds two additional bits to aid in nested page fault handling. > > Bit 32 - NPF occurred while translating the guest's final physical address > Bit 33 - NPF occurred while translating the guest p

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

2016-09-13 Thread Julia Lawall
On Tue, 13 Sep 2016, Namrata A Shettar wrote: > Yes I realize that this may be wrong.Thank you for your inputs! > >  Also,The version of the kernel I am using is : 4.8.0-rc2+ You should be using what you get by doing the following command: git clone -b staging-testing git://git.kernel.org/pub

非结构化面试与结构化面试

2016-09-13 Thread �蠲��
250 2016-9-13 17:54:12 非结构化面试与结构化面试.xls Description: Binary data ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: comedi_fops: fix checkpatch permission warnings

2016-09-13 Thread Simon Chopin
Fix the following checkpatch warning: Symbolic permissions are not preferred, use octal permissions. Signed-off-by: Simon Chopin --- drivers/staging/comedi/comedi_fops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/stag

Re: [PATCH] staging: comedi_fops: fix checkpatch permission warnings

2016-09-13 Thread Greg Kroah-Hartman
On Sat, Sep 10, 2016 at 05:23:57AM +0200, Simon Chopin wrote: > Fix the following checkpatch warning: > Symbolic permissions are not preferred, use octal permissions. > > Signed-off-by: Simon Chopin > --- > drivers/staging/comedi/comedi_fops.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 del

Re: [PATCH] staging: comedi_fops: fix checkpatch permission warnings

2016-09-13 Thread Simon Chopin
On Tue, Sep 13, 2016 at 2:52 PM, Greg Kroah-Hartman wrote: > On Sat, Sep 10, 2016 at 05:23:57AM +0200, Simon Chopin wrote: >> Fix the following checkpatch warning: >> Symbolic permissions are not preferred, use octal permissions. >> >> Signed-off-by: Simon Chopin >> --- >> drivers/staging/comedi

Re: [PATCH] staging: comedi_fops: fix checkpatch permission warnings

2016-09-13 Thread Ian Abbott
On 13/09/16 13:59, Simon Chopin wrote: On Tue, Sep 13, 2016 at 2:52 PM, Greg Kroah-Hartman wrote: On Sat, Sep 10, 2016 at 05:23:57AM +0200, Simon Chopin wrote: Fix the following checkpatch warning: Symbolic permissions are not preferred, use octal permissions. Signed-off-by: Simon Chopin ---

Re: [PATCH] staging: comedi_fops: fix checkpatch permission warnings

2016-09-13 Thread Greg Kroah-Hartman
On Tue, Sep 13, 2016 at 02:59:36PM +0200, Simon Chopin wrote: > On Tue, Sep 13, 2016 at 2:52 PM, Greg Kroah-Hartman > wrote: > > On Sat, Sep 10, 2016 at 05:23:57AM +0200, Simon Chopin wrote: > >> Fix the following checkpatch warning: > >> Symbolic permissions are not preferred, use octal permissio

[PATCH] staging: fwserial: fix checkpatch permission warnings

2016-09-13 Thread Simon Chopin
Fix the following warnings: Symbolic permissions are not preferred. Consider using octal permissions. Signed-off-by: Simon Chopin --- drivers/staging/fwserial/fwserial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/stagi

Re: [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

2016-09-13 Thread Laura Abbott
On 09/13/2016 02:19 AM, Will Deacon wrote: Hi Laura, On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote: arm64 may need to guarantee the caches are synced. Implement versions of the kernel_force_cache API to allow this. Signed-off-by: Laura Abbott --- v3: Switch to calling cache op

Re: [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

2016-09-13 Thread Will Deacon
On Tue, Sep 13, 2016 at 08:02:20AM -0700, Laura Abbott wrote: > On 09/13/2016 02:19 AM, Will Deacon wrote: > >On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote: > >> > >>arm64 may need to guarantee the caches are synced. Implement versions of > >>the kernel_force_cache API to allow this.

RE: [PATCH 2/2] pci-hyperv: properly handle device eject

2016-09-13 Thread Long Li
> -Original Message- > From: Dexuan Cui > Sent: Tuesday, September 13, 2016 2:51 AM > To: Long Li ; KY Srinivasan ; > Haiyang Zhang ; Bjorn Helgaas > > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: RE: [PATCH 2/2] pci-hyperv: pro

RE: [PATCH 2/2] pci-hyperv: properly handle device eject

2016-09-13 Thread Long Li
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Long Li > Sent: Tuesday, September 13, 2016 10:33 AM > To: Dexuan Cui ; KY Srinivasan > ; Haiyang Zhang ; Bjorn > Helgaas > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel

Re: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

2016-09-13 Thread Olaf Hering
On Thu, Sep 08, k...@exchange.microsoft.com wrote: > - default: > + case(VERSION_WIN10): > util_fw_version = UTIL_FW_VERSION; > sd_srv_version = SD_VERSION; > ts_srv_version = TS_VERSION; > hb_srv_version = HB_VERSION; > +

RE: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

2016-09-13 Thread Alex Ng (LIS)
> On Thu, Sep 08, k...@exchange.microsoft.com wrote: > > > - default: > > + case(VERSION_WIN10): > > util_fw_version = UTIL_FW_VERSION; > > sd_srv_version = SD_VERSION; > > ts_srv_version = TS_VERSION; > > hb_srv_version = HB_VERSION; > > +

Re: [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

2016-09-13 Thread Laura Abbott
On 09/13/2016 08:14 AM, Will Deacon wrote: On Tue, Sep 13, 2016 at 08:02:20AM -0700, Laura Abbott wrote: On 09/13/2016 02:19 AM, Will Deacon wrote: On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote: arm64 may need to guarantee the caches are synced. Implement versions of the kernel

[PATCH] staging: octeon: use defines instead of magic numbers

2016-09-13 Thread Asbjoern Sloth Toennesen
The ugly magic number 65392 is waiting for CVMX_IPD_MAX_MTU to appear in the mips tree. Signed-off-by: Asbjoern Sloth Toennesen --- drivers/staging/octeon/ethernet.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drive

Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

2016-09-13 Thread Arve Hjønnevåg
On Mon, Sep 12, 2016 at 11:42 PM, Greg Kroah-Hartman wrote: > On Mon, Sep 12, 2016 at 08:44:09PM -0700, Arve Hjønnevåg wrote: >> On Sat, Sep 10, 2016 at 10:28 AM, Greg Kroah-Hartman >> wrote: >> > On Sat, Sep 10, 2016 at 06:37:29PM +0200, Thomas Gleixner wrote: >> >> On Sat, 10 Sep 2016, Peter Zi

Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

2016-09-13 Thread Arve Hjønnevåg
On Tue, Sep 13, 2016 at 12:32 AM, Peter Zijlstra wrote: > On Mon, Sep 12, 2016 at 08:44:09PM -0700, Arve Hjønnevåg wrote: > >> A previous attempt to fix this problem, changed the lock to use >> rt_mutex instead of mutex, but this apparently did not work as well as >> this patch. I believe the adde

Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings

2016-09-13 Thread Dilger, Andreas
On Sep 12, 2016, at 04:27, Greg KH wrote: > > On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote: >> Added __acquires / __releases sparse locking annotations >> to lock_res_and_lock and unlock_res_and_lock functions in >> l_lock.c, to fix below sparse warnings: >> >> l_lock.c:4

RE: [PATCH 2/2] pci-hyperv: properly handle device eject

2016-09-13 Thread Dexuan Cui
> From: Long Li > Sent: Wednesday, September 14, 2016 1:41 > > I think this code is safe here. If we reach the code > pci_stop_and_remove_bus_device_locked, create_root_hv_pci_bus() is already > called. When hv_pci_probe() -> create_root_hv_pci_bus() -> pci_scan_child_bus() is running on one cpu