On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
> Fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
> Replace Avoid CamelCase range
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/comedidev.h| 8 ++---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
2 files
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge
> ---
> drivers/staging/comedi/comedidev.h| 8 ++---
> drivers/staging/comed
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/dr
On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge
> ---
[...]
Why are you sending so many copies of the same patch?
On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius
wrote:
> On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote:
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Amit Ghadge
>> ---
> [...]
>
> Why
I will be send individual patches.
I was try,
make M=drivers/staging/comedi/
No issue generated, Is there have any other option to test these changes?
Amit G
On Sun, Sep 4, 2016 at 2:05 PM, Greg KH wrote:
> On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
>> Fixes checkpatch warn
Re-sending as
On 01-09-2016 17:54:47, Greg KH wrote:
> There is no patch here :(
8<
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matthias Beyer (1)
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer
Reported-by: David Binderman
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers/
ord what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
con
ord what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
con
ord what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
config: i
ub.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> # save the attached .config to linux b
ord what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
reprod
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/d
On failure we were jumping to error_out0 where we were trying
sdio_release_host() but at this point of execution we still have not
done sdio_claim_host() and as a result host->claimed can still be 0.
And if host->claimed is 0 then WARN_ON(!host->claimed) will give
a warning.
Moreover, if it is stil
On Sun, Sep 04, 2016 at 01:01:20PM +0200, Matthias Beyer wrote:
> This patch removes the pointless `else if` test.
>
> Signed-off-by: Matthias Beyer
> Reported-by: David Binderman
> ---
looks like Greg has already applied your first patch.
db0c12744f8d ("drivers: staging: rtl8723au: hal: Remove
On Wed, Aug 31, 2016 at 08:20:10PM -0400, Nicholas Krause wrote:
> This fixes warning around a asterisk used in ks_wlan_net.c
> for the define statement used for this driver's transmit
> queue timeout value as defined by the marco, TX_TIMEOUT.
> Signed-off-by: Nicholas Krause
> ---
Please keep a
On Fri, Sep 02, 2016 at 09:14:15PM +0800, Louie Lu wrote:
> fixed comment style and space indent report from checkpatch
> in rtl8712/rtl871x_ioctl_linux.c:
>
> * WARNING: Statements should start on a tabstop
> * WARNING: Block comments use * on subsequent lines
> * WARNING: suspect code indent for
On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for
> 'sync_timeline_create' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which
Fixes checkpatch warning in das08_cs.c file:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/das08_cs.c | 70 +++
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/comedi/dr
Clean some all functions to return NULL on failure.
Used !x instead of x==NULL.
Signed-off-by: Amit Ghadge
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_li
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey2
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/stagi
This patchset removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey<#>
and uses the new macro DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Claudiu Beznea (5):
Staging: wlan-ng: uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
macro instead of
DIDmib_dot11s
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey0
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/stagi
This patch changes definition of
DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable instead of
using directly (P80211DID_MKSECTION(1) | P80211DID_MKGROUP(4)).
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 3 +--
1
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey1
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/stagi
This patch removes
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKey3
macro and uses DIDmib_dot11smt_dot11WEPDefaultKeysTable_key()
instead.
Signed-off-by: Claudiu Beznea
---
drivers/staging/wlan-ng/p80211metadef.h | 4
drivers/staging/wlan-ng/p80211req.c | 2 +-
drivers/stagi
Fix multiple line length warnings found by the checkpatch.pl tool
in ddk750_chip.c.
Signed-off-by: Moshe Green
---
drivers/staging/sm750fb/ddk750_chip.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers/stagin
Fix the following warning types:
- line length
- block comment line * prefix
- trailing */ on a separate line
found by the checkpatch.pl tool in multiple block comments.
Fix a single spelling error in a comment.
Signed-off-by: Moshe Green
---
drivers/staging/sm750fb/ddk750_chip.c | 49 ++
This patchset fixes some errors and warnings reported by checkpatch.pl.
Matthias Beyer (5):
drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
drivers: staging: rtl8723au: core: simplify if-break-else
drivers: staging: rtl8723au: core: Refactor pointless branching
drivers: staging
This patch fixes the ERRORs which are reported from the checkpatch.pl
script for this file.
Signed-off-by: Matthias Beyer
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b/drivers
As the if statement breaks/continues the loop, the else block is not
useful and can be omitted.
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git
As ether_addr_equal returns a bool, we can simply use the return value
to set the variable.
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl872
This patch fixes the "space prohibited between function name and open
parenthesis '('" warning from checkpatch.pl
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --gi
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 1e01
Dear Kalle,
thanks for your feedback.
On 02/09/2016 18:18, Kalle Valo wrote:
> Luca Ceresoli writes:
>
>> These functions have been declared without any implementation since
>> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
>> has been no mention of them in following comm
37 matches
Mail list logo
