Cma mem map to cpu address when allocated in ion driver, why do this design?

Hi all, When I review ion code in linux-3.18.y, I find a design that may cause a problem in our product. In the design, cma mem is allocated via the interface of dma_alloc_coherent , and this function will create a map to cpu. Sometimes, we just need cma phys addr, do not need cpu address. I

Re: Cma mem map to cpu address when allocated in ion driver, why do this design?

On Thu, Sep 01, 2016 at 12:46:32PM +, Yangwei (Yang Wei, Device Chipset Key Technologies Platform Development Dept) wrote: > Hi all, > > When I review ion code in linux-3.18.y, I find a design that may cause > a problem in our product. In the design, cma mem is allocated via the > interface

Re: Cma mem map to cpu address when allocated in ion driver, why do this design?

On 09/01/2016 05:46 AM, Yangwei (Yang Wei, Device Chipset Key Technologies Platform Development Dept) wrote: Hi all, When I review ion code in linux-3.18.y, I find a design that may cause a problem in our product. In the design, cma mem is allocated via the interface of dma_alloc_coherent ,

Re: [PATCH] staging: dgnc: Let line have less 80 char

On Sat, Aug 27, 2016 at 01:39:42AM +, Sean Wei wrote: > Lidza Louina <> (maintainer:DIGI NEO AND CLASSIC PCI PRODUCTS) > Mark Hounschell <> (maintainer:DIGI NEO AND CLASSIC PCI PRODUCTS) > Greg Kroah-Hartman <> (supporter:STAGING SUBSYSTEM) >  (open list:DIGI NEO AND CLASSIC PCI PRODUCTS) > de.

[PATCH 08/21] staging: unisys: visorbus: Convert visorchipset.h refs

From: David Binder visorbus_private.h was previously named visorchipset.h. This patch removes references to the old filename, and updates them with the new filename. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_p

[PATCH 13/21] staging: unisys: visorbus: Merge controlvm completion status to controlvmchannel

The completion status are valid only for the controlvm channel so they should be moved into its header file. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/controlvmchannel.h | 76 .../unisys/visorbus/controlvmcompletionstatus.h| 10

[PATCH 18/21] staging: unisys: visorbus: Move non global guestlinuxdebug to visorbus

Guestlinuxdebug.h is only used by visorbus, move the include file into its directory instead of the global one. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/guestlinuxdebug.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename dri

[PATCH 03/21] staging: unisys: visornic_main.c remove unused pound defines

From: Erik Arfvidson This removes two unused pound defines in the visornic_main.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic

[PATCH 21/21] staging: unisys: visorbus: cleanup include listings

Cleaned up include section of files so that they only include the files needed by them. If an include file includes the file already don't repeat it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- drivers/staging/unisys/visorbus/v

[PATCH 07/21] staging: unisys: Move vbushelper.h contents to visorbus_private.h

From: Bryan Thompson The contents of vbushelper.h are now only used by visorbus, so it no longer needs to be a general include file and it can be incorporated in the visorbus private header. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging

[PATCH 09/21] staging: unisys: visorbus: Merge channel_guid.h with channel.h

From: David Binder Merges the contents of channel_guid.h with channel.h, as the former was not a proper header file. Therefore, the channel_guid.h is no longer needed. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h

[PATCH 04/21] staging: unisys: visorbus: remove g_devicechangestate_packet

From: Jon Frisch This patch removes the unused struct controlvm_message_packet g_devicechangestate_packet. The struct is set but never called. Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1 file changed, 2 deletions(-) dif

[PATCH 19/21] staging: unisys: remove check for GNUC

The check for GNUC is redundant and is not needed for vmcallinterface.h. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vmcallinterface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/vmcallinterface.h b/drivers/st

[PATCH 11/21] staging: unisys: visorinput: Remove ultrainputreport.h include

From: Bryan Thompson Stop ultrainputreport.h from including itself. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorinput/ultrainputreport.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorinpu

[PATCH 06/21] staging: unisys: visorbus: remove putfile_buffer_entry

From: Jon Frisch This patch removes the unused struct putfile_buffer_entry. Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/

[PATCH 10/21] staging: unisys: visorinput: Update visorinput.c includes

From: Bryan Thompson Remove unnecessary channel.h include from visorinput.c. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorinput/visorinput.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorinp

[PATCH 01/21] staging: unisys: visorchipset.c remove unused pound defines

From: Erik Arfvidson This removes three unused pound defines in the visorchipset.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorch

[PATCH 15/21] staging: unisys: visorbus: merge vbusdeviceinfo.h into vbuschannel

vbusdeviceinfo.h was only used by vbuschannel.h so merge them together. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vbuschannel.h | 212 ++- drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 234 - drivers/s

[PATCH 12/21] staging: unisys: merge diagchannel.h to visorbus.h

From: Erik Arfvidson It is pointless to have a dedicated include for another include. So I merged them together. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/diagchannel.h | 38 --- drivers/stagi

[PATCH 00/21] Clean up header files and remove unused structures

This patch series removes unused defines and structures in visorbus. It also combines and simplifies the headers files for the s-Par drivers. Bryan Thompson (3): staging: unisys: Move vbushelper.h contents to visorbus_private.h staging: unisys: visorinput: Update visorinput.c includes stag

[PATCH 17/21] staging: unisys: visorbus: remove include for vbuschannel.h

visorbus_main.c does not need to include vbuschannel.h. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/v

[PATCH 05/21] staging: unisys: visorbus: remove unused lists

From: Jon Frisch This patch removes the following lists that were never used: LIST_HEAD(bus_info_list) LIST_HEAD(dev_info_list) LIST_HEAD(putfile_request_list) Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 10 -- 1 file ch

[PATCH 20/21] staging: unisys: visorbus: merge guestlinuxdebug with vmcallinterface.h

Merge guestlinuxdebug into vmcallinterface.h since it is dependent on it Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/guestlinuxdebug.h | 180 -- drivers/staging/unisys/visorbus/visorbus_main.c | 1 - drivers/staging/unisys/viso

[PATCH 02/21] staging: unisys: visorbus_main.c remove unused pound defines

From: Erik Arfvidson This removes two unused pound defines in the visorbus_main.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbu

[PATCH 16/21] staging: unisys: visorbus: Merge iovmcall_gnuc into vmcallinterface

iovmcall_gnuc was only being referenced by vmcallinterface, so merge them together. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 48 --- drivers/staging/unisys/visorbus/vmcallinterface.h | 35 +++-- 2

[PATCH 14/21] staging: unisys: visorbus: Reorder functions to avoid including header

Visorchannel does not need to include visorbus_private.h; all it was using it for was function prototypes. A simple reorder causes it to no longer need to include it. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchannel.c | 245 ---

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andrey Utkin wrote: > On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote: > > Fix checkpatch.pl 'line over 80 characters' warning > > > > Signed-off-by: Anson Jacob > > --- > > drivers/staging/android/lowmemorykiller.c | 4 ++-- > > 1 file chang

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote: > Hello David, > > On 08/25/2016 12:01 PM, David Daney wrote: > > On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: > >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > >> built-in or as a m

Re: [PATCH] staging: android: ion: ion_chunk_heap.c fix parenthesis alignment

On Wed, Aug 24, 2016 at 04:32:20PM +0700, Didik Setiawan wrote: > Fix checkpatch.pl warning about "Alignment should match open parenthesis". > > Signed-off-by: Didik Setiawan > --- > drivers/staging/android/ion/ion_chunk_heap.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 1/6] rtl8723au: remove declaration of unimplemented functions

On Sat, Aug 27, 2016 at 02:40:44PM +0200, Luca Ceresoli wrote: > Signed-off-by: Luca Ceresoli > Cc: Larry Finger > Cc: Jes Sorensen > Cc: Greg Kroah-Hartman > Cc: linux-wirel...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > --- > drivers/staging/rtl8723au/include/recv_osdep.h | 3 --- >

Re: [PATCH]staging:rts5208: Fix block comment trailing */ warning

On Mon, Aug 29, 2016 at 08:43:17PM +0530, Harsh Jain wrote: > Fix block comments using trailing */ on a separate line checkpatch warning > Signed-off-by: Harsh Jain Please put a blank line before the signed-off-by line, so our tools pick it up properly. Also, someone already sent this same patch

Re: [PATCH V2] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 06:23:39PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- > drivers/staging/xgifb/vb_setmode.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/xgifb/v

[PATCH] staging: dgnc: Let line have less 80 char

This patch fix a minor checkpath warming: "WARNING: line over 80 characters" Signed-off-by: Sean --- drivers/staging/dgnc/dgnc_neo.c | 116 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/

Re: [PATCH 1/2] staging: ks7010: return on failure

On Wed, Aug 24, 2016 at 12:07:35AM +0530, Sudip Mukherjee wrote: > On failure we were jumping to error_out0 where we were trying > sdio_release_host() but at this point of execution we still have not > done sdio_claim_host() and as a result host->claimed can still be 0. > And if host->claimed is 0

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

On Wed, Aug 31, 2016 at 09:32:56PM +0200, Matthias Beyer wrote: > Pinging here as nobody responded yet. > > Maybe this was overlooked. Nope, it was only a week, staging patches are at the bottom of my queue, please give me time to get to them, I process them usually ever few weeks... thanks, gr

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

On Tue, Aug 23, 2016 at 09:44:16PM +0200, Matthias Beyer wrote: > As reported by David Binderman, this test is useless as of > > if (a < 3) { > /* ... */ > } else if (a >= 3) { > /* ... */ > } > > so this patch removes the second check. > > Matthias Beyer (1): > dri

Re: [PATCH] staging: dgnc: Let line have less 80 char

On Thu, Sep 01, 2016 at 11:50:35PM +0800, Sean wrote: > This patch fix a minor checkpath warming: > > "WARNING: line over 80 characters" > > Signed-off-by: Sean I need a "full" name here, I doubt you sign legal documents just as "Sean", right? thanks, greg k-h

[PATCH] staging: dgnc: Let line have less 80 char

This patch fix a minor checkpath warming: "WARNING: line over 80 characters" Signed-off-by: Sean Wei --- drivers/staging/dgnc/dgnc_neo.c | 116 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/stag

Re: [PATCH 01/41] staging: r8188eu: remove rtw_ies_remove_ie function

On Wed, Aug 24, 2016 at 03:19:21PM +0700, Ivan Safonov wrote: > Driver does not use this function. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 47 > -- > drivers/staging/rtl8188eu/include/ieee80211.h | 2 -- > 2 files change

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: > Fix a line length warning found by the checkpatch.pl tool in > ddk750_chip.c. > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Lots of the patches i

Re: [PATCH] staging: dgnc: Let line have less 80 char

On Thu, Sep 01, 2016 at 11:58:41PM +0800, Sean wrote: > This patch fix a minor checkpath warming: > > "WARNING: line over 80 characters" > > Signed-off-by: Sean Wei > --- > drivers/staging/dgnc/dgnc_neo.c | 116 > > 1 file changed, 82 insertions(+), 34

Re: [PATCH] staging: dgnc: Let line have less 80 char

Sean, On Thu, Sep 1, 2016 at 5:58 PM, Sean wrote: > This patch fix a minor checkpath warming: > > "WARNING: line over 80 characters" Please don't do patches just because of the sake of checkpatch.pl. Especially since "line over 80 characters" is only a warning, not an error. Your changelog fails

Re: [PATCH 00/21] Clean up header files and remove unused structures

On Thu, Sep 01, 2016 at 11:17:57AM -0400, David Kershner wrote: > This patch series removes unused defines and structures in visorbus. > > It also combines and simplifies the headers files for the s-Par > drivers. Given that I pointed out almost all of these issues, it's usually a nice thing to

[PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

This is a patch to the ks7010_sdio.c that fixes the following warnings found by checkpatch.pl 1) Missing a blank line after declarations 2) braces are not necessary for single statement blocks 3) kfree(NULL) is safe and this check is probably not required 4) void function return statements are not

Re: [PATCH v2 00/11] staging: octeon: multi rx group (queue) support

Hi, On Wed, Aug 31, 2016 at 07:09:13PM -0700, Ed Swierk wrote: > On 8/31/16 13:57, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > > IRQ and NAPI for each group, and ask the

Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote: > This is a patch to the ks7010_sdio.c that fixes the following > warnings found by checkpatch.pl > 1) Missing a blank line after declarations > 2) braces are not necessary for single statement blocks > 3) kfree(NULL) is safe and this

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

On Thu, 2016-09-01 at 17:36 +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andrey Utkin wrote: > > > > On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote: > > > > > > Fix checkpatch.pl 'line over 80 characters' warning > > > > > > Signed-off-by: Anson Jacob

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

On Thu, Sep 01, 2016 at 11:19:41AM -0700, Joe Perches wrote: > On Thu, 2016-09-01 at 17:36 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andrey Utkin wrote: > > > > > > On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote: > > > > > > > > Fix checkpatch.pl

RE: [PATCH 00/21] Clean up header files and remove unused structures

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 1, 2016 12:25 PM > To: Kershner, David A > Cc: driverdev-devel@linuxdriverproject.org; *S-Par-Maintainer > ; jes.soren...@redhat.com > Subject: Re: [PATCH 00/21] Clean up header files and

Re: [PATCH] android: binder: use VM_ALLOC to get vm area.

On Thu, Sep 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: > VM_IOREMAP is used to access hardware through a mechanism called > I/O mapped memory. Android binder is a IPC machanism which will > not access I/O memory. > > Also VM_IOREMAP has alignment requiement which may not needed in > bin

[PATCH v2 05/21] staging: unisys: visorbus: remove unused lists

From: Jon Frisch This patch removes the following lists that were never used: LIST_HEAD(bus_info_list) LIST_HEAD(dev_info_list) LIST_HEAD(putfile_request_list) Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchi

[PATCH v2 02/21] staging: unisys: visorbus_main.c remove unused pound defines

From: Erik Arfvidson This removes two unused pound defines in the visorbus_main.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorbus_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

[PATCH v2 06/21] staging: unisys: visorbus: remove putfile_buffer_entry

From: Jon Frisch This patch removes the unused struct putfile_buffer_entry. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/u

[PATCH v2 00/21] Clean up header files and remove unused structures

This patch series removes unused defines and structures in visorbus. It also combines and simplifies the headers files for the s-Par drivers. Changes since original submission: -- Added Reported-by: Greg Kroah-Hartman to each patch. Bryan Thompson (3): staging: unisys: M

[PATCH v2 18/21] staging: unisys: visorbus: Move non global guestlinuxdebug to visorbus

Guestlinuxdebug.h is only used by visorbus, move the include file into its directory instead of the global one. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/{include => visorbus}/guestlinuxdebug.h | 0 1 file changed, 0 insertio

[PATCH v2 15/21] staging: unisys: visorbus: merge vbusdeviceinfo.h into vbuschannel

vbusdeviceinfo.h was only used by vbuschannel.h so merge them together. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/vbuschannel.h | 212 ++- drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 234

[PATCH v2 14/21] staging: unisys: visorbus: Reorder functions to avoid including header

Visorchannel does not need to include visorbus_private.h; all it was using it for was function prototypes. A simple reorder causes it to no longer need to include it. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorch

[PATCH v2 07/21] staging: unisys: Move vbushelper.h contents to visorbus_private.h

From: Bryan Thompson The contents of vbushelper.h are now only used by visorbus, so it no longer needs to be a general include file and it can be incorporated in the visorbus private header. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kr

[PATCH v2 11/21] staging: unisys: visorinput: Remove ultrainputreport.h include

From: Bryan Thompson Stop ultrainputreport.h from including itself. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorinput/ultrainputreport.h | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH v2 08/21] staging: unisys: visorbus: Convert visorchipset.h refs

From: David Binder visorbus_private.h was previously named visorchipset.h. This patch removes references to the old filename, and updates them with the new filename. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/s

[PATCH v2 20/21] staging: unisys: visorbus: merge guestlinuxdebug with vmcallinterface.h

Merge guestlinuxdebug into vmcallinterface.h since it is dependent on it Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/guestlinuxdebug.h | 180 -- drivers/staging/unisys/visorbus/visorbus_main.c |

[PATCH v2 10/21] staging: unisys: visorinput: Update visorinput.c includes

From: Bryan Thompson Remove unnecessary channel.h include from visorinput.c. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorinput/visorinput.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 04/21] staging: unisys: visorbus: remove g_devicechangestate_packet

From: Jon Frisch This patch removes the unused struct controlvm_message_packet g_devicechangestate_packet. The struct is set but never called. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1

[PATCH v2 12/21] staging: unisys: merge diagchannel.h to visorbus.h

From: Erik Arfvidson It is pointless to have a dedicated include for another include. So I merged them together. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/include/diagchannel.h | 38 -

[PATCH v2 09/21] staging: unisys: visorbus: Merge channel_guid.h with channel.h

From: David Binder Merges the contents of channel_guid.h with channel.h, as the former was not a proper header file. Therefore, the channel_guid.h is no longer needed. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers

[PATCH v2 03/21] staging: unisys: visornic_main.c remove unused pound defines

From: Erik Arfvidson This removes two unused pound defines in the visornic_main.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH v2 17/21] staging: unisys: visorbus: remove include for vbuschannel.h

visorbus_main.c does not need to include vbuschannel.h. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorbus_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/

[PATCH v2 16/21] staging: unisys: visorbus: Merge iovmcall_gnuc into vmcallinterface

iovmcall_gnuc was only being referenced by vmcallinterface, so merge them together. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 48 --- drivers/staging/unisys/visorbus/vmcallinte

[PATCH v2 21/21] staging: unisys: visorbus: cleanup include listings

Cleaned up include section of files so that they only include the files needed by them. If an include file includes the file already don't repeat it. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-

[PATCH v2 13/21] staging: unisys: visorbus: Merge controlvm completion status to controlvmchannel

The completion status are valid only for the controlvm channel so they should be moved into its header file. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/controlvmchannel.h | 76 .../unisys/visorbus/co

[PATCH v2 19/21] staging: unisys: remove check for GNUC

The check for GNUC is redundant and is not needed for vmcallinterface.h. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/vmcallinterface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visorbu

[PATCH v2 01/21] staging: unisys: visorchipset.c remove unused pound defines

From: Erik Arfvidson This removes three unused pound defines in the visorchipset.c file. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driver

Re: [PATCH] android: binder: use VM_ALLOC to get vm area.

On Thu, Sep 1, 2016 at 12:02 PM, Greg KH wrote: > On Thu, Sep 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: >> VM_IOREMAP is used to access hardware through a mechanism called >> I/O mapped memory. Android binder is a IPC machanism which will >> not access I/O memory. >> >> Also VM_IOREMAP

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

On Thu, Sep 1, 2016 at 11:42 AM, Joe Perches wrote: > On Thu, 2016-09-01 at 20:33 +0200, Greg Kroah-Hartman wrote: >> On Thu, Sep 01, 2016 at 11:19:41AM -0700, Joe Perches wrote: >> > On Thu, 2016-09-01 at 17:36 +0200, Greg Kroah-Hartman wrote: >> > > On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andr

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

On Thu, 2016-09-01 at 20:33 +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 01, 2016 at 11:19:41AM -0700, Joe Perches wrote: > > On Thu, 2016-09-01 at 17:36 +0200, Greg Kroah-Hartman wrote: > > > On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andrey Utkin wrote: > > > > On Thu, Aug 25, 2016 at 11:10:25AM

[PATCHv2 0/4] New Ion ioctls

Hi, This is a follow up to my previous series[1] for Ion ioctls. I've changed the focus slightly based on the feedback. The ID remapping was less useful than I originally thought and without that addition there isn't much benefit to have a new alloc ioctl. The ABI check and query interface still s

[PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps

Ion clients currently lack a good method to determine what heaps are available and what ids they map to. This leads to tight coupling between user and kernel space and headaches. Add a query ioctl to let userspace know the availability of heaps. Signed-off-by: Laura Abbott --- drivers/staging/a

[PATCHv2 1/4] staging: android: ion: Drop heap type masks

There is no advantage to having heap types be a mask. The ion client has long since dropped the mask. Drop the notion of heap type masks as well. Signed-off-by: Laura Abbott --- drivers/staging/android/uapi/ion.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/android/u

[PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file

The number of Ion ioctls may continue to grow along with necessary validation. Pull it out into a separate file for easier management and review. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Makefile| 3 +- drivers/staging/android/ion/ion-ioctl.c | 144 +

[PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

The current Ion ioctls lack a good way to tell what ioctls are available. Introduce an ioctl to give an ABI version. This way when the ABI inevitably gets screwed up userspace will have a way to tell what version of the screw up is available. Signed-off-by: Laura Abbott --- drivers/staging/andr

Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps

Hi Laura, [auto build test WARNING on next-20160825] [cannot apply to staging/staging-testing v4.8-rc4 v4.8-rc3 v4.8-rc2 v4.8-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto f

[PATCH v2] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either built-in or as a module, use that macro instead of open coding the same. Using the macro makes the code more readable by helping abstract away some of the Kconfig built-in and module enable details. Signed-off-by: Javier Ma

Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

On 09/01/2016 05:32 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote: >> Hello David, >> >> On 08/25/2016 12:01 PM, David Daney wrote: >>> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote: The IS_ENABLED() macro checks if a Kconfig

[PATCH] staging: i4l: act2000: Remove braces for single statement

Fix checkpatch.pl warning: braces {} are not necessary for single statement blocks Signed-off-by: Anson Jacob --- drivers/staging/i4l/act2000/act2000_isa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act

[PATCH] staging: i4l: act2000: Add blank line after declaration

Fix checkpatch.pl warning: Missing a blank line after declarations Signed-off-by: Anson Jacob --- drivers/staging/i4l/act2000/act2000_isa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c index 1d93151..fb

Re: [PATCH] staging: i4l: act2000: Add blank line after declaration

On Fri, 2016-09-02 at 01:09 -0400, Anson Jacob wrote: > Fix checkpatch.pl warning: > Missing a blank line after declarations [] > diff --git a/drivers/staging/i4l/act2000/act2000_isa.c > b/drivers/staging/i4l/act2000/act2000_isa.c [] > @@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card) >

Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote: > > The current Ion ioctls lack a good way to tell what ioctls are > available. Introduce an ioctl to give an ABI version. This way when the > ABI inevitably gets screwed up userspace will have a way to tell what > version of the screw

Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps

On Thu, Sep 01, 2016 at 03:40:44PM -0700, Laura Abbott wrote: > > Ion clients currently lack a good method to determine what > heaps are available and what ids they map to. This leads > to tight coupling between user and kernel space and headaches. > Add a query ioctl to let userspace know the ava