The first patch is a style fix, the second add calls to kfree.
The reason for me thinking that they are necessary is that every other branches
leading to an error return are jumping to the same destination.
---
drivers/staging/rts5208/ms.c | 18 ++
1 file changed, 10 insertions(
mg_get_local_EKB and mg_get_ICV used to return with an error code before
releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/stagi
Signed-off-by: Quentin Lambert
---
drivers/staging/rts5208/ms.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -4313,7 +4313,7 @@ int mg_get_local_EKB(struct scsi_cmnd *s
if (retval != STATUS_S
>>> Can't we use dev_* on the SDIO device?
>>
>> How should a connection be constructed from the data structure
>> "sdio_device_id"
>> to the corresponding device information for such an use case?
>
> What did you try so far?
Nothing what I would find noteworthy for increasing the usage of a fun
On Fri, Aug 12, 2016 at 02:58:34PM +0200, Quentin Lambert wrote:
> Signed-off-by: Quentin Lambert
> ---
> drivers/staging/rts5208/ms.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
I can't take patches without any changelog comments, sorry.
greg k-h
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, August 11, 2016 2:17 AM
> To: KY Srinivasan
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang Zhang
>
> Subject: Re: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs
The first patch is a style fix, the second add calls to kfree.
The reason for me thinking that they are necessary is that every other branches
leading to an error return are jumping to the same destination.
v2: add a commit message to the first patch
---
drivers/staging/rts5208/ms.c | 18 +
mg_get_local_EKB and mg_get_ICV used to return with an error code before
releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/stagi
This patch changes label names using camel case to snake case as well as giving
a new name representing what will be done after the label.
Signed-off-by: Quentin Lambert
---
v2: add a commit message
drivers/staging/rts5208/ms.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-
sunbing writes:
> On Aug 11, 2016, at 23:25, Jes Sorensen wrote:
>
>> Bing Sun writes:
>>> Fixed sparse parse error:
>>> Expected constant expression in case statement.
>>>
>>> Signed-off-by: Bing Sun
>>> ---
>>> drivers/staging/rtl8723au/os_dep/os_intfs.c | 11 +--
>>> 1 file changed,
On Thu, 11 Aug 2016 14:09:53 +0200
Vitaly Kuznetsov wrote:
> Yuval Mintz writes:
>
> >> +static void netvsc_inject_enable(struct net_device_context
> >> +*net_device_ctx) {
> >> + net_device_ctx->vf_inject = true;
> >> +}
> >> +
> >> +static void netvsc_inject_disable(struct net_device_context
> Nothing what I would find noteworthy for increasing the usage of a function
> like "dev_err".
>
> Are you on "a mission" to improve software around logging calls a bit more?
I have two of those cards and I would like to know which one caused an
error. dev_err helps with exactly that.
signat
ARE YOU LOOKING TO START A NEW BUSINESS?
ARE YOU LOOKING TO DEVELOP AN EXISTING BUSINESS?
ARE YOU LOOKING FOR FINANCE FOR A PROJECT OR BUSINESS?
ARE YOU LOOKING SEEKING FINANCE FOR A REAL-ESTATE DEVELOPMENT?
ARE YOU SEEKING FINANCE TO PURCHASE OR INVEST IN PROPERTIES?
OR YOU SEEK A 100% BUSINESS/PR
On Thu, 2016-08-11 at 07:48 +0200, SF Markus Elfring wrote:
> Prefer usage of the macro "pr_err" over the interface "printk".
Not correct
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c
> b/drivers/staging/ks7010/ks7010_sdio.c
[]
> @@ -998,11 +998,11 @@ static int ks7010_sdio_probe(struct sdi
For hardening, the driver structure containing function pointers can
be marked read only after initial registration is done.
Signed-off-by: Stephen Hemminger
---
drivers/hid/hid-hyperv.c |2 +-
drivers/input/serio/hyperv-keyboard.c |2 +-
drivers/net/hyperv/netvsc_drv.c
Сo6ерем gля Bас nо uнmeрнem 6азу qaнных nоmенцuальныx kлиентов gля Вaшero
Бuзнесa! B бaзe 6yqут вce контакmные qанные неoбxoдимые gля мacсoвoй nрogажu
Baшиx товapoв и уcлуr. Пo Вашeмy зaпрoсy пpишлeм npuмep и noqpo6ную инфopмaцию.
Еcли интеpecно зanpоcите nogpо6носmи cейчас МАЙЛ: bawupecoda-3...
On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger
wrote:
>
> For hardening, the driver structure containing function pointers can
> be marked read only after initial registration is done.
Yay more __ro_after_init! (Minor nit below...)
Also, I wonder if there's a way to do build-time section che
From: Vitaly Kuznetsov
Date: Thu, 11 Aug 2016 12:58:55 +0200
> We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on
> VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while
> vf_netdev is already NULL and we're trying to inject packets into NULL
> net device in netv
**
** THIS IS A WARNING MESSAGE ONLY **
** YOU DO NOT NEED TO RESEND YOUR MESSAGE **
**
The original message was received at Wed, 10 Aug 2016 08:10:26 +1000
from TPSAUS-FRSRKEN-COMB1
19 matches
Mail list logo
