Re: [lustre-devel] [PATCH v2] staging/lustre/lnet: changes value to correct type for assignment

On Jun 23, 2016, at 5:03 PM, Lidza Louina wrote: > > - Original Message - > From: oleg.dro...@intel.com > To: lidza.lou...@oracle.com > Cc: de...@driverdev.osuosl.org, gre...@linuxfoundation.org, > lustre-de...@lists.lustre.org > Sent: Thursday, June 23, 2016 12:50:01 PM GMT -08:00 US/C

[PATCH 2/6] rtlwifi: rtl8188ee: Fix potential race condition

Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock in most routines but not in rtl88e_dm_watchdog(), which could lead to a race condition. The necessary locking to prevent this condition is added. Reported-by: Pavel Andrianov Signed-off-by: Larry Finger Cc: Pavel Andrianov

[PATCH 1/6] rtlwifi: Remove unused parameter from rtl_ps_set_rf_state()

Commit 4b9d8d67b44a ("rtlwifi: rtl8192cu: Remove unused parameter") reworked this routine. Those changes were later reverted by commit d3feae41a347 ("rtlwifi: Update power-save routines for 062814 driver"). There were two changes in commit 4b9d8d67b44a. The first of these removed a parameter from

[PATCH 3/6] rtlwifi: rtl8192ee: Fix potential race condition

Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock in most routines but not in rtl92ee_dm_watchdog(), which could lead to a race condition. The necessary locking to prevent this condition is added. Reported-by: Pavel Andrianov Signed-off-by: Larry Finger Cc: Pavel Andrianov

[PATCH 0/6] rtlwifi: Miscellaneous fixes and cleanups

This set of patches removes an unused paramter from routine rtl_ps_set_rf_state() in rtlwifi. The routine is also no longer exported. In addition, a potential race condition in 5 of the drivers is fixed. This material is suitable for kernel 4.8. To my knowledge, the race condition has not been sh

[PATCH 6/6] rtlwifi: rtl8821ae: Fix potential race condition

Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock in most routines but not in rtl8821ae_dm_watchdog() which could lead to a race condition. The necessary locking to prevent this condition is added. Reported-by: Pavel Andrianov Signed-off-by: Larry Finger Cc: Pavel Andriano

[PATCH 4/6] rtlwifi: rtl8723be: Fix potential race condition

Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock in most routines but not in rtl8723be_dm_watchdog(), which could lead to a race condition. The necessary locking to prevent this condition is added. Reported-by: Pavel Andrianov Signed-off-by: Larry Finger Cc: Pavel Andrian

[PATCH 5/6] rtlwifi: rtl8723ae: Fix potential race condition

Flag rfchange_inprogress in struct rtl_ps_ctl is protected by a spinlock in most routines but not in rtl8723e_dm_watchdog(), which could lead to a race condition. The necessary locking to prevent this condition is added. Reported-by: Pavel Andrianov Signed-off-by: Larry Finger Cc: Pavel Andriano

[PATCH 02/10] rtlwifi: rtl8192ce: Convert driver to use common hardware info routine

The driver for RTL8192CE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8192ce/hw.c| 83 -- 1 file changed, 12 insertions

[PATCH 01/10] rtlwifi: Create common routine to get hardware info

All of the rtlwifi family of drivers have a similar routine that acquires the hardware info from efuse and initializes a number of variables in the driver's private area. A common routine is created for all drivers to use. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann

[PATCH 04/10] rtlwifi: rtl8188ee: Convert driver to use common hardware info routine

The driver for RTL8188EE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8188ee/hw.c| 76 -- 1 file changed, 13 insertions

[PATCH 00/10] rtlwifi: Various clean-ups for the hwinfo routines

The rtlwifi family of drivers use similar routines to extract hardware information from EFUSE. This set of patches create a common routine to extract this data, and converts most of the drivers to use this routine. In addition, a complicated set of if ... else if ... else statements are present in

[PATCH 03/10] rtlwifi: rtl8192cu: Convert driver to use common hardware info routine

The driver for RTL8192CU chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8192cu/hw.c| 61 ++ 1 file changed, 15 insertions

[PATCH 06/10] rtlwifi: rtl8723ae: Convert driver to use common hardware info routine

The driver for RTL8723AE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c| 76 -- 1 file changed, 11 insertions

[PATCH 08/10] rtlwifi: rtl8821ae: Convert driver to use common hardware info routine

The driver for RTL8821AE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c| 84 +++--- 1 file changed, 11 insertions

[PATCH 10/10] rtlwifi: rtl8723ae: Clean up the hardware info routine

This driver contains some complicated if ... else if ... else constructions. These are replaced by switch statements to improve readability. Signed-off-by: Larry Finger --- .../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c| 210 +++-- 1 file changed, 107 insertions(+), 103 dele

[PATCH 07/10] rtlwifi: rtl8723be: Convert driver to use common hardware info routine

The driver for RTL8723BE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c| 74 -- 1 file changed, 12 insertions

[PATCH 05/10] rtlwifi: rtl8192ee: Convert driver to use common hardware info routine

The driver for RTL8192EE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8192ee/hw.c| 73 -- 1 file changed, 12 insertions

[PATCH 09/10] rtlwifi: rtl8192de: Convert driver to use common hardware info routine

The driver for RTL8192DE chips is converted to use the common routine for getting the hardware information. Reported-by: Arnd Bergmann Signed-off-by: Larry Finger Cc: Arnd Bergmann --- .../net/wireless/realtek/rtlwifi/rtl8192de/hw.c| 77 +- 1 file changed, 15 insertions

Re: [PATCH v2 1/2] staging: wilc1000: fix error handling in wilc_debugfs_init()

On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote: > The common format to check if a function returned an error pointer is to > use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. > > Signed-off-by: Luis de Bethencourt > Reviewed-by: Julian Calaby > --- >

Re: [PATCH v2 2/2] staging: wilc1000: fix error values in wilc_debugfs_init()

On Thu, Jun 23, 2016 at 01:36:18PM +0100, Luis de Bethencourt wrote: > If there was an error, returning -EINVAL is more appropriate than -1. > > Signed-off-by: Luis de Bethencourt > Reviewed-by: Julian Calaby > --- > drivers/staging/wilc1000/wilc_debugfs.c | 4 ++-- > 1 file changed, 2 insertio

Re: [PATCH v2 1/2] staging: wilc1000: fix error handling in wilc_debugfs_init()

On 25/06/16 22:36, Greg KH wrote: > On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote: >> The common format to check if a function returned an error pointer is to >> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. >> >> Signed-off-by: Luis de Bethencourt

Re: [PATCH 01/10] rtlwifi: Create common routine to get hardware info

On Sat, 2016-06-25 at 14:53 -0500, Larry Finger wrote: > All of the rtlwifi family of drivers have a similar routine that acquires > the hardware info from efuse and initializes a number of variables in the > driver's private area. A common routine is created for all drivers to use. [] > diff --git