Re: [PATCH v2 1/1] Staging: comedi: dmm32at: fix BIT macro issue.

2016-06-14 Thread Ian Abbott
On 14/06/16 06:53, Ravishankar Karkala Mallikarjunayya wrote: This Replace all occurences of (1< --- Changes V1 -> V2: - BIT macros added(suggested by Ian Abbott) -i.e.DMM32AT_AI_CFG_SCINT(x), DMM32AT_CTRL_PAGE(x) --- drivers/staging/comedi/drivers/dmm32at.c | 98 +++

[patch 1/2] staging: ks7010: parsing bugs in ks_wlan_read_config_file()

2016-06-14 Thread Dan Carpenter
The check for the NUL terminator is wrong so it looks like this could read beyond the end of the buffer. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/ks7010/ks7010_config.c b/drivers/staging/ks7010/ks7010_config.c index 4b495cb..fb90012 100644 --- a/drivers/staging/ks7010/ks7010_co

[patch 2/2] staging: ks7010: remove bogus NULL checks

2016-06-14 Thread Dan Carpenter
enc->rx_seq[] and enc->key[] are arrays, not pointers and they can't be NULL. Let's remove these NULL checks. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 8ef0f11..fc93028 100644 --- a/drivers/staging/ks7010/ks_wlan

Mainlining of Pyra nub joystick driver

2016-06-14 Thread Andrey Utkin
There's a pair of "nub" devices on Pyra handheld PC (https://pyra-handheld.com/), and there's driver for nub, which is going to be reworked for upstreaming. While the device itself fits most to "joystick" category, the computer itself lacks touchpad and mouse buttons, and the existing driver is cap

Re: [patch 1/2] staging: ks7010: parsing bugs in ks_wlan_read_config_file()

2016-06-14 Thread Wolfram Sang
On Tue, Jun 14, 2016 at 02:16:30PM +0300, Dan Carpenter wrote: > The check for the NUL terminator is wrong so it looks like this could > read beyond the end of the buffer. > > Signed-off-by: Dan Carpenter Thanks, however I have a patch very soon to be submitted which removes the config.c file co

Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-06-14 Thread Neil Horman
On Fri, Jun 10, 2016 at 09:47:58PM -0400, David Kershner wrote: > Resending due to imcomplete distribution list. > > This patchset comprises the first 26 patches of the previously-submitted > patchset (but retracted): > > [PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2016-06-14 Thread Neil Horman
On Fri, Jun 10, 2016 at 11:23:53PM -0400, David Kershner wrote: > This patchset is dependent on the previously-submitted patchset: > > staging: unisys: fix visorbus & visorinput issues raised by tglx > > This patchset moves drivers/staging/unisys/include to > include/linux/visorbus, and mov

Re: Mainlining of Pyra nub joystick driver

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 2:45:23 PM CEST Andrey Utkin wrote: > There's a pair of "nub" devices on Pyra handheld PC > (https://pyra-handheld.com/), and there's driver for nub, which is going > to be reworked for upstreaming. While the device itself fits most to > "joystick" category, the computer i

[PATCH 1/1] vme: Fix module autoload

2016-06-14 Thread Alessio Igor Bogani
These drivers have a PCI device ID table but the PCI module alias information is not created so module autoloading won't work. Signed-off-by: Alessio Igor Bogani --- drivers/vme/bridges/vme_ca91cx42.c | 2 ++ drivers/vme/bridges/vme_tsi148.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH] staging: sm750fb: fix block comments errors in ddk750_display.c

2016-06-14 Thread yeongjun Kim
WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: yeongjun Kim --- drivers/staging/sm750fb/ddk750_display.c |

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-14 Thread Andrey Utkin
On Tue, Jun 14, 2016 at 02:45:23PM +0300, Andrey Utkin wrote: > There's a pair of "nub" devices on Pyra handheld PC > ... Update: found drivers/input/joystick/as5011.c in mainline kernel, will look how it works with as5013 hardware. ___ devel mailing lis

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-14 Thread H. Nikolaus Schaller
> Am 14.06.2016 um 19:02 schrieb Andrey Utkin : > > On Tue, Jun 14, 2016 at 02:45:23PM +0300, Andrey Utkin wrote: >> There's a pair of "nub" devices on Pyra handheld PC >> ... > > Update: found drivers/input/joystick/as5011.c in mainline kernel, > will look how it works with as5013 hardware. Be

staging: lustre headers include outdated and wrong (c) information

2016-06-14 Thread Xose Vazquez Perez
It should be resolved ASAP. This wrong/outdated info is in every staging/lustre file. > /* > * GPL HEADER START > * > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GN

Re: staging: lustre headers include outdated and wrong (c) information

2016-06-14 Thread Greg KH
On Wed, Jun 15, 2016 at 12:25:17AM +0200, Xose Vazquez Perez wrote: > It should be resolved ASAP. Why? What's the rush, let the people who work for the companies involved change this, no one else has the right to do so. sorry, greg k-h ___ devel maili

Re: staging: lustre headers include outdated and wrong (c) information

2016-06-14 Thread Xose Vazquez Perez
On 06/15/2016 12:55 AM, Greg KH wrote: > On Wed, Jun 15, 2016 at 12:25:17AM +0200, Xose Vazquez Perez wrote: >> It should be resolved ASAP. > > Why? What's the rush, let the people who work for the companies > involved change this, no one else has the right to do so. ASAP means as soon *as poss

Re: staging: lustre headers include outdated and wrong (c) information

2016-06-14 Thread Oleg Drokin
On Jun 14, 2016, at 7:20 PM, Xose Vazquez Perez wrote: > On 06/15/2016 12:55 AM, Greg KH wrote: > >> On Wed, Jun 15, 2016 at 12:25:17AM +0200, Xose Vazquez Perez wrote: >>> It should be resolved ASAP. >> >> Why? What's the rush, let the people who work for the companies >> involved change this

Re: staging: lustre headers include outdated and wrong (c) information

2016-06-14 Thread Greg KH
On Wed, Jun 15, 2016 at 01:20:45AM +0200, Xose Vazquez Perez wrote: > On 06/15/2016 12:55 AM, Greg KH wrote: > > > On Wed, Jun 15, 2016 at 12:25:17AM +0200, Xose Vazquez Perez wrote: > >> It should be resolved ASAP. > > > > Why? What's the rush, let the people who work for the companies > > invo

[PATCH 0/5] Lustre: Remove defunct SUN addresses

2016-06-14 Thread Oleg Drokin
This patch removes a paragraph about contacting SUN Microsystems from a lot of Lustre files since there's no more SUN Microsystems. A pointer to GPLv2 URL is also switched from defunct sun.com to gnu.org. For a good measure a couple of places that refer to "Please contact Oracle" are also removed

[PATCH 5/5] staging/lustre/libcfs: Remove "Please contact Oracle" from header

2016-06-14 Thread Oleg Drokin
The "Please contact Oracle Corporation" lines are removed since not only Oracle has nothing to do with Lustre anymore, there's a pointer to GPL already that's independent of any particular company. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 4

[PATCH 3/5] staging/lustre/lov: Fix gpl URL in lov_pool.c

2016-06-14 Thread Oleg Drokin
There's no longer a matching sun.com URL, so refer to gnu.org copy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c b/drivers/staging/lustre/lustre/lo

[PATCH 4/5] staging/lustre: Remove stray line from selftest/selftest.h

2016-06-14 Thread Oleg Drokin
The 'copy of GPLv2]' is an ending from template that's no longer needed, so remove it to avoid any extra confusion. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/selftest/selftest.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/selftest.h b

[PATCH 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one.

2016-06-14 Thread Oleg Drokin
http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no longer around, so replace it with (hopefully more permanent) http://http://www.gnu.org/licenses/gpl-2.0.html Signed-off-by: Oleg Drokin Reported-by: Xose Vazquez Perez --- drivers/staging/lustre/include/linux/libcfs/curproc.h

Re: [PATCH v3] storvsc: use small sg_tablesize on x86

2016-06-14 Thread Martin K. Petersen
> "Olaf" == Olaf Hering writes: Olaf> On Thu, Jun 09, James Bottomley wrote: >> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote: >> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, > >> after > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: >> storvsc: Set > t

Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches

2016-06-14 Thread James Simmons
> > This may also possibly help to save cycles due to high usage and > > contention when using a generic kmem_cache (when they stay separate > > from others, thanks for the precision!). > > Have you measured this? > > This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug, > whic

Re: [PATCH 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one

2016-06-14 Thread Xose Vazquez Perez
Oleg Drokin wrote: > http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no > longer around, so replace it with (hopefully more permanent) > http://http://www.gnu.org/licenses/gpl-2.0.html ^^ > [...] > drivers/staging/lustre/lustre/ptlrpc/service.c| 2

Re: [PATCH 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one

2016-06-14 Thread Oleg Drokin
On Jun 14, 2016, at 11:11 PM, Xose Vazquez Perez wrote: > Oleg Drokin wrote: > >> http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no >> longer around, so replace it with (hopefully more permanent) >> http://http://www.gnu.org/licenses/gpl-2.0.html >^^ > >> [...] >> dri

[PATCH v2 5/5] staging/lustre/libcfs: Remove "Please contact Oracle" from header

2016-06-14 Thread Oleg Drokin
The "Please contact Oracle Corporation" lines are removed since not only Oracle has nothing to do with Lustre anymore, there's a pointer to GPL already that's independent of any particular company. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 4

[PATCH v2 0/5] Remove defunct SUN addresses

2016-06-14 Thread Oleg Drokin
This patchset removes a paragraph about contacting SUN Microsystems from a lot of Lustre files since there's no more SUN Microsystems. A pointer to GPLv2 URL is also switched from defunct sun.com to gnu.org. For a good measure a couple of places that refer to "Please contact Oracle" are also remo

[PATCH v2 4/5] staging/lustre: Remove stray line from selftest/selftest.h

2016-06-14 Thread Oleg Drokin
The 'copy of GPLv2]' is an ending from template that's no longer needed, so remove it to avoid any extra confusion. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/selftest/selftest.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/selftest.h b

[PATCH v2 3/5] staging/lustre/lov: Fix gpl URL in lov_pool.c

2016-06-14 Thread Oleg Drokin
There's no longer a matching sun.com URL, so refer to gnu.org copy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c b/drivers/staging/lustre/lustre/lo

[PATCH v2 2/5] staging/lustre: Replace sun.com GPLv2 URL with gnu.org one.

2016-06-14 Thread Oleg Drokin
http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no longer around, so replae it with (hopefully more permanent) http://http://www.gnu.org/licenses/gpl-2.0.html Signed-off-by: Oleg Drokin Reported-by: Xose Vazquez Perez --- drivers/staging/lustre/include/linux/libcfs/curproc.h

[PATCH v2 0/5] *** staging: wilc1000: Replace semaphores with mutexes or completions ***

2016-06-14 Thread Binoy Jayan
These are a set of patches [v2] which removes semaphores from: drivers/staging/wilc1000 These are part of a bigger effort to eliminate all semaphores from the linux kernel. They build correctly (individually and as a whole). NB: The changes are untested Changes w.r.t. review comments on v1 1.

[PATCH v2 1/5] staging: wilc1000: Replace semaphore txq_event with completion

2016-06-14 Thread Binoy Jayan
The semaphore 'txq_event' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan --- drivers/staging/wilc1000/linux_wlan.c | 8 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 3 ++- drivers/staging/wilc1000/wilc_wlan.c | 8 +---

[PATCH v3 0/5] *** staging: wilc1000: Replace semaphores with mutexes or completions ***

2016-06-14 Thread Binoy Jayan
These are a set of patches [v3] which removes semaphores from: drivers/staging/wilc1000 These are part of a bigger effort to eliminate all semaphores from the linux kernel. They build correctly (individually and as a whole). NB: The changes are untested Changes w.r.t. review comments on v1 1.

[PATCH v3 1/5] staging: wilc1000: Replace semaphore txq_event with completion

2016-06-14 Thread Binoy Jayan
The semaphore 'txq_event' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 8 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 3 ++- drivers/staging/wilc1000/wilc_

[PATCH v3 2/5] staging: wilc1000: Replace semaphore txq_add_to_head_cs with mutex

2016-06-14 Thread Binoy Jayan
The semaphore 'txq_add_to_head_cs' is a simple mutex, so it should be written as one. Semaphores are going away in the future. Also, removing the timeout scenario as the error handling code does not propagate the timeout properly. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- driver

[PATCH v3 4/5] staging: wilc1000: Replace semaphore sync_event with completion

2016-06-14 Thread Binoy Jayan
The semaphore 'sync_event' is used as completion, so convert it to a struct completion type. Also, return -ETIME if the return value of wait_for_completion_timeout is 0. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 10 +- driv

[PATCH v3 5/5] staging: wilc1000: Remove semaphore close_exit_sync

2016-06-14 Thread Binoy Jayan
The semaphore 'close_exit_sync' does not serve any purpose other than delaying the deregistration of the device which it is trying to protect from shared access. 'up' is called only when a subdevice is closed and not when it is opened. So, the semaphore count only goes up when the device is used.

[PATCH v3 3/5] staging: wilc1000: Replace semaphore cfg_event with completion

2016-06-14 Thread Binoy Jayan
The semaphore 'cfg_event' is used as completion, so convert it to a struct completion type. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.

[PATCH v2] staging: gdm724x: Replace semaphore netlink with mutex

2016-06-14 Thread Binoy Jayan
Replace semaphore netlink_mutex with mutex. Semaphores are going away in the future. Signed-off-by: Binoy Jayan Reviewed-by: Arnd Bergmann --- drivers/staging/gdm724x/netlink_k.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/gdm724x/netlink_k.c