Re: [PATCH 1/2 v2] staging: dgnc: remove redundant NULL check for brd

2016-05-27 Thread Luis de Bethencourt
On 27/05/16 02:42, Daeseok Youn wrote: > the "brd" value cannot be NULL in dgnc_finalize_board_init(). > Because "brd" as a parameter of this function was already > checked for NULL. > > the dgnc_finalize_board_init() as a static function was called > only from dgnc_found_board() function and brd-

Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in

2016-05-27 Thread Luis de Bethencourt
On 27/05/16 02:43, Daeseok Youn wrote: > the "brd" was already checked for NULL before calling dgnc_do_remap(). > > the dgnc_do_remap() function was called only > from the dgnc_found_board() and the DGNC_BOARD_MAGIC value > was assigned to "brd->magic" in dgcn_found_board(). So it doesn't > need t

Re: [PATCH 1/7] staging: dgnc: remove useless variable 'intr_count'

2016-05-27 Thread Luis de Bethencourt
On 27/05/16 07:52, Daeseok Youn wrote: > The 'intr_count' variable was used only for increasing. > So the 'intr_count' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 2 -- > drivers/staging/dgnc/dgnc_driver.h | 1 - > drivers/

Re: [PATCH 2/7] staging: dgnc: remove unused variable 'intr_modem'

2016-05-27 Thread Luis de Bethencourt
On 27/05/16 07:53, Daeseok Youn wrote: > The 'intr_modem' variable was used only for increasing. > So the 'intr_modem' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 1 - > drivers/staging/dgnc/dgnc_driver.h | 1 - > drivers/s

Re: [PATCH 7/7] staging: dgnc: remove useless variable 'ch_intr_rx'

2016-05-27 Thread Luis de Bethencourt
On 27/05/16 07:55, Daeseok Youn wrote: > The 'ch_intr_rx' variable was used only for increasing. > So the 'ch_intr_rx' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 1 - > drivers/staging/dgnc/dgnc_driver.h | 2 -- > drivers/

CONGRATULATIONS!!!

2016-05-27 Thread Frau, Julia Gomez
PLAZA DE CASTRE E-28830, MADRID, SPAIN Tel: 0034-698-238-766 Fax: 0034-911-881-416 Ref Number: PLATUK/9GM/327739 Batch Number: PLAT-ENGINE08920 Dear Internet User, FINAL AWARD NOTIFICATIONS!!! We congratulate you over your success in the following official publicat

[PATCH] staging/wilc1000: fixes kzalloc call

2016-05-27 Thread Lidza Louina
The wl pointer was initialized as a pointer to a struct wilc and assigned to a piece of memory the size of the pointer. It should be the size of struct wilc. Signed-off-by: Lidza Louina --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01

2016-05-27 Thread Kalle Valo
Larry Finger wrote: > Commit 49f86ec21c01 ("rtlwifi: Change long delays to sleeps") was correct > for most cases; however, driver rtl8192ce calls the affected routines while > in atomic context. The kernel bug output is as follows: > > BUG: scheduling while atomic: wpa_supplicant/627/0x0002 >

[PATCH] staging/android: sync_debug: unproxify debugfs files' fops

2016-05-27 Thread Nicolai Stange
9d200deaa68 ("debugfs: prevent access to removed files' private data") Fixes: a44eb74cd413 ("staging/android: move SW_SYNC_USER to a debugfs file") Signed-off-by: Nicolai Stange --- Applicable to linux-next-20160527. x86_64 allm

Re: [PATCH] staging/wilc1000: fixes kzalloc call

2016-05-27 Thread Joe Perches
On Fri, 2016-05-27 at 13:51 -0400, Lidza Louina wrote: > The wl pointer was initialized as a pointer to a struct wilc and > assigned to a piece of memory the size of the pointer. It should be the > size of struct wilc. This isn't necessary. The code in question is: struct wilc *wl;

Re: [PATCH] staging/android: sync_debug: unproxify debugfs files' fops

2016-05-27 Thread Greg Kroah-Hartman
es: a44eb74cd413 ("staging/android: move SW_SYNC_USER to a debugfs > file") > Signed-off-by: Nicolai Stange > --- > Applicable to linux-next-20160527. > x86_64 allmodconfig build succeeds w/o any new warnings. > > Related discussion can be found here: &

Re: [PATCH] staging/wilc1000: fixes kzalloc call

2016-05-27 Thread Lidza Louina
On 05/27/2016 02:07 PM, Joe Perches wrote: On Fri, 2016-05-27 at 13:51 -0400, Lidza Louina wrote: The wl pointer was initialized as a pointer to a struct wilc and assigned to a piece of memory the size of the pointer. It should be the size of struct wilc. This isn't necessary. The code in qu

CONGRATULATIONS!!!

2016-05-27 Thread Frau, Julia Gomez
PLAZA DE CASTRE E-28830, MADRID, SPAIN Tel: 0034-698-238-766 Fax: 0034-911-881-416 Ref Number: PLATUK/9GM/327739 Batch Number: PLAT-ENGINE08920 Dear Internet User, FINAL AWARD NOTIFICATIONS!!! We congratulate you over your success in the following official publicat

21/05/2016

2016-05-27 Thread Email-alert
Economic Community of West African States (ECOWAS) Investigation Officer Accra Ghana. Attention, After proper and several investigations and research at Western Union and Money Gram Office, we found your name among those that have been scammed and swindled by those unscrupulous persons. In this

[PATCH v2 2/4] Staging: comedi: Fix WARNING issue in s626.c

2016-05-27 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a Block comments issues found by the checkpatch.pl tool. i.e. Block comments use a trailing */ on a separate line Signed-off-by: Ravishankar Karkala Mallikarjunayya --- changes since v1: No change --- drivers/staging/comedi/drivers/s626.c | 60 ++

[PATCH v2 1/4] staging : comedi : fix type issues in s626.c

2016-05-27 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a type issues like i.e Prefer kernel type 'u8' over 'uint8_t' Prefer kernel type 'u16' over 'uint16_t' Prefer kernel type 'u32' over 'uint32_t' Prefer kernel type 's16' over 'int16_t' Prefer kernel type 's32' over 'int32_t' found by t

[PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

2016-05-27 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a line over 80 characters issues found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya --- changes since v1: No change --- drivers/staging/comedi/drivers/s626.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c

2016-05-27 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a WARNING: Prefer 'unsigned int' to bare use of 'unsigned' found by the checkpatch.pl tool Signed-off-by: Ravishankar Karkala Mallikarjunayya --- changes since v1: No change --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4