Re: [PATCH 05/15] staging: lustre: ldlm: use accessor macros for l_flags

2016-04-28 Thread Dan Carpenter
On Wed, Apr 27, 2016 at 03:51:09PM -0700, Bruce Korb wrote: > Wow! I remember this stuff, even if from 3 years ago. Feels like a > lifetime. Is this patch being applied to official Linux, hence this > message? Xyratex collapsed, shed a mess of employees and sold the > remnant to Seagate. Conse

Re: Staging: VME Framework for the Linux Kernel

2016-04-28 Thread Martyn Welch
On 14/04/16 10:42, Dan Carpenter wrote: Hello Martyn Welch, The patch a17a75e2666f: "Staging: VME Framework for the Linux Kernel" from Jul 31, 2009, leads to the following static checker warning: drivers/vme/vme.c:161 vme_get_size() error: uninitialized variable 'size'. drive

Re: [PATCH 00/12] De-stage Sync File Framework

2016-04-28 Thread Gustavo Padovan
2016-04-27 Daniel Vetter : > On Wed, Apr 27, 2016 at 01:27:07PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Hi, > > > > This patchset sits on top of Sync ABI Rework v13: > > > > https://www.spinics.net/lists/dri-devel/msg105667.html > > > > The first eight clean up and pre

[PATCH v2 04/13] staging/android: make sync_file_merge() static

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan There is no plan in the near future to use this function outside of this file so keep it as static. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync.c | 5 ++--- drivers/staging/android/sync.h | 2 -- 2 files changed, 2 insertion

[PATCH v2 03/13] staging/android: move sync_file functions comments to sync.c

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan To keep comments in line with drivers/dma-buf/ move all sync_file comments to sync.c. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync.c | 26 +- drivers/staging/android/sync.h | 31 ---

[PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan struct sync_merge_data already have documentation on top of the struct definition. No need to duplicate it. Signed-off-by: Gustavo Padovan Reviewed-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/staging/android/uapi/sync.h | 10 +- 1 file changed,

[PATCH v2 06/13] staging/android: remove name arg from sync_file_create()

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Simplifies the API to only receive the fence it needs to add to the sync and create a name for the sync_file based on the fence context and seqno. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync.c | 16 +--- dr

[PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put()

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan These two functions are just wrappers for one line functions, they call fd_install() and fput() respectively, so just get rid of them and use fd_install() and fput() directly for more simplicity. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/stagi

[PATCH v2 00/13] De-stage Sync File Framework

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Hi, This patchset sits on top of Sync ABI Rework v13: https://www.spinics.net/lists/dri-devel/msg105667.html The first eight clean up and prepare sync_file for de-staging. The last four patches do the de-staging, moving files to drivers/dma-buf/ and include/linux/ plus ad

[PATCH v2 07/13] staging/android: prepare sync_file for de-staging

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Move its functions and structs to their own file. Also moves function's docs to the .c file. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/Makefile | 2 +- drivers/staging/android/sync.c | 37

[PATCH v2 05/13] staging/android: make sync_file_fdget() static

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan There is no plan in the near future to use this function outside of this file so keep it as static. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync.c | 3 +-- drivers/staging/android/sync.h | 1 - 2 files changed, 1 insertion(+)

[PATCH v2 11/13] dma-buf/sync_file: de-stage sync_file

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan sync_file is useful to connect one or more fences to the file. The file is used by userspace to track fences between drivers that share DMA bufs. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/Kconfig | 2 ++ drive

[PATCH v2 13/13] Documentation: add Sync File doc

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Add sync_file documentation on dma-buf-sync_file.txt Reviewed-by: Daniel Vetter --- Documentation/sync_file.txt | 69 + 1 file changed, 69 insertions(+) create mode 100644 Documentation/sync_file.txt diff --git a/Documentation/

[PATCH v2 10/13] dma-buf/sync_file: de-stage sync_file headers

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Move sync_file headers file to include/ dir. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync.h | 4 ++-- drivers/staging/android/sync_debug.c | 2 +- drivers/staging/

[PATCH v2 09/13] staging/android: style fix: alignment to match the open parenthesis

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Fix checks reported by checkpatch.pl. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync_file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/sync_file.c b/drivers/staging/andr

[PATCH v2 08/13] staging/android: improve documentation for sync_file

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan num_fences was missing a colon mark and sync_file_create() now have better description. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- drivers/staging/android/sync_file.c | 5 +++-- drivers/staging/android/sync_file.h | 2 +- 2 files changed, 4 insertions(

[PATCH v2 12/13] Documentation: include sync_file into DocBook

2016-04-28 Thread Gustavo Padovan
From: Gustavo Padovan Add entry in device-drivers.tmpl for sync_file documentation. Signed-off-by: Gustavo Padovan Reviewed-by: Daniel Vetter --- Documentation/DocBook/device-drivers.tmpl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/DocBook/device-drivers.tmpl b/Docume

Re: [RFC v2 1/8] dma-buf/fence: add fence_collection fences

2016-04-28 Thread Gustavo Padovan
2016-04-26 Chris Wilson : > On Mon, Apr 25, 2016 at 07:33:21PM -0300, Gustavo Padovan wrote: > > +static const char *fence_collection_get_timeline_name(struct fence *fence) > > +{ > > + return "no context"; > > "unbound" to distinguish from fence contexts within a timeline? > > > +static bool

Re: [RFC v2 8/8] drm/fence: add out-fences support

2016-04-28 Thread Gustavo Padovan
2016-04-26 Daniel Vetter : > On Mon, Apr 25, 2016 at 07:33:28PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Support DRM out-fences creating a sync_file with a fence for each crtc > > update with the DRM_MODE_ATOMIC_OUT_FENCE flag. > > > > We then send an struct drm_out_fence

[PATCH 2/8] staging: lustre: echo: remove echo_env_info() regions from echo_client.c

2016-04-28 Thread James Simmons
From: "John L. Hammond" This function declartion is not needed so remove it. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-on: http://review.whamcloud.com/5580 Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin S

[PATCH 3/8] staging: lustre: brw: added OBDO short io flag

2016-04-28 Thread James Simmons
From: Alexander Boyko To prevent collisions with any future flags needed in features written against this branch. Signed-off-by: Alexander Boyko Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1757 Xyratex-bug-id: MRP-1460 Reviewed-on: http://review.whamcloud.com/8182 Reviewed-by: Andreas D

[PATCH 7/8] staging: lustre: debugfs: improve osc/mdc "imports" connect data

2016-04-28 Thread James Simmons
From: Emoly Liu Improve /sys/debug/fs/lustre/{osc,mdc}/*/import files to print the struct obd_connect_data data fields as "connect_data:" in addition to the "connect_flags:" field. Signed-off-by: Emoly Liu Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3386 Reviewed-on: http://review.whamc

[PATCH 8/8] staging: lustre: llite: quiet overly verbose info message

2016-04-28 Thread James Simmons
From: Andreas Dilger The client doesn't need to print a message for every client mount that the layout lock feature is enabled. This can be found at runtime via the "import" proc file. I also noticed that deleting OST objects logs into the debug log with D_HA status, which is enabled by default

[PATCH 0/8] staging : lustre : missing fixes for lustre 2.5.53

2016-04-28 Thread James Simmons
This next set of patches covers what is in the upstream client that is present in lustre 2.5.53 Alexander Boyko (1): staging: lustre: brw: added OBDO short io flag Andreas Dilger (1): staging: lustre: llite: quiet overly verbose info message Emoly Liu (2): staging: lustre: obd: add case LC

[PATCH 4/8] staging: lustre: fld: add local fldb to each target

2016-04-28 Thread James Simmons
From: wang di Add local FLDB to each MDT, so OSD/OUT can check whether FID is remote by looking up local FLDB, i.e. no need send RPC to MDT0. This is just the client part of the work. Signed-off-by: wang di Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4076 Reviewed-on: http://review.wham

[PATCH 1/8] staging: lustre: debug: initialize debug_msg_data if needed

2016-04-28 Thread James Simmons
From: Oleg Drokin initialize the libcfs_debug_msg_data only if needed Signed-off-by: Oleg Drokin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1408 Reviewed-on: http://review.whamcloud.com/8338 Reviewed-by: Jinshan Xiong Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin Signed-off-

[PATCH 6/8] staging: lustre: obd: add case LCFG_PARAM to osd_process_config

2016-04-28 Thread James Simmons
From: Emoly Liu Some proc parameters were moved from ofd to osd module and only their symlinks were kept in ofd for interoperability/compatibility. To process this kind of config params passed by ofd, this patch is to do the following fixes: - since these parameters are not included by the stat

[PATCH 5/8] staging: lustre: ldlm: dont always check max_pages_per_rpc alignement

2016-04-28 Thread James Simmons
From: Sebastien Buisson If connection is not established yet, cli->cl_chunkbits is uninitilized so we cannot use it to check max_pages_per_rpc alignment. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4379 Reviewed-on: http://review.whamcloud.com/8558 Revie

[PATCH 1/8] staging: rtl8192u: check return value of read_nic_word_E

2016-04-28 Thread Salah Triki
The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 -- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- 2 files changed, 25 ins

[PATCH V3 0/8] staging: rtl8192u: Checking return value/propagating errors

2016-04-28 Thread Salah Triki
These patchs check the return value/propagate error of the functions read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_*. Salah Triki (8): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: check return value eprom_read staging: rtl8192u: prop

[PATCH 3/8] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

2016-04-28 Thread Salah Triki
Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/staging/

[PATCH 7/8] staging: rtl8192u: propagate errors in write_nic_word

2016-04-28 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) d

[PATCH 2/8] staging: rtl8192u: check return value eprom_read

2016-04-28 Thread Salah Triki
The call of eprom_read may fail, therefore its return value must be checked. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 147 +++-- 1 file changed, 104 insertions(+), 43 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/d

[PATCH 6/8] staging: rtl8192u: propagate errors in write_nic_byte_E

2016-04-28 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-)

[PATCH 8/8] staging: rtl8192u: propagate errors in write_nic_dword

2016-04-28 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-)

[PATCH 5/8] staging: rtl8192u: propagate errors in write_nic_byte

2016-04-28 Thread Salah Triki
Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 12 +++- 2 files changed, 8 insertions(+), 6 deletions

[PATCH 4/8] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

2016-04-28 Thread Salah Triki
The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki --- drivers/staging/rtl8192u/r8192U_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r

[PATCH v2] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

2016-04-28 Thread Jandy Gou
make C=1 M=drivers/staging/rtl8723au/ drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to restricted __le32 Signed-off-by: Jandy Gou --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 1

Re: [PATCH v2] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

2016-04-28 Thread Jes Sorensen
Jandy Gou writes: > make C=1 M=drivers/staging/rtl8723au/ > > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to > restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to > restricted __le32 > > Signed-off-by: Jandy Gou > --- > drivers/sta

Re: [PATCH 1/2] staging: wilc1000: fix double unlock

2016-04-28 Thread Greg Kroah-Hartman
On Thu, Apr 14, 2016 at 08:48:48PM +0530, Sudip Mukherjee wrote: > The semaphore was being released twice, once at the beginning of the > thread and then again when the thread is about to close. > The semaphore is acquired immediately after creating the thread so we > should be releasing it when th

[PATCH] staging: rts5208: Unnecessary parantheses around chip->sd_card

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra --- drivers/staging/rts5208/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index 87d6976..fbd2f90 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@

[PATCH] staging: rts5208: Avoid multiple assignment in one line

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra --- drivers/staging/rts5208/rtsx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 25d095a..77c2580 100644 --- a/drivers/staging/rts5208/rtsx.c +++ b/drivers/staging/rts520

Re: [PATCH] staging: rts5208: Avoid multiple assignment in one line

2016-04-28 Thread Greg KH
On Thu, Apr 28, 2016 at 10:30:49PM -0700, Manav Batra wrote: > Signed-off-by: Manav Batra I can't take patches without any changelog text :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/dri

[PATCH] staging: rts5208: Avoid multiple assignment in one line

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra Separates out assignment in one line to two lines. --- drivers/staging/rts5208/rtsx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 25d095a..77c2580 100644 --- a/drivers

[PATCH] staging: rts5208: Alignment should match open paranthesis

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra Fixed alignment of parantheses. --- drivers/staging/rts5208/ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index 0f0cd4a..6c5ef29 100644 --- a/drivers/staging/rts5208/ms.c +++ b/drive

[PATCH] staging: sm750fb: Braces {} on all arms

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra Applied braces on all arms of the statement. --- drivers/staging/sm750fb/ddk750_chip.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index f80ee77..7748862 10064

[PATCH] staging: sm750fb: Comparison to NULL fixed

2016-04-28 Thread Manav Batra
Signed-off-by: Manav Batra Improved comparison to NULL and removed some blank lines. --- drivers/staging/sm750fb/ddk750_dvi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index a4a2550..bac