On 11/04/16 19:23, H Hartley Sweeten wrote:
Tidy up the comments to fix the checkpatch.pl isses:
WARNING: Block comments use * on subsequent lines
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amcc_
On 11/04/16 19:18, H Hartley Sweeten wrote:
Rename the enum value to fix the checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
On 11/04/16 19:32, H Hartley Sweeten wrote:
Tidy up the defines to fix the checkpatch.pl issues:
CHECK: Prefer using the BIT macro
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_8254.h | 14 --
1 file changed, 8
On 11/04/16 19:12, H Hartley Sweeten wrote:
Fix the checkpatch.pl issues in this file.
H Hartley Sweeten (3):
staging: comedi: ni_stc.h: Prefer 'unsigned int' to bare use of 'unsigned'
staging: comedi: ni_stc.h: Prefer kernel type 'u8' over 'uint8_t'
staging: comedi: ni_stc.h: tidy up b
Fix libcfs_ioctl() prototype according to its definition in
libcfs/module.c.
Signed-off-by: Aleksei Fedotov
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
b/drivers
Remove a void pointer in rtw_security.c
Signed-off-by: Ben Marsh
---
drivers/staging/rtl8723au/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_security.c
b/drivers/staging/rtl8723au/core/rtw_security.c
index 038b57b..9d2
On Tue, Apr 12, 2016 at 01:30:55PM +0200, Ben Marsh wrote:
> Remove a void pointer in rtw_security.c
That's not what the patch does :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev
Turn typedef lstcon_test_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conctl.c |2 +-
drivers/staging/lustre/lnet/selftest/conrpc.c |5 ++-
drivers/staging/lustre/lnet/selftest/console.c | 26
drivers/staging/lus
Change all the wire protocol typedefs to proper structures
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 22 ++--
drivers/staging/lustre/lnet/selftest/conrpc.c| 44 +++---
drivers/staging/lustre/lnet/selftest/console.c | 10 +-
drivers/staging/lu
Convert the remaining typedefs into their proper data types.
Changelog:
v1) Based on 4.6-rc1 staging tree. Most patches were merged.
v2) Rebased on 4.6-rc3 due to PAGE_CACHE_* going away.
James Simmons (2):
staging: lustre: selftest: convert lstcon_test_t to proper struct
staging: lustre: s
> Fix libcfs_ioctl() prototype according to its definition in
> libcfs/module.c.
>
> Signed-off-by: Aleksei Fedotov
Acked-by: James Simmons
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/l
> Some of this series didn't apply, due to merge issues with 4.6-rc3. Can
> you rebase and resend the remaining patches?
This patch conflicts with a patch landed from Oleg which is a better
solution for this bug. We can drop this patch.
>
> thanks,
>
> greg k-h
>
> On Mon, Apr 04, 2016 at 0
This is the last collection of missing fixes present in the
Lustre 2.5.0 release. Once these are merged the upstream
client will be equal to the pre-2.6 lustre version since the
major of clio cleanups from that time frame have already
landed.
changelog:
v1) Based on 4.6-rc1.
v2) Rebased for 4.6-
From: Sebastien Buisson
Fix 'data race condition' defects found by Coverity version 6.5.0:
Data race condition (MISSING_LOCK)
Accessing variable without holding lock. Elsewhere,
this variable is accessed with lock held.
This patch is dedicated to code fragments involving oap_lock.
Signed-off-
From: Niu Yawei
Fixed several incorrect assumptions in 'enable-invariants'.
Signed-off-by: Niu Yawei
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3521
Reviewed-on: http://review.whamcloud.com/6832
Reviewed-by: Bobi Jam
Reviewed-by: Jinshan Xiong
Reviewed-by: Oleg Drokin
Signed-off-by:
From: Jinshan Xiong
Otherwise it will hit the assertion at cl_lock.c:
cl_lock.c:1967:discard_cb())
ASSERTION( (!(page->cp_type == CPT_CACHEABLE) ||
(!PageWriteback(cl_page_vmpage(env, page ) failed:
This is because in osc_lock_flush() we have to make sure the IO
is finished before disc
From: Jinshan Xiong
The root cause is that when max_cache_mb conf parameter is applied,
the client isn't connected to the OST yet so that sbi->ll_dt_exp is
NULL. However, it's not necessary to shrink the cache memory in this
case so success should be returned.
Signed-off-by: Jinshan Xiong
Intel
From: Andrew Perepechko
Assume dchild argument is fully initialized in ->unlink and
->rmdir callbacks, so additional lookup for ELC is not needed.
Signed-off-by: Andrew Perepechko
Reviewed-by: Alexander Boyko
Reviewed-by: Vitaly Fertman
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3473
From: Bobi Jam
If we specify multiple --mgsnode for a MDT, when we start MDS upon
it while MGS is no the other node, the MGC import connection will
always select the local nid (which is one of the candidate mgsnode)
since it think its the closest connection.
This patch treats further --mgsnode n
From: Andriy Skulysh
Patch for LU-631 which was landed before the upstream merge broke
OBD_STATFS_NODELAY behaviour. It adds unnecessary delay while
running df command with inactive OSTs. We shouldn't try to recover
connection to OST in this case.
Signed-off-by: Andriy Skulysh
Intel-bug-id: htt
From: Andrew Perepechko
This patch implements log2 using fls.
Signed-off-by: Andrew Perepechko
Reviewed-by: Alexander Boyko
Reviewed-by: alexander_zarochent...@xyratex.com
Reviewed-by: Vitaly Fertman
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3496
Xyratex-bug-id: MRP-999
Reviewed-on:
From: Swapnil Pimpale
This patch has the following:
1) Fix for the return value from ptlrpcd_init(). It will now return a
correct status instead of returning zero always.
2) ptlrpcd_addref() should not increment ptlrpcd_users on error.
3) Added code in a mdc_setup() and mgc_setup() to test the
From: Bruno Faccini
Since st_blocks = NULL is returned for released files, FIEMAP
should at least return a minimal mapping to make users aware
that file contains data but it is not immediately available.
This will make coreutils and tools such tar happy and have
them presume file is sparse.
Also
From: John L. Hammond
In the LL_IOC_HSM_CT_START case of ll_dir_ioctl() require
CAP_SYS_ADMIN, since the local handler for this ioctl may modify the
global KUC table.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3866
Reviewed-on: http://review.whamcloud.com
From: John L. Hammond
In the MDC HSM handlers that do not pack a real suppgid, use -1 rather
than 0 for the suppgid in mdt_body.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3866
Reviewed-on: http://review.whamcloud.com/7565
Reviewed-by: Aurelien Degremont
From: Andrew Perepechko
With the patch 6648 a fee variables were renamed. We do these
renames in broken out patch to the fix obvious.
Signed-off-by: Andrew Perepechko
Reviewed-by: Alexander Boyko
Reviewed-by: Vitaly Fertman
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3473
Xyratex-bug-
From: Bruno Faccini
Follow-on to patch introduced to fix LU-2665 ticket (Gerrit
Change at http://review.whamcloud.com/6415 with Change-Id:
I8faa331712abeadee46eabe111ee1c23a05840d5).
Original patch introduced regressions against POSIX test suite
(fcntl.18/fcntl.35 tests in LSB-VSX POSIX test suit
From: Jinshan Xiong
Truncate up is safe so it won't trigger restore.
Copy optimization for truncate down - only copy the part under
truncate length. If a file is truncated to zero usually it'll be
followed by write so I choose to restore the file and set correct
stripe information.
Signed-off-b
From: Bruno Faccini
Protect against race where lock could have been just destroyed
due to overlap, in ldlm_process_flock_lock().
Easy reproducer is BULL's NFS Locktests in pthread mode.
(http://nfsv4.bullopensource.org/tools/tests/locktest.php)
Signed-off-by: Bruno Faccini
Intel-bug-id: https:/
Variable lustre_profile_list is only used inside obd_config.c,
better make it static
Signed-off-by: Iban Rodriguez
---
drivers/staging/lustre/lustre/obdclass/obd_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c
b/dr
The 'bits' value passed to this function is properly set by the callers
so the BUG_ON() can never occur when writing to the NITIO_G[01]_INT_ENA
and NITIO_G01_RESET registers. Remove the BUG_ON() checks.
For aesthetic, also remove the static const variables. They don't add
any additional clarity.
For aesthetics, remove this local variable to fix the checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a
Absorb the inline helper functions that call ni_set_bitfield() to clear
the dma channel selection bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 35 ++
1 file changed, 8 insertions(+), 27
Fix the checkpatch.pl issues:
CHECK: Logical continuations should be on the previous line
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --gi
Fix the checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.h | 2 +-
drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
dif
The AO subdevice (*cancel), ni_ao_reset(), always sets the private
data 'ao_trigger_select' to 0. So when a command is started the
'trigsel' value in ni_ao_cmd_set_trigger() will always start as 0.
Remove the unnecessary member from the private data.
The (*do_cmdtest) validates that the cmd->start
The mite dma channels are only requested by a subdevice with a (*do_cmd)
and they are released by a (*cancel). The comedi core will only call the
(*do_cmd) if the subdevice is not already running a command and all
commands are terminated by the core with a (*cancel).
Remove the BUG_ON() checks in
Generally comedi drivers use 'unsigned int' types instead of the kernel type
'u32' for unsigned 32-bit values.
For aesthetics, change all the 'u32' and 'uin32_t' types and fix the
checkpatch.pl issues about:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
The various i/o helpers use for reading a
Tidy up the functions that request the mite dma channels by absorbing the
inline helper functions that call ni_set_bitfield() to set the channel
selection bits.
Add support for the NI_M_CDIO_DMA_SEL_REG register to ni_set_bitfield()
so that all the soft_reg_copy_lock spinlocking is done in one pla
The inline helper ni_stc_dma_channel_select_bitfield() returns the
bits needed to select a MITE channel to use for DMA. The MITE code
is setup to handle up to 8 channels but in reality only channels 0
to 3 are used by most of the drivers. The PCI-6032E and PCI-6033E
boards can also use channels 4 a
This "driver" is is bit of a mess. It's included by the ni_atmio, ni_mio_cs,
and ni_pcimio drivers instead of being a separate module.
Do some cleanup so I can work out what is needed to make it a module.
This fixes all the checkpatch.pl issues except for two:
CHECK: if this code is redundant con
Fix the checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/staging/come
This file is is bit of a mess. It's included by the ni_atmio, ni_mio_cs, and
ni_pcimio drivers. The ni_pcimio driver is the only one that uses DMA. It
defines PCIDMA so that the dma code is compiled it. This causes a bunch
of ifdef'ery in the file.
The DIO subdevice for the ni_pcidio "is_m_series"
The (*do_cmdtest) validates that the cmd->scan_begin_src will only be
TRIG_TIMER or TRIG_EXT. Refactor ni_ao_cmd_set_update() and remove the
BUG() which can never occur.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c |
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 78 --
1 file changed, 49 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.
The 'counter_index' is always in range (0 to < NUM_GPCT, which is 2).
For aesthetics, convert this inline function into a macro and remove
the BUG() which can never occur.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/staging/come
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 172 +
1 file changed, 90 insertions(+), 82 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.
Fix the checkpatch.pl issues.
WARNING: Block comments use * on subsequent lines
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 211 ++---
1 file changed, 117 insertions(+), 94 deletions(-)
diff --
On Tue, 12 Apr 2016 22:27:58 +
Han Xu wrote:
>
> I am fine with all gpmi patch set and tested on i.MX6Q, just found another
> issue in gpmi driver.
> The patch was sent, refer to https://patchwork.ozlabs.org/patch/609755/
Oh, was it related to the changes introduced by this series?
>
>
Fixed coding style warning
Signed-off-by: Panos Vlachos
---
drivers/staging/lustre/lnet/lnet/nidstrings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c
b/drivers/staging/lustre/lnet/lnet/nidstrings.c
index ebf468f..f532e44 1006
On Wed, Apr 13, 2016 at 03:10:45AM +0300, Panos Vlachos wrote:
> Fixed coding style warning
What warning?
And always put the driver name in the subject so we know where to merge
this to.
And finally, use get_maintainer.pl to determine who to send this to.
thanks,
greg k-h
_
From: Oleg Drokin
This patch fixes all checkpatch occurences of
CHECK: Blank lines aren't necessary after an open brace '{'
CHECK: Blank lines aren't necessary before a close brace '}'
in Lustre code.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fld/fld_request.c | 1 -
dri
From: Oleg Drokin
These are rebased cleanups from before -
style fixes and suppressign a spurious message.
Bobi Jam (1):
staging/lustre/llite: suppress non active IO error message
Oleg Drokin (1):
staging/lustre: Fix blank line after/before {/} style
drivers/staging/lustre/lustre/fld/fld_
From: Bobi Jam
Current CLIO does not support fadvise, suppress the error message.
Signed-off-by: Bobi Jam
Reviewed-on: http://review.whamcloud.com/9658
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4717
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
-
On Wed, 2016-04-13 at 03:10 +0300, Panos Vlachos wrote:
> Fixed coding style warning
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c
> b/drivers/staging/lustre/lnet/lnet/nidstrings.c
[]
> @@ -197,7 +197,7 @@ add_nidrange(const struct cfs_lstr *src,
> struct netstrfns *nf;
>
57 matches
Mail list logo
