> I don't think this is right. A compound_page still has a page struct
> for every page, you should be passing the page struct where your data
> starts. Using an offset > PAGE_SIZE is going to break lots of places,
> for example anywhere that uses kmap(sg_page(sg)).
Was kind-of expecting that re
On 08/04/16 18:14, H Hartley Sweeten wrote:
DMA is optional with this driver. If it was not enabled the devpriv->dma
pointer will be NULL.
Fix the possible NULL pointer dereference when trying to disable the DMA
channels in das1800_ai_cancel() and tidy up the comments to fix the
checkpatch.pl is
On 08/04/16 20:41, H Hartley Sweeten wrote:
Tidy up this driver and fix all the checkpatch.pl issues.
This series applies after the bug fix series:
[PATCH v2 0/3] staging: comedi: das1800: bug fixes
v2 changes:
* refactor based on the bug fix series
* reorder the series to tidy up das1
On Mon, Apr 11, 2016 at 09:18:24AM +0300, Dan Carpenter wrote:
> No one objects to this.
>
> Resend it, but without the RFC in the subject. Greg has a no RFC rule,
> probably he has to edit the subject.
Apparently Greg already applied it.
regards,
dan carpenter
That may work, but I think it would be simpler to do this next to the
kzalloc() before we do the wilc->vif[i]->hif_drv = hif_drv; assignment.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
On Mon, Apr 11, 2016 at 02:57:05PM +0300, Dan Carpenter wrote:
> On Mon, Apr 11, 2016 at 09:18:24AM +0300, Dan Carpenter wrote:
> > No one objects to this.
> >
> > Resend it, but without the RFC in the subject. Greg has a no RFC rule,
> > probably he has to edit the subject.
>
> Apparently Greg
From: Itai Katz
The dpmcp driver supports dpmcp version 3.0 and above.
This patch adds the code to check the version.
Signed-off-by: Itai Katz
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h|6 +++---
drivers/staging/fsl-mc/bus/mc-allocator.c | 11 +++
From: Horia Geantă
There are some error paths that allow for a NULL new_mc_io and err = 0
return code. Return -EINVAL instead.
Signed-off-by: Horia Geantă
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-allocator.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s
From: Itai Katz
Up until now if the object version expected by a driver (in the API header
file) did not match the actual object version in the MC hardware the bus
driver refused to bind the object to the driver or printed out WARN_ON
dumps.
This patch removes those checks, and the responsibilit
From: Itai Katz
The root dprc is discovered as a platform device in the device tree. The
version of that dprc was previously set using hardcoded values from the API
header in the kernel). This patch removes the use of the hardcoded version
numbers and instead reads the actual dprc version from
From: Itai Katz
The dprc driver supports dprc version 5.0 and above.
This patch adds the code to check the version.
Signed-off-by: Itai Katz
(Stuart: resolved merge conflicts, split dpseci quirk into separate patch)
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-cmd.h |
From: Itai Katz
Some DPAA2 devices have mmio regions that should be mapped as
cacheable by drivers. Set IORESOURCE_CACHEABLE in the region's
flags if applicable.
Signed-off-by: Itai Katz
[Stuart: update subject and commit message]
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc
From: Stuart Yoder
incorporated feedback from review comments, other misc cleanup/tweaks
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/README.txt | 138 +
1 file changed, 80 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/fsl-mc/README
From: Stuart Yoder
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dpbp.c | 77 -
drivers/staging/fsl-mc/include/dpbp-cmd.h |4 +-
drivers/staging/fsl-mc/include/dpbp.h | 51 ++-
3 files changed, 127 insertions(+), 5 del
From: Stuart Yoder
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h |5 ++---
drivers/staging/fsl-mc/bus/dpmcp.c | 35 ++--
drivers/staging/fsl-mc/bus/dpmcp.h | 10 ++---
3 files changed, 6 insertions(+), 44 deletions(-)
dif
From: Stuart Yoder
Unless discovered devices have the no shareability flag set,
set up coherent dma ops for them.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-bus.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/stagin
From: Stuart Yoder
This patch series makes further progress towards completing the fsl-mc
TODO list.
-patch 1 removes three items from the TODO file that were previously
completed-- multiple root dprc support, MSI support, and command
serialization
-patch 2 makes some way overdue updates to
From: Stuart Yoder
The meaning of the "status" parameter in dprc_get_irq_status
has changed, and this patch updates the flib and caller
of the API.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-cmd.h|4 ++--
drivers/staging/fsl-mc/bus/dprc-driver.c |1 +
drivers/s
From: Stuart Yoder
remove 3 of the remaining TODO items:
-multiple root fsl-mc buses-- done in patch series starting with
commit 14f928054a05 ("staging: fsl-mc: abstract test for existence
of fsl-mc bus")
-interrupt support-- done in patch series starting with
commit 9b1b282cc
From: Stuart Yoder
Add Stuart Yoder as additional maintainer of fsl-mc bus driver.
Signed-off-by: Stuart Yoder
---
MAINTAINERS |1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 03e00c7..62db04e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4670,6 +4670,7 @
From: Horia Geanta
dpseci objects < 4.0 are not coherent-- in spite of the fact
that the MC reports them to be coherent in certain versions.
Add a special case to set the no shareability flag for dpseci
objects < 4.0.
Signed-off-by: Horia Geanta
(Stuart: reworded commit message, updated comment
From: Horia Geantă
There are some error paths that allow for a NULL new_mc_io and err = 0
return code. Return -EINVAL instead.
Signed-off-by: Horia Geantă
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/mc-allocator.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s
The android drivers have a few other people reviewing patches.
Add a separate entry to ensure patches go to the right people.
Signed-off-by: Laura Abbott
---
v2: Drop RFC tag
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 40eb1db..c69
On Mon, Apr 11, 2016 at 11:50:48AM -0500, Stuart Yoder wrote:
> From: Stuart Yoder
>
> Add Stuart Yoder as additional maintainer of fsl-mc bus driver.
>
> Signed-off-by: Stuart Yoder
I need an ack from the existing maintainer for this, and the other
patches in this series :)
thanks,
greg k-h
Change the type to fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_stc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_stc.h
b/drivers/staging/com
Tidy up the block comments to fix the checkpatch.pl issues:
WARNING: Block comments use * on subsequent lines
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_stc.h | 35 -
1 file changed, 17 insertions
Fix the checkpatch.pl issues in this file.
H Hartley Sweeten (3):
staging: comedi: ni_stc.h: Prefer 'unsigned int' to bare use of 'unsigned'
staging: comedi: ni_stc.h: Prefer kernel type 'u8' over 'uint8_t'
staging: comedi: ni_stc.h: tidy up block comments
drivers/staging/comedi/drivers/ni
Change the types to fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_stc.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_stc.h
b/drivers/st
Rename the enum value to fix the checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/plx9080.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/
Tidy up the comments to fix the checkpatch.pl isses:
WARNING: Block comments use * on subsequent lines
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amcc_s5933.h | 24 +++-
1 file c
Tidy up the defines to fix the checkpatch.pl issues:
CHECK: Prefer using the BIT macro
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_8254.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/driv
>From 08473aa48a1726c09dbab43e99059be9b0e88af2 Mon Sep 17 00:00:00 2001
From: Aleksei Fedotov
Date: Mon, 11 Apr 2016 21:13:27 +0300
Subject: [PATCH] staging: lustre: libcfs: Fix warnings reported by sparse
This patch fixes sparse warnings:
lustre/lnet/libcfs/linux/linux-module.c:177:35: warning:
> On Mon, Apr 11, 2016 at 10:28:51PM +0300, Aleksey Fedotov wrote:
> > >From c3b19bf16c1a11f78362847646399309c4ff6d41 Mon Sep 17 00:00:00 2001
> > From: Aleksei Fedotov
> > Date: Mon, 11 Apr 2016 21:13:27 +0300
> > Subject: [PATCH] staging: lustre: Fix warnings reported by sparse
>
> What is all
> -Original Message-
> From: Stuart Yoder [mailto:stuart.yo...@nxp.com]
> Sent: Monday, April 11, 2016 11:48 AM
> To: gre...@linuxfoundation.org; Jose Rivera
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de;
> a...@arndb.de; Yang-Leo Li ; Stuart Yoder
>
> Subj
On Mon, Apr 11, 2016 at 11:50:13PM +0300, Aleksey Fedotov wrote:
> >From 08473aa48a1726c09dbab43e99059be9b0e88af2 Mon Sep 17 00:00:00 2001
> From: Aleksei Fedotov
> Date: Mon, 11 Apr 2016 21:13:27 +0300
> Subject: [PATCH] staging: lustre: libcfs: Fix warnings reported by sparse
Why is this here i
On Apr 11, 2016, at 4:50 PM, Aleksey Fedotov wrote:
> From 08473aa48a1726c09dbab43e99059be9b0e88af2 Mon Sep 17 00:00:00 2001
> From: Aleksei Fedotov
> Date: Mon, 11 Apr 2016 21:13:27 +0300
> Subject: [PATCH] staging: lustre: libcfs: Fix warnings reported by sparse
A better title would be someth
> -Original Message-
> From: Stuart Yoder [mailto:stuart.yo...@nxp.com]
> Sent: Monday, April 11, 2016 11:48 AM
> To: gre...@linuxfoundation.org; Jose Rivera
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de;
> a...@arndb.de; Yang-Leo Li ; Stuart Yoder
>
> Subj
> -Original Message-
> From: Stuart Yoder
> Date: Mon, Apr 11, 2016 at 11:56 AM
> Subject: [PATCH 13/14] staging: fsl-mc: return -EINVAL for all
> fsl_mc_portal_allocate() failures
> To: gre...@linuxfoundation.org, german.riv...@nxp.com
> Cc: de...@driverdev.osuosl.org, linux-ker...@vger.
On Fri, Apr 01, 2016 at 03:18:02PM -0400, gr...@linuxhacker.ru wrote:
> From: Oleg Drokin
>
> This patch fixes all checkpatch occurences of
> CHECK: Blank lines aren't necessary after an open brace '{'
> CHECK: Blank lines aren't necessary before a close brace '}'
> in Lustre code.
>
> Signed-of
Some of this series didn't apply, due to merge issues with 4.6-rc3. Can
you rebase and resend the remaining patches?
thanks,
greg k-h
On Mon, Apr 04, 2016 at 09:37:03PM -0400, James Simmons wrote:
> When Lustre is in a read or write system call and receives a
> SIGALRM, it will return EINTR if
On Mon, Apr 04, 2016 at 11:31:14PM -0400, David Kershner wrote:
> From: Tim Sell
>
> The caller of visor_copy_fragsinfo_from_skb() is prepared to log a
> dev_err() message if it fails (by returning a negative value), so we now
> just fail in the one occasion where visor_copy_fragsinfo_from_skb()
On Sun, Apr 10, 2016 at 09:13:24AM -0400, James Simmons wrote:
> From: Sebastien Buisson
>
> Fix 'data race condition' defects found by Coverity version 6.5.0:
>
> Data race condition (MISSING_LOCK)
>
> Accessing variable without holding lock. Elsewhere,
> this variable is accessed with lock he
On Wed, Apr 06, 2016 at 03:25:26PM -0400, James Simmons wrote:
> The lnet selftest code is littered with typedefs. Convert these
> typedefs into their proper data types.
Not all of these applied, please fix up and resend the remaining ones.
thanks,
greg k-h
__
43 matches
Mail list logo
