Re: [PATCH] staging: wilc1000: rework comments in wilc_sdio.c

2016-04-10 Thread Julian Calaby
Hi Mohammed, On Sun, Apr 10, 2016 at 5:11 AM, wrote: > From: Mohammed Billoo > > Remove unnecessary comments (highlighting sections of functions), make > multiline comments into single line comments, and ensure that multiline > comments adhere to coding style. You need to add a signed-off-by l

[PATCH 00/17] staging : lustre : rest of missing patches from 2.5.0 release

2016-04-10 Thread James Simmons
This is the last collection of missing fixes present in the Lustre 2.5.0 release. Once these are merged the upstream client will be equal to the pre-2.6 lustre version since the major of clio cleanups from that time frame have already landed. Andrew Perepechko (3): staging: lustre: llite: variab

[PATCH 05/17] staging: lustre: llite: variable rename in namei.c

2016-04-10 Thread James Simmons
From: Andrew Perepechko With the patch 6648 a fee variables were renamed. We do these renames in broken out patch to the fix obvious. Signed-off-by: Andrew Perepechko Reviewed-by: Alexander Boyko Reviewed-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3473 Xyratex-bug-

[PATCH 07/17] staging: lustre: llite: error setting max_cache_mb at mount time

2016-04-10 Thread James Simmons
From: Jinshan Xiong The root cause is that when max_cache_mb conf parameter is applied, the client isn't connected to the OST yet so that sbi->ll_dt_exp is NULL. However, it's not necessary to shrink the cache memory in this case so success should be returned. Signed-off-by: Jinshan Xiong Intel

[PATCH 03/17] staging: lustre: ldlm: Fix a race during FLock handling

2016-04-10 Thread James Simmons
From: Bruno Faccini Protect against race where lock could have been just destroyed due to overlap, in ldlm_process_flock_lock(). Easy reproducer is BULL's NFS Locktests in pthread mode. (http://nfsv4.bullopensource.org/tools/tests/locktest.php) Signed-off-by: Bruno Faccini Intel-bug-id: https:/

[PATCH 01/17] staging: lustre: osc: fix race issues thanks to oap_lock

2016-04-10 Thread James Simmons
From: Sebastien Buisson Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. This patch is dedicated to code fragments involving oap_lock. Signed-off-

[PATCH 02/17] staging: lustre: clio: incorrect assertions in 'enable-invariants'

2016-04-10 Thread James Simmons
From: Niu Yawei Fixed several incorrect assumptions in 'enable-invariants'. Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3521 Reviewed-on: http://review.whamcloud.com/6832 Reviewed-by: Bobi Jam Reviewed-by: Jinshan Xiong Reviewed-by: Oleg Drokin Signed-off-by:

[PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread James Simmons
From: Jeff Mahoney On ppc64 with 64k pages, we get a build failure in lloop: drivers/staging/lustre/lustre/llite/lloop.c:527:2: note: in expansion of macro 'CLASSERT' CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8))); There's no need to change the queue's logical block size. Even

[PATCH 09/17] staging: lustre: ptlrpc: return a meaningful status from ptlrpcd_init()

2016-04-10 Thread James Simmons
From: Swapnil Pimpale This patch has the following: 1) Fix for the return value from ptlrpcd_init(). It will now return a correct status instead of returning zero always. 2) ptlrpcd_addref() should not increment ptlrpcd_users on error. 3) Added code in a mdc_setup() and mgc_setup() to test the

[PATCH 17/17] staging: lustre: hsm: don't use real suppgid

2016-04-10 Thread James Simmons
From: John L. Hammond In the MDC HSM handlers that do not pack a real suppgid, use -1 rather than 0 for the suppgid in mdt_body. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3866 Reviewed-on: http://review.whamcloud.com/7565 Reviewed-by: Aurelien Degremont

[PATCH 06/17] staging: lustre: llite: speedup in unlink/rmdir

2016-04-10 Thread James Simmons
From: Andrew Perepechko Assume dchild argument is fully initialized in ->unlink and ->rmdir callbacks, so additional lookup for ELC is not needed. Signed-off-by: Andrew Perepechko Reviewed-by: Alexander Boyko Reviewed-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3473

[PATCH 16/17] staging: lustre: hsm: permission checks for HSM ioctl operations

2016-04-10 Thread James Simmons
From: John L. Hammond In the LL_IOC_HSM_CT_START case of ll_dir_ioctl() require CAP_SYS_ADMIN, since the local handler for this ioctl may modify the global KUC table. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3866 Reviewed-on: http://review.whamcloud.com

[PATCH 11/17] staging: lustre: osc: osc_extent_wait() shouldn't be interruptible

2016-04-10 Thread James Simmons
From: Jinshan Xiong Otherwise it will hit the assertion at cl_lock.c: cl_lock.c:1967:discard_cb()) ASSERTION( (!(page->cp_type == CPT_CACHEABLE) || (!PageWriteback(cl_page_vmpage(env, page ) failed: This is because in osc_lock_flush() we have to make sure the IO is finished before disc

[PATCH 04/17] staging: lustre: ldlm: refine LU-2665 patch for POSIX compliance

2016-04-10 Thread James Simmons
From: Bruno Faccini Follow-on to patch introduced to fix LU-2665 ticket (Gerrit Change at http://review.whamcloud.com/6415 with Change-Id: I8faa331712abeadee46eabe111ee1c23a05840d5). Original patch introduced regressions against POSIX test suite (fcntl.18/fcntl.35 tests in LSB-VSX POSIX test suit

[PATCH 10/17] staging: lustre: llite: Truncate to restore file

2016-04-10 Thread James Simmons
From: Jinshan Xiong Truncate up is safe so it won't trigger restore. Copy optimization for truncate down - only copy the part under truncate length. If a file is truncated to zero usually it'll be followed by write so I choose to restore the file and set correct stripe information. Signed-off-b

[PATCH 15/17] staging: lustre: lov: Don't wait for active target with OBD_STATFS_NODELAY

2016-04-10 Thread James Simmons
From: Andriy Skulysh Patch for LU-631 which was landed before the upstream merge broke OBD_STATFS_NODELAY behaviour. It adds unnecessary delay while running df command with inactive OSTs. We shouldn't try to recover connection to OST in this case. Signed-off-by: Andriy Skulysh Intel-bug-id: htt

[PATCH 08/17] staging: lustre: obd: MDT mount fails on MDS w/o MGS on it

2016-04-10 Thread James Simmons
From: Bobi Jam If we specify multiple --mgsnode for a MDT, when we start MDS upon it while MGS is no the other node, the MGC import connection will always select the local nid (which is one of the candidate mgsnode) since it think its the closest connection. This patch treats further --mgsnode n

[PATCH 14/17] staging: lustre: lov: return minimal FIEMAP for released files

2016-04-10 Thread James Simmons
From: Bruno Faccini Since st_blocks = NULL is returned for released files, FIEMAP should at least return a minimal mapping to make users aware that file contains data but it is not immediately available. This will make coreutils and tools such tar happy and have them presume file is sparse. Also

[PATCH 12/17] staging: lustre: lprocfs: implement log2 using bitops

2016-04-10 Thread James Simmons
From: Andrew Perepechko This patch implements log2 using fls. Signed-off-by: Andrew Perepechko Reviewed-by: Alexander Boyko Reviewed-by: alexander_zarochent...@xyratex.com Reviewed-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3496 Xyratex-bug-id: MRP-999 Reviewed-on:

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
This patch was shown not to work. I just haven't removed it from opensuse yet. -Jeff -- Jeff Mahoney (apologies for the top post -- from my mobile) > On Apr 10, 2016, at 9:13 AM, James Simmons wrote: > > From: Jeff Mahoney > > On ppc64 with 64k pages, we get a build failure in lloop: > > dr

Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

2016-04-10 Thread Jonathan Cameron
On 06/04/16 22:06, Lars-Peter Clausen wrote: > On 04/06/2016 06:11 AM, Alison Schofield wrote: >> Replace the code that guarantees the device stays in direct mode with >> iio_device_{claim|release}_direct_mode() which does same. >> >> Signed-off-by: Alison Schofield > > Looks good, thanks. > > A

Re: [PATCH] staging: iio: ad7606: use iio_device_{claim|release}_direct_mode()

2016-04-10 Thread Jonathan Cameron
On 06/04/16 19:06, Lars-Peter Clausen wrote: > On 04/03/2016 11:09 AM, Jonathan Cameron wrote: >> On 01/04/16 17:53, Alison Schofield wrote: >>> Two instances are moved to the new claim/release API: >>> >>> In the first instance, the driver was using mlock followed by >>> iio_buffer_enabled(). Repl

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread James Simmons
> This patch was shown not to work. I just haven't removed it from opensuse yet. Its been running in our production tree as well for some time. Guess that change is a noop. In any case we have been discussing redoing the lloop driver anyways. Just need to find the cycles. > -- > Jeff Mahoney >

Re: [PATCH 08/27] staging: lustre: avoid to use bio->bi_vcnt directly

2016-04-10 Thread James Simmons
> The lloop driver should be removed entirely - use the loop driver > instead. I talked with Andreas last week at our annual Lustre users group meeting about this. The reason I was told for existance is that some users were using files on a Lustre file system with the loop back device. The perf

Re: [PATCH 08/27] staging: lustre: avoid to use bio->bi_vcnt directly

2016-04-10 Thread Christoph Hellwig
On Sun, Apr 10, 2016 at 03:37:42PM +0100, James Simmons wrote: > > > The lloop driver should be removed entirely - use the loop driver > > instead. > > I talked with Andreas last week at our annual Lustre users group meeting > about this. The reason I was told for existance is that some users we

Re: [lustre-devel] [PATCH] staging: lustre: split error handling code into multiple labels

2016-04-10 Thread James Simmons
> Instead of using a switch-case statement to find out what kind of error > has just happened, split error handling logic into multiple labels and > jump right into the appropriate label to do the error handling. This way > it is easier to follow different code paths. It also looks easy on the > e

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Greg Kroah-Hartman
On Sun, Apr 10, 2016 at 03:04:51PM +0100, James Simmons wrote: > > > This patch was shown not to work. I just haven't removed it from opensuse > > yet. > > Its been running in our production tree as well for some time. Guess that > change is a noop. In any case we have been discussing redoing t

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread James Simmons
> > > This patch was shown not to work. I just haven't removed it from opensuse > > > yet. > > > > Its been running in our production tree as well for some time. Guess that > > change is a noop. In any case we have been discussing redoing the lloop > > driver anyways. Just need to find the cyc

Re: [PATCH 08/27] staging: lustre: avoid to use bio->bi_vcnt directly

2016-04-10 Thread James Simmons
> On Sun, Apr 10, 2016 at 03:37:42PM +0100, James Simmons wrote: > > > > > The lloop driver should be removed entirely - use the loop driver > > > instead. > > > > I talked with Andreas last week at our annual Lustre users group meeting > > about this. The reason I was told for existance is tha

[PATCH] staging: wilc1000: rework comments in wilc_sdio.c

2016-04-10 Thread mohammed . billoo
From: Mohammed Billoo Remove unnecessary comments (highlighting sections of functions), make multiline comments into single line comments, and ensure that multiline comments adhere to coding style. Signed-off-by: Mohammed Billoo --- drivers/staging/wilc1000/wilc_sdio.c | 136 --

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
On 4/10/16 10:04 AM, James Simmons wrote: > >> This patch was shown not to work. I just haven't removed it from opensuse >> yet. > > Its been running in our production tree as well for some time. Guess that > change is a noop. In any case we have been discussing redoing the lloop > driver anyw

Re: [PATCH 08/27] staging: lustre: avoid to use bio->bi_vcnt directly

2016-04-10 Thread Ming Lei
On Mon, Apr 11, 2016 at 12:02 AM, James Simmons wrote: > >> On Sun, Apr 10, 2016 at 03:37:42PM +0100, James Simmons wrote: >> > >> > > The lloop driver should be removed entirely - use the loop driver >> > > instead. >> > >> > I talked with Andreas last week at our annual Lustre users group meetin

Re: [RFC][PATCH] MAINTAINERS: Add Android Ion as a separate entry

2016-04-10 Thread Dan Carpenter
No one objects to this. Resend it, but without the RFC in the subject. Greg has a no RFC rule, probably he has to edit the subject. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail