On 06/04/16 02:21, Hartley Sweeten wrote:
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee
---
There may be a chance that reading from DAS1800_CONTROL_C is necessary
before reading from DAS1800_STATUS. If that is t
On 06/04/16 10:41, Ian Abbott wrote:
On 06/04/16 02:21, Hartley Sweeten wrote:
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee
---
There may be a chance that reading from DAS1800_CONTROL_C is necessary
before rea
CHECK: Alignment should match open parenthesis
WARNING: line over 80 characters
Signed-off-by: Manav Batra
---
drivers/staging/rts5208/ms.c | 66 ++--
1 file changed, 39 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/st
On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote:
> Added braces on if arm of if statement where else arm already needs braces
> as suggested for clarity in Documentation/CodingStyle
>
> Signed-off-by: Nicholas Sim
> ---
> drivers/staging/rts5208/ms.c | 3 ++-
> 1 file changed, 2 ins
From: Alexander Curtin
The respond_to_device_create flag was used previously when we used to
delay responses to create requests until the drivers were finished
loading. This behaviour was removed some time ago, yet the field still
existed, while never being referenced or even initialized.
Signed
On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote:
> On 06/04/16 02:21, Hartley Sweeten wrote:
>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>> The variable unipolar was never used.
>>>
>>> Signed-off-by: Sudip Mukherjee
>>> ---
>>>
>>> There may be a chance that reading from
The analog input samples are 2's complement when the inputs are configured
for bipolar ranges and offset binary when they are unipolar ranges. For
bipolar ranges the samples need to be munged to the offset binary format
that comedi uses.
The (*insn_read) does the munging correctly but the async co
The "hc" type boards have 64 analog input channels with a 64 entry queue.
All the others have 16 channels and a 256 entry queue.
Currently the boardinfo 'qram_len' is used to initialize the subdevice
'n_chan' and 'len_chanlist'. This works for the 64 channel boards but
sets the 'n_chan' wrong for
On 04/03/2016 11:09 AM, Jonathan Cameron wrote:
> On 01/04/16 17:53, Alison Schofield wrote:
>> Two instances are moved to the new claim/release API:
>>
>> In the first instance, the driver was using mlock followed by
>> iio_buffer_enabled(). Replace that code with the new API to guarantee
>> the d
On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote:
> On 06/04/16 10:41, Ian Abbott wrote:
>> On 06/04/16 02:21, Hartley Sweeten wrote:
>>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee
---
>>
The "da" type boards all have 4 analog inputs. Fix the boardinfo
for the das-1801st-da.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
Hello Tetsuo Handa,
This is a semi-automatic email about new static checker warnings.
The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse
TIF_MEMDIE." from Mar 8, 2016, leads to the following Smatch
complaint:
drivers/staging/android/lowmemorykiller.c:145 lowmem_scan()
error
> A number of new laptops have been delivered with only a single antenna.
> In principle, this is OK; however, a problem arises when the on-board
> EEPROM is programmed to use the other antenna connection. The option
> of opening the computer and moving the connector is not always possible
> as it
> Smatch reports the following:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/pci.c
> drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv()
> error: we previously assumed 'tpriv' could be null (see line 368)
> drivers/net/wireless/realtek/rtlwifi/pci.c:1216 _rtl_pci_init
> While building with W=1 we were getting the warning:
>
> drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16:
> warning: old-style function definition
> struct lu_env *cl_env_percpu_get()
> ^
>
> Signed-off-by: Sudip Mukherjee
Acked-by: James Simmons
> ---
>
The lnet selftest code is littered with typedefs. Convert these
typedefs into their proper data types.
James Simmons (24):
staging: lustre: selftest: convert srpc_event_type to proper enum
staging: lustre: selftest: convert srpc_event_t to proper struct
staging: lustre: selftest: convert srp
Turn typedef srpc_service_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |3 +-
drivers/staging/lustre/lnet/selftest/console.c |3 +-
drivers/staging/lustre/lnet/selftest/framework.c |8 +++---
drivers/staging/lustre/lnet/sel
Turn tyepdef srpc_event_type to proper enum
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/selftest.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/selftest.h
b/drivers/staging/lustre/lnet/selftest/selft
Turn typedef sfw_session_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |6 ++--
drivers/staging/lustre/lnet/selftest/framework.c | 40 +++---
drivers/staging/lustre/lnet/selftest/ping_test.c |8 ++--
drivers/stag
Turn typedef sfw_batch_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/framework.c | 38 +++---
drivers/staging/lustre/lnet/selftest/selftest.h |6 ++--
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/sta
Turn typedef swi_workitem_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/framework.c |4 +-
drivers/staging/lustre/lnet/selftest/rpc.c |8 +++---
drivers/staging/lustre/lnet/selftest/selftest.h | 26 +++--
3 files chan
Turn typedef srpc_event_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/rpc.c | 20 ++--
drivers/staging/lustre/lnet/selftest/selftest.h | 14 +++---
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/driv
Turn typedef srpc_buffer_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/rpc.c | 12 ++--
drivers/staging/lustre/lnet/selftest/selftest.h |6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustr
Turn typedef sfw_test_case_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/framework.c | 16
drivers/staging/lustre/lnet/selftest/selftest.h |4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/stagi
Turn typedef srpc_bulk_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 14 +++---
drivers/staging/lustre/lnet/selftest/conrpc.c|4 ++--
drivers/staging/lustre/lnet/selftest/framework.c |2 +-
drivers/staging/lustre/l
Turn typedef sfw_test_unit_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |8
drivers/staging/lustre/lnet/selftest/framework.c | 20 ++--
drivers/staging/lustre/lnet/selftest/ping_test.c |4 ++--
drivers/
Turn typedef srpc_client_rpc_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |6 ++--
drivers/staging/lustre/lnet/selftest/conrpc.c|8 ++--
drivers/staging/lustre/lnet/selftest/conrpc.h|2 +-
drivers/staging/lustre/lnet/
Turn typedef lstcon_rpc_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 50
drivers/staging/lustre/lnet/selftest/conrpc.h | 18
drivers/staging/lustre/lnet/selftest/console.c |2 +-
3 files changed
Turn typedef sfw_test_instance_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |8 +++---
drivers/staging/lustre/lnet/selftest/framework.c | 26 +++---
drivers/staging/lustre/lnet/selftest/ping_test.c |8 +++---
dr
Turn typedef lstcon_tsb_hdr_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c |5 +++--
drivers/staging/lustre/lnet/selftest/console.c |2 +-
drivers/staging/lustre/lnet/selftest/console.h |8
3 files changed, 8 insertions(
Turn typedef lstcon_rpc_trans_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 36
drivers/staging/lustre/lnet/selftest/conrpc.h | 20 ++--
drivers/staging/lustre/lnet/selftest/console.c | 20 ++---
Turn typedef srpc_state_t to proper enum
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/rpc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
b/drivers/staging/lustre/lnet/selftest/rpc.c
index 812b9a
Turn typedef lstcon_group_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c |6 +-
drivers/staging/lustre/lnet/selftest/console.c | 80
drivers/staging/lustre/lnet/selftest/console.h |9 ++-
3 files changed, 4
Turn typedef lstcon_node_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 32
drivers/staging/lustre/lnet/selftest/console.c | 20 +++---
drivers/staging/lustre/lnet/selftest/console.h |9 +++---
3 fi
Turn typedef lstcon_batch_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c |4 +-
drivers/staging/lustre/lnet/selftest/console.c | 46
drivers/staging/lustre/lnet/selftest/console.h |7 ++--
3 files changed,
Turn typedef lstcon_test_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conctl.c |2 +-
drivers/staging/lustre/lnet/selftest/conrpc.c |5 ++-
drivers/staging/lustre/lnet/selftest/console.c | 26
drivers/staging/lus
Change all the wire protocol typedefs to proper structures
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 22 ++--
drivers/staging/lustre/lnet/selftest/conrpc.c| 44 +++---
drivers/staging/lustre/lnet/selftest/console.c | 10 +-
drivers/staging/lu
Turn typedef sfw_test_client_ops_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |3 ++-
drivers/staging/lustre/lnet/selftest/framework.c |2 +-
drivers/staging/lustre/lnet/selftest/ping_test.c |3 ++-
drivers/staging/lustre/lne
Turn typedef lstcon_ndlink_t to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/conrpc.c |6 +-
drivers/staging/lustre/lnet/selftest/console.c | 64
drivers/staging/lustre/lnet/selftest/console.h |7 ++-
3 files changed,
Turn typedef struct srpc_msg to proper structure
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/selftest/brw_test.c |8
drivers/staging/lustre/lnet/selftest/conrpc.c| 14 +++---
drivers/staging/lustre/lnet/selftest/conrpc.h|2 +-
drivers/staging/
On Wed, Apr 06, 2016 at 04:38:07AM -0700, Manav Batra wrote:
> CHECK: Alignment should match open parenthesis
> WARNING: line over 80 characters
>
> Signed-off-by: Manav Batra
> ---
> drivers/staging/rts5208/ms.c | 66
> ++--
> 1 file changed, 39 insertio
On 04/06/2016 06:11 AM, Alison Schofield wrote:
> Replace the code that guarantees the device stays in direct mode with
> iio_device_{claim|release}_direct_mode() which does same.
>
> Signed-off-by: Alison Schofield
Looks good, thanks.
Acked-by: Lars-Peter Clausen
> ---
> Changed in v2:
> -
Fixes CHECK: Alignment should match open parenthesis
Is the subject and patch fine?
Sorry, just getting used to the process, and thanks.
Signed-off-by: Manav Batra
---
drivers/staging/rts5208/ms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/ms.c b
Dan Carpenter wrote:
> Hello Tetsuo Handa,
Hello, Dan.
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse
> TIF_MEMDIE." from Mar 8, 2016, leads to the following Smatch
> complaint:
>
> drivers/staging/andro
Functions ion_handle_put and ion_handle_get_by_id are only used locally
in ion.c, so they should be made static as they used to be before
9590232b ("staging/android/ion : fix a race condition in the ion driver").
Signed-off-by: Markus Böhme
---
drivers/staging/android/ion/ion.c |6 +++---
1
This patch changes return type of ret variable from s32 to int.
ret has return value from wilc_send_config_pkt that has return type of
int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagin
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() function are used as result,
others are used as ret. It will be changed as ret in all handle_*()
function to match variable name.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/
When handle_set_wfi_drv_handler is called in hostIFthread that is a
kernel thread, it is not checked return type of this function. This
patch changes return type to void and removes braces if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_
This patch changes data type of result variable from s32 to int.
result is used to get return value from wilc_send_config_pkt that has
return type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
When handle_set_operation_mode is called in hostIFthread that is a
kernel thread, it is not checked return type of this function. This
patch changes return type to void and removes braces if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_i
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc100
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Wed, Apr 06, 2016 at 02:41:01PM -0700, Manav Batra wrote:
> Fixes CHECK: Alignment should match open parenthesis
>
> Is the subject and patch fine?
> Sorry, just getting used to the process, and thanks.
Yes, this is better, but please resend without these two lines in here,
you don't want them
Absorb this helper function into the analog input (*do_cmd).
For aesthetics, convert the switch code into if/else.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 31 +++
1 file changed, 7 inserti
The boards supported by this driver have analog inputs with gains of
1, 10, 50, and 250 ("01" type) or 1, 2, 4, and 8 ("02" type).
Replace the 'range_ai' member of the boardinfo with a bit-field flag,
'das1801_range' and only set it for the "01" type boards. Remove the
unnecessary initialization f
The "hc" type boards have 8 digtial outputs. All other board types have 4.
Replace the 'do_n_chan' member of the boardinfo with a bit-field flag,
'has_8_do_chan', and only set it for the "hc" type boards. Remove the
unnecessary initialization for all other board types.
Signed-off-by: H Hartley Sw
For aesthetics, add some whitespace to the subdevice init and rename
the (*insn_bits) function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
di
This value is compared against the unsigned int cmd->convert_arg to
check the minimum value (max speed) for the analog input conversion
timing.
For aesthetics, change the type to match the cmd->convert_arg type.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
driver
For aesthetics, add some whitespace to the subdevice init and rename
the (*insn_bits) function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
di
Rename this function so it has namespace associated with the driver.
Remove the unnecessary comment about the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions
Use the core provided readback support to allow reading back the last
value written to the analog output channels.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 17 +
1 file changed, 9 insertions(+), 8 dele
Fix the checkpatch.pl issues:
WARNING: Block comments use a trailing */ on a separate line
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 17 ++---
1 file changed, 10 insertions(
Introduce a helper function for the common code needed to get the control c
register bits for a channel specification.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 47 +++-
1 file changed, 22 i
Absorb this helper function into the analog input (*do_cmd).
For aesthetics, convert the switch code into if/else.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 58 +++-
1 file changed, 19 inser
For aesthetics, add some whitespace to the boardinfo array and
remove the unnecessary '= 0' initializations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 331 ++-
1 file changed, 150 insertions
These comments are just extra cruft. Remove them to fix the
checkpatch.pl issues:
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
The "hr" type boards have 16-bit analog inputs and outputs. All other board
types are 12-bit.
Replace the 'resolution' member of the boardinfo with a bit-field flag,
'is_16bit', and only set it for the 16-bit boards. Remove the unnecessary
initialization for the 12-bit boards.
Signed-off-by: H Ha
The comments about the members of the private data are not really
necessary and removing them fixes a couple checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 6 ++
1 file changed, 2 insertions(+), 4
DMA is optional with this driver. If it was not enabled the devpriv->dma
pointer will be NULL. Fix the possible NULL pointer dereference when trying
to disable the DMA channels.
Also, tidy up the comments to fix the checkpatch.pl issues:
WARNING: line over 80 characters
Signed-off-by: H Hartley S
DMA is optional with this driver. If it was not enabled the devpriv->dma
pointer will be NULL. It's probably harmless here because the 'desc' pointer
will not be used if DMA is disabled. But, fix the possible NULL pointer
dereference.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
The (*insn_write) functions are supposed to write insn->n values to the
specified channel. Tidy up this function and make it work like the core
expects.
Use the comedi_offset_munge() helper to handle the munging of the data
to 2's complement format.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbot
The waveform analog outputs on the 'ao' boards are not currently
supported. Modify the comment about the analog output range on
these boards so that the information is saved but fixes the
checkpatch.pl issues:
WARNING: Block comments use a trailing */ on a separate line
Move the comment so it's gr
Fix the checkpatch.pl issues:
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das
For aesthetics, add some whitespace to the subdevice init and rename
the subdevice support functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 57
1 file changed, 28 insertions(+), 29
Use the helper function to handle the busywaiting for the analog
input conversion to complete.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 34
1 file changed, 21 insertions(+), 13 deletio
The current code used to initialize the analog outputs only sets the
last channel. The other channels will be reloaded with the last value
that was written to them.
Move the initialzation into the subdevice init and properly initialize
all the channels to 0V.
Signed-off-by: H Hartley Sweeten
Cc:
Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u16' over 'uint16_t'
Change the type to 'unsigned short' as that is more typical in comedi
drivers.
Use sizeof(*p) instead of sizeof(type) when allocation the buffer.
Also fix the checkpatch.pl issue:
WARNING: line over 80 characters
Signed
Refactor this function so it can be used to program the chanlist for
the analog input (*do_cmd) and (*insn_read).
Rename the function so it has namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das18
For aesthetics, add some whitespace to the subdevice init and rename
the (*insn_write) function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
The 64 channel "hc" type boards do not support common mode analog
inputs all the other boards do.
Remove the unnecessary member from the boardinfo and use the
'has_64_ai_chan' member to determine if the SDF_COMMON flag needs
to be set for the subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian A
For aesthetics, move this information into the comedi comment block.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das
Tidy up this driver and fix all the checkpatch.pl issues.
This series applies after the bug fix patches:
staging: comedi: das1800: fix analog input sample munging
staging: comedi: das1800: fix analog input number of channels
staging: comedi: das1800: fix das-1801st-da boardinfo
Patch 28/35
The comedi_device spinlock is used to protect the indirect addressing
selected by the DAS1800_SELECT register. It also prevents races between
the interrupt handler and the analog input (*poll).
Update the comments to make this clear.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
The "st-da" board types have 4 analog output channels. All other board
types, with analog outputs, only have 2 channels.
Replace the 'ao_n_chan' member of the boardinfo with a bit-field flag,
'has_4_ao_chan' and only set it for the "st-da" boards. Remove the
unnecessary initialization for all othe
The "da" and "hc" type boards have normal analog outputs. The "ao"
type boards have move advanced analog outputs with waveform generation
capability.
Replace the 'ao_ability' member of the boardinfo with some bit-field
flags, 'has_ao' and 'has_wform_ao', and only set them appropriately
based on th
These comments are just added cruft. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c
b/drivers/staging/comedi/driver
Refactor das1800_probe() to return an errno instead of the boardinfo
pointer.
Add the board 'id' to the boardinfo to tidy up this function to clarify
the sanity check when the user provided a board name when trying to
attach to the driver.
Currently when this function probes for a boardinfo based
Change the MODULE_DESCRIPTION to something more usefull than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
Tidy up these multi-line comments to fix the checkpatch.pl issues:
WARNING: Block comments use * on subsequent lines
WARNING: line over 80 characters
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 150 --
Fixes CHECK: Alignment should match open parenthesis
Signed-off-by: Manav Batra
---
drivers/staging/rts5208/ms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 3e75db7..0f0cd4a 100644
--- a/drivers/staging/rts
90 matches
Mail list logo
