> "KY" == KY Srinivasan writes:
KY> How would I get the sysfs files under fc_host if I don't use the FC
KY> transport. The customer scripts expect these sysfs files.
Right, but I was interested in finding out why they need those
files. And whether an alternative to the FC transport would be
On Fri, 2016-03-18 at 17:48 +, Yousof El-Sayed wrote:
> This is a patch to the rtllib_softmac.c file that fixes up all instances of
> the 'line over 80 characters' warnings found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
> b/drivers/staging/rtl8192
Jandy Gou writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou
> ---
> drivers/staging/
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Wednesday, March 16, 2016 4:41 PM
> To: KY Srinivasan ; Martin K. Petersen
>
> Cc: Christoph Hellwig ; gre...@linuxfoundation.org;
> linux-ker...@vger.kernel.org; de...@linuxdriverproject.
On Thu, Mar 17, 2016 at 8:25 PM, Greg KH wrote:
> Ok, the diffstat below seems "odd" in that I had done a merge with my
> char-misc tree to resolve some merge issues a while ago, and that tree
> is now in your tree, so the diffstat shouldn't be showing it (I updated
> my master branch), but someho
Reformat the multi-line comment in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/comedi/
lustre_cfg_new() returns error pointers on error, it never returns NULL.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c
b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 65caffe..b7dc872 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.
This member of the struct is not used, and just takes up space. Remove it.
Instead, add the enum ni_660x_register indexes to the table to clarify, and
document, the entries.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 19
>A patch intended to add a dependency on LNET for lustre didn't
>actually do that and instead allowed configurations that contain
>lustre with lnet but without IPv4 support that subsequently
>fail to link:
>
>warning: (LUSTRE_FS) selects LNET which has unmet direct dependencies (STAGING
>&& INET &
Remove the enums global_interrupt_{status,config}_register_bits and
add defines for the CamelCase values.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 27 ++-
1 file changed, 10 insertions(+), 17 d
Convert this big switch into an array and refactor ni_660x_gpct_{write,read}()
functions to use the array to find the register offset.
All the TIO (GPCT) registers are included in the array except for NITIO_G0_ABZ
and NITIO_G1_ABZ. These registers only exist on the ni_pcimio m-series boards
and th
On Thu, Mar 17, 2016 at 10:19:04PM -0700, Linus Torvalds wrote:
> On Thu, Mar 17, 2016 at 8:25 PM, Greg KH wrote:
> > Ok, the diffstat below seems "odd" in that I had done a merge with my
> > char-misc tree to resolve some merge issues a while ago, and that tree
> > is now in your tree, so the dif
On Thu, Mar 17, 2016 at 04:55:37PM +, Yousof El-Sayed wrote:
> Signed-off-by: Yousof El-Sayed
I can't take patches without any changelog entry, sorry.
And be specific about what and why you are changing anything, "coding
style issues" is very vague.
thanks,
greg k-h
___
From: Gustavo Padovan
This function had copies in 3 different files. Unify them in kernel.h.
Cc: Andrew Morton
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 5 -
drivers/gpu/drm/i915/i915_drv.h
2016-03-18 16:53+0100, Vitaly Kuznetsov:
> Radim Krcmar writes:
>> 2016-03-18 13:33+0100, Vitaly Kuznetsov:
>>> @@ -530,9 +542,17 @@ static void vmbus_wait_for_unload(void)
>>
>> (I'm not a huge fan of the unloaded variable; what about remembering the
>> header/msgtype here ...
>>
>>>
This BUG_ON() happens if a mite DMA channel is already requested when an
ansynchronous command is started for one of the counter subdevices.
The comedi core will only call the (*do_cmd) if the subdevice is not busy.
In this driver, the (*cancel) for the subdevice will always release any
requested
On 2016/03/18, 13:28, "lustre-devel on behalf of Dilger, Andreas"
wrote:
>On 2016/03/17, 23:42, "Dan Carpenter" wrote:
>
>>lustre_cfg_new() returns error pointers on error, it never returns NULL.
Hmm, looking at the broader context, I see there are other callers of
lustre_cfg_new() that are che
On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>
> Is this a gcc-6 specific issue? Seems line this warning should be showing
> up in a lot of drivers.
Yes, I did not see this before moving to gcc-6.0, but this is the only dri
staging: rtl8192e - dot11d.c
[patch 1/2] Fixed throughout:
spaces preferred around that '+' (ctx:VxV)
[patch 2/2] Fixed throughout:
Please don't use multiple blank lines
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/dot11d.c | 14 ++
1 file changed, 6 insertions(+), 8
Hello Peng Tao,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lustre/obdecho/echo_client.c:1040
cl_echo_enqueue0()
error: 'lck' dereferencing possible ERR_PTR()
dri
On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_device_unregister() also does a cleanup, rename it
> to media_device_unregister_cleanup().
>
> Signed-off-by: Mauro Carvalho Chehab
I think adding cleanup is redundant. media_device_unregister()
would imply that there has to b
On Fri, Mar 18, 2016 at 01:41:19PM +0100, Geert Uytterhoeven wrote:
> > @@ -249,11 +246,7 @@ aim_read(struct file *filp, char __user *buf, size_t
> > count, loff_t *offset)
> > struct aim_channel *c = filp->private_data;
> >
> > mutex_lock(&c->io_mutex);
> > - if (c->stacked_
Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent
patch for paranthesis check and use this one.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/pla
On Sun, 2016-03-20 at 01:42 +, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
The subject prefix [PATCH] should be numbered
with the revision like [PATCH v2]
> Please ignore earlier sent patch for paranthesis check and use this one.
This bit of your email should go be
On Thursday 17 March 2016 10:10:40 H Hartley Sweeten wrote:
> Arnd Bergmann pointed out that gcc-6 warns about passing negative signed
> integer into swab16() due to the macro expansion of 'outw'.
>
> It appears that the register map constants are causing the warnings.
> Actually, it might just be
Fixed alignment of parenthesis checkpatch warning to fit coding standards.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_
Fixed checkpatch warnings about parenthesis alignment at line #186.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
in
Hi,
Thanks for pointing out that the changes have been done. Nevertheless this was
a good learning exercise. How do I check which changes have already been done?
I’m planning to send in another patch on a blank line warning on the same file.
I don’t want to overburden the mailing list by repeati
On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote:
> Hi,
> Thanks for pointing out that the changes have been done. Nevertheless
> this was a good learning exercise. How do I check which changes have
> already been done?
Use this tree:
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1960
rtl8812ae_dm_txpower_tracking_callback_thermalmeter() warn: inconsistent
indenting
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.c
d
Removed copyright notice as per checkpatch check warning.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a/drive
On Sat, Mar 12, 2016 at 02:11:10PM +0530, PrasannaKumar Muralidharan wrote:
> From: PrasannaKumar Muralidharan
>
> Remove unnecessary use of volatile for 'request_counter' and
> 'service_counter' members.
>
> Signed-off-by: PrasannaKumar Muralidharan
> ---
> drivers/staging/most/hdm-dim2/dim2_
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, March 18, 2016 5:33 AM
> To: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ;
> Haiyang Zhang ; Alex Ng (LIS)
> ; Radim Krcmar ; Cathy
> Avery
> Subject: [PATCH] Dri
Rename this function to help shorten some of the long lines.
Remove the inline, let the compiler figure it out.
Change the 'unsigned' parameters to 'unsigned int' to fix the
checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian
Use some local variables to clarify this function.
This (*insn_bits) function is a bit different from most comedi drivers.
Add some comments to clarify why the shifts are used.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c
From: Gustavo Padovan
sync_file is useful to connect one or more fences to the file. The file is
used by userspace to track fences.
Signed-off-by: Gustavo Padovan
---
drivers/Kconfig| 2 +
drivers/dma-buf/Kconfig| 11 +
drivers
101 - 136 of 136 matches
Mail list logo
