Remove enum ni_660x_constants and just #define the value.
Move all the constant #defines so they are in one place and rename
them so they are more conesistent.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 49
On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote:
> Fixed block comment checkpatch warnings.
>
> Signed-off-by: Gavin O'Leary
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging
2016-03-17 Joe Perches :
> On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
> []
> > > It's a name that seems like it should be a straightforward
> > > cast of a kernel pointer to a __user pointer like:
> > >
> > > static inline void __u
Make sure the interrupts are disabled before freeing the irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/d
On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
[]
> > It's a name that seems like it should be a straightforward
> > cast of a kernel pointer to a __user pointer like:
> >
> > static inline void __user *to_user_ptr(void *p)
> > {
> >
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/pci.c
drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv()
error: we previously assumed 'tpriv' could be null (see line 368)
drivers/net/wireless/realtek/rtlwifi/pci.c:1216 _rtl_pci_init_struct() war
On Tuesday, March 15, 2016 2:50 PM, Arnd Bergmann wrote:
> On Tuesday 15 March 2016 21:35:40 Hartley Sweeten wrote:
>> On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
>>> gcc-6 warns about passing negative signed integer into swab16()
>>> in the dt282x driver:
>>
>>
>>
>>> The warning ma
On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote:
> On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
>> 2016-03-17 Gustavo Padovan :
>> > 2016-03-17 Joe Perches :
>> > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
>> > > >
>> > > > This function had copies in 3 different f
The BUG_ON() in this function is unnecessary. The 'pfi_channel' will
always be in range of the subdevice 'n_chan' (NUM_PFI_CHANNELS) which
will return a valid 'reg'.
Convert the inline function into a simple macro.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dri
Smatch lists the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c:648
rtl92s_phy_set_rf_power_state() warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c
The previous patch added an option to rtl8723be to manually select the
antenna for those cases when only a single antenna is present, and the
on-board EEPROM is incorrectly programmed. This patch implements the
necessary changes in the Bluetooth coexistence driver.
Signed-off-by: Larry Finger
Cc:
This spinlock is only used to protect changes to the private data 'dma_cfg'.
Before calling any function that would change the 'dma_cfg' the spinlock
'mite_channel_lock' is also locked. That spinlock is not unlocked until
after the 'dma_cfg' change.
Remove the redundant spinlock.
Signed-off-by:
Did you get my previous message i sent to you? when and what time can i call
you?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2016/03/17, 23:42, "Dan Carpenter" wrote:
>lustre_cfg_new() returns error pointers on error, it never returns NULL.
>
>Signed-off-by: Dan Carpenter
>
>diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c
>b/drivers/staging/lustre/lustre/mgc/mgc_request.c
>index 65caffe..b7dc872 100644
On Fri, Mar 18, 2016 at 7:44 PM, Andrey Shvetsov
wrote:
> On Fri, Mar 18, 2016 at 06:32:15PM +0530, Amitoj Kaur Chawla wrote:
>> Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
>> with devm_request_irq") introduced the following static checker
>> warning:
>> drivers/staging/most
Hi Jandy,
On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou wrote:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-o
On Thu, Mar 17, 2016 at 06:21:55PM +, Yousof El-Sayed wrote:
> staging: rtl8192e - dot11d.c
???
>
> [patch 1/2] Fixed throughout:
> spaces preferred around that '+' (ctx:VxV)
>
> [patch 2/2] Fixed throughout:
> Please don't use multiple blank lines
What are these? You put 2 patches inside
Introduce separate functions for estimating how much can be read from
and written to the ring buffer.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/ring_buffer.c | 24
include/linux/hyperv.h | 27 +++
2 files changed, 31 insertions(+), 20 d
gcc-6 warns about passing negative signed integer into swab16()
in the dt282x driver:
drivers/staging/comedi/drivers/dt282x.c: In function 'dt282x_load_changain':
include/uapi/linux/swab.h:14:33: warning: integer overflow in expression
[-Woverflow]
(((__u16)(x) & (__u16)0xff00U) >> 8)))
~
On Wednesday 16 March 2016 17:04:15 Hartley Sweeten wrote:
> > #define DT2821_SUPCSR_DS_AD_TRIG (3 << 10)
>
> Use a helper macro for those bits:
>
> #define DT2821_SUPCSR_DS(x) (((x) & 0x3) << 10)
> #define DT2821_SUPCSR_DS_PIODT2821_SUPCSR_DS(0)
> #define DT2821_SUP
Fix the checkpatch.pl issues:
CHECK: spinlock_t definition without comment
For aesthetics, rename the 'soft_reg_copy_lock' to clarify what it's
used for.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 16 +---
On Fri, Mar 18, 2016 at 10:54:42AM +, Yousof El-Sayed wrote:
> This is a patch to the rtllib_softmac.c file that fixes up all instances of
> the 'line over 80 characters' warnings found by the checkpatch.pl tool
Your changelog should be wrapped, ironic given the contents of your
patch :(
Ple
The BUG_ON() checks in the helper functions are not necessary. The mite
driver quiries the PCI chip to determine the number of DMA channels.
This is then used when a DMA channel is requested so the channel will
always be in range.
Convert the inline functions used to set the bits in the NI600X_DMA
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:1726
_rtl8723be_phy_path_a_rx_iqk() warn: inconsistent indenting
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2304
_rtl8723be_phy_lc_calibrate
enum ni_gpct_register and enum ni_660x_register now have a 1:1
relationship for the NITIO_* registers. The static const array
is no longer necessary to find the proper NI660X_* register for
a given NITIO_*. Remove it and refactor the register read/write
functions.
Use the NITIO_* values to init th
On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
> On Thu, 2016-03-17 at 16:33 -0400, Rob Clark wrote:
>> On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote:
>> > On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
>> > > 2016-03-17 Gustavo Padovan :
>> > > > 2016-03-17 Joe Perches :
>>
On Wed, Mar 16, 2016 at 06:24:47PM -0700, Gavin O'Leary wrote:
> Fixed the coding style checkpatch warnings.
Which ones? Always be specific. And only fix one type of thing at a
time.
>
> Signed-off-by: Gavin O'Leary
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 16 ++-
From: Gustavo Padovan
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan
Reviewed-by: Maarten Lankhorst
---
drivers/staging/android/uapi/sync.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
On Thu, Mar 17, 2016 at 02:33:50PM -0700, Joe Perches wrote:
> On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote:
> > 2016-03-17 Joe Perches :
> > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote:
> > > []
> > > > > It's a name
This is a patch to the rtllib_softmac.c file that fixes up all instances of the
'line over 80 characters' warnings found by the checkpatch.pl tool
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/rtllib_softmac.c | 35 +++
1 file changed, 22 insertions(+),
This patch fixed the problems caused by if firmware is not started.
That is why, in nl80211 put current TX power in interface info.
If firmware is not started, this function(get_tx_power) does not work.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++
1 f
This enum is used to define the, unused, 'direction' of each register
in struct NI_660xRegisterData. Remove the unused member, as well as
the enum.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 203 +++-
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Wednesday, March 16, 2016 4:08 PM
> To: Martin K. Petersen ; KY Srinivasan
>
> Cc: Christoph Hellwig ; gre...@linuxfoundation.org;
> linux-ker...@vger.kernel.org; de...@linuxdriverproject.
On Fri, Mar 18, 2016 at 08:02:39PM +, Chris Wilson wrote:
> Drivers, especially i915.ko, can fail during the initial migration of a
> dma-buf for CPU access. However, the error code from the driver was not
> being propagated back to ioctl and so userspace was blissfully ignorant
> of the failur
Am 07.03.2016 um 07:57 schrieb Holger Schurig:
> I know that in Germany a good amount of land-line telephone line are
> still using ISDN. [...]
> Especially company line are using ISDN still, and there are some Linux
> programs that act on then, e.g. Asterisk and derived PBX software has
> ISDN sup
Use the inline instead of direct code to improve readability
and shorten the code a little.
Done with perl:
$ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1,
\2)/g' drivers/staging/skein/threefish_block.c
Signed-off-by: Joe Perches
---
drivers/staging/skein/threefi
Fixed the coding style checkpatch warnings.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/vi
Julian Calaby writes:
> Hi Jandy,
>
> On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou
> wrote:
>> make C=1 M=drivers/staging/rtl8723au/
>>
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
>> restricted __le16
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast
On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> 2016-03-17 Gustavo Padovan :
> > 2016-03-17 Joe Perches :
> > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > >
> > > > This function had copies in 3 different files. Unify them in
> > > > kernel.h.
> > > This is only us
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/dot11d.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
index 4d8fb41..a08bfef 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++
Made comments not break coding style guidlines and easier to read.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 29 +++--
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/d
2016-03-17 Gustavo Padovan :
> 2016-03-17 Joe Perches :
>
> > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > > This function had copies in 3 different files. Unify them in
> > > kernel.h.
> >
> > This is only used by gpu/drm.
> >
> > I think this is a poor name for a generic func
On 17/03/16 17:10, H Hartley Sweeten wrote:
Arnd Bergmann pointed out that gcc-6 warns about passing negative signed
integer into swab16() due to the macro expansion of 'outw'.
It appears that the register map constants are causing the warnings.
Actually, it might just be the (1 << 15) ones...
On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote:
> Hello Shuah,
>
> On 03/18/2016 11:01 AM, Shuah Khan wrote:
>> On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
>>> Now that media_device_unregister() also does a cleanup, rename it
>>> to media_device_unregister_cleanup().
>>>
>>> Signe
On Fri, 2016-03-18 at 10:27 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> This function had copies in 3 different files. Unify them in
> kernel.h.
This function might be used more in drm files
in a separate patch too:
$ git grep -n -E "__user.*\(\s*uintptr_t\s*\)" drivers/gpu/drm
dr
Xose Vazquez Perez writes:
> People should not waste time and energy working on this staging driver.
> A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> in the 4.3 kernel.
>
> Cc: Jes Sorensen
> Cc: Larry Finger
> Cc: Kalle Valo
> Cc: Greg Kroah-Hartman
> Cc: Linux D
On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>
> gcc-6 warns about passing negative signed integer into swab16()
> in the dt282x driver:
>
> drivers/staging/comedi/drivers/dt282x.c: In function 'dt282x_load_changain':
> include/uapi/linux/swab.h:14:33: warning: integer overflow in exp
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c:1140
rtl88e_dm_check_txpower_tracking() warn: inconsistent indenting
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c
drivers/net/wireless/
Remove the unnecessary NULL pointer check.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/drivers/staging/comed
On Thu, 2016-03-17 at 16:33 -0400, Rob Clark wrote:
> On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote:
> > On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote:
> > > 2016-03-17 Gustavo Padovan :
> > > > 2016-03-17 Joe Perches :
> > > > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan w
Convert the inline functions used to set the bits in the NI600X_IO_CFG
registers into macros. Also convert the enum ni_660x_pfi_output_select
into defines. This clarifies the association with the register.
This also fixes a number of checkpatch.pl issues about:
WARNING: Prefer 'unsigned int' to b
make C=1 M=drivers/staging/rtl8723au/
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
restricted __le32
Signed-off-by: Jandy Gou
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++--
On Thu, Mar 17, 2016 at 01:41:02PM -0500, Larry Finger wrote:
> Smatch reports the following:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c:137
> rtl8723e_dm_bt_need_to_dec_bt_pwr() warn: inconsistent indenting
>
Now that media_device_unregister() also does a cleanup, rename it
to media_device_unregister_cleanup().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/common/siano/smsdvb-main.c | 2 +-
drivers/media/media-device.c | 4 ++--
drivers/media/pci/saa7134/s
Remove this enum and add a define for the bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/drivers/st
Em Fri, 18 Mar 2016 16:20:19 +0200
Sakari Ailus escreveu:
> Shuah Khan wrote:
> > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote:
> >> Hello Shuah,
> >>
> >> On 03/18/2016 11:01 AM, Shuah Khan wrote:
> >>> On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_de
On 16/03/16 20:51, Arnd Bergmann wrote:
gcc-6 warns about passing negative signed integer into swab16()
in the dt282x driver:
drivers/staging/comedi/drivers/dt282x.c: In function 'dt282x_load_changain':
include/uapi/linux/swab.h:14:33: warning: integer overflow in expression
[-Woverflow]
(((
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.
This is only used by gpu/drm.
I think this is a poor name for a generic function
that would be in kernel.h.
Isn't there an include file in linux/drm that's
appropr
On Wed, Mar 16, 2016 at 08:00:45PM -0700, Gavin O'Leary wrote:
> Made comments not break coding style guidlines and easier to read.
>
> Signed-off-by: Gavin O'Leary
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 29
> +++--
> 1 file changed, 17 insertions(+), 12 d
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.
Signed-ff-by: Roger H. Newell
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 31 +--
drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 +--
2 files changed,
This patch corrects checks generated by checkpatch.pl by
replacing comparison to null statements with equivalent
statements in the form "x" or "!x"
Signed-off-by: Roger H. Newell
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_wlan_cfg.c | 4 ++--
2 files cha
For aesthetics, move the initialization of the default routing for the
DIO channels so it happens when the subdevice is initialized.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 27 +--
1 file chan
All the registers are defined struct NI_660xRegisterData and they are
either 2 or 4 bytes in size. Remove the enum and just use a char member
to define the size as 2 or 4 bytes.
Simplify the ni_660x_{write,read}_register() functions and remove the
unnecessary BUG() in each.
Signed-off-by: H Hartl
Hello Mauro,
On 03/18/2016 10:05 AM, Mauro Carvalho Chehab wrote:
> Now that media_device_unregister() also does a cleanup, rename it
> to media_device_unregister_cleanup().
>
I believe there should be a Suggested-by Sakari Ailus tag here.
> Signed-off-by: Mauro Carvalho Chehab
The patch look
2016-03-17 Joe Perches :
> On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> > This function had copies in 3 different files. Unify them in
> > kernel.h.
>
> This is only used by gpu/drm.
>
> I think this is a poor name for a generic function
> that would be in kernel.h.
>
> Isn't the
People should not waste time and energy working on this staging driver.
A replacement(rtl8xxxu) using the kernel wireless stack already was merged
in the 4.3 kernel.
Cc: Jes Sorensen
Cc: Larry Finger
Cc: Kalle Valo
Cc: Greg Kroah-Hartman
Cc: Linux Driver Project Developer List
Cc: Linux Wirel
Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
with devm_request_irq") introduced the following static checker
warning:
drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
error: 'dev->netinfo_task' dereferencing possible ERR_PTR()
Remove the warning by returning PTR_ERR
Made comments not break coding style guidlines and easier to read.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 29 +++--
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/d
On Fri, Mar 18, 2016 at 06:32:15PM +0530, Amitoj Kaur Chawla wrote:
> Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
> with devm_request_irq") introduced the following static checker
> warning:
> drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
> error: 'dev->netinfo_ta
Rename this function to help shorten some of the long lines.
Remove the inline, let the compiler figure it out.
Change the 'unsigned' parameters to 'unsigned int' to fix the
checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian
Rename this CamelCase struct and the associated 'registerData' variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/d
The ni_gpct_device_construct() could fail allocating the memory for
device and its counters. For aesthetics, call the function before
initializing the subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 20 ++
Hi,
I haven’t received any feedback as to whether my patch has been accepted. Would
request someone to kindly help me out. Maybe you could weigh in here Greg?
Regards,
Parth Sane
> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.com wrote:
>
> From: Parth Sane
>
> Fixed multiple assignment ch
On Sat, Mar 19, 2016 at 2:04 PM, Parth Sane wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted.
> Would request someone to kindly help me out. Maybe you could weigh in here
> Greg?
> Regards,
> Parth Sane
>> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.c
Hi Roger,
Can I submit more patches similarly until this has been accepted? I’ll be sure
to remove the from part in my next patch(I hope I don’t have to submit the
earlier patch again).Thanks for your wise comments!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:33 PM, Roger H Newell wrote:
>
> On
On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted.
> Would request someone to kindly help me out. Maybe you could weigh in here
> Greg?
> Regards,
> Parth Sane
> > On 15-Mar-2016, at 10:16 PM, laerdevstud..
Hi,
Thanks for getting back to me Greg! I’m still learning, so thanks again for
bearing with me!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:43 PM, Greg KH wrote:
>
> On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
>> Hi,
>> I haven’t received any feedback as to whether my patch has
For aesthetics, add some whitespace to the subdevice init and use
a couple local variables to make the code easier to follow.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 59 +---
1 file change
Smatch lists the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c:371
rtl92ee_rx_query_desc() warn: inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +-
From: Gustavo Padovan
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan
Reviewed-by: Maarten Lankhorst
---
drivers/staging/android/uapi/sync.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Gustavo Padovan
Change SYNC_IOC_FILE_INFO (former SYNC_IOC_FENCE_INFO) behaviour to avoid
future API breaks and optimize buffer allocation.
Now num_fences can be filled by the caller to inform how many fences it
wants to retrieve from the kernel. If the num_fences passed is greater
than ze
On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote:
> On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
>> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>>
>> Is this a gcc-6 specific issue? Seems line this warning should be showing
>> up in a lot of drivers.
>
> Yes, I
On Fri, Mar 18, 2016 at 05:38:45PM +, Hartley Sweeten wrote:
> On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote:
> > On 15/03/16 21:48, H Hartley Sweeten wrote:
> >> Memory mapped io (dev->mmio) should not also be writing to the ioport
> >> (dev->iobase) registers. Add the missing 'else'
Remove the extra for loop and just initialize the counter as the subdevices
are created.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/
From: Gustavo Padovan
This function had copies in 3 different files. Unify them in kernel.h.
Cc: Joe Perches
Cc: Andrew Morton
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Signed-off-by: Gustavo Padovan
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 11 +++
drivers/gpu/drm
Em Wed, 16 Mar 2016 10:28:35 +0200
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 14 Mar 2016 14:09:09 +0200
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
...
> > > Notify callbacks, perhaps not, but the lis
On Wed, 2016-03-16 at 18:34 -0400, Martin K. Petersen wrote:
> > > > > > "KY" == KY Srinivasan writes:
>
> KY> How would I get the sysfs files under fc_host if I don't use the
> FC
> KY> transport. The customer scripts expect these sysfs files.
>
> Right, but I was interested in finding out why
From: Ubuntu
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index daee1b2..82af02
Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
with devm_request_irq") introduced the following static checker
warning:
drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
error: 'dev->netinfo_task' dereferencing possible ERR_PTR()
Remove the bug introduced by the commit
On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote:
> From: Andrey Utkin
>
> Support for boards based on Techwell TW5864 chip which provides
> multichannel video & audio grabbing and encoding (H.264, MJPEG,
> ADPCM G.726).
>
> Signed-off-by: Andrey Utkin
> Tested-by: Andrey Utkin
> -
Change the generic MODULE_DESCRIPTION text to something more useful.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
Rename these functions so they have namespace associated with the
driver.
Fix the checkpatch.pl issues:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 16 +++---
Fix the checkpatch.pl issues about:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 17 +++--
1 file
2016-03-18 13:33+0100, Vitaly Kuznetsov:
> Kdump keeps biting. Turns out CHANNELMSG_UNLOAD_RESPONSE is always
> delivered to CPU0 regardless of what CPU we're sending CHANNELMSG_UNLOAD
> from. vmbus_wait_for_unload() doesn't account for the fact that in case
> we're crashing on some other CPU and C
On Sat, 2016-03-19 at 18:35 +, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.
Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c
> b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct p
Use the comedi.h provided constants (enum ni_660x_pfi_routing) instead
of defining new ones for the output sources.
Use a switch to clarify the channel/source validation.
For aesthetics, rename the private data members 'pfi_output_selects' and
'pfi_direction_bits'.
Remove the 'min_counter_pfi_ch
This is a patch to the rtllib_softmac.c file that fixes up all instances of
the 'line over 80 characters' warnings found by the checkpatch.pl tool.
Signed-off-by: Yousof El-Sayed
---
drivers/staging/rtl8192e/rtllib_softmac.c | 35 +++
1 file changed, 22 insertions(+)
On Fri, Mar 18, 2016 at 6:42 AM, Linux Kernel Mailing List
wrote:
> Web:
> https://git.kernel.org/torvalds/c/f45b0fba43f415f69982df743dfa9b5d1b57785e
> Commit: f45b0fba43f415f69982df743dfa9b5d1b57785e
> Parent: b3c9f3c56c41cbebe7804b48ba8e6e484509c2c0
> Refname:refs/heads/maste
Fixed block comment checkpatch warnings.
Signed-off-by: Gavin O'Leary
---
drivers/staging/unisys/visornic/visornic_main.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_ma
1 - 100 of 136 matches
Mail list logo
