From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_ea.c | 3 +-
drivers/staging/lustre/lustre/lov/lov_internal.h | 6 +-
drivers/staging/lustre/lustre/lo
From: Oleg Drokin
Replace it with enum ldlm_error
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 8
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c| 4 ++--
drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++--
drivers/staging/lustre/lus
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dcache.c | 18 ++-
drivers/staging/lustre/lustre/llite/dir.c | 29 ++--
drivers/staging/lustre/
From: Oleg Drokin
This patch removes remaining several places that still had that
extra paragraph included in Lustre code.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h | 5 -
drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h | 5 -
From: Oleg Drokin
Object update was originally planned to be used for cross-server
updates, so nothing to do with the client. The idea was
later significantly reworked anyway so even wire structs should
not be retained.
This gets rid of update_cmd_t, UPDATE and UPDATE_REPLY rpc and
corresponding
From: Oleg Drokin
CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK,
CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused
on the client.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 11 ---
1 file changed, 11 deletions(-)
diff --
From: Oleg Drokin
lustre_idl.h contains various protocol data. In order to avoid
reusal of values that might have meant something else in the past,
the old no longer used values are commented out, convert the
comments into regular comments from C99 where appropriate.
Signed-off-by: Oleg Drokin
From: Oleg Drokin
QUOTABLOCK_BITS, QUOTABLOCK_SIZE and toqb are only used on the server
and are copied from kernel code anyway.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 12
drivers/staging/lustre/lustre/ptlrpc/wiretest.c
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lclient/glimpse.c| 3 ++-
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 24 ++
.../sta
From: Oleg Drokin
These defines are only used on the servers to determine
what connect flags corresponding servers support:
MDT_CONNECT_SUPPORTED
OST_CONNECT_SUPPORTED
MGS_CONNECT_SUPPORTED
ECHO_CONNECT_SUPPORTED
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h
From: Oleg Drokin
Replace with enum sec_cmd
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
b/drivers/staging/lustre/lustr
From: Oleg Drokin
These server-only structures and some supporting defines are unused
on the client.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h | 52 --
drivers/staging/lustre/lustre/ptlrpc/wiretest.c| 44 --
2 file
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 71 -
1 file changed, 46 insertions(+), 25 deletions(-)
diff --git a/drive
From: Oleg Drokin
This fixes most of the
"Block comments use a trailing */ on a separate line" checkpatch
warnings, also some slight reformats of structures or comments
at places.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 69 ++
dri
From: Oleg Drokin
none look like bugs or bugs-inducing, mostly just
off by a couple of spaces all around.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 2 +-
.../lustre/lustre/include/lustre/lustre_idl.h | 8 ++--
.../lustre/lustre/include/lustre/lu
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lmv/lmv_fld.c| 3 ++-
drivers/staging/lustre/lustre/lmv/lmv_intent.c | 9 ---
drivers/staging/lustre/lustre/
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/cl_io.c | 13 +++--
drivers/staging/lustre/lustre/obdclass/cl_lock.c | 24 +---
drivers/staging/lust
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_cache.c | 168 ++---
.../staging/lustre/lustre/osc/osc_cl_internal.h| 33 ++--
driver
From: Oleg Drokin
No need to check for it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
b/drivers/staging/lustre/lustre/include/lustre/l
From: Oleg Drokin
Despite it's name struct obd_export could exist on the client too
(used for reverse exports), but all the actual server bits
are not needed there, so could be dropped. This is mostly
various target-related stuff.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/includ
From: Oleg Drokin
So no need to see if they are.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
b/drivers/staging/lustre/lustre/include/l
From: Oleg Drokin
struct idx_info, struct lu_idxpage, lustre_swab_idx_info,
request formats and related defines are all unused and could
only happen for between-servers communications, so remove them
from the client code.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_i
From: Oleg Drokin
It's only used for communications between servers.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h | 31 ---
.../lustre/lustre/include/lustre_req_layout.h | 3 --
drivers/staging/lustre/lustre/ptlrpc/layout.c | 36 -
From: Oleg Drokin
Capabilities code was the only user and it is long gone.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_internal.h | 6 ++
drivers/staging/lustre/lustre/llite/llite_lib.c | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/
From: Oleg Drokin
Replace it with enum ldlm_appetite
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 8
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/
From: Oleg Drokin
Does not appear to be used anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
b/drivers/staging
From: Oleg Drokin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/lustre/lustre/llite/file.c
index bbe6ebf..ba65fc0 100644
--- a/drivers/staging/lustre/lu
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lus
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fld/fld_cache.c| 9 ++---
drivers/staging/lustre/lustre/fld/fld_internal.h | 24
dri
From: Oleg Drokin
Replace it with enum se_stat
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/statahead.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/statahead.c
b/drivers/staging/lustre/lustre/llite/st
From: Oleg Drokin
This code has been commented out since end of 2012, so it's
clearly not needed here.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
b/
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 6 +-
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 12 +-
drivers/staging/lustre/lus
From: Oleg Drokin
This file mostly contains various on the wire data and got
significantly mangled in transition.
This patch rectifies the situation somewhat. Also fixes the
comment style for block comments.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h | 28
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 +-
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 87 -
drivers/stag
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdecho/echo_client.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lust
From: Oleg Drokin
of the two macroses is contained the LUSTRE_RELEASE was unused and
BUILD_VERSION is too generically named and was replaced with
LUSTRE_VERSION_STRING with all the users (provided by lustre_ver.h)
With in-kernel client the build version should be combined with
kernel build infor
From: Oleg Drokin
These values cannot be seen on the client so we probably should
not even be aware of them on the client.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre/lustre_idl.h| 16
1 file changed, 16 deletions(-)
diff --git a/drivers/stagin
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/connection.c | 3 +-
drivers/staging/lustre/lustre/ptlrpc/events.c | 51 ++---
drivers/staging/lust
Hi Oleg,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.5-rc5 next-20160222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/green-linuxhacker-ru/More-Lustre
Hello Geliang Tang,
The patch e280d71bea18: "staging: rtl8723au: use
list_for_each_entry*()" from Feb 18, 2016, leads to the following
static checker warning:
drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a()
error: potential NULL dereference 'psta'.
drivers/s
Dear Dan,
Thank you your great comments.
I will be not forget your advice.
Please understand that if you have a misunderstanding.
Thank you & Best Regards.
Leo
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, February 22, 2016 11:44 PM
To: Kim, Le
wid_cnt variable is used as indicating array index of struct wid_list.
This patch renames wid_cnt to i that makes more readability.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 184 +++---
1 file changed, 92 insertions(+), 92 deletions(-)
d
This struct just wrap struct cfg_param_val. There is no other member
except struct cfg_param_val.
This patch remove struct cfg_param_attr, then struct cfg_param_val is
renamed to struct cfg_param_attr.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 172 ++
commit 31cc9885e7c7 ("staging: wilc1000: handle_set_mac_address: use kmemdup")
introduces a new checkpatch warning, so this patch fixes it.
WARNING: Missing a blank line after declarations
FILE: drivers/staging/wilc1000/host_interface.c:430:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1
This patch fixes line over 80 characters found by checkpatch
WARNING: line over 80 characters
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/stagi
This patch fixes logical continuations found by checkpatch
CHECK: Logical continuations should be on the previous line
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc10
This patch changes data type of wid_cnt from u8 to int.
This variable uses array index of struct wid_list so that it is better
to use int type.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
This patch removes unnecessary whitespace before a quoted newline found
by checkpatch
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
101 - 148 of 148 matches
Mail list logo
