There is a use-after-free problem in the ion driver.
This is caused by a race condition in the ion_ioctl()
function.
A handle has ref count of 1 and two tasks on different
cpus calls ION_IOC_FREE simultaneously.
cpu 0 cpu 1
---
This patch removes unnecessary wilc_debug print log and the check routine.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index 2719c3d..a51c66b 100
This patch removes unnecessary variable of wilc_mac_cfg_t structure.
The variable is debug print function pointer.
Removes all what used this variable.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/wi
This patch removes wilc_dbg function because it's not any more.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/linux_wlan.c | 4
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 --
drivers/staging/wilc1000/wilc_wlan.c | 2 --
3 files changed, 8 deletions(-)
diff --g
This patch removes unnecessary wilc_debug print log.
The print log was written when if condition fail.
The condition is chip-id check function.
Also, replaces this condition with normal function.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 4 +---
1 file changed, 1 insertio
This patches replaces wilc_debug with netdev_err.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index 81a40e8..2719c3d 100644
-
This patch changes the argument of the wilc_wlan_cfg_init function,
wilc_debug to void type because wilc_debug function is not used any more.
In addition, finally removes wilc_debug and related variables.
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 17 +
Run your patch through scripts/checkpatch.pl
ERROR: that open brace { should be on the previous line
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Feb 17, 2016 at 09:32:52AM +0800, Nicolas Boichat wrote:
> This patch was first sent upstream here: https://lkml.org/lkml/2015/5/28/747,
> but was not picked up (probably because it was part of a bigger series that
> refactored binder).
Riley was supposed to resend it with a proper sign of
From: Chris Park
This patch removes useless define in linux_wlan_common.h file
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/linux_wlan_common.h | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan
From: Chris Park
This patch moves MODALIS and GPIO_NUM define to wilc_wlan.h file.
MODALIS and GPIO_NUM define are used to two files (wilc_sdio.c,
wilc_spi.c), these files already include wilc_wlan.h file in common.
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000
From: Chris Park
This patch moves WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file.
This define is used to three files(host_interface.c,host_interface.h,
linux_wlan.c) these files already include wilc_wlan_if.h file in common.
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
---
driver
From: Chris Park
This patch removes linux_wlan_common.h file and also removes the following
preprocessor at files that include it:
- #include 'linux_wlan_common.h'
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
---
drivers/staging/wilc1000/linux_mon.c | 1 -
drivers/staging/wilc100
Of course, we still reach almost the same maximum stack usage as before
because we're going to put the function on stack in the end anyway.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.or
On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
>
> Should I send this patch again due the spelling mistake in the patch
> description?
>
Yes. And put what Oleg Drokin said about it worked because there were
no users in the changelog.
regards,
dan carpenter
___
On Fri, Feb 19, 2016 at 05:37:10PM +0900, Leo Kim wrote:
> This patch removes unnecessary wilc_debug print log.
> The print log was written when if condition fail.
> The condition is chip-id check function.
> Also, replaces this condition with normal function.
>
> Signed-off-by: Leo Kim
> ---
>
There is a use-after-free problem in the ion driver.
This is caused by a race condition in the ion_ioctl()
function.
A handle has ref count of 1 and two tasks on different
cpus calls ION_IOC_FREE simultaneously.
cpu 0 cpu 1
---
Hi,
On Tue, Feb 16, 2016 at 5:32 PM, Nicolas Boichat wrote:
> From: Lisa Du
>
> There's one point was missed in the patch commit da49889deb34 ("staging:
> binder: Support concurrent 32 bit and 64 bit processes."). When configure
> BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but si
Replace complex definition of single-bit fields with BIT() macro for the
registers that are not currently referenced by the driver.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 1071 +
drivers/staging/sm750fb/sm750_accel.h | 36 +-
2
Hi,
This is the fourth (and final) set of patches that aim to replace custom
defines for register fields. The MSB:LSB notation for register fields is
completely removed and replaced by BIT() for single-bit fields and with
*_MASK for multi-bit fields. The removal of MSB:LSB notation allowed to get
The MHz() and roundedDiv macros are used only by ddk750_chip.c, so move
their definition there.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 4
drivers/staging/sm750fb/sm750_help.h | 7 ---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drive
This header only contains unused FIELD_*() macros and friends and may be
removed
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_help.h | 1 -
drivers/staging/sm750fb/sm750_accel.c | 1 -
drivers/staging/sm750fb/sm750_cursor.c | 1 -
drivers/staging/sm750fb/sm750_help.h |
Use stratigh-forward of multi-bit register fields
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_reg.h | 907 +-
drivers/staging/sm750fb/sm750_accel.h | 62 +--
2 files changed, 484 insertions(+), 485 deletions(-)
diff --git a/drivers/staging/s
already has 'abs', use it instead of custom absDiff
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 3 ++-
drivers/staging/sm750fb/sm750_help.h | 8
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
b/drivers
These patches change the behavior of the `COMEDI_BUFINFO` ioctl, which
is used to manage buffer positions for a previously set up asynchronous
acquisition command. It is used instead of the read and write file
operations when the buffer has been mmapped.
Patches 1 to 4 are fairly innocuous. Patc
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the new
position. On input, the `bytes_read` member of `struct comedi_bufinfo`
specifies the amount to advance the "read" position for an asynchronous
command in the "rea
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the new
position. On input, the `bytes_read` member of `struct comedi_bufinfo`
specifies the amount to advance the "read" position for an asynchronous
command in the "rea
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the new
position. On input, the `bytes_read` member of `struct comedi_bufinfo`
specified the amount to advance the "read" position for an asynchronous
command in the "rea
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the current
position. An asynchronous command in the "read" direction is terminated
automatically once it has stopped and information about the final
position and error h
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the new
position. For an asynchronous command in the "read" direction, if the
command has finished acquiring data normally, `do_become_nonbusy()` is
called to terminate t
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the new
position. On input, the `bytes_written` member of `struct
comedi_bufinfo` specifies the amount to advance the "write" position for
an asynchronous command in the
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer by a specified amount (which can be 0) and get the current
position. If an asynchronous command in the "read" direction has
stopped normally, the command is terminated as soon as the position has
been advanced to the
The `COMEDI_BUFINFO` ioctl is used to advance the current position in
the buffer and/or get the current buffer position. If no asynchronous
command is active (started via the file object that issued this ioctl),
this information is meaningless. Change it to return an error
(`-EINVAL`) in this cas
On 19/02/16 16:13, Ian Abbott wrote:
...stuff...
Sorry, I forgot to tag that email as "[PATCH 0/8]".
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
___
devel mailing list
de...@linuxdriverproje
On 02/18/2016 03:45 PM, Greg Kroah-Hartman wrote:
On Fri, Feb 19, 2016 at 12:20:45AM +0200, Aaro Koskinen wrote:
Use atomic_long_t, so that we can avoid some 32 vs. 64-bit ifdeffery.
Why are these atomic at all? There's no reason they can't just be a
u64 like all other network drivers have, r
On Fri, Feb 19, 2016 at 10:08:07AM -0800, David Daney wrote:
> On 02/18/2016 03:45 PM, Greg Kroah-Hartman wrote:
> >On Fri, Feb 19, 2016 at 12:20:45AM +0200, Aaro Koskinen wrote:
> >>Use atomic_long_t, so that we can avoid some 32 vs. 64-bit ifdeffery.
> >
> >Why are these atomic at all? There's n
This fixes the checkpatch.pl warning:
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Signed-off-by: Joseph Bisch
---
drivers/staging/speakup/kobjects.c| 12 ++--
drivers/staging/speakup/main.c| 6 +-
drivers/staging/speakup/varhandlers.c | 6 +-
3 files
Hi,
On Fri, Feb 19, 2016 at 10:17:54AM -0800, Greg Kroah-Hartman wrote:
> On Fri, Feb 19, 2016 at 10:08:07AM -0800, David Daney wrote:
> > On 02/18/2016 03:45 PM, Greg Kroah-Hartman wrote:
> > >On Fri, Feb 19, 2016 at 12:20:45AM +0200, Aaro Koskinen wrote:
> > >>Use atomic_long_t, so that we can a
Fix a driver hang caused by earlier suspend/resume cycles. By handling a
ENODEV error during suspend as a real error we eventually end up stopping
the whole driver.
Fix this by handling the ENODEV error (during suspend) essentially by
retrying.
Signed-off-by: Hemmo Nieminen
---
drivers/staging/
On 02/19/2016 04:03 AM, EunTaik Lee wrote:
> There is a use-after-free problem in the ion driver.
> This is caused by a race condition in the ion_ioctl()
> function.
>
> A handle has ref count of 1 and two tasks on different
> cpus calls ION_IOC_FREE simultaneously.
>
> cpu 0
From: Simon Xiao
Date: Wed, 17 Feb 2016 16:43:59 -0800
> Enable skb_tx_timestamp in hyperv netvsc.
>
> Signed-off-by: Simon Xiao
> Reviewed-by: K. Y. Srinivasan
> Reviewed-by: Haiyang Zhang
Applied.
___
devel mailing list
de...@linuxdriverproject.o
We have only one NAPI poll running at a time, so virtual port rx counters
can be updated normally.
Update of rx_dropped can still race with the gathering of statistics,
but full accuracy is not required there.
Signed-off-by: Aaro Koskinen
---
Replaces this patch: http://marc.info/?t=145
On 02/19/2016 12:47 PM, Aaro Koskinen wrote:
We have only one NAPI poll running at a time, so virtual port rx counters
can be updated normally.
Update of rx_dropped can still race with the gathering of statistics,
but full accuracy is not required there.
Signed-off-by: Aaro Koskinen
Acked-by
On Thu, Feb 18, 2016 at 08:30:01PM +0900, Leo Kim wrote:
> This patches removes PRINT_ER that is unnecessary debug logs.
>
> Signed-off-by: Leo Kim
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 2 --
> 1 file changed, 2 deletions(-)
What changed in this series from v1? Why should I take it?
On Fri, Feb 19, 2016 at 05:37:07PM +0900, Leo Kim wrote:
> This patch removes wilc_dbg function because it's not any more.
>
> Signed-off-by: Leo Kim
> ---
> drivers/staging/wilc1000/linux_wlan.c | 4
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 --
> drivers/staging/wilc1000
On Fri, Feb 19, 2016 at 06:57:42PM +0900, Leo Kim wrote:
> From: Chris Park
>
> This patch moves WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file.
> This define is used to three files(host_interface.c,host_interface.h,
> linux_wlan.c) these files already include wilc_wlan_if.h file in comm
2016-02-16 7:12 GMT+09:00 Larry Finger :
> Routine rtl_addr_delay() uses delay statements in code that can
> sleep. To improve system responsiveness, the various delay statements
> are changed.
>
> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are
> rewritten to use the code in rtl_add
47 matches
Mail list logo
