Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > This patch fixes coding style of kmalloc usage found by checkpatch. > CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct > message)...) > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_msgque

Re: [PATCH] rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

Larry Finger writes: > Recently, it has been reported that D-Link DWA-582 cards, which use an > RTL8812AE chip are not able to scan for 5G networks. The problems started > with kernel 4.2, which is the first version that had commit d10101a60372 > ("rtlwifi: rtl8821ae: Fix problem with regulatory

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: > On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > > This patch fixes coding style of kmalloc usage found by checkpatch. > > CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct > > message)...) > > >

Re: [PATCH] rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

On 01/21/2016 02:52 AM, Kalle Valo wrote: Larry Finger writes: Recently, it has been reported that D-Link DWA-582 cards, which use an RTL8812AE chip are not able to scan for 5G networks. The problems started with kernel 4.2, which is the first version that had commit d10101a60372 ("rtlwifi: rt

[PATCH] staging: iio: replace clk_get() with devm_clk_get()

From: Hari Prasath Gujulan Elango This patch replaces the clk_get() with devm_clk_get(). Accordingly,modified the error paths and removed clk_put() as well. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/iio/adc/spear_adc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletion

Re: [PATCH] Staging: panel: Fix sparse warnings (line length, space after a cast) in panel.c

These are all checkpatch.pl warnings, not sparse warnings. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: s626: Remove unnecessary cast on void pointer

On Wed, Jan 20, 2016 at 09:48:39PM -0200, Lucas Tanure wrote: > The conversion from void pointer to any other pointer type is guaranteed by > the C programming language. > > Signed-off-by: Lucas Tanure > --- > drivers/staging/comedi/drivers/s626.c | 8 > 1 file changed, 4 insertions(+),

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 09:11:38AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > Your email address is missing here. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 12:45:59PM +0300, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 09:11:38AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > Your email address is missing here. Hello Dan, Many thanks for notifying.I am sending a v2. regards

[PATCHv2] staging: iio: replace clk_get() with devm_clk_get()

From: Hari Prasath Gujulan Elango This patch replaces the clk_get() with devm_clk_get(). Accordingly,modified the error paths and removed clk_put() as well. Signed-off-by: Hari Prasath Gujulan Elango --- v2: email address was missing in the From field. --- drivers/staging/iio/adc/spear

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: >> On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: >> > This patch fixes coding style of kmalloc usage found by checkpatch. >> > CHECK: Prefer kmalloc(sizeof(*new_

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 07:01:45PM +0900, Chaehyun Lim wrote: > On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter > wrote: > > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: > >> On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > >> > This patch fixes coding style of k

[PATCH] staging: nvec: replace led_classdev_register

From: Hari Prasath Gujulan Elango Replace the led_classdev_register() with the platform managed version devm_led_classdev_register() & henceforth remove the redundant nvec_paz00_remove() function. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/nvec/nvec_paz00.c | 12 +--

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 7:04 PM, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 07:01:45PM +0900, Chaehyun Lim wrote: >> On Thu, Jan 21, 2016 at 5:55 PM, Dan Carpenter >> wrote: >> > On Thu, Jan 21, 2016 at 01:48:16PM +0530, Sudip Mukherjee wrote: >> >> On Thu, Jan 21, 2016 at 10:20:28AM +0900,

[PATCH V2 02/27] staging: wilc1000: rename pvBuffer in struct message

This patch renames pvBuffer to buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue

[PATCH V2 01/27] staging: wilc1000: rename struct __Message_struct

This patch renames typedef from struct __Message_struct and renames it to struct message. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH V2 07/27] staging: wilc1000: rename strCriticalSection in struct message_queue

This patch renames strCriticalSection to lock to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/w

[PATCH V2 00/27] rename variables in wilc1000 driver

V2: A 18/27 patch of series has a wrong name as tail_msg, which is should be changed to pstrTailMsg. I fixed it in V2. Chaehyun Lim (27): staging: wilc1000: rename struct __Message_struct staging: wilc1000: rename pvBuffer in struct message staging: wilc1000: rename u32Length in struct messa

[PATCH V2 03/27] staging: wilc1000: rename u32Length in struct message

This patch renames u32Length to len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 09/27] staging: wilc1000: rename u32ReceiversCount in struct message_queue

This patch renames u32ReceiversCount to recv_count to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc10

[PATCH V2 04/27] staging: wilc1000: rename pstrNext in struct message

This patch renames pstrNext to next to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqu

[PATCH V2 22/27] staging: wilc1000: rename u32RecvBufferSize in wilc_mq_recv

This patch renames u32RecvBufferSize to recv_buf_size to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH V2 05/27] staging: wilc1000: rename struct WILC_MsgQueueHandle

This patch removes typedef from struct WILC_MsgQueueHandle and renames it to struct message_queue. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.c | 14 +++--- drivers/staging/wilc1000/wilc_msgqueue.h | 18

[PATCH V2 14/27] staging: wilc1000: rename pHandle in wilc_mq_send

This patch renames pHandle to mq to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 22 +++--- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/w

[PATCH V2 15/27] staging: wilc1000: rename pvSendBuffer in wilc_mq_send

This patch renames pvSendBuffer to send_buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msg

[PATCH V2 18/27] staging: wilc1000: rename pstrTailMsg in wilc_mq_send

This patch renames pstrTailMsg to tail_msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 08/27] staging: wilc1000: rename bExiting in struct message_queue

This patch renames bExiting to exiting to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue

[PATCH V2 20/27] staging: wilc1000: rename pHandle in wilc_mq_recv

This patch renames pHandle to mq to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 34 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/

[PATCH V2 12/27] staging: wilc1000: rename pHandle in wilc_mq_destroy

This patch renames pHandle to mq to avoid camelcase Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_m

[PATCH V2 10/27] staging: wilc1000: rename pstrMessageList in struct message_queue

This patch renames pstrMessageList to msg_list to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 20 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/stagin

[PATCH V2 13/27] staging: wilc1000: rename pstrMessge in wilc_mq_destroy

This patch renames pstrMessge to msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 103

[PATCH V2 11/27] staging: wilc1000: rename pHandle in wilc_mq_create

This patch renames pHandle to mq to avoid camelcase Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.

[PATCH V2 16/27] staging: wilc1000: rename u32SendBufferSize in wilc_mq_send

This patch renames u32SendBufferSize to send_buf_size to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc100

[PATCH V2 06/27] staging: wilc1000: rename hSem in struct message_queue

This patch renames hSem to sem to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 10 +- drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH V2 19/27] staging: wilc1000: fix return error code

Three argument are checked at the beginning of wilc_mq_send whether they are valid arguments or not. It is correct to use return error code as -EINVAL, not -EFAULT. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH V2 17/27] staging: wilc1000: rename pstrMessage in wilc_mq_send

This patch renames pstrMessage to new_msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/

[PATCH V2 21/27] staging: wilc1000: rename pvRecvBuffer in wilc_mq_recv

This patch renames pvRecvBuffer to recv_buf to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 drivers/staging/wilc1000/wilc_msgqueue.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msg

[PATCH V2 27/27] staging: wilc1000: remove over-commenting

There are over-commenting in wilc_msgqueue.h file. This comment is not explain exactly what codes do and make checkpatch warning about "line over 80 charcters". If necessary, comment will be added later with preferred coding style. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_ms

[PATCH V2 26/27] staging: wilc1000: fix logical continuations

This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgq

[PATCH V2 25/27] staging: wilc1000: fix coding style of kmalloc usage

This patch fixes coding style of kmalloc usage found by checkpatch. CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct message)...) Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH V2 23/27] staging: wilc1000: rename pu32ReceivedLength in wilc_mq_recv

This patch renames pu32ReceivedLength to recv_len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 7 +++ drivers/staging/wilc1000/wilc_msgqueue.h | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wi

[PATCH V2 24/27] staging: wilc1000: rename pstrMessage in wilc_mq_recv

This patch renames pstrMessage to msg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_

[PATCH] staging: android: ion: Set the length of the DMA sg entries in buffer

From: Liviu Dudau ion_buffer_create() will allocate a buffer and then create a DMA mapping for it, but it forgot to set the length of the page entries. Signed-off-by: Liviu Dudau Signed-off-by: Jon Medhurst --- drivers/staging/android/ion/ion.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

Re: [PATCH 1/3] staging: comedi: mite: enable continuous regeneration of finite samples

On 12/01/16 08:17, Spencer E. Olson wrote: This change enables the mite DMA controller to only transfer the amount of data needed by a command. By default, the old behavior of transferring the entire comedi DMA data buffer is still in effect. These changes allow a command to only transmit a lim

[PATCH 04/11] staging/android: create a 'sync' dir for debugfs information

From: Gustavo Padovan Creates the 'sync' dir on debugfs root dir and move the 'sync' file to sync/info. This is the preparation to add more debug info and control. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync_debug.c | 21 + 1 file changed, 17 insertions(

[PATCH 02/11] staging/android: sync: remove interfaces that are not used

From: Gustavo Padovan These interfaces are not used nor have plans to be used in the near future so remove them for a cleaner solution before de-staging the sync framework. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 56 driver

[PATCH 07/11] staging/android: rename 'sync_pt' to 'fence' in struct sync_fence_cb

From: Gustavo Padovan 'sync_pt' is actually declared as struct fence so to make the name means its type we rename it to 'fence'. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 20 ++-- drivers/staging/android/sync.h | 2 +- drivers/staging/andr

[PATCH 05/11] staging/android: move SW_SYNC_USER to a debugfs file

From: Gustavo Padovan This remove CONFIG_SW_SYNC_USER and instead compile the sw_sync file into debugpfs under /sync/sw_sync. Signed-off-by: Gustavo Padovan --- drivers/staging/android/Kconfig | 9 --- drivers/staging/android/sw_sync.c| 129 --- drive

[PATCH 01/11] staging/android: fix sync framework documentation

From: Gustavo Padovan Updates comments about functions and structures. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.h | 45 -- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/staging/android/sync.h b/drivers/sta

[PATCH 00/11] sync framework de-staging: part 1 - clean up

From: Gustavo Padovan Hi, The following patches are some clean ups on the sync framework before we start the actual de-staging. The main changes here are the move of SW_SYNC_USER to debugfs. Removal of struct sync_pt in favor of direct use of struct fence. And the rename of sync_fence to sync_fi

[PATCH 11/11] staging/android: remove sync_fence_create_dma()

From: Gustavo Padovan With the removal of struct sync_pt sync_fence_create_dma() now takes the same arguments as sync_fence_create() so let's keep only sync_fence_create(). Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 8 +--- drivers/staging/android/sync.h | 10

[PATCH 03/11] staging/android: remove not used sync_timeline ops

From: Gustavo Padovan .dup and .compare are not used by the sync framework, so remove them from sw_sync. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 29 + drivers/staging/android/sync.c| 6 -- drivers/staging/android/sync.h| 1

[PATCH 06/11] staging/android: rename sync_fence to sync_file

From: Gustavo Padovan sync_file has a more close meaning to what a sync_fence really, a struct that represent a file that can be used by userspace to get information on a fence, or wait for it to be signaled. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 254 +++

[PATCH 08/11] staging/android: remove struct sync_pt

From: Gustavo Padovan struct sync_pt was just wrapping around struct fence and creating an extra abstraction layer. The only two members of struct sync_pt, child_list and active_list, were moved to struct fence in an earlier commit. After removing those two members struct sync_pt is nothing more

[PATCH 10/11] staging/android: remove pointless sync_timeline_signal at destroy phase

From: Gustavo Padovan All changes to timeline value come through the user via sync_timeline_signal() calls. When sync_timeline_destroy() is called no changes on timeline->value happens hence call sync_timeline_signal() with no increment is pointless. Signed-off-by: Gustavo Padovan --- drivers/

[PATCH 09/11] staging/android: remove unused var from sync_timeline_signal()

From: Gustavo Padovan signaled_pts is not used in this function. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 3c2c8d0..9ec55ef 100644 --- a/drivers/stag

Re: [PATCH 2/3] staging: comedi: ni_mio_comon: adds finite regeneration to AO output

On 12/01/16 08:17, Spencer E. Olson wrote: This patch implements for analog output the reinterpretation of stop_arg when stop_src == TRIG_NONE to allow the user to specify the length of the buffer that should be repeated. The intent is to allow a user to have a specific buffer repeated as-is ind

Re: [PATCH 3/3] staging: comedi: ni_mio_comon: add finite regeneration to dio output

On 12/01/16 08:17, Spencer E. Olson wrote: This patch continues the implementation of reinterpreting stop_arg when stop_src == TRIG_NONE for national instruments cdio output on e/m-series devices. This is part of a series of patches that allow a user to have a specific buffer repeated as-is inde

Re: [PATCH] staging: android: ion: Set the length of the DMA sg entries in buffer

On 01/21/2016 03:57 AM, Jon Medhurst (Tixy) wrote: From: Liviu Dudau ion_buffer_create() will allocate a buffer and then create a DMA mapping for it, but it forgot to set the length of the page entries. Signed-off-by: Liviu Dudau Signed-off-by: Jon Medhurst --- drivers/staging/android/ion/

Re: [PATCH] Staging: panel: Fix sparse warnings (line length, space after a cast) in panel.c

On Thu, Jan 21, 2016 at 12:27:59PM +0300, Dan Carpenter wrote: > These are all checkpatch.pl warnings, not sparse warnings. > > regards, > dan carpenter > Thanks for pointing this out. I will be more careful when choosing a subject in the future. Regards, --Arthur Marble ___

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 1:11 AM, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch replaces the clk_get() with devm_clk_get(). > Accordingly,modified the error paths and removed clk_put() as well. > > Signed-off-by: Hari Prasath Gujulan Elango > --- > dr

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote: > > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *pdev) > > > > errout3: > > clk_disable_unprepare(st->clk); > > Shouldn't errout3 now be errout2.. having a gap would seem odd. > > > -errout2: > > -

Re: [PATCH] staging: android: ion: Set the length of the DMA sg entries in buffer

On Thu, 2016-01-21 at 09:39 -0800, Laura Abbott wrote: > On 01/21/2016 03:57 AM, Jon Medhurst (Tixy) wrote: > > From: Liviu Dudau > > > > ion_buffer_create() will allocate a buffer and then create a DMA > > mapping for it, but it forgot to set the length of the page entries. > > > > Signed-off-by:

Re: [PATCH] staging: android: ion: Set the length of the DMA sg entries in buffer

On 01/21/2016 12:19 PM, Jon Medhurst (Tixy) wrote: On Thu, 2016-01-21 at 09:39 -0800, Laura Abbott wrote: On 01/21/2016 03:57 AM, Jon Medhurst (Tixy) wrote: From: Liviu Dudau ion_buffer_create() will allocate a buffer and then create a DMA mapping for it, but it forgot to set the length of th

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote: > On Thu, Jan 21, 2016 at 1:11 AM, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch replaces the clk_get() with devm_clk_get(). > > Accordingly,modified the error paths and removed clk

[PATCH 2/2] staging: wilc1000: pass vif to wilc_send_config_pkt

This patch passes vif instead of wilc to wilc_send_config_pkt and it's related functions as well, because we need vif which is currently being used and vif has wilc as well. Change custom print with netdev_xxx format if there are custom print inside the functions we have changed. Function paramete

[PATCH 1/2] staging: wilc1000: move wilc_send_config_pkt to wilc_wlan.c

This patch moves the function wilc_send_config_pkt to wilc_wlan.c which handles transport since the purpose of the function is sending/getting of config information. coreconfiguator.[ch] will be rename with frame.[ch] later. The print codes of the function is removed also and they will be implement

Re: [PATCH 04/26] staging: wilc1000: add sdio resume/suspend

You should be running checkpatch.pl on your patches. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 20/26] staging: wilc1000: remove define TCP_ACK_FILTER

What does TCP_ACK_FILTER do? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel