Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl

2016-01-19 Thread Greg KH
On Tue, Jan 19, 2016 at 03:49:27PM +0800, chenfeng wrote: > > > On 2016/1/19 15:33, Greg KH wrote: > > On Tue, Jan 19, 2016 at 11:45:36AM +0800, Chen Feng wrote: > >> When a process fork a child process, we should not allow the > >> child process use the binder which opened by parent process. > >

Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl

2016-01-19 Thread chenfeng
On 2016/1/19 16:35, Greg KH wrote: > On Tue, Jan 19, 2016 at 03:49:27PM +0800, chenfeng wrote: >> >> >> On 2016/1/19 15:33, Greg KH wrote: >>> On Tue, Jan 19, 2016 at 11:45:36AM +0800, Chen Feng wrote: When a process fork a child process, we should not allow the child process use the bi

[PATCH v2] android: binder: Sanity check at binder ioctl

2016-01-19 Thread Chen Feng
When a process fork a child process, we should not allow the child process use the binder which opened by parent process. But if the binder-object creater is a thread of one process who exit, the other thread can also use this binder-object normally. We can distinguish this by the member proc->tsk

[PATCH 2/3] staging: wilc1000: remove redundant initialization for counter variable

2016-01-19 Thread Chaehyun Lim
There is no need to set counter variable to 0 because it is initialized in next for-loop statement. So, just delete it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/dr

[PATCH 3/3] staging: wilc1000: use int type for counter variable

2016-01-19 Thread Chaehyun Lim
counter is used as for-loop control variable and indicating index of struct wid array so that it is better to use int type. There is no need to set to 0 when it is declared at the top of this function. counter is initialized as 0 in for-loop statement. Signed-off-by: Chaehyun Lim --- drivers/sta

[PATCH 1/3] staging: wilc1000: fix return type of wilc_send_config_pkt

2016-01-19 Thread Chaehyun Lim
wilc_send_config_pkt is returned to 0 or -ETIMEDOUT according to return value of wilc_wlan_cfg_get and wilc_wlan_cfg_set functions. It is better to use int type in order to represent linux standard error code. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 5 +++--

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Daniel Vetter
On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > This patch series de-stage the sync framework, and in order to accomplish that > a bunch of cleanups/improvements on the sync and fence were made. > > The sync framework contained some abstractions aroun

[PATCH RESEND] staging: android: sync_debug.c: remove unnecessary braces

2016-01-19 Thread Robin Krahl
Remove unnecessary braces {} around a single statement within a for loop. Indicated by checkpatch. Signed-off-by: Robin Krahl --- drivers/staging/android/sync_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/and

Re: [PATCH 3/3] staging: wilc1000: use int type for counter variable

2016-01-19 Thread Dan Carpenter
On Tue, Jan 19, 2016 at 07:26:17PM +0900, Chaehyun Lim wrote: > counter is used as for-loop control variable and indicating index of > struct wid array so that it is better to use int type. > There is no need to set to 0 when it is declared at the top of this > function. counter is initialized as 0

Re: [PATCH v1 1/3] staging: rtl8188eu: provide an absolute path to include folder

2016-01-19 Thread Andy Shevchenko
On Thu, 2015-12-10 at 17:43 +0200, Andy Shevchenko wrote: > Otherwise compiler will complain as follows > >   CC [M]  drivers/staging/rtl8188eu/core/rtw_ap.o > cc1: warning: drivers/staging/rtl8188eu/include: No such file or > directory [-Wmissing-include-dirs] Any comments on the series? > > S

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Gustavo Padovan
Hi Daniel, 2016-01-19 Daniel Vetter : > On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > This patch series de-stage the sync framework, and in order to accomplish > > that > > a bunch of cleanups/improvements on the sync and fence were made. >

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread John Harrison
On 19/01/2016 15:23, Gustavo Padovan wrote: Hi Daniel, 2016-01-19 Daniel Vetter : On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan This patch series de-stage the sync framework, and in order to accomplish that a bunch of cleanups/improvements on the syn

[PATCH 1/6] staging: wlan-ng: Fixed block comments coding style issue

2016-01-19 Thread Pranjal Bhor
All block comment lines now begin with "*" and end with "*/" on a new line. Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers

[PATCH 3/6] staging: wlan-ng: Removed blank lines after braces

2016-01-19 Thread Pranjal Bhor
Blank lines before closing braces and after opening braces have been removed. Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 81f3624..00

[PATCH 2/6] staging: wlan-ng: Logical continuation fixes

2016-01-19 Thread Pranjal Bhor
Logical continuation coding style issues fixed while condition checking Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 47 ++-- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/

[PATCH 4/6] staging: wlan-ng: Coding style fix for casting operation

2016-01-19 Thread Pranjal Bhor
Removed spaces after casting operating Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 00d82e2..c4fd5b2 10064

[PATCH 5/6] staging: wlan-ng: Open parenthesis alignment style fix

2016-01-19 Thread Pranjal Bhor
Alignment of lines matched with open parenthesis Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index

[PATCH 6/6] staging: wlan-ng: NULL comparisons made elegant

2016-01-19 Thread Pranjal Bhor
Elegance added for NULL comparisons Signed-off-by: Pranjal Bhor --- drivers/staging/wlan-ng/p80211conv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c index 81f0f06..0a8f396 100644 --- a

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Gustavo Padovan
2016-01-19 John Harrison : > On 19/01/2016 15:23, Gustavo Padovan wrote: > >Hi Daniel, > > > >2016-01-19 Daniel Vetter : > > > >>On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > >>>From: Gustavo Padovan > >>> > >>>This patch series de-stage the sync framework, and in order to ac

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 03:52:26PM -0200, Gustavo Padovan wrote: > 2016-01-19 John Harrison : > > > On 19/01/2016 15:23, Gustavo Padovan wrote: > > >Hi Daniel, > > > > > >2016-01-19 Daniel Vetter : > > > > > >>On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > > >>>From: Gustavo Pa

Re: [PATCH v1 1/3] staging: rtl8188eu: provide an absolute path to include folder

2016-01-19 Thread Greg Kroah-Hartman
On Tue, Jan 19, 2016 at 01:50:35PM +0200, Andy Shevchenko wrote: > On Thu, 2015-12-10 at 17:43 +0200, Andy Shevchenko wrote: > > Otherwise compiler will complain as follows > > > >   CC [M]  drivers/staging/rtl8188eu/core/rtw_ap.o > > cc1: warning: drivers/staging/rtl8188eu/include: No such file o

Re: [patch] staging: rdma: shift wrapping bug in c2_get_dma_mr()

2016-01-19 Thread Doug Ledford
On 01/08/2016 08:29 AM, Christoph Hellwig wrote: > Looks fine. > > Doug: what's the status of the staged out drivers? I thought we were > going to delete them for 4.5? > I am. They will be going away shortly. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: O

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Gustavo Padovan
2016-01-19 Daniel Vetter : > On Tue, Jan 19, 2016 at 03:52:26PM -0200, Gustavo Padovan wrote: > > 2016-01-19 John Harrison : > > > > > On 19/01/2016 15:23, Gustavo Padovan wrote: > > > >Hi Daniel, > > > > > > > >2016-01-19 Daniel Vetter : > > > > > > > >>On Fri, Jan 15, 2016 at 12:55:10PM -0200,

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Gustavo Padovan
2016-01-19 Daniel Vetter : > On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > This patch series de-stage the sync framework, and in order to accomplish > > that > > a bunch of cleanups/improvements on the sync and fence were made. > > > > The s

Re: [RFC 00/29] De-stage android's sync framework

2016-01-19 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 06:10:40PM -0200, Gustavo Padovan wrote: > 2016-01-19 Daniel Vetter : > > - get_timeline_name and get_driver_name are imo too much indirection, just > > add ->(drv_)name field to each of these. > > I don't think is a good idea to change that now as there are other fence >

Re: [PATCH] Staging: goldfish: Add DMA support using dma_alloc_coherent

2016-01-19 Thread Alan Cox
> Yes I will free it using dma_free_coherent. Why should devm_kzalloc > be > replaced with dma_alloc_coherent ? I was trying to replace _pa() Why keep allocating and freeing a buffer rather than having a single buffer allocated once (as it is in the old driver). Alan ___

Re: [PATCH v2] android: binder: Sanity check at binder ioctl

2016-01-19 Thread David Rientjes
On Tue, 19 Jan 2016, Chen Feng wrote: > When a process fork a child process, we should not allow the > child process use the binder which opened by parent process. > > But if the binder-object creater is a thread of one process who exit, > the other thread can also use this binder-object normally

[PATCH] Staging: rtl8712: Remove unnecessary cast on void pointer

2016-01-19 Thread Lucas Tanure
The conversion from void pointer to any other pointer type is guaranteed by the C programming language. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Lucas Tanure --- dri

Re: [PATCH] Staging: goldfish: Add DMA support using dma_alloc_coherent

2016-01-19 Thread Shraddha Barke
On Tue, 19 Jan 2016, Alan Cox wrote: Yes I will free it using dma_free_coherent. Why should devm_kzalloc be replaced with dma_alloc_coherent ? I was trying to replace _pa() Why keep allocating and freeing a buffer rather than having a single buffer allocated once (as it is in the old driver)

[PATCH] staging: wilc1000: remove redundant check in wilc_mq_recv

2016-01-19 Thread Chaehyun Lim
At the beginning of wilc_mq_recv, it is checked if pHandle->bExiting is false or true. There is no need to check it again at the middle of this function. So just remove it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 6 -- 1 file changed, 6 deletions(-) diff -