[PATCH] staging: rtl8712: consolidate kmalloc/memset 0 of array to kcalloc

2016-01-04 Thread Nicholas Mc Guire
compile tested with: x86_64_defconfig + CONFIG_STAGING=y, CONFIG_R8712U=m Patch is against linux-next (localversion-next is -next-20160104) drivers/staging/rtl8712/rtl871x_recv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers

Re: [PATCH 04/29] staging/lustre/obdecho: Remove unused ioctls

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 12:05:35PM -0500, gr...@linuxhacker.ru wrote: > diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h > b/drivers/staging/lustre/lustre/include/lustre_lib.h > index 428469f..7daf954 100644 > --- a/drivers/staging/lustre/lustre/include/lustre_lib.h > +++ b/drivers/

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 12:25:29AM +0100, Samuel Thibault wrote: > 5e6dc54 broke the port information in the speakup driver: There is a correct format for this. Patch 5e6dc548e453 ('drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.') broke the port information ...

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 03:22:49PM +0300, Dan Carpenter wrote: > On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > > I had a patch which also worked, but yours may be better -- I enclose it > > > here for your i

Re: [PATCH 04/29] staging/lustre/obdecho: Remove unused ioctls

2016-01-04 Thread Oleg Drokin
On Jan 4, 2016, at 4:55 AM, Dan Carpenter wrote: > On Sun, Jan 03, 2016 at 12:05:35PM -0500, gr...@linuxhacker.ru wrote: >> diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h >> b/drivers/staging/lustre/lustre/include/lustre_lib.h >> index 428469f..7daf954 100644 >> --- a/drivers/st

Re: [PATCH 04/29] staging/lustre/obdecho: Remove unused ioctls

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 08:18:59AM -0500, Oleg Drokin wrote: > > On Jan 4, 2016, at 4:55 AM, Dan Carpenter wrote: > > > On Sun, Jan 03, 2016 at 12:05:35PM -0500, gr...@linuxhacker.ru wrote: > >> diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h > >> b/drivers/staging/lustre/lustre/

[RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Sven Dziadek
Remove byte order conversions. Conversion is already done in usb_ops_linux.c when accessing usb port. The deleted lines convert to little-endian and then call FillH2CCmd to convert back. Additionally, they are applied to wrong types and process wrong parts of variables later on. Signed-off-by: Sve

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Jes Sorensen
Sven Dziadek writes: > Remove byte order conversions. > Conversion is already done in usb_ops_linux.c when accessing usb port. > The deleted lines convert to little-endian and then call FillH2CCmd to > convert back. Additionally, they are applied to wrong types and > process wrong parts of variabl

RE: [PATCH] staging: rdma: hfi1: diag: constify hfi1_filter_array structure

2016-01-04 Thread Marciniszyn, Mike
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Julia Lawall > Subject: [PATCH] staging: rdma: hfi1: diag: constify hfi1_filter_array > structure > > The hfi1_filter_array structure is never modified, so declare it as const. > > Done with the help of Coccinell

[PATCH v2] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-04 Thread Jubin John
From: Jim Snow The link state will transition from ARMED to ACTIVE when a non-SC15 packet arrives, but the driver might not notice the change. With this fix, if the slowpath receive interrupt handler sees a non-SC15 packet while in the ARMED state, we queue work to call linkstate_active_work fro

RE: [PATCH 02/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack

2016-01-04 Thread Simmons, James A.
>From: Oleg Drokin > >IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug >statistics on a peer when peer timeout happens. >Redo it properly as a separate LNet API call, >also get rid of "ioctl" forwarding into the underlying LNDs, >since no current LNDs implement this function a

Re: [PATCH 02/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack

2016-01-04 Thread Oleg Drokin
On Jan 4, 2016, at 12:45 PM, Simmons, James A. wrote: >> From: Oleg Drokin >> >> IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug >> statistics on a peer when peer timeout happens. >> Redo it properly as a separate LNet API call, >> also get rid of "ioctl" forwarding into t

RE: [PATCH 02/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack

2016-01-04 Thread Simmons, James A.
>>> @@ -1436,6 +1406,12 @@ LNetCtl(unsigned int cmd, void *arg) >>> } >>> EXPORT_SYMBOL(LNetCtl); >>> >>> +void LNetDebugPeer(lnet_process_id_t id) >>> +{ >>> + lnet_debug_peer(id.nid); >>> +} >>> +EXPORT_SYMBOL(LNetDebugPeer); >> >> Lets just use lnet_debug_peer directly. > >It's not exported

[PATCH] staging: wilc1000: add missing __user attribute

2016-01-04 Thread Hugo Camboulive
This removes a Sparse warning. Signed-off-by: Hugo Camboulive --- drivers/staging/wilc1000/wilc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c index 27c653a..291e6fa 100644 --- a/dri

Re: [PATCH v2] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-04 Thread Leon Romanovsky
On Mon, Jan 04, 2016 at 11:21:19AM -0500, Jubin John wrote: > From: Jim Snow > > } else { > + /* Auto activate link on non-SC15 packet receive */ > + if (unlikely(rcd->ppd->host_link_state == > + HLS_UP_ARMED))

[PATCH] staging: wilc1000: make some variables static

2016-01-04 Thread Hugo Camboulive
terminated_handle is used only in host_interface.c wilc1000_spi_driver is exported by module_spi_driver() This fixes a few Sparse warnings. Signed-off-by: Hugo Camboulive --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 2 +- 2 files changed, 2 i

Re: [RFC PATCH] staging: rtl8723au: fix byte order problems

2016-01-04 Thread Julian Calaby
Hi Sven, On Tue, Jan 5, 2016 at 2:29 AM, Sven Dziadek wrote: > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > index 1662c03c..57f5941 100644 > --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > +++ b/drivers/staging/rtl8723au/hal/rt

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Mmm, sorry. I don't submit patches often enough, so that each time I do it, there are new things to know about it :) Thanks for the comments, Samuel ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/list

[PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Patch f79b0d9c223c ("staging: speakup: Fixed warning instead of ") broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, and no other header includes asm/serial.h. We here make sure serialio.c does get the arch-specific definition of SER

[PATCH] staging: r8192U: Fix check pointer after usage problem

2016-01-04 Thread Larry Finger
In routine rtl8192_tx_isr(), pointer skb is dereferenced before it is checked for NULL. This patch has only been compile-tested, as I do not have the hardware. This problem was reported at https://bugzilla.kernel.org/show_bug.cgi?id=109951. Fixes: bugzilla.kernel.org: #109951 Reported-by: Yong Shi

Re: [PATCH] staging: rtl8712: consolidate kmalloc/memset 0 of array to kcalloc

2016-01-04 Thread Joe Perches
ound by coccinelle script (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_STAGING=y, CONFIG_R8712U=m > > Patch is against linux-next (localversion-next is -next-20160104) > >  drivers/st

[PATCH 4/4] staging: wilc1000: rename u8ssidnum in struct hidden_network

2016-01-04 Thread Chaehyun Lim
This patch renames u8ssidnum to n_ssids that is a member of struct hidden_network. There is no need to use u8 prefix to show data type so just rename it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 10 +- drivers/staging/wilc1000/host_interface.h

[PATCH 3/4] staging: wilc1000: rename pstrHiddenNetworkInfo in struct hidden_network

2016-01-04 Thread Chaehyun Lim
This patch renames pstrHiddenNetworkInfo to net_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 14 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 --

[PATCH 1/4] staging: wilc1000: rename pu8ssid in struct hidden_net_info

2016-01-04 Thread Chaehyun Lim
This patch renames pu8ssid to ssid that is a member of struct hidden_net_info. There is no need to use pu8 prefix to show data type so just remove it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +

[PATCH 2/4] staging: wilc1000: rename u8ssidlen in struct hidden_net_info

2016-01-04 Thread Chaehyun Lim
This patch renames u8ssidlen to ssid_len that is a member of hidden_net_info. There is no need to use u8 prefix to show data type so just rename it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h |

[PATCH] staging: lustre: add static declarations

2016-01-04 Thread CHANG FU CHIAO
Signed-off-by: CHANG FU CHIAO --- drivers/staging/lustre/lustre/osc/osc_page.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_page.c b/drivers/staging/lustre/lustre/osc/osc_page.c index 2439d80..8943f0a 100644 --- a/drivers/staging/l

From Miss. Taala M

2016-01-04 Thread Miss. Taala M.Al-Liby
Hello Dear, Greetings from me. It is wonderful to contact you, i saw your profile today and became interested In you,i will also like to know you the more, I wish you will have the desire so that we can get acquainted to each other.Life itself is a mystery, no one knows tomorrow till it comes. (