[PATCH 17/30] staging: wilc1000: fix return type of wilc_del_allstation

2016-01-03 Thread Chaehyun Lim
This patch changes return type of wilc_del_allstation from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/wil

[PATCH 03/30] staging: wilc1000: rename u32SessionID in wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch renames u32SessionID to session_id to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 16/30] staging: wilc1000: remove rates variable in wilc_edit_station

2016-01-03 Thread Chaehyun Lim
Instead of using rates variable, it is used as add_sta_info->rates directly. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc100

[PATCH 07/30] staging: wilc1000: rename pvUserArg in wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch renames pvUserArg to user_arg to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interfac

[PATCH 05/30] staging: wilc1000: rename RemainOnChanExpired in wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch renames RemainOnChanExpired to expired to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host

[PATCH 15/30] staging: wilc1000: use kmemdup in wilc_edit_station

2016-01-03 Thread Chaehyun Lim
This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.

[PATCH 04/30] staging: wilc1000: rename u32duration in wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch renames u32duration to duration to remove u32 prefix. There is no need u32 prefix to show data type of this variable. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+),

[PATCH 08/30] staging: wilc1000: fix return type of wilc_del_all_rx_ba_session

2016-01-03 Thread Chaehyun Lim
This patch changes return type of wilc_del_all_rx_ba_session from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/st

[PATCH 14/30] staging: wilc1000: rename pstrAddStationMsg in wilc_edit_station

2016-01-03 Thread Chaehyun Lim
This patch renames pstrAddStationMsg to add_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc100

[PATCH 09/30] staging: wilc1000: rename pBSSID in wilc_del_all_rx_ba_session

2016-01-03 Thread Chaehyun Lim
This patch renames pBSSID to bssid to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 01/30] staging: wilc1000: rename u32duration in struct remain_ch

2016-01-03 Thread Chaehyun Lim
The patch renames u32duration to duration that is a member of struct remain_ch. The prefix u32 shows data type of its member, but there is no need to use u32 prefix to represent data type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc100

[PATCH 02/30] staging: wilc1000: fix return type of wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch changes return type of wilc_remain_on_channel from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/

[PATCH 13/30] staging: wilc1000: rename pstrStaParams in wilc_edit_station

2016-01-03 Thread Chaehyun Lim
This patch renames pstrStaParams to sta_param to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_i

[PATCH 10/30] staging: wilc1000: rename TID in wilc_del_all_rx_ba_session

2016-01-03 Thread Chaehyun Lim
This patch renames TID to tid to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/driv

[PATCH 11/30] staging: wilc1000: rename pBASessionInfo in wilc_del_all_rx_ba_session

2016-01-03 Thread Chaehyun Lim
This patch renames pBASessionInfo to ba_session_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_

[PATCH 06/30] staging: wilc1000: rename RemainOnChanReady in wilc_remain_on_channel

2016-01-03 Thread Chaehyun Lim
This patch renames RemainOnChanReady to ready to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 12/30] staging: wilc1000: fix return type of wilc_edit_station

2016-01-03 Thread Chaehyun Lim
This patch changes return type of wilc_edit_station from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1

[PATCH 28/30] staging: wilc1000: rename u32TailLen in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames u32TailLen to tail_len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_int

[PATCH 29/30] staging: wilc1000: rename pu8Tail in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames pu8Tail to tail to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 23/30] staging: wilc1000: fix return type of wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch changes return type of wilc_add_beacon from s32 to int. The result variable gets return value from wilc_mq_send that has data type of int. It should be changed return type of this function as well as result variable. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interf

[PATCH 27/30] staging: wilc1000: rename pu8Head in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames pu8Head to head to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 22/30] staging: wilc1000: rename u8AssocNumb in wilc_del_allstation

2016-01-03 Thread Chaehyun Lim
This patch renames u8AssocNumb to assoc_sta to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 30/30] staging: wilc1000: rename pstrSetBeaconParam in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames pstrSetBeaconParam to beacon_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/

[PATCH 25/30] staging: wilc1000: rename u32DTIMPeriod in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames u32DTIMPeriod to dtim_period to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_i

[PATCH 21/30] staging: wilc1000: use int instead of u32

2016-01-03 Thread Chaehyun Lim
The variable i is used as array index so that it is better to use data type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/

[PATCH 24/30] staging: wilc1000: rename u32Interval in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames u32Interval to interval to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interf

[PATCH 19/30] staging: wilc1000: rename pstrDelAllStationMsg in wilc_del_allstation

2016-01-03 Thread Chaehyun Lim
This patch renames pstrDelAllStationMsg to del_all_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/st

[PATCH 18/30] staging: wilc1000: rename pu8MacAddr in wilc_del_allstation

2016-01-03 Thread Chaehyun Lim
This patch renames pu8MacAddr to mac_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_inter

[PATCH 20/30] staging: wilc1000: rename au8Zero_Buff in wilc_del_allstation

2016-01-03 Thread Chaehyun Lim
This patch renames au8Zero_Buff to zero_addr to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.

[PATCH 26/30] staging: wilc1000: rename u32HeadLen in wilc_add_beacon

2016-01-03 Thread Chaehyun Lim
This patch renames u32HeadLen to head_len to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_inter

RE: [PATCH V5 4/9] Drivers: hv: ring_buffer: enhance hv_ringbuffer_read() to support hvsock

2016-01-03 Thread Dexuan Cui
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, January 2, 2016 12:30 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; step...@networkplumber.org; > net...@vger.kernel.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o

can we discuss?

2016-01-03 Thread Thomas Frederick
Happy New Year!!! Do you need to better your business in the new year? No matter you are selling products or services, we can generate you leads of the buyers. Please reply for pricing and details. Thomas Frederick contact: martwe...@sina.com ___ deve

Re: [RFC PATCH v0] Add tw5864 driver

2016-01-03 Thread Andrey Utkin
On Sun, Jan 3, 2016 at 5:47 AM, Joe Perches wrote: > several of these have unnecessary parentheses Thanks, fixed. > Maybe use bool a bit more Thanks, fixed. > or maybe just use fls Thanks, fls() fit greatly, rewritten the function with compatibility testing. >> +static inline int bs_size_ue(

[PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 3 Jan 2016 17:25:59 +0100 Replace explicit initialisation for two local variables at the beginning by assignments. Signed-off-by: Markus Elfring --- drivers/staging/slicoss/slicoss.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread Julia Lawall
On Sun, 3 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 17:25:59 +0100 > > Replace explicit initialisation for two local variables at the beginning > by assignments. Why? julia > Signed-off-by: Markus Elfring > --- > drivers/staging/slicoss/slicoss.c | 6

[PATCH 01/29] staging/lustre/lnet: Make lnet_ping static

2016-01-03 Thread green
From: Oleg Drokin It's not used anywhere outside of api-ni.c anyway. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 -- drivers/staging/lustre/lnet/lnet/api-ni.c| 7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH 02/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack

2016-01-03 Thread green
From: Oleg Drokin IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug statistics on a peer when peer timeout happens. Redo it properly as a separate LNet API call, also get rid of "ioctl" forwarding into the underlying LNDs, since no current LNDs implement this function anymore.

[PATCH 06/29] staging/lustre: Add __user attributes to libcfs_ioctl_get/popdata args

2016-01-03 Thread green
From: Oleg Drokin Just make clear which pointers are from userspace and which are not in libcfs_ioctl_getdata/libcfs_ioctl_popdata and their callers. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 4 ++-- drivers/staging/lustre/lustre/libcfs/linux/l

[PATCH 00/29] Clean up Lustre userspace accesses

2016-01-03 Thread green
From: Oleg Drokin This patch series is aimed at cleaning up lustre<->userspace communications, sprinkling around __user attributes where needed to make sparse happy and so on (mostly in various ioctl code paths). This activity also uncovered a couple of bugs that are fixed too (even if some prece

[PATCH 03/29] staging/lustre/lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl

2016-01-03 Thread green
From: Oleg Drokin This has been unused for ages and could be safely removed now. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h | 2 +- drivers/staging/lustre/lnet/lnet/api-ni.c | 6 -- drivers/staging/lustre/lustre/ptlrpc/event

[PATCH 05/29] staging/lustre/obdecho: remove userspace LSM handling

2016-01-03 Thread green
From: "John L. Hammond" In lustre/obdecho/echo_client.c, remove handling of lov_stripe_md passed from userspace (since userspace never passes it). Remove the LOV specific code (ed_next_islov) from the echo client (since it doesn't work). Remove echo_get_stripe_off_id() and all calls to it since

[PATCH 27/29] staging/lustre: Properly cast ll_getname argument to __user in ll_dir_ioctl

2016-01-03 Thread green
From: Oleg Drokin This makes sparse happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c index 8cd594c..7e54650

[PATCH 08/29] staging/lustre: Update user pointers in struct obd_ioctl_data

2016-01-03 Thread green
From: Oleg Drokin Make them void __user * instead of char * (or char __user *), void * removes the necessity of explicit casts to proper type where people also need to remember __user qualifiers, so I think it works better here. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/incl

[PATCH 22/29] staging/lustre: Properly mark lmv_fid2path uarg argment as __user

2016-01-03 Thread green
From: Oleg Drokin This makes sparse happy too. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c index 58b00

[PATCH 25/29] staging/lustre: Properly cast ll_fid2path argument to __user in ll_file_ioctl

2016-01-03 Thread green
From: Oleg Drokin When calling ll_fid2path, it expects a userspace pointer. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/

[PATCH 14/29] staging/lustre: Declare lprocfs_write_frac_u64_helper argument as __user

2016-01-03 Thread green
From: Oleg Drokin The buffer that lprocfs_write_frac_u64_helper is working on is presumed to be a userspace one, so it's not suitable for use on kernel buffers. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +- drivers/staging/lustre/lustre/obdclass

[PATCH 17/29] staging/lustre/llite: Fix improper userspace access in ll_fiemap

2016-01-03 Thread green
From: Oleg Drokin Cannot use memcpy, but use copy_to/from_user instead Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/stag

[PATCH 07/29] staging/lustre: Change ioctl user pointers in libcfs_ioctl_data

2016-01-03 Thread green
From: Oleg Drokin Make them void __user * instead of char * (or char __user *), void * removes the necessity of explicit casts to proper type where people also need to remember __user qualifiers, so I think it works better here. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/lin

[PATCH 04/29] staging/lustre/obdecho: Remove unused ioctls

2016-01-03 Thread green
From: Oleg Drokin Remove long unused ECHO_IOC_GET_STRIPE, ECHO_IOC_SET_STRIPE, ECHO_IOC_ENQUEUE and ECHO_IOC_CANCEL ioctls. Signed-off-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 8 +- .../staging/lustre/lustre/obdecho/echo_client.

[PATCH 24/29] staging/lustre/llite: Update all file.c user pointer casts to __user

2016-01-03 Thread green
From: Oleg Drokin unsigned long user address must be casted with __user attribute to make sparse happy when used with userspace access functions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/file.c | 47 +++--- 1 file changed, 24 insertions(+), 23

[PATCH 12/29] staging/lustre: Properly mark obd_iocontrol argument as __user

2016-01-03 Thread green
From: Oleg Drokin Also update all methods and calls everywhere. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 2 +- drivers/staging/lustre/lustre/include/obd_class.h | 2 +- drivers/staging/lustre/lustre/llite/dir.c | 6 -- drivers/staging

[PATCH 15/29] staging/lustre/osc: Do not use lprocfs_write_helper in sysfs store methods

2016-01-03 Thread green
From: Oleg Drokin sysfs store methods provide us with a kernel buffer already, but lprocfs_write_helper is expecting a user buffer. Replace lprocfs_write_helper with kstrto[u]int() calls instead in contention_seconds_store() and lockless_truncate_store() Signed-off-by: Oleg Drokin --- drivers/

[PATCH 26/29] staging/lustre: Properly cast ll_fid2path argument to __user in ll_dir_ioctl

2016-01-03 Thread green
From: Oleg Drokin This makes sparse happier. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c index 22c59e5..8cd594

[PATCH 09/29] staging/lustre: Mark obd_ioctl_popdata/getdata argument as __user

2016-01-03 Thread green
From: Oleg Drokin arg is a userspace pointer and marking it as such makes sparse happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 4 ++-- drivers/staging/lustre/lustre/llite/dir.c | 4 ++-- drivers/staging/lustre/lustre/obdcl

[PATCH 23/29] staging/lustre: Mark lmv_hsm_ct_register/unregister uarg as __user

2016-01-03 Thread green
From: Oleg Drokin Since it is a userspace pointer, this makes things neater and sparse happier. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/dri

[PATCH 10/29] staging/lustre/lnet: Properly mark userspace pointer of lnet_ping()

2016-01-03 Thread green
From: Oleg Drokin This also happens to silence sparce warnings about different address spaces. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/lnet/api-ni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers

[PATCH 29/29] staging/lustre: Add __user annotations in lnetselftest code

2016-01-03 Thread green
From: Frank Zago This fixes a bunch of sparse warnings. There is no code change. Signed-off-by: frank zago Reviewed-on: http://review.whamcloud.com/11819 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 Reviewed-by: James Simmons Reviewed-by: Dmitry Eremin Signed-off-by: Oleg Drokin

[PATCH 18/29] staging/lustre: Declare lov_getstripe lump argument as __user

2016-01-03 Thread green
From: Oleg Drokin This is a user pointer, so that makes sparse a lot happier. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_internal.h | 2 +- drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 19/29] staging/lustre/llite: Update llite_lib.c with proper __user attributes

2016-01-03 Thread green
From: Oleg Drokin Casts for get/put_user and copy_to/from_user should have __user attribute for the userspace buffer address. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stagi

[PATCH 13/29] staging/lustre: Properly mark argument to p_ioctl in cfs_psdev_ops as __user

2016-01-03 Thread green
From: Oleg Drokin This also silents a sparse address space warning Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/libcfs/libcfs.h | 2 +- drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 28/29] staging/lustre/llite: Update ll_dir_ioctl pointer casts with __user

2016-01-03 Thread green
From: Oleg Drokin When casting unsingned long userspace pointer from ioctl argument to a pointer suitable for use with userspace access functions, need to remember to add __user attribute, to make sparse happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c | 69 +

[PATCH 16/29] staging/lustre/llite: Properly mark ll_obd_statfs argument as __user

2016-01-03 Thread green
From: Oleg Drokin Also update all callers. This fixes a bunch of address space mismatch warnings from sparse. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c| 2 +- drivers/staging/lustre/lustre/llite/file.c | 2 +- drivers/staging/lustre/lustre/l

[PATCH 11/29] staging/lustre: Get rid of an ugly statfs hack in lov_iocontrol

2016-01-03 Thread green
From: Oleg Drokin For some crazy reason ll_obd_statfs decided to decode async flag passed from userspace and then pass it via a userspace pointer argument to lov_iocontrol. This patch moves flags decoding to lov_iocontrol where it belongs. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/

[PATCH 21/29] staging/lustre/lloop: Properly mark userspace pointers in lo/lloop_ioctl

2016-01-03 Thread green
From: Oleg Drokin When casting unsigned long userspace pointer for use with userspace-accessing functions, need to use __user attribute to make sparse happy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lloop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH 20/29] staging/lustre/osc: Mark osc_getstripe user pointer argument as __user

2016-01-03 Thread green
From: Oleg Drokin This shuts some sparse address space mismatch warnings Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_request.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustr

[PATCH] drivers: staging: octeon-usb: octeon-hcd.c: fixed coding style related warnings

2016-01-03 Thread Saatvik Arya
fixed coding style warnings related to comment blocks Signed-off-by: Saatvik Arya --- drivers/staging/octeon-usb/octeon-hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 6f28717..16

[PATCH] drivers: staging: xgifb: vgatypes.h: fixed coding style warnings

2016-01-03 Thread Saatvik Arya
fixed warnings about comment block coding style Signed-off-by: Saatvik Arya --- drivers/staging/xgifb/vgatypes.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/xgifb/vgatypes.h b/drivers/staging/xgifb/vgatypes.h index 61fa10f..de80e5c 100644 --- a/driv

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
>> Replace explicit initialisation for two local variables at the beginning >> by assignments. > > Why? I prefer that assignments for variables like "card" and "slic_regs" will only be performed immediately before the corresponding content will be read again (after a few condition checks were exe

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread Greg Kroah-Hartman
On Sun, Jan 03, 2016 at 06:48:17PM +0100, SF Markus Elfring wrote: > >> Replace explicit initialisation for two local variables at the beginning > >> by assignments. > > > > Why? > > I prefer that assignments for variables like "card" and "slic_regs" > will only be performed immediately before th

Re: [PATCH 29/29] staging/lustre: Add __user annotations in lnetselftest code

2016-01-03 Thread kbuild test robot
Hi Frank, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20151231] [cannot apply to v4.4-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/green-linuxh

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
>> I prefer that assignments for variables like "card" and "slic_regs" >> will only be performed immediately before the corresponding content will be >> read again (after a few condition checks were executed). >> >> Another description could be this view: >> I suggest to move the variable initialis

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread Greg Kroah-Hartman
On Sun, Jan 03, 2016 at 07:16:49PM +0100, SF Markus Elfring wrote: > >> I prefer that assignments for variables like "card" and "slic_regs" > >> will only be performed immediately before the corresponding content will be > >> read again (after a few condition checks were executed). > >> > >> Anothe

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
>> I am a bit surprised that you do not like such source code fine-tuning. > > It's moving stuff around for no real reason, why would I like it? Can such fine-tuning result in positive effects for the run-time behaviour? > Reading and reviewing and applying this type of stuff takes away from >

[PATCH v2 0/2] Staging: panel: Fix checkpatch warnings

2016-01-03 Thread Ksenija Stanojevic
Fix checkpatch.pl warnings in panel.c Signed-off-by: Ksenija Stanojevic Ksenija Stanojevic (2): Staging: panel: Fix line over 80 characters Staging: panel: Remove space drivers/staging/panel/panel.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.9.1 __

[PATCH v2 1/2] Staging: panel: Fix line over 80 characters

2016-01-03 Thread Ksenija Stanojevic
Move statement into line below the comment to follow 80 characters per line rule. Found by checkpatch.pl Signed-off-by: Ksenija Stanojevic --- Changes in v2: - don't split comment in multiline drivers/staging/panel/panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[PATCH v2 2/2] Staging: panel: Remove space

2016-01-03 Thread Ksenija Stanojevic
No space is necessary after a cast, therefore remove it. Found by checkpatch.pl Signed-off-by: Ksenija Stanojevic --- Changes in v2: - nothing drivers/staging/panel/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/sta

[PATCH v2 0/5] Staging: panel: TODO fixes

2016-01-03 Thread Ksenija Stanojevic
This patchset is based on checkpatch fixes made by previous patches. Here I tried to address all suggestions made by Dan and Willy. Signed-off-by: Ksenija Stanojevic Ksenija Stanojevic (5): Staging: panel: Use u8 type Staging: panel: Remove typedef pmask_t Staging: panel: Remove ULL Stag

[PATCH v2 1/5] Staging: panel: Use u8 type

2016-01-03 Thread Ksenija Stanojevic
Declare om, im, omask and imask as u8 to remove any confusion if that describes the 8 bits of the data bus on the parallel port. Also change return type of lcd_write_data() to u8. Signed-off-by: Ksenija Stanojevic --- v2: nothing drivers/staging/panel/panel.c | 6 +++--- 1 file changed, 3 inser

[PATCH v2 2/5] Staging: panel: Remove typedef pmask_t

2016-01-03 Thread Ksenija Stanojevic
Use __u64 instead of pmask_t and remove pmask_t since is useless. Signed-off-by: Ksenija Stanojevic --- v2: nothing drivers/staging/panel/panel.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/

[PATCH v2 3/5] Staging: panel: Remove ULL

2016-01-03 Thread Ksenija Stanojevic
Remove ULL on om and im, since it's useless. Signed-off-by: Ksenija Stanojevic --- v2: leave ULL on m and v. drivers/staging/panel/panel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index 7138ee7..e9641ea

[PATCH v2 4/5] Staging: panel: Reduce value range for *name

2016-01-03 Thread Ksenija Stanojevic
out is 0-9 so it's too much for om, therefore reduce value range for *name from '0'-'9' to '0'-'7'. Signed-off-by: Ksenija Stanojevic --- v2: nothing drivers/staging/panel/panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/

Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread Greg Kroah-Hartman
On Sun, Jan 03, 2016 at 07:50:18PM +0100, SF Markus Elfring wrote: > >> I am a bit surprised that you do not like such source code fine-tuning. > > > > It's moving stuff around for no real reason, why would I like it? > > Can such fine-tuning result in positive effects for the run-time behaviour?

[PATCH v2 5/5] Staging: panel: Make code more readable

2016-01-03 Thread Ksenija Stanojevic
Repace 'for' statement by strchr() function to make code more readable. Signed-off-by: Ksenija Stanojevic --- v2: use strchr(). drivers/staging/panel/panel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/pan

Re: staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
>> Can such fine-tuning result in positive effects for the run-time behaviour? > > If you can not benchmark and show the proof, don't even start to claim > such a thing. Which measurement results would you accept for further discussion? >> My suggestions can result in measurable differences. >

Re: staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread Greg Kroah-Hartman
On Sun, Jan 03, 2016 at 09:10:45PM +0100, SF Markus Elfring wrote: > >> Can such fine-tuning result in positive effects for the run-time behaviour? > > > > If you can not benchmark and show the proof, don't even start to claim > > such a thing. > > Which measurement results would you accept for f

Re: staging-slicoss: Replace variable initialisations by assignments in slic_if_init()

2016-01-03 Thread SF Markus Elfring
>> Which measurement results would you accept for further discussion? > > If you don't know how to show your results, then this whole discussion > is pointless. I could show test results. But it could happen that I would choose insufficient variations for execution environments. I am unsure abou

[PATCHv7 2/5] hdmi: added functions for MPEG InfoFrames

2016-01-03 Thread Enric Balletbo i Serra
The MPEG Source (MS) InfoFrame is in EIA/CEA-861B. It describes aspects of the compressed video stream that were used to produce the uncompressed video. The patch adds functions to work with MPEG InfoFrames. Signed-off-by: Enric Balletbo i Serra --- drivers/video/hdmi.c | 156 ++

[PATCHv7 0/5] Add initial support for slimport anx78xx

2016-01-03 Thread Enric Balletbo i Serra
Hi all, This is another version of the patch set to introduce the anx7814 transmitter. Any comments are welcome. The following series add initial support for the Slimport ANX7814 transmitter, a ultra-low power Full-HD (1080p60) transmitter designed for portable device. The driver was originally

[PATCHv7 1/5] drm/dp: add DPCD definitions from DP 1.1

2016-01-03 Thread Enric Balletbo i Serra
Add a number of DPCD definitions from DP 1.1 Signed-off-by: Enric Balletbo i Serra --- include/drm/drm_dp_helper.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index bb9d0de..9b0c990 100644 --- a/include/drm/drm_dp_help

[PATCHv7 4/5] devicetree: Add new ANX7814 SlimPort transmitter binding.

2016-01-03 Thread Enric Balletbo i Serra
The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. You can add support to your board with current binding. Example: anx7814: anx7814@38 { compatible = "analogix,anx7814"; reg = <0x38>; in

[PATCHv7 3/5] of: Add vendor prefix for Analogix Semiconductor, Inc.

2016-01-03 Thread Enric Balletbo i Serra
Analogix Semiconductor develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv7 5/5] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2016-01-03 Thread Enric Balletbo i Serra
At the moment it only supports ANX7814. The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. The ANX7814 transforms the HDMI output of an application processor to MyDP or DisplayPort. The driver supports HDMI to DP pass-through mode and works usi