> Markus, please stop sending these things to rename out labels unless
> there is a bug. CodingStyle allows out labels.
How does this feedback fit to information like the following?
"…
Chapter 7: …
…
Choose label names which say what the goto does or why the goto exists.
… Avoid using GW-BASIC n
On Mon, Dec 14, 2015 at 10:08:03AM +0100, SF Markus Elfring wrote:
> > Markus, please stop sending these things to rename out labels unless
> > there is a bug. CodingStyle allows out labels.
>
> How does this feedback fit to information like the following?
>
> "…
> Chapter 7: …
> …
> Choose labe
Signed-off-by: George Kobiashvili
---
drivers/staging/comedi/comedi.h | 202 ++--
1 file changed, 112 insertions(+), 90 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 66edda1..8ab57ce 100644
--- a/drivers/stag
>>> Markus, please stop sending these things to rename out labels unless
>>> there is a bug. CodingStyle allows out labels.
>>
>> How does this feedback fit to information like the following?
>>
>> "…
>> Chapter 7: …
>> …
>> Choose label names which say what the goto does or why the goto exists.
>
Hi Simon,
Am Mittwoch, 9. Dezember 2015, 08:14:06 schrieb Simon Guinot:
> This patch fixes a couple of checkpatch warnings about block comments.
>
> Signed-off-by: Simon Guinot
> ---
> drivers/staging/nvec/nvec.c | 6 --
> drivers/staging/nvec/nvec_power.c | 14 +-
> 2 fi
Hi George,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.4-rc5 next-20151214]
url:
https://github.com/0day-ci/linux/commits/George-Kobiashvili/comedi-comedi-h-cleanup-coding-style/20151214-175007
config: i386-randconfig-s0-201550 (attached as .config
On Sun, Dec 13, 2015 at 02:57:38PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 13 Dec 2015 12:21:17 +0100
>
> A few checks would be performed by the mgc_process_recover_log() function
> even if it is known already that the passed variable "pages" contained
> a null pointer
>> A few checks would be performed by the mgc_process_recover_log() function
>> even if it is known already that the passed variable "pages" contained
>> a null pointer.
>>
>> * Let us return directly if a call of the kcalloc() function failed.
>>
>> * Move assignments for the variables "eof" and "
On Mon, Dec 14, 2015 at 01:04:14PM +0100, SF Markus Elfring wrote:
> >> A few checks would be performed by the mgc_process_recover_log() function
> >> even if it is known already that the passed variable "pages" contained
> >> a null pointer.
> >>
> >> * Let us return directly if a call of the kcal
>> Can you accept the proposed changes around the affected memory allocations?
>
> Just leave it as-is if there is no reason.
I suggest to make the implementation of the function "mgc_process_recover_log"
a bit more efficient.
>> Do you prefer to stash any changes together for a bigger update s
inmsg should be freed in case of on_msg() failure to avoid memory leak.
Preserve the error code from on_msg().
Signed-off-by: Vitaly Kuznetsov
---
Changes since v1:
- Preserve the error code from on_msg(). [Dan Carpenter]
---
drivers/hv/hv_utils_transport.c | 7 ---
1 file changed, 4 inserti
As a preparation to reusing outmsg_lock to protect test-and-set openrations
on 'mode' rename it the more general 'lock'.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_utils_transport.c | 14 +++---
drivers/hv/hv_utils_transport.h | 2 +-
2 files changed, 8 insertions(+), 8 deletions
Changes since v2:
- No changes, this is just a resend.
Changes since v1:
- Don't re-introduce memory leak in hvt_op_write(), preserve the error
code from on_msg() [Dan Carpenter]
Original description:
I'm observing a crash when a utility driver is disabled host side (e.g.
'Guest services' is d
When Hyper-V host asks us to remove some util driver by closing the
appropriate channel there is no easy way to force the current file
descriptor holder to hang up but we can start to respond -EBADF to all
operations asking it to exit gracefully.
As we're setting hvt->mode from two separate contex
The crash is observed when a service is being disabled host side while
userspace daemon is connected to the device:
[ 90.244859] general protection fault: [#1] SMP
...
[ 90.800082] Call Trace:
[ 90.800082] [] __fput+0xc8/0x1f0
[ 90.800082] [] fput+0xe/0x10
...
[ 90.800082] []
re use
//
// missing check in:
// ./drivers/staging/rdma/hfi1/chip.c:10131 unchecked allocation
// in -next-20151214
// reported-by Mike Marciniszyn
//
// after generalization this also found:
// ./drivers/clk/shmobile/clk-div6.c:197 unchecked alloca
On Mon, Dec 14, 2015 at 01:45:11PM +0100, SF Markus Elfring wrote:
> >> Do you prefer to stash any changes together for a bigger update step?
> >
> > Yes. Patches 5 and 6 would be easier to review if they were folded into
> > one patch.
>
> I do not like patch squashing for my update suggestions
This fixes all messages "no space necesarry after a cast" in cfg80211.c
file
Signed-off-by: Bogicevic Sasa
---
drivers/staging/wlan-ng/cfg80211.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/w
On Fri, Dec 11, 2015 at 7:58 AM, Martyn Welch wrote:
> On 09/12/15 13:50, Linus Walleij wrote:
>>
>> This makes the driver use the data pointer added to the gpio_chip
>> to store a pointer to the state container instead of relying on
>> container_of().
>>
>> Cc: Greg Kroah-Hartman
>> Cc: Martyn W
This fixes all "space preferred around that ..." messages from
checkpatch.pl
Signed-off-by: Bogicevic Sasa
---
drivers/staging/wlan-ng/hfa384x_usb.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x
CONFIG_INFINIBAND=m, CONFIG_STAGING=y, CONFIG_STAGING_RDMA=m
Patch is against linux-next (localversion-next is -next-20151214)
drivers/staging/rdma/hfi1/chip.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index 52d2bd7..
(localversion-next is -next-20151214)
drivers/staging/rdma/hfi1/chip.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index dc69159..31eec8a 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers
Add a null check after the kcalloc call as proposed by
Mike Marciniszyn .
Signed-off-by: Nicholas Mc Guire
---
Patch was compile tested with: x86_64_defconfig
CONFIG_INFINIBAND=m, CONFIG_STAGING=y, CONFIG_STAGING_RDMA=m
Patch is against linux-next (localversion-next is -next-20151214
goto bail;
> +
I checked out a linux-next remote at the next-20151214 tag.
The allocation method is clearly kmalloc_array() not kcalloc().
Where are you seeing the kcalloc()?
While it is tempting to allocate and zero, there is a chip r
> --- a/drivers/staging/rdma/hfi1/chip.c
> +++ b/drivers/staging/rdma/hfi1/chip.c
> @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd,
> u32 first_ctxt)
> goto bail;
> if (num_vls * qpns_per_vl > dd->chip_rcv_contexts)
> goto bail;
> - rsmmap
Most functionality is still being done in the driver, set flags so that
rdmavt will let hfi1 continue to handle mr, qp, and cq init.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/verbs.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Remove protection domain from hfi1 and use rdmavt's version.
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/keys.c |4 +-
drivers/staging/rdma/hfi1/mr.c|2 +
drivers/staging/rdma/hfi1/ruc.c |4 +-
drivers/
Remove the dma.c file from hfi1 in favor of using that which is
present in rdmavt.
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/Makefile |2 +-
drivers/staging/rdma/hfi1/verbs.c |2 +-
drivers/staging/rdma/hfi1/ve
This patch series is being submitted as a Request For Comment only. It depends
on code submitted to the rdma subsystem [1].
This work is the first submission aimed to satisfy the TODO item for removing
duplicated code in hfi1. At the time of submission hfi1 and qib contained alot
of duplicated ver
Remove MR data structures from hfi1 and use the version in rdmavt
Reviewed-by: Dean Luick
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/keys.c | 30 +-
drivers/staging/rdma/hfi1/mr.c| 22 ++---
drivers/staging/rdm
Original patch from Kamal Heib , split
apart from original and modified to accomodate recent changes
in rdmavt.
Remove AH from hfi1 and use rdmavt version.
Signed-off-by: Kamal Heib
Signed-off-by: Dennis Dalessandro
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/common.h |2 -
dr
Implement get_card_name and get_pci_dev helper functions for rdmavt
for hfi1.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Ira Weiny
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/driver.c | 16
drivers/staging/rdma/hfi1/hfi.h|2 ++
drivers/staging/rdm
For OPA devices additional work is required to create an AH.
This patch adds support to set the VL correctly.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/verbs.c | 24
1 files changed, 24 insertions(+), 0 deletions(-)
No need to keep providing the query pkey function. This is now being
done in rdmavt. Remove support from hfi1. The allocation and
maintenance of the list still resides in the driver.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/verbs.c | 20 +--
SRQ data structure has been moved to rdmavt. Make use of it.
Reviewed-by: Harish Chegondi
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/qp.c|2 +-
drivers/staging/rdma/hfi1/ruc.c |4 ++--
drivers/staging/rdma/hfi1/srq.c | 10 +-
drivers/staging/rdma/h
In preparation for moving the queue pair data structure to rdmavt the
members of the driver specific queue pairs which are not common need to be
pushed off to a private driver structure. This structure will be available
in the queue pair once moved to rdmavt as a void pointer. This patch while
not
This patch does the actual removal of the queue pair from the hfi1 driver
along with a number of dependent data structures. These were moved to rvt.
It also removes the MR functions to use those in rdmavt.
These two pieces can not reasonably be split apart becuase they depend on
each other.
Revi
Mmap data structure has already been moved to rdmavt and hfi1 supports
it. Now that the mmap functionality has also been moved to rdmavt its
time for hfi1 to use that as well.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi
Remove most of the ibport members from hfi1 and use the rdmavt version.
Also register the port with rdmavt.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Harish Chegondi
Signed-off-by: Dennis Dalessandro
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c| 34 +++
driver
Rdmavt split the header files to be based on ibta object. This patch
makes changes in hfi1 to account for the move.
The actual removal of HFI1 code continues in the following patch.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
Signed-off-by: Jubin John
---
drivers/staging/r
p = kcalloc(NUM_MAP_REGS, sizeof(u64), GFP_KERNEL);
> > + if (!rsmmap)
> > + goto bail;
> > +
>
> I checked out a linux-next remote at the next-20151214 tag.
>
> The allocation method is clearly kmalloc_array() not kcalloc().
>
> Where are you seeing
This patch begins to make use of rdmavt by registering with it and
providing access to the header files. This is just the beginning of
rdmavt support in hfi1.
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
---
drivers/staging/rdma/hfi1/Kconfig |2 +-
On Mon, Dec 14, 2015 at 03:28:46PM +, Marciniszyn, Mike wrote:
> > --- a/drivers/staging/rdma/hfi1/chip.c
> > +++ b/drivers/staging/rdma/hfi1/chip.c
> > @@ -10128,8 +10128,7 @@ static void init_qos(struct hfi1_devdata *dd,
> > u32 first_ctxt)
> > goto bail;
> > if (num_vls * qpn
>> I do not like patch squashing for my update suggestions here.
>
> I am a maintainer in drivers/staging.
Thanks for this information.
> I am telling you what you need to do if you want us to apply your patch.
I am still waiting for a bit more constructive feedback for this
patch series. How
Fixed commenting style warnings.
Signed-off-by: Ben Gilbert
---
drivers/staging/fbtft/fb_uc1701.c | 53 ++-
1 file changed, 35 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/fbtft/fb_uc1701.c
b/drivers/staging/fbtft/fb_uc1701.c
index 212908e..5f
On Mon, Dec 14, 2015 at 05:41:23PM +, Nicholas Mc Guire wrote:
> I obviously made a real mess here.
> I incorrectly concluded that rxcontext is 0 which it is not in some cases
Yep. Plus you build tested it but assumed that the unused variable
warning must have been there in the original... I
Fix the subject line.
On Mon, Dec 14, 2015 at 06:09:46PM +, Ben Gilbert wrote:
> Fixed commenting style warnings.
This stuff is dead code. Just delete it.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev
Deleted various commented out lines that have been replaced by write_reg()
Signed-off-by: Ben Gilbert
---
drivers/staging/fbtft/fb_uc1701.c | 27 ++-
1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/fbtft/fb_uc1701.c
b/drivers/staging/fbtft/
On 14/12/15 18:17, Dan Carpenter wrote:
Fix the subject line.
On Mon, Dec 14, 2015 at 06:09:46PM +, Ben Gilbert wrote:
Fixed commenting style warnings.
This stuff is dead code. Just delete it.
Thanks Dan. Please ignore this patch, I am sending a new one.
regards,
dan carpenter
_
Greg,
It looks like you missed this patch for 4.4-rc5
Could we get it included for rc6?
Thanks,
Ira
- Forwarded message from Jubin John -
From: Jubin John
To: ,
CC: , ,
, ,
Subject: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build
Date: Fri, 20 Nov 2015 18:13:08 -
Any further feedback on this series?
Ira
On Tue, Dec 01, 2015 at 02:47:55PM -0500, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> This was a single patch before. The change to dev_dbg required a precursor
> patch to add the dd_dev_dbg which is consistent with the other dev_* macros
> which a
Signed-off-by: George Kobiashvili
---
drivers/staging/comedi/comedilib.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/comedilib.h
b/drivers/staging/comedi/comedilib.h
index 56baf85..ccbe17b 100644
--- a/drivers/stag
On Fri, Dec 11, 2015 at 08:21:24PM -0800, K. Y. Srinivasan wrote:
> Most of the patches in this set are being resent.
Why? What changed?
Also, your series can't be sorted by subject at all, so I can't apply
them in the correct order (some have RESEND in the subject, some do
not...)
Please resen
On Sat, Dec 12, 2015 at 02:58:50AM -0500, Sanidhya Solanki wrote:
> >From a1635ea5e75cb2f10728ae4ddf3a21567958e98f Mon Sep 17 00:00:00 2001
> From: Sanidhya Solanki
> Date: Sat, 12 Dec 2015 02:20:03 -0500
> Subject: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch
> fixes
>
> Pat
On Fri, Nov 13, 2015 at 04:48:10PM +0530, Nizam Haider wrote:
> removed heckpatch warning
heckpatch? And what warning is that?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Dec 14, 2015 at 02:36:39PM -0500, ira.weiny wrote:
> Greg,
>
> It looks like you missed this patch for 4.4-rc5
>
> Could we get it included for rc6?
I'll try, but again, I'm way behind, give me a few more days...
thanks,
greg k-h
___
devel ma
On Mon, Dec 14, 2015 at 02:54:09PM -0500, ira.weiny wrote:
> Any further feedback on this series?
I'm way behind on staging patches right now (1000+ patches behind...),
hopefully will catch up on them this week.
thanks,
greg k-h
___
devel mailing list
On 14/12/15 14:14, Linus Walleij wrote:
On Fri, Dec 11, 2015 at 7:58 AM, Martyn Welch wrote:
On 09/12/15 13:50, Linus Walleij wrote:
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().
Cc: Greg Kro
Greg,
We have other patch series close to being submitted.
Some depend on the inflight patches you are behind on, some on each other.
What is the best way of handling this to insure no conflicts?
Mike
___
devel mailing list
de...@linuxdriverproject.or
On Mon, Dec 14, 2015 at 09:52:31PM +, Marciniszyn, Mike wrote:
> Greg,
>
> We have other patch series close to being submitted.
>
> Some depend on the inflight patches you are behind on, some on each other.
>
> What is the best way of handling this to insure no conflicts?
I apply patches in
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, December 14, 2015 10:59 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com
> Sub
Miscellaneous fixes and improvements.
Andrey Smetanin (2):
drivers/hv: cleanup synic msrs if vmbus connect failed
drivers/hv: correct tsc page sequence invalid value
Dexuan Cui (6):
Drivers: hv: vmbus: serialize process_chn_event() and
vmbus_close_internal()
Drivers: hv: vmbus: do san
From: Dexuan Cui
This fixes an incorrect assumption of channel state in the function.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/chann
Util services such as KVP and FCOPY need assistance from daemon's running
in user space. Increase the timeout so we don't prematurely terminate
the transaction in the kernel. Host sets up a 60 second timeout for
all util driver transactions. The host will retry the transaction if it
times out. Set
From: Olaf Hering
Use memdup_user to handle OOM.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_utils_transport.c |9 -
1 files changed, 4 insertions(+), 5 deletions
From: Andrey Smetanin
Hypervisor Top Level Functional Specification v3/4 says
that TSC page sequence value = -1(0x) is used to
indicate that TSC page no longer reliable source of reference
timer. Unfortunately, we found that Windows Hyper-V guest
side implementation uses sequence value =
Force all channel messages to be delivered on CPU0. These messages are not
performance critical and are used during the setup and teardown of the
channel.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/connection.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git
Currently we have two policies for deciding when to signal the host:
One based on the ring buffer state and the other based on what the
VMBUS client driver wants to do. Consider the case when the client
wants to explicitly control when to signal the host. In this case,
if the client were to defer s
From: Jake Oshins
This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This
is necessary for retargeting an interrupt when it is given a new affinity.
Since we are exporting this API, rename the API as it will be visible outside
the hv.c file.
Signed-off-by: Jake Oshins
S
From: Jake Oshins
This patch exposes the mapping between Linux CPU number and Hyper-V virtual
processor number. This is necessary because the hypervisor needs to know which
virtual processors to target when making a mapping in the Interrupt Redirection
Table in the I/O MMU.
Signed-off-by: Jake
From: Olaf Hering
The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly retu
The macro VMBUS_DEVICE() is unused; get rid of it.
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index b9f3bb2..f773a68 100644
--- a/include/linux/hy
From: Dexuan Cui
Fix the write()'s argument in the daemon code.
Cc: Vitaly Kuznetsov
Cc: "K. Y. Srinivasan"
Signed-off-by: Dexuan Cui
Cc: sta...@vger.kernel.org
Signed-off-by: K. Y. Srinivasan
---
tools/hv/hv_vss_daemon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --g
Consistently use uuid_le type in the Hyper-V driver code.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c |2 +-
drivers/hv/vmbus_drv.c | 10 ++--
include/linux/hyperv.h | 92 +-
include/linux/mod_devicetable.h |
Use uuid_le_cmp() for comparing GUIDs.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c |3 +--
drivers/hv/vmbus_drv.c|4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 38470aa..dc4fb0b 1006
From: Dexuan Cui
spinlock is unnecessary here.
mutex is enough.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 12 ++--
drivers/hv/connection.c |7 +++
drivers/hv/hyperv_vmbus.h |2 +-
3 files changed, 10 insertions(+), 11 del
From: Andrey Smetanin
Before vmbus_connect() synic is setup per vcpu - this means
hypervisor receives writes at synic msr's and probably allocate
hypervisor resources per synic setup.
If vmbus_connect() failed for some reason it's neccessary to cleanup
synic setup by call hv_synic_cleanup() at e
From: Olaf Hering
Catch allocation errors in hvutil_transport_send.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_utils_transport.c |9 ++---
1 files changed, 6 inserti
From: Olaf Hering
Currently some "Unspecified error 0x80004005" is reported on the Windows
side if something fails. Handle the ENOSPC case and return
ERROR_DISK_FULL, which allows at least Copy-VMFile to report a meaning
full error.
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
--
When the handshake with daemon is complete, we should poll the channel since
during the handshake, we will not be processing any messages. This is a
potential bug if the host is waiting for a response from the guest.
I would like to thank Dexuan for pointing this out.
Signed-off-by: K. Y. Srinivas
The irq we extract from ACPI is not used - we deliver hypervisor
interrupts on a special vector. Make the necessary adjustments.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/vmbus_drv.c | 16 +++-
1 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/hv/vmbus_dr
From: Dexuan Cui
In the path vmbus_onoffer_rescind() -> vmbus_device_unregister() ->
device_unregister() -> ... -> __device_release_driver(), we can see for a
device without a driver loaded: dev->driver is NULL, so
dev->bus->remove(dev), namely vmbus_remove(), isn't invoked.
As a result, vmbus_
From: Kamal Mostafa
Use the local uapi headers to keep in sync with "recently" added #define's
(e.g. VSS_OP_REGISTER1).
Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb
Signed-off-by: Kamal Mostafa
Signed-off-by: K. Y. Srinivasan
---
tools/hv/Makefile |2 ++
1 files changed, 2 insertions(+
From: Dexuan Cui
We want to simplify vmbus_onoffer_rescind() by not invoking
hv_process_channel_removal(NULL, ...).
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 21 +++--
1 files changed, 15 insertions(+), 6 deletions(-)
diff --g
From: Jake Oshins
This patch makes 16GB GPUs work in Hyper-V VMs, since, for
compatibility reasons, the Hyper-V BIOS lists MMIO ranges in 2GB
chunks in its root bus's _CRS object.
Signed-off-by: Jake Oshins
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/vmbus_drv.c | 16
1
From: Olaf Hering
HV_FCOPY is already used as identifier in syslog.
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
tools/hv/hv_fcopy_daemon.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
ind
From: Jake Oshins
This defines the channel type for PCI front-ends in Hyper-V VMs.
Signed-off-by: Jake Oshins
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c |3 +++
include/linux/hyperv.h| 11 +++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a
From: Dexuan Cui
process_chn_event(), running in the tasklet, can race with
vmbus_close_internal() in the case of SMP guest, e.g., when the former is
accessing channel->inbound.ring_buffer, the latter could be freeing the
ring_buffer pages.
To resolve the race, we can serialize them by disabling
From: Olaf Hering
All channel interrupts are bound to specific VCPUs in the guest
at the point channel is created. While currently, we invoke the
polling function on the correct CPU (the CPU to which the channel
is bound to) in some cases we may run the polling function in
a non-interrupt context
To: kv...@codeaurora.org
Cc: linux-wirel...@vger.kernel.org
de...@driverdev.osuosl.org
Several of the rtlwifi-driver family have errors in the handling of
module parameters. These 8 patches for the -next repo contain fixes.
Signed-off-by: Larry Finger
Larry Finger (8):
rtlwifi: rtl8723be:
This driver has a number of errors in the module initialization. These
include the following:
Parameter msi_support is stored in two places - one is removed.
Paramters sw_crypto and disable_watchdog were never stored in the final
locations, nor were they initialized properly.
Signed-off-by: Larry
The module parameter for software encryption was never transferred to
the location used by the driver.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl819
This driver fails to copy the module parameter for software encryption
to the locations used by the main code.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwif
Two of the module parameter descriptions show incorrect default values.
In addition the value for software encryption is not transferred to
the locations used by the driver.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c | 6 --
1 file changed
This driver has some errors in the handling of module parameters. These
include missing initialization for parameters msi_support and
disable_watchdog. In addition, neither of these parameters nor sw_crypto
are transferred into the locations used by the driver. A final fix is
adding parameter msi t
In this driver, parameters disable_watchdog and sw_crypto are never
copied into the locations used in the main code. While modifying the
parameter handling, the copying of parameter msi_support is moved to
be with the rest.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek
Two of the module parameters are listed with incorrect default values.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
b/dr
This driver failed to copy parameters sw_crypto and disable_watchdog into
the locations actually used by the driver. In addition, msi_support was
initialized three times and one of them used the wrong variable. The
initialization of parameter int_clear was moved so that it is near that
of the rest
You have been picked up for a scam victim compensation payment. For
details contact Mr. John Wale through this email: cc...@foxmail.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/d
Constifies tty_port_operations structure in
the tty code of the gdm724x driver since it
is not modified after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion
1 - 100 of 133 matches
Mail list logo
