Re: [PATCH v2] staging: gdm72xx: fix address space warnings

2015-12-12 Thread Dan Carpenter
This fix isn't correct and Wim already fixed this. https://lkml.org/lkml/2015/12/11/221 regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Dan Carpenter
On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: > > This patch does the following: > > * changed the complicated if statements to simple case statements > > * in case of E_DEFAULT, no need to return error as ERESTART

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Saurabh Sengar
On 12 December 2015 at 14:10, Dan Carpenter wrote: > On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > This patch does the following: >> > * changed the complicated if statements to simple case statements >> > *

[PATCH] Staging: comedi: fixed unwrapped commit description

2015-12-12 Thread Siddharth Ramesh
Fixed an unwrapped commit description. Signed-off-by: Siddharth Ramesh --- drivers/staging/comedi/comedi.h | 62 ++--- 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 66edd

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote: > On Fri, 11 Dec 2015 16:02:33 +0300 > Dan Carpenter wrote: > > > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote: > > > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 > > > From: Sanidhya

Re: [PATCH] Staging: comedi: fixed unwrapped commit description

2015-12-12 Thread Dan Carpenter
This is a terrible patch... :( Why would you think that's helpful. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sudip Mukherjee
On Sat, Dec 12, 2015 at 11:57:45AM +0300, Dan Carpenter wrote: > On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote: > > On Fri, 11 Dec 2015 16:02:33 +0300 > > Dan Carpenter wrote: > > > > > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote: > > > > >From 1dbe78ce9803

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Sudip Mukherjee
On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: > On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: > > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: > > > This patch does the following: > > > * changed the complicated if statements to simple case sta

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Thank you everyone for your concern regarding my email client. Unfortunately, there is a bug in "git send-email" that leads to the gmail SMTP server rejecting certain patches sent by the git command. If I can replicate and fix the issue for " git am" (which I do apply after emailing to myself) I

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sudip Mukherjee
On Sat, Dec 12, 2015 at 01:12:21AM -0500, Sanidhya Solanki wrote: > Thank you everyone for your concern regarding my email client. > > Unfortunately, there is a bug in "git send-email" that leads to the gmail > SMTP server rejecting certain patches sent by the git command. Is it? I am using git

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Saurabh Sengar
On 12 December 2015 at 15:41, Sudip Mukherjee wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > > This patch does the following: >> >

Re: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
>From a1635ea5e75cb2f10728ae4ddf3a21567958e98f Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki Date: Sat, 12 Dec 2015 02:20:03 -0500 Subject: [PATCH] [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes Patch contains the spacing fixes that checkpatch prompted for, as asked by the TODO

Re: [PATCH 2/3] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Patch contains the CamelCase fixes & Macro fixes that checkpatch prompted for, as asked by the TODO. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/dgnc_driver.c | 56 - drivers/staging/dgnc/dgnc_driver.h | 25 ++-- drivers/staging/dgnc/dgnc_mgmt.c | 28 ++--- drivers/stag

Re: [PATCH 3/3] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Patch updates the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++ b/drivers/staging/dgnc/TODO @@ -1,

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-12 Thread Sanidhya Solanki
Sorry about Patch 1/3 having the header information. The rest should be fine. I broke up the patches as you requested. I can also confirm that git am gives me an error if the patch to be applied does not contain the header information. Specifically, "Patch format detection failed.". Yes, this is

[PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with !

2015-12-12 Thread Benjamin Young
Fixed coding style for null comparisons in netlogic driver to be more consistant with the rest of the kernel coding style Signed-off-by: Benjamin Young --- drivers/staging/netlogic/xlr_net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/netlogic/xlr_

Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with !

2015-12-12 Thread Benjamin Young
On Sat, Dec 12, 2015 at 06:45:59AM -0800, Benjamin Young wrote: > Fixed coding style for null comparisons in netlogic driver to be more > consistant > with the rest of the kernel coding style > > Signed-off-by: Benjamin Young > --- > drivers/staging/netlogic/xlr_net.c | 8 > 1 file cha

[PATCH 3/3] STAGING: COMEDI: Using kernel types in plx9080.h

2015-12-12 Thread Moritz König
This patch makes plx9080.h use kernel types. Signed-off-by: Moritz König Signed-off-by: Fabian Lang --- drivers/staging/comedi/drivers/plx9080.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/plx9080.h b/drivers/staging/comedi/drivers/plx9080

[PATCH 0/3] STAGING: COMEDI: checkpatch.pl cleanups in plx9080.h

2015-12-12 Thread Moritz König
This patchset fixes all the warnings and legitimate checks of checkpatch.pl in plx9080.h. The following warnings were fixed: * WARNING: Block comments use a trailing */ on a separate line * WARNING: Block comments use * on subsequent lines * WARNING: line over 80 characters The following check

[PATCH 2/3] STAGING: COMEDI: Added spaces around binary operators in plx9080.h

2015-12-12 Thread Moritz König
This patch adds spaces around binary operators in plx9080.h. Signed-off-by: Moritz König Signed-off-by: Fabian Lang --- drivers/staging/comedi/drivers/plx9080.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/plx9080.h b/drivers/staging/comedi

[PATCH 1/3] STAGING: COMEDI: Fixed format of comments in plx9080.h

2015-12-12 Thread Moritz König
This patch fixes the format of comments in plx9080.h. Signed-off-by: Moritz König Signed-off-by: Fabian Lang --- drivers/staging/comedi/drivers/plx9080.h | 132 ++- 1 file changed, 95 insertions(+), 37 deletions(-) diff --git a/drivers/staging/comedi/drivers/plx9080

[PATCH V2 0/4] scsi: storvsc: Properly support FC hosts

2015-12-12 Thread K. Y. Srinivasan
Properly support FC hosts. Additional cleanup patches are also included. In this version I have adddressed comments from Dan Carpenter and from Johannes Thumshirn . K. Y. Srinivasan (4): scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet scsi: storvsc: Properly support Fibre Chan

[PATCH V2 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-12 Thread K. Y. Srinivasan
For FC devices managed by this driver, atttach the appropriate transport template. This will allow us to create the appropriate sysfs files for these devices. With this we can publish the wwn for both the port and the node. Signed-off-by: K. Y. Srinivasan Reviewed-by: Long Li Tested-by: Alex Ng

[PATCH V2 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-12 Thread K. Y. Srinivasan
On the interrupt path, we repeatedly establish the pointer to the storvsc_device. Fix this. Signed-off-by: K. Y. Srinivasan Reviewed-by: Long Li Reviewed-by: Johannes Thumshirn Tested-by: Alex Ng --- drivers/scsi/storvsc_drv.c | 23 --- 1 files changed, 8 insertions(+),

[PATCH V2 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

2015-12-12 Thread K. Y. Srinivasan
The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match the Window's definition. Signed-off-by: K. Y. Srinivasan Reviewed-by: Johannes Thumshirn Reviewed-by: Long Li Tested-by: Alex Ng --- drivers/scsi/storvsc_drv.c |5 ++--- 1 files changed, 2 insertions(+), 3 de

[PATCH V2 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-12 Thread K. Y. Srinivasan
The function storvsc_channel_init() repeatedly interacts with the host to extract various channel properties. Refactor this code to eliminate code repetition. Signed-off-by: K. Y. Srinivasan Reviewed-by: Long Li Reviewed-by: Johannes Thumshirn Tested-by: Alex Ng --- V2: Fixed error pat

Re: [PATCH] staging: speakup: kobjects.c: fix char argument to %02x

2015-12-12 Thread Andy Shevchenko
On Sun, Dec 6, 2015 at 2:05 AM, Rasmus Villemoes wrote: > If char is signed and ch happens to be negative, printing ch with > "%02x" will not do as intended (when ch is -19, one will get > "ffed"). Fix that by masking with 0xff. > > Signed-off-by: Rasmus Villemoes > --- > drivers/staging/spe

Re: [PATCH V2 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-12 Thread kbuild test robot
Hi Srinivasan, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.4-rc4 next-20151211] url: https://github.com/0day-ci/linux/commits/K-Y-Srinivasan/scsi-storvsc-Properly-support-FC-hosts/20151213-042209 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f

Re: [PATCH V2 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-12 Thread kbuild test robot
Hi Srinivasan, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.4-rc4 next-20151211] url: https://github.com/0day-ci/linux/commits/K-Y-Srinivasan/scsi-storvsc-Properly-support-FC-hosts/20151213-042209 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f

[GIT PULL] Staging driver fixes for 4.4-rc5

2015-12-12 Thread Greg KH
The following changes since commit 1ec218373b8ebda821aec00bb156a9c94fad9cd4: Linux 4.4-rc2 (2015-11-22 16:45:59 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.4-rc5 for you to fetch changes up to 9225c0b7b976d

[PATCH] staging: netlogic: Coding Style Alignment should match open parenthesis

2015-12-12 Thread Benjamin Young
Fixed alignment issues with parenthesis so the code is easier to read. Signed-off-by: Benjamin Young --- drivers/staging/netlogic/platform_net.c | 12 +-- drivers/staging/netlogic/xlr_net.c | 159 +--- 2 files changed, 91 insertions(+), 80 deletions(-) diff --g