[PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could

2015-12-10 Thread Benjamin Young
>From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001 From: Benjamin Young Date: Thu, 10 Dec 2015 17:31:00 -0500 Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around that '+' Helped improve coding style to make arithemethic easier to read Signed-off-b

[PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could

2015-12-10 Thread Benjamin Young
>From f279a9e98b35301690abb39271367ecb0f611aff Mon Sep 17 00:00:00 2001 From: Benjamin Young Date: Thu, 10 Dec 2015 17:35:33 -0500 Subject: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could be written "!r" Fixed coding style for null comparisons in goldfish_audio.c to be more

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > moment! Oops, sloppy mistake. > data_s can just be modified to be __user. All uses of it follow that > rule. What do you mean? The data still needs to

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread One Thousand Gnomes
On Fri, 11 Dec 2015 00:47:38 +0100 Wim de With wrote: > On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > > moment! > > Oops, sloppy mistake. Compile/test/send - even when in a hurry > > data_s ca

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-10 Thread Brian Norris
On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > Unregister the NAND device from the NAND subsystem when removing a denali > NAND controller, otherwise the MTD attached to the NAND device is still > exposed by the MTD layer, and accesses to this device will likely crash > the syst

Re: [PATCH v4 38/58] mtd: nand: s3c2410: use the mtd instance embedded in struct nand_chip

2015-12-10 Thread Krzysztof Kozlowski
On 10.12.2015 17:00, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Make use of this mtd instance. > > Signed-off-by: Boris Brezillon > --- > Changes generated with the following coccinelle script > > --->8--- > virtual patch > > @fix1@ > identifier __chipfield, __mtdfield;

Re: [PATCH] Style Fix: Blank lines after declaration

2015-12-10 Thread Sudip Mukherjee
On Thu, Dec 10, 2015 at 06:00:14AM -0700, BryanSPaul wrote: > WARNING: Missing a blank line after declarations lines added > > Signed-off-by: Bryan Paul > --- Your name in the From: header and Signedoff-by name should match. > drivers/staging/rtl8188eu/core/rtw_efuse.c | 13 + > 1 f

[PATCH] Staging:rtl8192u: fixes the following sparse warning:

2015-12-10 Thread Jandy Gou
drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol 'rtl819x_watchdog_wqcallback' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol 'watch_dog_timer_callback' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c

Re: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could

2015-12-10 Thread Sudip Mukherjee
On Thu, Dec 10, 2015 at 06:31:09PM -0500, Benjamin Young wrote: > From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001 > From: Benjamin Young > Date: Thu, 10 Dec 2015 17:31:00 -0500 > Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around > that '+' Rega

Re: [PATCH] Staging:rtl8192u: fixes the following sparse warning:

2015-12-10 Thread Sudip Mukherjee
On Fri, Dec 11, 2015 at 01:52:11PM +0800, Jandy Gou wrote: > drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol > 'rtl819x_watchdog_wqcallback' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol > 'watch_dog_timer_callback' was not de

Re: [PATCH 172/182] staging: vme: use gpiochip data pointer

2015-12-10 Thread Martyn Welch
On 09/12/15 13:50, Linus Walleij wrote: This makes the driver use the data pointer added to the gpio_chip to store a pointer to the state container instead of relying on container_of(). Cc: Greg Kroah-Hartman Cc: Martyn Welch Cc: Manohar Vanga Cc: de...@driverdev.osuosl.org Signed-off-by: L

RE: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-12-10 Thread Dexuan Cui
> -Original Message- > From: KY Srinivasan > Sent: Friday, December 11, 2015 7:23 > > It looks the patch has not been Greg's tree yet. > > > > I have 2 questions about the patch: > > > > 1. hv_poll_channel() is invoked in fcopy_handle_handshake(), but not in > > vss_handle_handshake() and k

<    1   2