My wife and I will be giving out donation to few individuals and if you have
receive this email, please reply back for more details.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
Staging: Skein: Moved macros from skein_block.c to header
file.
The original code defined macros in the source code, making it
harder to read. Moved them to the header file, as per the TODO file.
Signed-off-by: Sanidhya Solanki
---
drivers/staging/skein/skein_block.c | 473 +---
The patch is included below.
I would like to apologize for the past few emails. It turns out the
documentation included in the eMail clients file is woefully out of
date. I have checked the patches for errors using the scripts provided.
However, it turns out that the scripts are slightly incorrect,
Hi Sanidhya,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.4-rc3 next-20151203]
url:
https://github.com/0day-ci/linux/commits/Sanidhya-Solanki/Staging-Skein-Moved-macros-from-skein_block-c-to-header/20151205-233922
config: x86_64-randconfig-s4-12052352
If char is signed and ch happens to be negative, printing ch with
"%02x" will not do as intended (when ch is -19, one will get
"ffed"). Fix that by masking with 0xff.
Signed-off-by: Rasmus Villemoes
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Sun, 2015-12-06 at 01:05 +0100, Rasmus Villemoes wrote:
> If char is signed and ch happens to be negative, printing ch with
> "%02x" will not do as intended (when ch is -19, one will get
> "ffed"). Fix that by masking with 0xff.
I presume there are a lot of these in the kernel.
Did you use
On Sun, Dec 06 2015, Joe Perches wrote:
> On Sun, 2015-12-06 at 01:05 +0100, Rasmus Villemoes wrote:
>> If char is signed and ch happens to be negative, printing ch with
>> "%02x" will not do as intended (when ch is -19, one will get
>> "ffed"). Fix that by masking with 0xff.
>
> I presume th
When char is signed and one of the bytes in lmm happens to have a byte
value above 127, the result of printing that with %.2X will be 8 hex
chars, the first 6 of which are 'F'. Worst case, we'll overrun our
'carefully' allocated buffer.
I didn't have the tenacity to work through the gazillion and
Hi Mauro,
Thank you for the patch.
On Sunday 30 August 2015 00:06:48 Mauro Carvalho Chehab wrote:
> This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a
> hack to check if the remote entity is a subdev. Get rid of it.
While I agree with the idea of the patch I don't think this is a hack,
Hi Mauro,
Thank you for the patch.
On Sunday 30 August 2015 00:06:47 Mauro Carvalho Chehab wrote:
> This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV:
>
> - it uses a hack to check if the remote entity is a subdev;
Same comment as for "omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse", this isn't
a h
Hi Mauro,
Thank you for the patch.
On Sunday 30 August 2015 00:06:44 Mauro Carvalho Chehab wrote:
> On omap3/omap4/davinci drivers, MEDIA_ENT_T_V4L2_SUBDEV macro is
> abused in order to "simplify" the pad checks.
As explained in a couple of other replies to similar patches, it's not a hack
:-)
Hi Mauro,
Thank you for the patch.
On Sunday 30 August 2015 00:06:43 Mauro Carvalho Chehab wrote:
> Instead of relying on media subtype, use the new macros to detect
> if an entity is a subdev or an A/V DMA entity.
>
> Please note that most drivers assume that there's just AV_DMA or
> V4L2 subde
Hi Javier,
Thank you for the patch.
On Thursday 03 September 2015 18:00:32 Javier Martinez Canillas wrote:
> The omap4iss driver initializes the entities and creates the pads links
> before the entities are registered with the media device. This does not
> work now that object IDs are used to cre
Hi Javier,
Thank you for the patch.
On Sunday 30 August 2015 00:06:13 Mauro Carvalho Chehab wrote:
> From: Javier Martinez Canillas
>
> Assessing media_entity ID should now use media_entity_id() macro to
Did you mean "accessing" ?
> obtain the entity ID, as a next patch will remove the .id fi
I disagree with the output of the automaton. Included below are my
compile checks before and after the patch.
The output has been scrubbed to remove information about my file layout.
--
[~ linux]$ git branch -v
master 31ade3b Linux
15 matches
Mail list logo