On Fri, Nov 20, 2015 at 10:59 PM, Arnd Bergmann wrote:
> The rmi4 touchscreen driver encloses the power-management
> functions in #ifdef CONFIG_PM, but the smtcfb_pci_suspend/resume
> functions are only really used when CONFIG_PM_SLEEP is also
> set, as a frequent gcc warning shows:
>
> ste_rmi4/
On Mon, Nov 30, 2015 at 12:44:43PM +0530, Rajan Vaja wrote:
> Fix below coding style problems reported by checkpatch:
> - Check for pointer comparisons to NULL
> - No space after a cast
That's two different things, please break this into two different
patches.
thanks,
greg k-h
__
On Mon, Nov 30, 2015 at 09:34:15AM -0500, Mike Marciniszyn wrote:
> This two patch series fixes regressions for qib and hfi1
> introduced in the 4.4 merge window.
>
> These are critical for 4.4 and for rebasing the qib/hfi1
> refactoring.
Doug, Greg,
It should also be noted that without this cha
On Mon, Nov 30, 2015 at 01:05:19PM -0500, ira.weiny wrote:
> On Mon, Nov 30, 2015 at 09:34:15AM -0500, Mike Marciniszyn wrote:
> > This two patch series fixes regressions for qib and hfi1
> > introduced in the 4.4 merge window.
> >
> > These are critical for 4.4 and for rebasing the qib/hfi1
> > r
Greg, over the last month or more we have sent numerous Hyper-V patches and
these are yet to be comitted (all review comments have been addressed
for these patches). Please let me know if I should resend these patches.
Regards,
K. Y
___
devel mailing
From: Erik Arfvidson
This patches resolves the NULL comparison checkpatch warnings
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/vi
From: Erik Arfvidson
This patch simply fixes all trailing */ by modifying the comments
structures while trying to reduce the total number of lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 237 +++--
1
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
.../staging/unisys/visorinput/ultrainputreport.h |
From: Erik Arfvidson
This patch fixes checkpatch's no space is necessary after a cast
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys
From: Erik Arfvidson
Fixes checkpatch trailing */ comment in vbusdeviceinfo.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/
From: Erik Arfvidson
This patch fixes the following type of check patch warnings:
Comparison to NULL could be written
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(
From: Erik Arfvidson
this patch removes the following checkpatch warnings:
please use a blank line after …
Please don’t use multiple blank lines
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 +--
1 file chang
From: Erik Arfvidson
This patch fixes the following type of check patch warning:
Blank lines aren't necessary before a close brace '}'
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --g
From: Erik Arfvidson
This patch fixes the following checkpatch warning:
spaces preferred around that ‘*’ or ‘|’
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff -
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
else is not generally useful after a break or return
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Erik Arfvidson
This patch simply cleans up all checkpatch comment issues
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/uni
This set of patches cleans up all remaining checkpatch formatting warnings
in the Unisys driver series.
Erik Arfvidson (15):
staging: unisys: Fix guestlinuxdebug.h comments
staging: unisys: fix comments for controlvmchannel.h
staging: unisys: Fix NULL comparison vbusdeviceinfo.h
staging: u
From: Erik Arfvidson
This patch fixes all the Block comments by using a trailing */
on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchipset.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff -
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visor
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Alignment should match open parenthesis
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 10 +-
1 file changed, 5 insertions(+), 5 deleti
From: Erik Arfvidson
This patch fixes the following types of check patch warnings:
Block comments use a trailing */ on a separate line
Comment alignments
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
Signed-off-by: Mario J. Rugiero
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index d5b7725..9ce1d22 100644
--- a/drivers/staging/wilc1000/hos
This patch replaces an "if (ptr > 0)" comparison that seems to be a
confusing way to check for null by a simpler "if (ptr)" check.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wil
NIGERIA ECONOMIC AND FINANCIAL
CRIME COMMISSION (EFCC).
15 AWOLOWO WAYS VICTORIA
ISLAND LAGOS NIGERIA
PHONE: +2348034321492
Attention: Beneficiary,
YOUR REF: CLAIMS/ATM/2015
The Economic and Financial Crimes Commission (EFCC) has severally sent you an
email but no single response yet.This corre
On Mon, Nov 30, 2015 at 02:46:06PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch fixes the following checkpatch warning:
> spaces preferred around that ‘*’ or ‘|’
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorbus/vis
On Mon, Nov 30, 2015 at 02:46:15PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch fixes the following type of check patch warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
This has alrea
The success path and the error path both are first doing
spin_unlock_irqrestore() before returning. Use that in the common path
and return the success/error value.
Signed-off-by: Sudip Mukherjee
---
It is dependent on the patch series sent by Benjamin (Nov 30th).
drivers/staging/unisys/visorni
27 matches
Mail list logo
