Re: [PATCH 18/27] mtd: nand: update mtd_to_nand()

On Mon, 16 Nov 2015 19:03:53 -0800 Brian Norris wrote: > On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > > Now that all drivers are using the mtd instance embedded in the nand_chip > > Do you have a script that verifies this? I thought you did at some > point, and it'd be nice

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Brian, On Mon, 16 Nov 2015 19:00:19 -0800 Brian Norris wrote: > Hi Boris, > > On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > > struct nand_chip now embeds an mtd device. Patch all drivers to make use > > of this mtd instance instead of using the instance embedded in their

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

> > (This isn't the worst one, but it just happens to be one of the first.) > > There are many cases where the typical style would be to declare a new > > variable at the top of the function, where you perform the > > macro/function-call to convert from one abstraction to another. Like > > > > stat

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

Em Mon, 16 Nov 2015 13:28:10 +0100 Arnd Bergmann escreveu: > I think we can also move some of the existing platform data headers to the > same > place, but that could be a separate patch: > > $ git grep linux/platform_data drivers/media/ > drivers/media/platform/coda/coda-common.c:#include >

Re: [PATCH 09/19] staging/wilc1000: move init/exit functions to driver files

Hi Arnd, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20151117] [cannot apply to v4.4-rc1] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/staging-wilc1000-cleanups/20151116-221148 config: x86_64-randconfig-s1-11171709 (attached as .config

[PATCH] staging: rtl8712: Fix typos and checkpatch warnings.

Fix typo SUCESS -> SUCCESS and multiple checkpatch checks (blank line, indentation). Signed-off-by: Christian Colic --- drivers/staging/rtl8712/rtl8712_led.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging

[PATCH] staging: fwserial: (coding-style) rewrite comparisons to NULL as "!fifo->data"

Rewrite multiple comparisons to NULL as "!fifo->data" to fix the last coding style problems of this file. Signed-off-by: Christian Colic --- drivers/staging/fwserial/dma_fifo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fwserial/dma_fifo.c b/d

Re: rtlwifi: rtl8821ae: Fix lockups on boot

> In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"), > an attempt was made to fix a regression introduced in commit 1277fa2ab2f9 > ("rtlwifi: Remove the clear interrupt routine from all drivers"). > Unfortunately, there were logic errors in that patch that prevented > affe

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Julia, On Tue, 17 Nov 2015 10:05:03 +0100 (CET) Julia Lawall wrote: > > > (This isn't the worst one, but it just happens to be one of the first.) > > > There are many cases where the typical style would be to declare a new > > > variable at the top of the function, where you perform the > > >

[PATCH 08/14] staging: unisys: Add channel feature access functions

From: David Kershner Need access functions to set channel polling Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 55 + 1 file changed, 55 insertions(+) diff --git a/drivers/staging/unisys/visorbus/viso

[PATCH 05/14] staging: unisys: visorinput: use spinlock for channel_interrupt() locking

From: Tim Sell Because visorinput_channel_interrupt() is now called from interrupt context, we can't use our lock_visor_dev semaphore there. Instead, we use a new lock_isr spinlock, which is essentially needed to prevent visorinput_dev from disappearing while we're accessing it in visorinput_cha

[PATCH 00/14] staging: unisys: add channel interrupt support

This patch series adds a centralized infrastructure and device support for channel interrupts sent to s-Par virtual devices. With these changes, the visorhba device is ~80% faster than with only polling, and visornic receives a speedup of over 3500% (from ~9Mb/s to between 360Mb/s and 390Mb/s). Da

[PATCH 03/14] staging: unisys: visorhba: Convert visorhba to use visorbus channel interrupts.

From: David Kershner Use a tasklet to process the response queue from the IO Service Partition instead of using a thread. Register with visorbus to have it issue either "soft" interrupts or "s-Par" interrupts depending on registration values from the create message. Signed-off-by: David Kershner

[PATCH 01/14] staging: unisys: Change poll rate to 2 ms for work

From: David Kershner Use ms_to_jiffies for the periodic work queue instead of raw jiffies. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/un

[PATCH 06/14] staging: unisys: Only process up to budget amount of responses

From: David Kershner >From napi documentation you should only process the amount your budget allows, if you go over it just wait for the next napi poll to continue. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 9 + 1

[PATCH 02/14] staging: unisys: set client state

From: David Kershner Every channel has an s-Par channel state associated with it. This patch correctly sets of the channels. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 32 - 1 file changed, 31 inser

[PATCH 04/14] staging: unisys: Convert visornic to use visorbus channel interrupt code

From: David Kershner Instead of having our own timer to set off a interrupt, use the shared code from visorbus. When visorbus gets s-Par interrupts working we will automatically get support from it. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorni

[PATCH 10/14] staging: unisys: Capture data from device create to register interrupt.

From: David Kershner s-Par Firmware sends a CREATE_DEVICE information for each device that gets created. Contained in the CREATE_DEVICE is the GSI interrupt vector we should request an interrupt on. Save off that information and when the client driver asks to register for interrupt, register the

[PATCH 13/14] staging: unisys: Remove semaphores around channel interrupts.

From: David Kershner We can remove the semaphore from around the interrupt callback in dev_periodic_work(). Signed-off-by: David Kershner Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH 14/14] staging: unisys: Allow for unregistering of interrupts.

From: David Kershner The new interrupt code was NOT distinguishing between the availability of an irq (i.e., visor_device.irq != 0), and the fact that we were in fact operating in real interrupt mode (i.e., request_irq() succeeded). This could cause us to do the wrong thing in visorbus_enable_ch

[PATCH 07/14] staging: unisys: Add support to update Features bits in channel queues

From: David Kershner Add support to visorbus to update the features in the channel queues. Signal queues features is the memory location to disable/enable signal queue interrupts. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h |

[PATCH 09/14] staging: unisys: Re-enable interrupts after we have done the work

From: David Kershner Instead of rescheduling the work queue after we have called the channel interrupt, start it when the driver has finished processing the queue. This patch introduces the visorbus_rearm_channel_interrupts function that must get called when the driver decides that it is done pr

[PATCH 12/14] staging: unisys: Don't set polling mode in visorhba_probe

From: David Kershner Visorbus handles interrupt states for the drivers now, don't need to handle it in the driver. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorhba/visorhba_main.c | 14 -- 1 file changed, 14 deletions(-) diff --git a

[PATCH 11/14] staging: unisys: Don't go into POLLING mode in visornic_probe.

From: David Kershner Since visorbus now supports s-Par interrupts it will handle the polling/interrupt mode for us. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/stagin

Re: [PATCHv2 0/3] Devicetree bindings for Ion

On Monday 16 November 2015 16:57:32 Laura Abbott wrote: > Hi, > > This is another attempt at devicetree bindings for Ion. The big complaint from > v1 was that too much unnecessary data was being pushed into devicetree. > v2 takes a different approach of using just compatbile strings for the heaps.

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

On Tue, 17 Nov 2015, Boris Brezillon wrote: > Hi Julia, > > On Tue, 17 Nov 2015 10:05:03 +0100 (CET) > Julia Lawall wrote: > > > > > (This isn't the worst one, but it just happens to be one of the first.) > > > > There are many cases where the typical style would be to declare a new > > > > varia

Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

On Mon, Nov 16, 2015 at 10:48:27PM +0530, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator, usleep_range is preferred over > udelay - coding style issue > > Signed-off-by: Ranjith Thangavel > --- I am not seeing any change related to udelay. C

Re: [PATCH 2/2] comedi: dmm32at: Fix coding style - use BIT macro

On Mon, Nov 16, 2015 at 10:48:28PM +0530, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator, usleep_range is preferred over > udelay - coding style issue > > Signed-off-by: Ranjith Thangavel > --- In this one I am not seeing any change to BIT.

randconfig build error with next-20151117, in drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

Building with the attached random configuration file, warning: (INTEL_SOC_DTS_IOSF_CORE && PUNIT_ATOM_DEBUG) selects IOSF_MBI which has unmet direct dependencies (PCI) drivers/built-in.o: In function `mgmt_tx_cancel_wait': wilc_wfi_cfgoperations.c:(.text+0x24e1d4): undefined reference to `cfg8021

[PATCH] staging: goldfish: fix checkpatch checks

Fix checkpatch checks: spaces around + at "reg_base+addr2" and rewrite comparisons with NULL to "!data->reg_base" Signed-off-by: Christian Colic --- drivers/staging/goldfish/goldfish_audio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/goldfish/gold

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > From: Jubin John > > Correct the checks on diag.c with the latest checkpatch > > Reviewed-by: Dennis Dalessandro > Reviewed-by: Mike Marciniszyn > Signed-off-by: Jubin John > Signed-off-by: Ira Weiny > --- Different type

Re: [PATCH] staging: goldfish: fix checkpatch checks

On Tue, Nov 17, 2015 at 05:44:55PM +0100, Christian Colic wrote: > Fix checkpatch checks: spaces around + at "reg_base+addr2" and > rewrite comparisons with NULL to "!data->reg_base" That becomes multiple changes in a single patch. It should be in separate patches. regards sudip _

[PATCH 01/14] staging: unisys: iochannel fix block comments

From: Erik Arfvidson This patch fixes warning messages from checkpatch.pl specifically: WARNING: Block comments use a trailing */ on a separate lines Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h | 137 +

[PATCH 11/14] staging: unisys: Fix periodic_work.c parenthesis alignment

From: Erik Arfvidson This patch fixes checkpatch.pl message: CHECK: Alignment should match open parenthesis Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/periodic_work.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[PATCH 09/14] staging: unisys: Fix vmcallerinterface.h block comments

From: Erik Arfvidson This patch fixes all the checkpatch Block comments use a trailing */ while keeping comments clean. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/vmcallinterface.h | 34 ++- 1 file changed, 15 insertions

[PATCH 02/14] staging: unisys: iochannel.h remove redundant comments

From: Erik Arfvidson iochannel cleanup redudant comments in function declarations. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/uni

[PATCH 08/14] staging: unisys: Fix visorchannel.c block comments

From: Erik Arfvidson This patch fixes the last checkpatch warning about: Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchannel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 06/14] staging: unisys: vbushelper.h fix Block comment

From: Erik Arfvidson This patch fixes last checkpatch warning for vbushelper.h WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/vbushelper.h | 3 ++- 1 file changed, 2 insertions(+), 1 d

[PATCH 05/14] staging: unisys: visorbus.h fix block comment

From: Erik Arfvidson This fixes last checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/visorbus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson This patch simply cleans up all checkpatch warnings and fixes styling Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 03/14] staging: unisys: iochannel fix spacing around operators

From: Erik Arfvidson This patch fixes check warning from checkpatch.pl in the macro definition CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 04/14] staging: unisys: iochannel fix trailing */

From: Erik Arfvidson Fixed last warning message from checkpatch.pl by removing the wordiness of the comment Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

[PATCH 00/14] staging: unisys: checkpatch cleanup series

This series takes care of checkpatch.pl issues found recently, as the current version now inspects comment formatting. In addition, some spacing and alignment issues are corrected. Erik Arfvidson (14): staging: unisys: iochannel fix block comments staging: unisys: iochannel.h remove redundant

[PATCH 10/14] staging: unisys: Fix channel.h Block comments

From: Erik Arfvidson This patch fixes all the checkpatch.pl block commments that use a trailing */ in channel.h Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/channel.h | 114 ++- 1 file changed, 67 insertions(+), 47

[PATCH 13/14] staging: unisys: fix vbuschannel.h comments

From: Erik Arfvidson Fixes trailling */ from vbuschannel.h and alignment issue on the same comment block Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/vbuschannel.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 14/14] staging: unisys: fix ultrainputreport.h block comment warnings

From: Erik Arfvidson This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../staging/unisys/visorinput/ultrainputreport.h |

[PATCH 12/14] staging: unisys: controlvmcompletionstatus.h fix block comments

From: Erik Arfvidson This patch fixes the checkpatch warning messages in controlvmcompletionstatus.h. All the warning messages in this file are caused by "Block comments use atrailing */ on a separate line" Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../unisys/visorbus/co

Re: [PATCHv2 0/3] Devicetree bindings for Ion

On 11/17/15 7:15 AM, Arnd Bergmann wrote: On Monday 16 November 2015 16:57:32 Laura Abbott wrote: Hi, This is another attempt at devicetree bindings for Ion. The big complaint from v1 was that too much unnecessary data was being pushed into devicetree. v2 takes a different approach of using jus

[PATCH 0/2] Remove the last use and definition of IS_PO2

Concerned with the removal of IS_PO2 by replacing its use with is_power_of_2 and then removing the definition. Aya Mahfouz (2): staging: lustre: hash.c: Replace IS_PO2 by is_power_of_2 staging: lustre: libcfs.h: remove IS_PO2 and __is_po2 drivers/staging/lustre/include/linux/libcfs/libcfs.h

[PATCH 2/2] staging: lustre: libcfs.h: remove IS_PO2 and __is_po2

Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have been replaced by is_power_of_2 Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h b/drivers/s

[PATCH 1/2] staging: lustre: hash.c: Replace IS_PO2 by is_power_of_2

Replaces IS_PO2 by is_power_of_2. It is more accurate to use is_power_of_2 since it returns 1 for numbers that are powers of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are powers of 2. Reviewed-by: Andreas Dilger Signed-off-by: Aya Mahfouz --- drivers/staging/lustre/lustre/libcfs/ha

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > > From: Jubin John > > > > Correct the checks on diag.c with the latest checkpatch > > > > Reviewed-by: Dennis Dalessandro > > Reviewed-by: Mike Marciniszyn

Re: [PATCH v2 7/7] staging: unisys: visorinput: add INPUT to dependent driver list

On Mon, Nov 16, 2015 at 03:22:17PM -0500, Benjamin Romer wrote: > From: Tim Sell > > This was an obvious omission, as visorinput is an input-class driver. > > Signed-off-by: Tim Sell > Signed-off-by: Benjamin Romer > > --- > v2: the patch was resubmitted. > --- > drivers/staging/unisys/visor

Re: [PATCH v2 1/7] staging: unisys: visorinput: use kref ref-counting for device data struct

On Mon, Nov 16, 2015 at 03:22:11PM -0500, Benjamin Romer wrote: > From: Tim Sell > > This is NOT technically required for the code as it stands now, but will > be needed for subsequent patches. > > Signed-off-by: Tim Sell > Signed-off-by: Benjamin Romer > > --- > v2: resources are released in

Re: [PATCH v2 3/7] staging: unisys: visorinput: ensure proper locking wrt creation & ints

On Mon, Nov 16, 2015 at 03:22:13PM -0500, Benjamin Romer wrote: > From: Tim Sell > > Ensure we properly lock between visorinput_channel_interrupt() and > devdata_create(). We now guarantee that interrupts will be disabled and > we will be holding lock_visor_dev at the time input_register_device(

Re: [PATCH v2 2/7] staging: unisys: visorinput: remove need for 'depends on FB'

On Mon, Nov 16, 2015 at 03:22:12PM -0500, Benjamin Romer wrote: > From: Tim Sell > > Previously, we used a hack to determine the max x,y resolution of the > visor virtual mouse: we just looked at the resolution of the > first-registered framebuffer device, using the currently-valid assumption > t

Re: [PATCH v2 6/7] staging: unisys: visorinput: add useful dev_dbg() and dev_info() messages

On Mon, Nov 16, 2015 at 03:22:16PM -0500, Benjamin Romer wrote: > From: Tim Sell > > The dev_info() messages at init time are particularly useful for mapping > visor devices to input devices. But that's just "noise", why would a user ever need that? Please keep the kernel log clean, if you real

Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements

On Mon, Nov 16, 2015 at 03:22:10PM -0500, Benjamin Romer wrote: > This patch series fixes visorinput to remove the dependency on FB and > add dependency to INPUT, cleans up some formatting issues found with > checkpatch.pl, and adds the capability to change screen resolutions > without breaking mou

Re: [PATCH 00/14] staging: unisys: add channel interrupt support

On Tue, Nov 17, 2015 at 09:57:58AM -0500, Benjamin Romer wrote: > This patch series adds a centralized infrastructure and device support > for channel interrupts sent to s-Par virtual devices. With these changes, > the visorhba device is ~80% faster than with only polling, and visornic > receives a

Re: [PATCH 01/14] staging: unisys: Change poll rate to 2 ms for work

On Tue, Nov 17, 2015 at 09:57:59AM -0500, Benjamin Romer wrote: > From: David Kershner > > Use ms_to_jiffies for the periodic work queue instead of raw jiffies. > > Signed-off-by: David Kershner > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- >

Re: [PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

On Tue, Nov 17, 2015 at 01:34:54PM -0500, Benjamin Romer wrote: > From: Erik Arfvidson > > This patch simply cleans up all checkpatch warnings and fixes > styling > > Signed-off-by: Erik Arfvidson > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/include/guestlinuxdebug.h | 13 ++

Re: [PATCH 14/14] staging: unisys: fix ultrainputreport.h block comment warnings

On Tue, Nov 17, 2015 at 01:35:01PM -0500, Benjamin Romer wrote: > From: Erik Arfvidson > > This patch fixes the following types of check patch warnings: > Block comments use * on subsequent lines > Block comments use a trailing */ on a separate line > > Signed-off-by: Erik Arfvidson > Signed-of

RE: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, November 17, 2015 5:18 PM > To: Romer, Benjamin M > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org > Subject: Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and > enhancements > >

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

On Tue, Nov 17, 2015 at 03:30:24PM -0500, ira.weiny wrote: > On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > > > From: Jubin John > > > > > > Correct the checks on diag.c with the latest checkpatch > > >

Re: [PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements

On Tue, Nov 17, 2015 at 10:28:17PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, November 17, 2015 5:18 PM > > To: Romer, Benjamin M > > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org > > Subject:

[staging:staging-testing 203/406] undefined reference to `nf_conntrack_untracked'

Hi Glen, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 34d96c0dedbfbba50349dcc76546a86ad59a0789 commit: b22fa80cdbf4ff1056ecddb4efdcc0ede5f5f422 [203/406] staging: wilc1000: fix kbuild tes

Re: [staging:staging-testing 203/406] undefined reference to `nf_conntrack_untracked'

Hi fengguang, This is because cfg80211 is built as module but wilc1000 is built into the Kernel. Arnd have posted patch series, not yet applied, which also can fix this Kconfig issue. [PATCH 17/19] staging/wilc1000: split out bus specific modules regards, glen lee. On 2015년 11월 18일 10:24, k

[PATCH 01/16] staging: wilc1000: remove sdio speed control codes

This patch removes spi speed control related functions and variable. We cannot get exact clock what we need in this way and it can causes some problem in host side by setting the clock, so remove the codes. Speed control codes in spi also will removed in next patch, so it's ok to remove functions i

[PATCH 02/16] staging: wilc1000: remove spi speed control codes

This patch removes spi speed control codes. We are not using define SPEED to specify speed of spi, it is not proper way of doing this. It will be provided by the device tree. The following functions and variable are removed. MIN_SPEED, MAX_SPEED, SPEED wilc_spi_set_max_speed wilc_spi_max_bus_speed

[PATCH 03/16] staging: wilc1000: remove paltform define PLAT_WMS8304

This patch removes PLAT_WMS8304 and it's related codes as well. We will not use this way of supporting other platform. This will be supported if necessary by device tree later. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_spi.c | 161 -- 1 file chan

[PATCH 00/16] tidy up sdio/spi module and remove wilc_dev

This patch series removes global variable wilc_dev and tidy up sdio/spi modules. I sync with arnd's latest patch series because this work depends on his patches. Glen Lee (16): staging: wilc1000: remove sdio speed control codes staging: wilc1000: remove spi speed control codes staging: wilc1

[PATCH 04/16] staging: wilc1000: pass struct wilc to the functions which use hif_func

This patch passes struct wilc to the functions which use hif_func inside. The function pointers of wilc_hif_func will pass wilc also in the later patch. Pass wilc to the functions if necessary. Flollowings are modified functions. chip_wakeup wilc_chip_sleep_manually chip_allow_sleep wilc_get_chipi

[PATCH 08/16] staging: wilc1000: wilc_spi_write: pass struct wilc

This patch add new function parameter struct wilc and use it instead of wilc_dev, and pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_spi.c | 4 ++-- drivers/staging/wilc1000/linux_wlan_spi.h | 3 ++- drivers/staging/wilc1000/wilc_spi.c |

[PATCH 11/16] staging: wilc1000: add struct wilc to host_if_drv

This patch adds struct wilc to host_if_dev and assign wilc to use driver's primary structure in host_if_dev. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 1 + drivers/staging/wilc1000/host_interface.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/stagi

[PATCH 09/16] staging: wilc1000: wilc_spi_read: pass struct wilc

This patch adds new function parameter struct wilc and use it instead of global variable wilc_dev, and pass wilc to the functions as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_spi.c | 4 ++-- drivers/staging/wilc1000/linux_wlan_spi.h | 2 +- drivers/staging/wilc1000/

[PATCH 10/16] staging: wilc1000: wilc_spi_write_read: pass struct wilc

This patch adds new function parameter struct wilc and use it instead of global variable wilc_dev, and pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_spi.c | 4 ++-- drivers/staging/wilc1000/linux_wlan_spi.h | 2 +- drivers/staging/wilc1000/wil

[PATCH 05/16] staging: wilc1000: pass wilc to all function pointers of wilc_hif_func

This patch adds new function parameter struct wilc to all function pointers of struct wilc_hif_func, and all functions of wilc_sdio.c and wilc_spi.c need to be changed as it's function pointer is changed. Pass wilc in all the functions call as well. The wilc will be passed to functions in linux_wl

[PATCH 07/16] staging: wilc1000: wilc_sdio_cmd53: pass struct wilc

This patch adds new function parameter struct wilc and use it instead of global variable wilc_dev and pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_sdio.c | 4 ++-- drivers/staging/wilc1000/linux_wlan_sdio.h | 2 +- drivers/staging/wilc1000/

[PATCH 16/16] staging: wilc1000: use wilc instead of wilc_dev and remove wilc_dev

This patch changes wilc_dev with wilc in the function call wilc_wlan_get_num_conn_ifcs, and remove wilc_dev and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 5 + drivers/staging/wilc1000/

[PATCH 06/16] staging: wilc1000: wilc_sdio_cmd52: pass struct wilc

This patch adds new function parameter struct wilc and use it instead of wilc_dev. Pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan_sdio.c | 4 +-- drivers/staging/wilc1000/linux_wlan_sdio.h | 2 +- drivers/staging/wilc1000/wilc_sdio.c |

[PATCH 15/16] staging: wilc1000: wilc_dbg: remove wilc

This patch remove parameter struct wilc since it is not used and also wilc_dev will be removed. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 3 files ch

[PATCH 12/16] staging: wilc1000: wilc_send_config_pkt: pass struct wilc

This patch passes struct wilc to wilc_send_config_pkt. The function wilc_wlan_cfg_set and wilc_wlan_cfg_get function will get wilc to replace wilc_dev with it. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/coreconfigurator.c | 3 +- drivers/staging/wilc1000/coreconfigurator.h | 3 +-

[PATCH 13/16] staging: wilc1000: wilc_wlan_cfg_set: pass struct wilc

This patch pass struct wilc to the function and use it instead of global variable wilc_dev. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 101 drivers/staging/wilc1000/wilc_wlan.c

[PATCH 14/16] staging: wilc1000: wilc_wlan_cfg_get: pass struct wilc

This patch passes the struct wilc to the function and use it instead of global variable wilc_dev. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c| 4 ++-- drivers/stag

Dead or Alive

FROM THE DESK OF MR. WALI IBRAHIM INTERNATIONAL MONETARY FUND AGENCY INTERNATIONAL OPERATION DEPT VICTORIA ISLAND LAGOS-NIGERIA. RE-OUTSTANDING PAYMENT This is to inform you of your long overdue Payment outstanding our Banking records. I saw your name in the Central Computer among list of unpaid