Re: [PATCH v3 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

On 2015/10/27 7:15, ja...@microsoft.com wrote: > From: Jake Oshins > > The existing PCI code looks for an IRQ domain associated with a root PCI bus > by looking in the Open Firmware tree. This patch introduces a second way > to identify the associated IRQ domain, if the lookup in the OF tree f

Re: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally

On 2015/10/27 7:15, ja...@microsoft.com wrote: > From: Jake Oshins > > This patch allows a PCI front-end implementation to supply an fwnode_handle > associated with a root PCI bus, optionally. If supplied, the PCI driver > records this. > > This patch supports the next patch in the series, whic

Re: [PATCH v3 7/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

On 2015/10/27 7:15, ja...@microsoft.com wrote: > From: Jake Oshins > > This patch introduces a new driver which exposes a root PCI bus whenever a PCI > Express device is passed through to a guest VM under Hyper-V. The device can > be single- or multi-function. The interrupts for the devices are m

Re: [PATCH 00/19] staging/wilc1000 cleanups

Hi Arnd, I expect your opinion but I would like to make the patch to revert the commit bcc43a4b5ed75285aeacf2cf8d9b96d6379fb429 if you don't mind because the WILC1000 in staging still has compile errors. Then, we had better make patch for your concerns. I always appreciate your review and contrib

Re: [PATCH 02/10] staging: fsl-mc: Added generic MSI support for FSL-MC devices

On 2015/10/26 23:49, J. German Rivera wrote: > Created an MSI domain for the fsl-mc bus-- including functions > to create a domain, find a domain, alloc/free domain irqs, and > bus specific overrides for domain and irq_chip ops. > > Signed-off-by: J. German Rivera > --- > drivers/staging/fsl-mc/

Re: [PATCH v2] staging: rtl8188eu: clamp kernel macro used in proc_get_rx_signal

On Mon, Oct 26, 2015 at 11:25:00PM +0700, Ivan Safonov wrote: > To limit the range of integers there is clamp macro. > > Signed-off-by: Ivan Safonov > --- > Changes in v2: > - big patchset splitted into some small independent patches. You didn't tell me that this was a v2 of a specific patch i

Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Clean up the context and sdma macros and move them to a more logical place in > hfi.h > > Signed-off-by: Mitko Haralanov > Signed-off-by: Ira Weiny > --- > drivers/staging/rdma/hfi1/hfi.h | 22 +++

Re: [PATCH v3 14/23] staging/rdma/hfi1: Implement Expected Receive TID caching

On Mon, Oct 26, 2015 at 10:28:40AM -0400, ira.we...@intel.com wrote: > From: Mitko Haralanov > > Expected receives work by user-space libraries (PSM) calling into the > driver with information about the user's receive buffer and have the driver > DMA-map that buffer and program the HFI to receive

[PATCH V4] staging: wilc1000: wilc_msgqueue.c : remove goto statement

From: Leo Kim This patch removes goto statement and moves the spin lock position. If a memory allocation fails, directly returns an error. The spin lock actually protects the pHandle. Therefore, call spin lock just before pHandle is used. Signee-eff-by: Lee Kim Signed-off-by: Tony Cho Signed-o

Re: [PATCH v3 19/23] staging/rdma/hfi: modify workqueue for parallelism

On Mon, Oct 26, 2015 at 10:28:45AM -0400, ira.we...@intel.com wrote: > From: Mike Marciniszyn > > The workqueue is currently single threaded per port which for a small number > of > SDMA engines is ok. > > For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in > parallel.

Re: [PATCH v3 23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote: > From: Jubin John > > Signed-off-by: Jubin John > Signed-off-by: Ira Weiny > --- > drivers/staging/rdma/hfi1/common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rdma/hfi1/common

[PATCH] staging: wilc1000: fix build error on SPI

wilc_netdev_init function has parameters to pass but no argument is passed when bus type SPI is selected. Which causes build error. This patch passes argument &wilc to the function wilc_netdev_init. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 6 +- 1 file changed, 5 i

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > wrote: > Please follow standard naming convention for the patches. > It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. Does this matter? It's in a thread so it sorts fin

[PATCH V2 02/27] staging: wilc1000: isr_bh_routine: use wilc instead of g_linux_wlan

Use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 324cc57..

[PATCH V2 03/27] staging: wilc1000: deinit_irq: use wilc instead of g_linux_wlan

This patch changes function parameter linux_wlan_t nic with net_dev dev and use netdev private data member wilc instead of nic and g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a

[PATCH V2 09/27] staging: wilc1000: wlan_initialize_threads: change argument with net_device

This patch changes function argument with net_device and use netdev private data member wilc instead of g_linux_wlan. And there are assignment code with different value continuously. Take last code. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 21 - 1 f

[PATCH V2 01/27] staging: wicl1000: isr_uh_routine: use netdev private wilc

Use netdev private member wilc instead of g_linux_wlan and change argument wilc with dev in the function request_threaded_irq to pass back to handler the function isr_uh_routine. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH V2 06/27] staging: wilc1000: wilc_wlan_handle_rxq: add new argument and use wilc

This patch adds new argument struct wilc and use it instead of g_linux_wlan. Pass wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/dri

[PATCH V2 11/27] staging: wilc1000: wilc_wlan_handle_txq: add argument and use wilc

This patch adds argument net_device dev and use netdev private data memeber wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 11 --- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 3 files ch

[PATCH V2 10/27] staging: wilc1000: linux_wlan_txq_task: use wilc instead of g_linux_wlan

Pass argument dev instead of wilc from kthread_run and use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/staging/

[PATCH V2 08/27] staging: wilc1000: linux_wlan_set_bssid: use wilc instead of g_linux_wlan

This patch uses netdev private data memeber wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan

[PATCH V2 04/27] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It is void type for now because wilc_wlan.c was implemented platform independently at the beginning (linux_wlan.c is implementation of LINUX part), so the header file which defines struct wilc cannot be included at t

[PATCH V2 05/27] staging: wilc1000: wilc_wlan_handle_isr_ext: add argument struct wilc

This patch adds argument struct wilc and pass wilc to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index be6f631.

[PATCH V2 07/27] staging: wilc1000: linux_wlan_mac_indicate: add argument and use wilc

This patch adds argument wilc and pass the function wilc. Use wilc instead of g_linux_wlan and pd. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 13 ++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c |

[PATCH V2 14/27] staging: wilc1000: wlan_deinit_locks: change argument wilc with net_device

This patch changes argument wilc with net_device and use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH V2 16/27] staging: wilc1000: wlan_deinitialize_threads: change argument and use wilc

This patch changes function parameter type struct wilc with struct net_device and use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff

[PATCH V2 17/27] staging: wilc1000: mac_ioctl: use private data instead of g_linux_wlan

Use netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index b6244f93..bd9

[PATCH V2 12/27] staging: wilc1000: wilc_wlan_txq_filter_dup_tcp_ack: add argument and use wilc

This patch add argument net_device dev and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH V2 13/27] staging: wilc1000: host_int_init: add argument net_device

This patch add argument net_device and pass netdev private data member wilc to kthread_run. Pass net_device to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 11 +-- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/

[PATCH V2 15/27] staging: wilc1000: WILC_WFI_mgmt_rx: add argument wilc and use it

This patch add new argument wilc and use it instead of g_wlan_linux. Declare the function in wilc_wfi_netdevice.h. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 10 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + drivers/staging/wilc1000/wilc_wlan.c

[PATCH V2 19/27] staging: wilc1000: wilc_wlan_rxq_remove: add argument wilc and use it

This patch adds new argument struct wilc and use it instead of g_linux_wlan. Pass wilc to wilc_wlan_rxq_remove. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan

[PATCH V2 18/27] staging: wilc1000: wilc_wlan_cleanup: add new argument struct net_device

This patch adds new function argument net_device and pass dev to the functions. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

[PATCH V2 21/27] staging: wilc1000: GetIfHandler: add argument struct wilc and use it

This patch adds new argument struct wilc and use it instead of g_linux_wlan. And also pass wilc to the function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/l

[PATCH V2 26/27] staging: wilc1000: wilc_wlan_txq_add_net_pkt: add argument struct net_device

This patch add new argument struct net_device *dev and pass net_device to wilc_wlan_txq_add_net_pkt. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.h | 4 ++-- 3 files changed, 6 inse

[PATCH V2 23/27] staging: wilc1000: wilc_wlan_rxq_add: add argument wilc and use it

This patch adds new argument struct wilc and use it instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c i

[PATCH V2 27/27] staging: wilc1000: tcp_process: add argument dev and use private data

This patch adds new argument net_device and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/d

[PATCH V2 24/27] staging: wilc1000: wilc_wlan_txq_get_next: add argument wilc

This patch adds new argument struct wilc and use wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.

[PATCH V2 22/27] staging: wilc1000: Set_machw_change_vir_if: add argument struct net_device

Add new argument net_device and use netdev private data member wilc instead of g_linux_wlan. Pass argument dev to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ drivers/

[PATCH V2 25/27] staging: wilc1000: mac_xmit: use netdev private wilc instead of g_linux_wlan

This patch uses netdev private data member wilc instead of g_linux_wlan. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c in

[PATCH V2 20/27] staging: wilc1000: frmw_to_linux: add argument struct wilc

This patch adds new argument struct wilc and use it instead of g_linux_wlan. Pass argument wilc to the function as well. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter wrote: > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani >> wrote: >> Please follow standard naming convention for the patches. >> It should be [PATCH v2 1/4] and not [PATCH

Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path

On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote: > -error_cleanup_open: > +dprc_scan_container_error: > (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle); The error label was better in the original code. A "goto error_cleanup_open", that tells you what the goto does. "

Re: [PATCH] staging: rtl8188eu: fixed width data types replaced by int

On Tue, Oct 27, 2015 at 12:04:12AM +0700, Ivan Safonov wrote: > There is no need to use fixed width data types. > True enough, this patch is fine. But we use u32 for "unsigned int" in many places just because it is shorter to type. Don't do a wholesale changing of these types. There should alwa

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: > On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter > wrote: > > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: > >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani > >> wrote: > >> Please follow standard nam

[PATCH 4/8] staging: wilc1000: rename u8WepKeylen in host_int_add_wep_key_bss_sta

This patch changes u8WepKeylen to len that is third argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions

[PATCH 1/8] staging: wilc1000: fix return type of host_int_add_wep_key_bss_sta

This patch changes return type of host_int_add_wep_key_bss_sta from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim --- drivers/

[PATCH 3/8] staging: wilc1000: rename pu8WepKey in host_int_add_wep_key_bss_sta

This patch changes pu8WepKey to key that is second argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 2/8] staging: wilc1000: fix parameter name of function declaration

This patch changes struct host_if_drv of host_int_add_wep_key_bss_sta function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface

[PATCH 6/8] staging: wilc1000: replace kmalloc/memcpy with kmemdup

This patch replaces kmalloc followed by memcpy with kmemdup. It is also added error checking of kmemdup. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 5/8] staging: wilc1000: rename u8Keyidx in host_int_add_wep_key_bss_sta

This patch changes u8Keyidx to index that is fourth argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 8/8] staging: wilc1000: remove multiple blank lines

This patch removes multiple blank lines found by checkpatch. CHECK: Please don't use multiple blank lines FILE: drivers/staging/wilc1000/host_interface.c:3175: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/st

[PATCH 7/8] staging: wilc1000: fix line over 80 characters

This patch fixes line over 80 characters found by checkpatch. WARNING: line over 80 characters FILE: drivers/staging/wilc1000/host_interface.h:408: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

Re: [PATCH V2 11/27] staging: wilc1000: wilc_wlan_handle_txq: add argument and use wilc

Hi Glen, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Glen-Lee/staging-wicl1000-isr_uh_routine-use-netdev-private-wilc/20151027-173115 config:

[PATCH v2] Staging: android: uapi: fixed comment block coding style error in ion.h

Fixed checkpatch.pl warning about comment block coding style. Signed-off-by: Dzonatans Melgalvis http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2 13/27] staging: wilc1000: host_int_init: add argument net_device

Hi Glen, [auto build test ERROR on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Glen-Lee/staging-wicl1000-isr_uh_routine-use-netdev-private-wilc/20151027-173115 config:

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On October 27, 2015 4:40:42 PM GMT+05:30, Dan Carpenter wrote: >On Tue, Oct 27, 2015 at 11:45:18AM +0200, Leon Romanovsky wrote: >> On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter >> wrote: >> > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> >> On Sun, Oct 25, 2015 at 12:1

[PATCH] staging: board: Set PM domain before probe

PM domains shouldn't be modified after a device is probed, so set it before device registration to be sure of that. In the future the PM domain pointer will be set through a setter that will WARN if the device has been probed already. Signed-off-by: Tomeu Vizoso Cc: Geert Uytterhoeven --- driv

Re: [PATCH] staging: board: Set PM domain before probe

On Tue, Oct 27, 2015 at 3:27 PM, Tomeu Vizoso wrote: > PM domains shouldn't be modified after a device is probed, so set it > before device registration to be sure of that. > > In the future the PM domain pointer will be set through a setter that > will WARN if the device has been probed already.

[PATCH v2 05/20] staging: rtl8188eu: ternary operator (?:) replaced by min_t kernel macro

min_t macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - min replaced by mit_t. drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 3 fi

[PATCH v2 08/20] staging: rtl8188eu: unused MEM_ALIGNMENT_OFFSET and MEM_ALIGNMENT_PADDING macros removed

This patch removes unused MEM_ALIGNMENT_OFFSET and MEM_ALIGNMENT_PADDING macros from include/basic_types.h. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/include/basic_types.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH v2 17/20] staging: rtl8188eu: checkpatch fixes: line over 80 characters splited into two parts

This is checkpatch fixes for hal/bb_cfg.c file: line over 80 characters. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/d

[PATCH v2 03/20] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

min (or max) kernel macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 6 ++ drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++-- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 2 +-

[PATCH v2 18/20] staging: rtl8188eu: checkpatch fixes: 'Avoid CamelCase' in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: Avoid CamelCase. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/s

[PATCH v2 02/20] staging: rtl8188eu: clamp kernel macro used in proc_get_rx_signal

To limit the range of integers there is clamp macro. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/core/rtw_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c b/drivers/staging/rtl8188e

[PATCH v2 09/20] staging: rtl8188eu: unused MIN macro removed

This patch removes unused MIN macro from include/rtw_security.h. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/include/rtw_security.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h b/drivers/staging/

[PATCH v2 10/20] staging: rtl8188eu: while loop replaced by for loop in rtw_restruct_wmm_ie

This patch replaces while loop with for loop, because the initial condition and the increment clearly and briefly defined for this loop. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(

[PATCH v2 16/20] staging: rtl8188eu: checkpatch fixes: alignment should match open parenthesis

This is checkpatch fixes for hal/bb_cfg.c file: alignment should match open parenthesis. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c

[PATCH v2 04/20] staging: rtl8188eu: ternary operator (?:) replaced by min_t kernel macro

min_t macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- Changes in v2: - min replaced by mit_t. drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++--

[PATCH v2 00/20] staging: rtl8188eu: code cleanups

Kernel macros used, unnecessary macro removed, some checkpatch fixes performed and other changes added. --- Changes in v2: - patch 21 subject corrected. - patch 15 (staging: rtl8188eu: BITn macro replaced by BIT(n) in hal/bb_cfg.c) removed. It is no longer relevant. - min replaced by mit_

[PATCH v2 01/20] staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro

ARRAY_SIZE shorter and more difficult to create bugs. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/mac_cfg.c| 2 +- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 3 files changed,

[PATCH v2 06/20] staging: rtl8188eu: abs kernel macro used in simularity_compare function

abs macro is useful for determining the difference between the two integers. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/

[PATCH v2 15/20] staging: rtl8188eu: checkpatch fixes: unnecessary parentheses removed in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: unnecessary parentheses around . Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c

[PATCH v2 14/20] staging: rtl8188eu: checkpatch fixes: spaces preferred around that '|' in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: spaces preferred around that '|'. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drive

[PATCH v2 13/20] staging: rtl8188eu: operator = replaced by += in loop increment

x = x + a and x += a equivalen, but second preferably. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +++--- drivers/staging/rtl8188eu/hal/mac_cfg.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH v2 20/20] staging: rtl8188eu: pwrGrpCnt variable removed in store_pwrindex_offset function

This variable used only once in the beginning of the function, it can be removed. Signed-off-by: Ivan Safonov --- Changes in v2: - subject corrected. drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_c

[PATCH v2 11/20] staging: rtl8188eu: increment placed into for loop header

The increment at the end of the cycle, and it can be placed in the loop header. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_

[PATCH v2 07/20] staging: rtl8188eu: unused SUCCESS and FAIL macros removed

This patch removes unused SUCCESS and FAIL macros in include/basic_types.h. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/include/basic_types.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers

[PATCH v2 19/20] staging: rtl8188eu: new variable for hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] in store_pwrindex_offset function

hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] frequent in this function, so it replaced by the power_level_offset new variable. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/bb_cfg.c | 34 ++ 1 file changed, 18 ins

[PATCH v2 12/20] staging: rtl8188eu: occurrence of the 5 GHz code marked

Channel numbers greater than 14 are used here, which are possible only for the 5 GHz frequency. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8188eu/hal/rtl81

[PATCH 01/16] staging: comedi: comedi_test: reformat multi-line comments

Use the preferred style for multi-line comments. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_test.c | 94 ++-- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/dr

[PATCH 02/16] staging: comedi: comedi_test: saturate fake waveform values

While an asynchronous command is running on the analog input subdevice, fake waveform generators are connected to each channel to provide the input voltages that are converted to sample value. Channel 0 is connected to a sawtooth generator, channel 1 is connected to a squarewave generator, and the

[PATCH 04/16] staging: comedi: comedi_test: limit maximum convert_arg

When testing the parameters for setting up an asynchronous command on the AI subdevice, limit the maximum conversion period (`cmd->convert_arg`) so that the number of conversions in a scan (`cmd->scan_end_arg`, same as `cmd->chanlist_len`) multiplied by the conversion period fits within an `unsigne

[PATCH 05/16] staging: comedi: comedi_test: support scan_begin_src == TRIG_FOLLOW

It is quite common for COMEDI subdevices that support commands to support setting `scan_begin_src` to `TRIG_FOLLOW`. This means the next scan begins once all conversions in the current scan are complete. Support the following timing combinations for the AI subdevice: scan_begin_src == TRIG_TIME

[PATCH 00/16] staging: comedi: comedi_test: enhancements

The "comedi_test" module is a driver for a dummy COMEDI device. It has an analog input subdevice and an analog output subdevice. The analog input subdevice supports COMEDI asynchronous acquisition commands using waveform generators to generate the input data for each channel. A kernel timer is u

[PATCH 10/16] staging: comedi: comedi_test: rename waveform members

Rename the members `struct waveform_private` associated with fake waveform generation. The affected members are `uvolt_amplitude` --> `wf_amplitude` (the amplitude of the waveform), `usec_period` --> `wf_period` (the period of the waveform), and `usec_current` --> `wf_current` (the current time wi

[PATCH 13/16] staging: comedi: comedi_test: allow read-back of AO channels

COMEDI drivers often allow the last value written to a channel on an analog output subdevice to be read back via the "insn_read" handler. The "comedi_test" driver does not currently support that. It is a bit special because it loops back the last values written to the channel on the analog output

[PATCH 16/16] staging: comedi: comedi_test: implement commands on AO subdevice

Implement COMEDI asynchronous commands on the fake analog output subdevice. This is useful for testing asynchronous commands in the "write" direction when no real hardware is available. A normal kernel timer is used to drive the command. The new timer expiry function `waveform_ao_timer()` handle

[PATCH 12/16] staging: comedi: comedi_test: use unsigned short for loopback values

The last sample values written to the AO subdevice channels by its "insn_write" handler `waveform_ao_insn_write()` are stored in the member array `ao_loopbacks[]` in the device private data `struct waveform_private`. They can be read back via the "insn_read" handler of the AI subdevice `waveform_a

[PATCH 07/16] staging: comedi: comedi_test: use unsigned int for waveform timing

Use `unsigned int` instead of `unsigned long` to hold the period of the fake waveform generator and the current time within each waveform. The waveform period will be no more than `INT_MAX` and the current time within the waveform (prior to the modulo operation to bring it actually within the wave

[PATCH 03/16] staging: comedi: comedi_test: remove nano_per_micro

The `static const int nano_per_micro` variable is set to 1000, the number of nanoseconds in a microsecond. Remove it and use the `NSEC_PER_USEC` macro from instead. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_test.c | 17 +++-- 1 file changed, 7 insertions(+

[PATCH 06/16] staging: comedi: comedi_test: move modulo operations for waveform

The fake waveform generator functions, `fake_sawtooth()` and `fake_squarewave()`, called from `fake_waveform()`, have a `current_time` parameter which is the time since the start of a waveform period. The parameter value may be greater than the waveform period so they do a modulo operation to brin

[PATCH 08/16] staging: comedi: comedi_test: simplify time since last AI scan

The private data structure `struct waveform_private` currently uses member `last` to remember the time of the last timer interrupt, and the member `usec_remainder` to keep track of how far into a simulated scan the interrupt occurred. Replace these with a single new member `ai_last_scan_time` that

[PATCH 09/16] staging: comedi: comedi_test: rename members for AI commands

Rename the members of `struct waveform_private` that are used to handle AI commands, apart from those members used to control fake waveform generation. The renames are `timer` --> `ai_timer`, `scan_period` --> `ai_scan_period`, and `convert_period` --> `ai_convert_period`. Signed-off-by: Ian Abbo

[PATCH 11/16] staging: comedi: comedi_test: make timer rate similar to scan rate

The asynchronous command handling for the analog input subdevice uses a kernel timer which expires approximately `HZ` times a second. However, it only needs to do anything after each scan period. Set the timer to expire just after the next scan period. Although the timer expiry function `wavefor

[PATCH 15/16] staging: comedi: comedi_test: rename waveform_ai_interrupt()

`waveform_ai_interrupt()` is a timer expiry function used to generate fake waveform data for an analog input subdevice. Rename it to `waveform_ai_timer()`. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 14/16] staging: comedi: comedi_test: handle partial scans in timer routine

For asynchronous command handling on the analog input subdevice, a kernel timer routine is used to generate the fake waveform data. A "scan" consists of a number of conversions separated in time by a conversion period. Successive scans are separated in time by a scan period, which is at least the

RE: [PATCH v3 4/7] PCI: Record an fwnode associated with root PCI buses, optionally

> -Original Message- > From: Jiang Liu [mailto:jiang@linux.intel.com] > Sent: Tuesday, October 27, 2015 12:10 AM > To: Jake Oshins ; gre...@linuxfoundation.org; KY > Srinivasan ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > vkuzn...

[PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

This patch is to the host_interface.c that fixes up following warning by checkpatch: -prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/ho

Re: [PATCH v2 01/20] staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro

2015-10-27 13:13 GMT-02:00 Ivan Safonov : > ARRAY_SIZE shorter and more difficult to create bugs. > > Signed-off-by: Ivan Safonov You tested ? Albino ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

Re: [PATCH v2 01/20] staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro

On 10/28/2015 12:05 AM, Albino B Neto wrote: 2015-10-27 13:13 GMT-02:00 Ivan Safonov : ARRAY_SIZE shorter and more difficult to create bugs. Signed-off-by: Ivan Safonov You tested ? Albino Not tested. Is this transformation can to break the code? ___

  1   2   >