Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 15:57, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote: This patch add new argument wilc to wilc_handle_isr and pass wilc to the function. It's not important enough to redo the patch but why are we sometimes using "wl" and sometimes "wilc"? We

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-23 Thread Tony Cho
Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and also

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Dan Carpenter
On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: > In addition, the function parameter names will be wilc > for the variable of struct wilc. > > The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local variable then it is wl? That seems like an

Re: [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr

2015-10-23 Thread Tony Cho
On 2015년 10월 23일 16:52, Dan Carpenter wrote: On Fri, Oct 23, 2015 at 04:36:07PM +0900, Tony Cho wrote: In addition, the function parameter names will be wilc for the variable of struct wilc. The "wl" is local variable naming as well. So if it is a parameter it is wilc but if it is a local va

[PATCH] staging: comedi: fix extreme case of comedi_nsamples_left()

2015-10-23 Thread Ian Abbott
`comedi_nsamples_left(s, nsamples)` returns the number of samples remaining to complete an asynchronous command or the passed in `nsamples`, whichever is lower. However, it goes wrong in the extreme case of setting the `nsamples` parameter to `UINT_MAX` when the number of conversions per "scan" (`

staging/rtl8723au should be removed

2015-10-23 Thread Xose Vazquez Perez
Hi, Support for RTL8723AU devices was added to wireless-drivers-next.git recently: https://marc.info/?l=linux-wireless&m=144541406318463 commit: https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h?id=26f1fad29a

Re: staging/rtl8723au should be removed

2015-10-23 Thread Larry Finger
On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: Hi, Support for RTL8723AU devices was added to wireless-drivers-next.git recently: https://marc.info/?l=linux-wireless&m=144541406318463 commit: https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/drivers/net/wir

Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-23 Thread Dilger, Andreas
On 2015/10/22, 22:30, "Nilesh Kokane" wrote: >Fixed- Return of an errno should typically be negative (ie: return >-EAGAIN) Nak. Please do not change these function return values. They are converted as necessary by the callers before returning to userspace, but allow the code to distinguish betwe

Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-23 Thread Nilesh Kokane
On Fri, Oct 23, 2015 at 5:10 PM, Dilger, Andreas wrote: > On 2015/10/22, 22:30, "Nilesh Kokane" wrote: >>Fixed- Return of an errno should typically be negative (ie: return >>-EAGAIN) > > Nak. Please do not change these function return values. They are > converted as necessary by the callers befo

Re: staging/rtl8723au should be removed

2015-10-23 Thread Jes Sorensen
Larry Finger writes: > On 10/23/2015 05:44 AM, Xose Vazquez Perez wrote: >> Hi, >> >> Support for RTL8723AU devices was added to >> wireless-drivers-next.git recently: >> https://marc.info/?l=linux-wireless&m=144541406318463 >> commit: >> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless

[PATCH 3/5] staging: sm750fb: remove unused methods from lynx_share

2015-10-23 Thread Mike Rapoport
The suspend and resume methods in lynx_share are not implemented and never set. Remove them. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 6 -- drivers/staging/sm750fb/sm750.h | 3 --- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drive

[PATCH 4/5] staging: sm750fb: replace lynx_crtc methods with function calls

2015-10-23 Thread Mike Rapoport
The methods in lynx_crtc always use the same implementation and there is no point to use redirection rather than direct function call. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 12 drivers/staging/sm750fb/sm750.h | 10 -- 2 files changed, 4 insertion

[PATCH 1/5] staging: sm750fb: remove defintion of offsetof

2015-10-23 Thread Mike Rapoport
There is no need to redefine offsetof Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 52fe945..e74a3e1 100644 --- a/drivers/staging/sm750fb/sm750.h +++

[PATCH 2/5] staging: sm750fb: remove ancient kernel support

2015-10-23 Thread Mike Rapoport
Remove the code that should be compiled for ancient kernel versions together with controlling '#if LINUX_VERSION_CODE' conditionals Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_hw.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers

[PATCH 5/5] staging: sm750fb: use direct call to hw_sm750_output_setMode

2015-10-23 Thread Mike Rapoport
The proc_setMode method in lynx_output always uses the same implementation and there is no point to use redirection rather than direct function call. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 4 +--- drivers/staging/sm750fb/sm750.h | 4 2 files changed, 1 insertion(

[PATCH 0/5] staging: sm750fb: misc cleanups

2015-10-23 Thread Mike Rapoport
Hi, These patches remove some dead code and replace several methods in lynx_ctrc and lynx_output with direct function calls. Mike Rapoport (5): staging: sm750fb: remove defintion of offsetof staging: sm750fb: remove ancient kernel support staging: sm750fb: remove unused methods from lynx_sh

RE: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-23 Thread Simmons, James A.
>Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) > >Signed-off-by: Nilesh Kokane >--- > drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) Bad idea. I also made this mistake and it broke LNet rea

Re: [PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

2015-10-23 Thread Jes Sorensen
Luis de Bethencourt writes: > For loop is outside of the else branch of the above conditional statement. > Fixing misleading indentation. > > Fix a smatch warning: > drivers/staging/rtl8723au/core/rtw_wlan_util.c:528 > WMMOnAssocRsp23a() warn: curly braces intended? > > Signed-off-by: Luis de Beth

[PATCH 0/5] staging:lustre: split kernel comm between user and kernel

2015-10-23 Thread James Simmons
The kernel communication code used for HSM and changelog is entangled. Move the user space bits into the liblustreapi. This will also help for a possible relicensing. The kernel portion is also moved from libcfs to obdclass. The original libcfs_kernelcomm.h header is split into three parts: * l

[PATCH] staging:lustre: Prevent duplicate CT registrations

2015-10-23 Thread James Simmons
From: Henri Doreau Associate copytool registration to a given MDC import so that multiple mounts of the same filesystem do not lead to having the copytool registered multiple time. Signed-off-by: Henri Doreau Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3882 Reviewed-on: http://review.wh

[PATCH] staging:lustre: move kernel_user_comm.c from libcfs to lustre

2015-10-23 Thread James Simmons
From: frank zago Move the kernel portion from libcfs to obdclass. This code is only used by lustre. This is broken out of the original patch 14270. The part covered by this change is as follows: The original code in kernel_user_comm.c is split into two parts: * obdclass/kernelcomm.c for the k

[PATCH 4/5] staging:lustre: split kernel comm between user and kernel

2015-10-23 Thread James Simmons
From: frank zago Split the kernel comm header in libcfs into two new headers to handle both kernel space and user space for the lustre layer. This is broken out of the original patch 14270. The part covered by this change is as follows: The original libcfs_kernelcomm.h header is split into three

[PATCH 1/5] staging:lustre: kg_sem semaphore handling is incorrectly

2015-10-23 Thread James Simmons
During the removal of the cfs wrappers the kg_sem semaphore was handled incorrectly. We need to take a write lock when writing data to the kkuc_groups. The libcfs_kkuc_group_foreach needs to only take a read lock. This makes use match the OpenSFS development branch. Signed-off-by: James Simmons -

[PATCH 5/5] staging:lustre: Update license and copyright for kernel comm

2015-10-23 Thread James Simmons
From: frank zago Point to the right place for GNU license. Update Intel copyright. Update Nathan Rutmans email address. This was broken out of the original patch 14270. Signed-off-by: frank zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/14

[GIT PULL] Staging driver fixes for 4.3-rc7

2015-10-23 Thread Greg KH
The following changes since commit 25cb62b76430a91cc6195f902e61c2cb84ade622: Linux 4.3-rc5 (2015-10-11 11:09:45 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.3-rc7 for you to fetch changes up to 4301de3b0ac46

[PATCH] staging: most: hdm-usb: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -

[PATCH 1/4] staging: rdma: ipath: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -

[PATCH 2/4] staging: rdma: ipath: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -

[PATCH 3/4] staging: rdma: ipath: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. Signed-off-by: Muhammad Falak R Wani --- drivers/staging/rdma/ipath/ipath_sdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_sdma

[PATCH 4/4] staging: rdma: ipath: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. Signed-off-by: Muhammad Falak R Wani --- drivers/staging/rdma/ipath/ipath_verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_verb

[PATCH 1/3] staging: rdma: hfi1: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -

[PATCH 2/3] staging: rdma: hfi1: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -

[PATCH 3/3] staging: rdma: hfi1: Use setup_timer

2015-10-23 Thread Muhammad Falak R Wani
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani -