Hi Arnd Bergmann,
When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because
CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs.
Can you consider this patch?
Thanks,
Tony.
On 2015년 10월 17일 05:45, Arnd Bergmann wrote:
My first attempt to fix the
On Sat, Oct 17, 2015 at 1:29 AM, Arnd Bergmann wrote:
> The iio dummy code was recently changed to use irq_work_queue, but
> that code is compiled into the kernel only if IRQ_WORK is set, so
> we can get a link error here:
>
> drivers/built-in.o: In function `iio_evgen_poke':
> (.text+0x208a04): u
Hi,
On 19 October 2015 at 00:04, Martyn Welch wrote:
> On 18/10/15 18:53, Dmitry Kalinkin wrote:
[...]
>> Other drives meaning vme_pio, I don't see any others. All this time
>> we are discussing how many GE PIO boards one can plug into a crate
>> with or without vme_user. Most of people have zero
From: Leo Kim
This patch uses goto statement to separet error conditionals into release_lock
and mem_free in wilc_mq_send. If unexpected errors happen, this function
cannot up the semaphore, otherwise, if no errors, the semaphore should be
released, but freeing memory is not needed in this functi
> On 2015/10/18, at 18:04, Martyn Welch wrote:
>
>
>
> On 18/10/15 18:53, Dmitry Kalinkin wrote:
>> On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch wrote:
>>>
>>> On 11/10/15 01:13, Dmitry Kalinkin wrote:
This introduces a new dma device that provides a single ioctl call that
provid
From: Leo Kim
This patch renames variable s32Error to result
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 781 ++
1 file changed, 370 insertions(+), 411 deletions(-)
diff --git
From: Leo Kim
This patch moves the variable 'FALSE_FRMWR_CHANNEL' to where local definitions
are.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_inte
From: Leo Kim
This patch removes an unnecessary variable use for the errors and
returns errors directly without a result variable.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 28 +---
1 file changed, 9 insertions(+), 1
From: Leo Kim
This patch moves static variable clients_count to around where the local
variables are togther.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc
This series of patches are resent after some of 40 patches are rebased.
Leo Kim (6):
staging: wilc1000: rename variable s32Error
staging: wilc1000: move variable clients_count
staging: wilc1000: move variable FALSE_FRMWR_CHANNEL
staging: wilc1000: fixes unnecessary variable replacement
s
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 153 +++---
1 file changed, 78 insertions(+), 75 deletions(-)
From: Leo Kim
This patch fixes the checks reported by checkpatch.pl
for comparison to NULL could be written.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 181 ++
1 file changed, 87 insertions(+), 94 deletions(-)
di
On Monday 19 October 2015 16:54:23 Tony Cho wrote:
> Hi Arnd Bergmann,
>
> When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because
> CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211
> APIs.
>
> Can you consider this patch?
Ah, you are right. I see
Olaf Hering writes:
> The Backup integration service on WS2012 has appearently trouble to
> negotiate with a guest which does not support the provided util version.
> Currently the VSS driver supports only version 5/0. A WS2012 offers only
> version 1/x and 3/x, and vmbus_prep_negotiate_resp corr
Hi,
On 19 October 2015 at 11:19, Dmitry Kalinkin wrote:
[...]
> There is no optimal solution. In vanilla kernel you have just two drivers. You
> can either have 8 GE PIO2 boards or 4 GE PIO2 boards and any amount of boards
> potentially accessible through vme_user. None of this provides for the c
On Monday 19 October 2015 11:39:31 Arnd Bergmann wrote:
> On Monday 19 October 2015 16:54:23 Tony Cho wrote:
> > Hi Arnd Bergmann,
> >
> > When I apply this patch, I cannot make WILC1000 module (wilc1000.ko)
> > because CONFIG_WILC1000 is y and also I can see some link errors for the
> > cfg8021
Estimado usuario Webmail,
Lamentamos tener que anunciarles que vamos a hacer algo importante
el mantenimiento de nuestro sistema de Webmail. Durante este proceso, es
posible que tienen problemas de inicio de sesión en sesión en su cuenta en
línea, para evitar esto, usted tendrá que confirmar s
On Sun, Oct 18, 2015 at 08:35:04PM +0100, Luis de Bethencourt wrote:
> Boolean tests do not need explicit comparison to true or false.
>
> Signed-off-by: Luis de Bethencourt
> ---
> drivers/staging/rtl8712/os_intfs.c| 4 +-
> drivers/staging/rtl8712/rtl8712_cmd.c | 9 +-
>
On Mon, Oct 19, 2015 at 06:03:15PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch uses goto statement to separet error conditionals into release_lock
> and mem_free in wilc_mq_send. If unexpected errors happen, this function
> cannot up the semaphore, otherwise, if no errors, the semaphore
On 10/15/2015 08:55 PM, Drokin, Oleg wrote:
> Yes, it's still accurate from 10.000 ft view.
>
> If you need some more detailed ideas, here's my current list of stuff:
>
> getting rid of remaining lustre allocation macros: OBD_SLAB_ALLOC/FREE and
> friends much like we got rid of
> OBD_ALLOC/F
Greg,
On Fri, Oct 16, 2015 at 10:04:57PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 11:27:54AM +0530, Sudip Mukherjee wrote:
> > > > >
> > > > > The code from ddk750_dvi and ddk750_sii164 is never called from the
> > > > > rest
> > > > > of the driver, the USE_DVICHIP is defined
On Mon, Oct 19, 2015 at 10:32:10AM +0900, Tony Cho wrote:
>
>
> On 2015년 10월 17일 13:59, Greg KH wrote:
> >On Fri, Oct 16, 2015 at 01:37:31PM +0900, Tony Cho wrote:
> >>From: Leo Kim
> >>
> >>This patch renames ssidLen of struct join_bss_param to ssid_len
> >>to avoid CamelCase naming convention.
On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger wrote:
> On 10/18/2015 09:00 PM, Greg KH wrote:
>>
>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote:
>>>
>>> One more thing I would like suggestion how can start switching this
>>> driver to LIB80211 ,MAC80211 ? Which is the first file I s
On Friday, October 16, 2015 11:21 PM, Greg KH wrote:
> On Tue, Oct 13, 2015 at 05:48:03PM -0700, H Hartley Sweeten wrote:
>> Clarify the interrupt handler by splitting the analog input handling
>> into a new function.
>>
>> Signed-off-by: H Hartley Sweeten
>> Reviewed-by: Ian Abbott
>> ---
>> d
From: Dean Luick
The latest version of the 8051 firmware will wait longer
when bringing the link down. Extend the driver's timeout
to go with that.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c | 2 +-
1 file changed,
From: Easwar Hariharan
The QSFP interface code has been running without issues and the flag is
never set to off. This patch removes the QSFP_ENABLED bit from HFI1_CAP.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Easwar Hariharan
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c
From: Mike Marciniszyn
This additional call is a regression from
qib. For small messages the progress routine
always builds one and clears out the ahg
state when the queue has gone to empty which
is the predominant case for small messages.
Inline the routine to mitigate the call and move
the ro
There was a merge conflict with the last 7 patches of:
[PATCH 00/45] staging: comedi: cb_pcidas: cleanup driver
Due to commit e4c0c6bc0c3baa6ba8cce4db5568fe9db5ad3c5f
Staging: comedi: Remove unnecessary cast on void pointer
Following are the rebased patches with Ian's Reviewed-by added.
H Hartle
From: Ira Weiny
The following series has bug fixes and updates to the staging hfi1 driver.
Arthur Kepner (1):
staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs - UC, RC
Caz Yokoyama (1):
staging/rdma/hfi1: Reset firmware instead of reloading Sbus
Dean Luick (4):
staging/rdma/h
From: Easwar Hariharan
The ASIC registers were not reset on FLR, and the code to
protect the ASIC block against multiple initializations by
peer HFIs did not extend to multiple ASICs in a system. This
patch addresses this gap.
Reviewed-by: Dean Luick
Signed-off-by: Easwar Hariharan
Signed-off-
From: Niranjana Vishwanathapura
When the number of scatter gather elements in the request is more
that the number of per packet descriptors supported by the hardware,
allocate and coalesce the extra scatter gather elements into a single
buffer. The last descriptor is reserved and used for this co
From: Dean Luick
When the receive interrupt is threaded, the packet processing path is no longer
guaranteed to have IRQs disabled. Add irqsaves where needed on several locks
in the packet processing path. Anything that did not have an obvious, "close"
irqsave in its caller is a candidate.
Revi
From: Dean Luick
When under heavy load, the send handler can run too long without allowing other
tasks to run. Add a conditional resched to break this up.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/chip.c | 10 ++
From: Easwar Hariharan
Using fw_sbus_load to control SBus firmware load doesn't scale across multiple
HFI1 cards in a single system. This patch ensures that the SBus firmware is
loaded once per ASIC.
Reviewed-by: Dean Luick
Reviewed-by: Dennis Dalessandro
Signed-off-by: Easwar Hariharan
Signe
From: Dean Luick
When under heavy load, the receive interrupt handler can run too long with IRQs
disabled. Add a mixed-mode threading scheme. Initially process packets in the
handler for quick responses (latency). If there are too many packets to
process move to a thread to continue (bandwidth
From: Easwar Hariharan
The DC firmware overwrites the enable_lane_tx register and does not update it
on a host request to go to Poll. This causes an infinite loop through the LNI
state machine if a link width downgrade occurs. This patch re-sets the
enable_lane_tx register to all 4 lanes.
Review
From: Mitko Haralanov
User SDMA keeps track of progress into the submitted IO vectors by tracking an
offset into the vectors when packets are submitted. This offset is updated
after a successful submission of a txreq to the SDMA engine.
The same offset was used when determining whether an IO vec
From: Arthur Kepner
(This patch adds RC, and UC processing based on commit 48c479f.)
To more rapidly respond to Explicit Congestion Notifications,
prescan the receive queue, and process FECNs, and BECNs first.
When a UC, or RC packet containing a FECN, or BECN is found,
immediately react to the
From: Mike Marciniszyn
The workqueue is currently single threaded per port which for a small number of
SDMA engines is ok.
For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in
parallel.
This patch:
- Converts to use alloc_workqueue
- Changes the workqueue limit from 1 to
From: Mitko Haralanov
Expected receives work by user-space libraries (PSM) calling into the driver
with information about the user's receive buffer and have the driver DMA-map
that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driv
From: Niranjana Vishwanathapura
Use NULL instead of 0 for pointer argument to fix the sparse error.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Reviewed-by: Dennis Dalessandro
Signed-off-by: Niranjana Vishwanathapura
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/sdm
The comedi core expects (*insn_write) functions to write insn->n
data values to the hardware. Fix this function to work like the
core expects.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++
1 file
From: Jareer Abdel-Qader
Driver does not verify userid for shared context assignments, allowing
malicious user access.
Reviewed by: Mike Marciniszyn
Signed-off-by: Jareer H Abdel-Qader
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 1 +
1 file changed, 1 insertion(+)
di
The analog output and analog input interrupts are currently cleared
as they are handled. Refactor the code to gather all the bits needed
to clear the interrupts and do it once at the end of the interrupt
handler.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
--
The comedi core expects (*insn_write) functions to write insn->n
data values to the hardware. Fix this function to work like the
core expects.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++
1 file
This inline function just returns the bits needd to enable
a calibration source. For aethetics, absorb it into the callers.
Sorten the variable name in the private data used to hold the
current calibration source.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
-
From: Jubin John
The name used to create the verbs txreq cache was not qualified with the unit
number. This causes a panic when destroying the cache on a dual HFI systems.
Create a unique name with the unit number with this patch
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
Signed-o
From: Vennila Megavannan
Add a module paramter to toggle prescan/Fast ECN Detection.
In addition change the PRESCAN_RXQ Kconfig default to "yes".
Reviewed-by: Arthur Kepner
Reviewed-by: Mike Marciniszyn
Signed-off-by: Vennila Megavannan
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/K
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Mike Marciniszyn
Add additional rc traces to aid in debugging rc retry logic.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/rc.c| 4
drivers/staging/rdma/hfi1/trace.c | 4 ++--
drivers/staging/rdma/hfi1
From: Caz Yokoyama
Reset firmware instead of reloading Sbus firmware if it's already done for this
ASIC. To work around thermal polling problem in firmware, don't reload Sbus
firmware, instead, reset the firmware on the initialization of the second HFI.
Reviewed-by: Easwar Hariharan
Reviewed-b
The ao (*cancel) function does not need commented.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/com
From: Jubin John
Signed-off-by: Jubin John
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/common.h
b/drivers/staging/rdma/hfi1/common.h
index 7809093eb55e..5dd92720faae 100644
--- a/
Clarify the interrupt handler by splitting the analog input handling
into a new function.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 80 ++
1 file changed, 47 insertions(+), 33 del
From: Vennila Megavannan
This patch increases the timout for packet egress to 500 us and timer
resets to zero if the packet occupancy changes. Also we bounce the link
on time out.
Reviewed-by: Dean Luick
Signed-off-by: Vennila Megavannan
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1
From: Mitko Haralanov
The SDMA engines were configured to generate progrss interrupts every time they
processed N/2 descriptors (where N is the size of the descriptor queue). This
interval was too infrequent, leading to degraded performance.
This commit adds a module parameter, which allows for
On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The following series has bug fixes and updates to the staging hfi1 driver.
Why are you adding new functionality to this driver before it is moved
out of drivers/staging/ ? I _REALLY_ don't like to see tha
On Mon, Oct 19, 2015 at 12:43:39PM -0400, ira.we...@intel.com wrote:
> From: Mitko Haralanov
>
> Expected receives work by user-space libraries (PSM) calling into the driver
> with information about the user's receive buffer and have the driver DMA-map
> that buffer and program the HFI to receive
On Mon, Oct 19, 2015 at 04:34:01PM +, Hartley Sweeten wrote:
> On Friday, October 16, 2015 11:21 PM, Greg KH wrote:
> > On Tue, Oct 13, 2015 at 05:48:03PM -0700, H Hartley Sweeten wrote:
> >> Clarify the interrupt handler by splitting the analog input handling
> >> into a new function.
> >>
>
Rewrite explicit NULL comparison in its simpler form.
@NULL_REPLACE@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Muhammad Falak R Wani
---
drivers/staging/android/ion/ion_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_heap.c
b/dr
Hi,
I initially submitted a patch to remove all the explicit boolean comparisons
in rtl8712. These code changes included two instances where braces needed to be
added to clean the output of checkpatch.pl on this patch.
Mike Rapaport correctly pointed out those changes had to go in a separate
patc
Boolean tests do not need explicit comparison to true or false.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8712/os_intfs.c| 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 9 +-
drivers/staging/rtl8712/rtl8712_efuse.c | 56 -
drivers/staging/rt
Fix all instances of the following checkpatch.pl check:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8712/hal_init.c| 11 +++---
drivers/staging/rtl8712/ieee80211.c | 15 +---
drivers/staging/rtl
Clean up all instances of checkpatch.pl checks:
CHECK: spaces preferred around that '+'
(and other operands)
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8712/ieee80211.c | 21 ++---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.
Rewrite explicit NULL comparison in its simpler form.
@NULL_REPLACE@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Muhammad Falak R Wani
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/
>
> On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > The following series has bug fixes and updates to the staging hfi1 driver.
>
> Why are you adding new functionality to this driver before it is moved out of
> drivers/staging/ ? I _REALLY_ don't
On Mon, Oct 19, 2015 at 06:16:55PM +, Weiny, Ira wrote:
> >
> > On Mon, Oct 19, 2015 at 12:43:24PM -0400, ira.we...@intel.com wrote:
> > > From: Ira Weiny
> > >
> > > The following series has bug fixes and updates to the staging hfi1 driver.
> >
> > Why are you adding new functionality to th
Remove the explicit NULL comparison and rewrite in a compact form.
Signed-off-by: Muhammad Falak R Wani
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet.c
b/drivers/staging/octeon/ethernet.c
index fbbe866..
Remove the explicit NULL comparison and rewrite in a compact form.
Signed-off-by: Muhammad Falak R Wani
---
drivers/staging/octeon/ethernet-tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/staging/octeon/ethernet-tx.c
index
This series cleans up a bit firmware loading code.
I had it stashed for some time, but finally was able to
repackage patches to a "reviewable" format.
It generates one new LONG_LINE warning, but breaking it would
make code less readable (and it's just 1 character).
Series was target tested and
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 3 ++-
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
b/drivers/staging/rtl8192e/
Rename:
codevirtualaddress -> data
buffer_len -> len
packettype -> type
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 17 -
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 3 +--
2 files changed, 9 insertions(+), 11 deletions(-)
d
rtl92e_send_cmd_pkt used hardcoded NORMAL packet type.
As it may be used to send other packet types as well - use
provided packet type instead of defaults.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
Use send_cmd_pkt(dev, type, data , size) order to avoid confusion
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c| 2 +-
3 files changed, 3
rtl92e_send_cmd_packet sends only NORMAL packets, passing
invalid type (even it it's ignored) is confusing.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_d
Add CMDPACKET_FRAG_SIZE macro and use it as fragmentation threshold
in send_cmd_pkt functions.
This makes rt_firmware::cmdpacket_frag_thresold and
rtl92e_init_fw_param() obsolete.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 8 ++--
drivers/st
Drop ugly label as no resource cleanup is needed.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/r
Add function waiting for firmware load/boot;
Remove _rtl92e_is_fw_ready() that is obsolete (can be replaced
with _rtl92e_wait_for_fw().
Signed-off-by: Mateusz Kulikowski
---
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 73 ++
1 file changed, 18 insertions(+), 55 dele
Add support for DESC_PACKET_TYPE_INIT to rtl92e_send_cmd_pkt().
With this generalization, _rtl92e_fw_download_code() may be removed
after slight modification.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 32 +--
1 file changed, 24
Reuse rtl92e_send_cmd_pkt() instead.
Signed-off-by: Mateusz Kulikowski
---
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 56 ++
1 file changed, 3 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl819
rst_opt is always equal to OPT_SYSTEM_RESET in this scope.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl81
rt_fw_blob contains single firmware blob and its size.
Update firmware loading code accordingly.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 19 +--
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.h | 12
2 files chan
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 14 +++---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.h | 2 +-
3 files changed, 12 insertions(+), 12 deletions(-)
diff -
Drop legacy logging system.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_f
Remove endian swap from _rtl92e_fw_download_code(),
this way it can be replaced with _rtl92e_send_cmd_pkt().
Signed-off-by: Mateusz Kulikowski
---
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 25 --
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drive
Add function to request and prepare firmware image.
Signed-off-by: Mateusz Kulikowski
---
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c| 71 --
1 file changed, 39 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers
Clean up the analog input async command support code and the interrupt
handler.
H Hartley Sweeten (10):
staging: comedi: adl_pci9118: TRIG_INT is not vaild for scan_begin_src
staging: comedi: adl_pci9118: remove unnecessary check in check_channel_list()
staging: comedi: adl_pci9118: tidy up
Rename this function to give it namespace associated with the driver.
Currently this function is called by both the AI (*do_cmdtest) and the (*do_cmd)
functions. It really only needs to be called by the (*do_cmdtest) to validate
that the chanlist meets the requirements of the hardware. It's only c
Step 3 of the AI (*do_cmdtest) validates that the cmd->chanlist_len is >= 1. If
it's not the (*do_cmdtest) fails and check_channel_list() is never called. This
This function is also called by the AI (*do_cmd) and the comedi core ensures
that the async command has a valid chanlist. Remove the unnece
This define is only used to initialize the analog input sudevice
'len_chanlist'. Remove the define and just open code the value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 7 +--
1 file changed, 1 insertion(+),
The (*do_cmdtest) in this driver validated the scan_begin_src as being
TRIG_FOLLOW | TRIG_TIMER | TRIG_EXT. The TRIG_INT source is not valid.
Remove the Step 2 mutual compatibility check that makes sure that TRIG_INT
is only used for the start_src or the scan_begin_src.
Signed-off-by: H Hartley S
These defines are not used in the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drivers/staging/c
For aesthetics, remove "interrupt_" from this functions name to shorten
it a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/sta
For aesthetics, rename these functions so it they namespace associated
with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
Rename this function so it has namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/driver
Rename this function so it has namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
For aesthetics, init the dmalen[01] local variables when they are declared.
Use a local variable, 'scan_bytes', for the (devpriv->ai_n_realscanlen << 1)
calculation. For aesthetics and clarification, use comedi_bytes_per_sample()
instead of the '<< 1' shift to calculate the value.
The local varia
From: Ira Weiny
The following are fixes to the hfi1 driver for stability, security, and
performance.
Changes from v1:
Reviewed each patch for new features. Found 2 which fixed congestion
notification in some corner cases but they could be considered
additional features,
From: Mike Marciniszyn
This additional call is a regression from qib. For small messages the progress
routine always builds one and clears out the ahg state when the queue has gone
to empty which is the predominant case for small messages.
Inline the routine to mitigate the call and move the ro
From: Easwar Hariharan
The ASIC registers were not reset on FLR, and the code to
protect the ASIC block against multiple initializations by
peer HFIs did not extend to multiple ASICs in a system. This
patch addresses this gap.
Reviewed-by: Dean Luick
Signed-off-by: Easwar Hariharan
Signed-off-
1 - 100 of 133 matches
Mail list logo
