Hi Glen,
[auto build test ERROR on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-remove-extern-declarations-of-g_linux_wlan/20151014-195239
config: i386-ra
On Fri, Oct 16, 2015 at 10:21:05PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:07:28AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> >
> > Signed-off-by: Aya Mahfouz
> > ---
> > drivers/staging/lustre/include/l
On Fri, Oct 16, 2015 at 10:41:09PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:05:44AM +0200, Aya Mahfouz wrote:
> > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
> > macros. In this case, it is LASSERT. Note that the replacement changes
> > the types involved, because
On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
> > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
> > macros. In this case, it is CDEBUG. Note that the replacement changes
> > the types involved, because t
The code can be much cleaner and readable by simplifying the conditional
statement.
Signed-off-by: Luis de Bethencourt
---
Hi,
Dan Carpenter pointed out that the check needs to be >= and not just > because
ieee->state can change between the two if statements.
Thanks for the review!
Luis
driv
On Sat, 17 Oct 2015, Aya Mahfouz wrote:
> On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
> > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
> > > macros. In this case, it is CDEBUG. Note that the repl
On Sat, Oct 17, 2015 at 12:47:13PM +0200, Julia Lawall wrote:
> On Sat, 17 Oct 2015, Aya Mahfouz wrote:
>
> > On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> > > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
> > > > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with se
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 1:59 AM
> To: Romer, Benjamin M
> Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org; Sell,
> Timothy C
> Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref ref
On Sat, Oct 17, 2015 at 03:04:37PM +, Sell, Timothy C wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Saturday, October 17, 2015 1:59 AM
> > To: Romer, Benjamin M
> > Cc: *S-Par-Maintainer; driverdev-devel@linuxdriverproject.org; Sell,
> > T
On Oct 17, 2015, at 07:23, Aya Mahfouz wrote:
>
>> On Sat, Oct 17, 2015 at 12:47:13PM +0200, Julia Lawall wrote:
>>> On Sat, 17 Oct 2015, Aya Mahfouz wrote:
>>>
On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
>
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 1:16 AM
> To: Rivera Jose-B46482
> Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org; Hamciuc Bogdan-BHAMCIU1; Sharma Bhupesh-B45370;
> ag...@suse.de; Yod
On Oct 16, 2015, at 23:40, Greg KH wrote:
>
>> On Sat, Oct 17, 2015 at 12:06:59AM +0200, Aya Mahfouz wrote:
>> Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
>> macros. In this case, it is CDEBUG. Note that the replacement changes
>> the types involved, because the parameter
Whitespace cleanup-- add missing spaces in column 1 of copyright
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/include/dpcon-cmd.h | 60 +++---
1 file changed, 30 insertions(+)
Changed dev_info() calls to dev_dbg() in
fsl_mc_allocator_probe/fsl_mc_allocator_remove, as they
are useful only for debugging.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +++
This patch series includes the following code cleanup and
bug fixes for the fsl-mc bus driver:
Patch 1: Naming cleanup in fsl_mc-portal_allocate
Patch 2: fsl_mc_io object refactoring
Patch 3: dpmcp opening/closing refactoring
Patch 4: Changed dev_info() calls to dev_dbg()
Patch 5: Changed types of
Before, we were opening and closing a mc_io's dpmcp object
in fsl_mc_portal_reset(), since that was the only function that was
calling dpmcp MC operations. However, it is better for maintainability
to open the dpmcp object when it gets associated with an mc_io object,
and close it when this associa
When initializing the object attributes for the root dprc, the
irq_count was uninitialized. Initialize it to 1.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 inse
The macros were a left-over from a previous implementation
of the dpmcp APIs and are no longer used.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79
Check that resource is not NULL before de-referencing it.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Changed these two fields from 32-bit integers to 16-bit integers in
struct fsl_mc_io, as 32 bits is too much for these fields. This
change does not affect other components since fsl_mc_io is an opaque
type.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-
Each fsl_mc_io object is associated with an fsl_mc_device object
of type "dpmcp" representing the MC portal associated with the
fsl_mc_io object. Before, we were representing this association with
an fsl_mc_resource pointer. To enhance code clarity, it is more
straight forward to use an fsl_mc_devi
mc_adev is a local variable for the allocated dpmcp object.
Renamed mc_adev as dpmcp_dev for clarity.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 14 +++---
1 file chang
Replaced error gotos with direct returns in fsl_mc_allocator_probe()
and fsl_mc_allocator_remove(), since the only error handling done
in those functions is to exit.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3: none
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-alloca
Call fsl_mc_resource_pool_remove_device() only if mc_dev->resource
is not NULL.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +---
1 file changed, 5 insertions(+), 3 deleti
owner needs to be initialized as THIS_MOUDLE.
Signed-off-by: J. German Rivera
---
CHANGE HISTORY
Changes in v3:
- Added missing signed-off-by
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/driv
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 11:42 AM
> To: Sell, Timothy C
> Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par-
> Maintainer
> Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref r
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 1:16 AM
> To: Rivera Jose-B46482
> Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org; Hamciuc Bogdan-BHAMCIU1; Sharma Bhupesh-B45370;
> ag...@suse.de; Yod
On Sat, Oct 17, 2015 at 04:36:44PM +, Jose Rivera wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Saturday, October 17, 2015 1:16 AM
> > To: Rivera Jose-B46482
> > Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux-
> > ker...@vger.kernel.
On Sat, Oct 17, 2015 at 04:34:28PM +, Sell, Timothy C wrote:
> > How can you guarantee it? Please document that somehow, I don't see it
> > here in this patch how that can be true, but maybe I'm not looking close
> > enough...
>
> Sure; I'll add some code comments. Basically they will amount
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 12:51 PM
> To: Sell, Timothy C
> Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par-
> Maintainer
> Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref r
On Sat, Oct 17, 2015 at 05:04:43PM +, Sell, Timothy C wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Saturday, October 17, 2015 12:51 PM
> > To: Sell, Timothy C
> > Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par-
> >
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, October 17, 2015 1:41 PM
> To: Sell, Timothy C
> Cc: Romer, Benjamin M; driverdev-devel@linuxdriverproject.org; *S-Par-
> Maintainer
> Subject: Re: [PATCH 3/9] staging: unisys: visorinput: use kref re
cvm_oct_xaui_open() is trivial and does not need a dedicated file.
Move it to the main file.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/Makefile | 2 --
drivers/staging/octeon/ethernet-xaui.c | 31 ---
drivers/staging/octeon/ethernet.c
Drop redundant poll_now parameter from cvm_oct_common_open.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 2 +-
drivers/staging/octeon/ethernet-sgmii.c | 2 +-
drivers/staging/octeon/ethernet-xaui.c | 2 +-
drivers/staging/octeon/ethernet.c| 5 ++---
driv
Get the initial link status already on open instead of postponing
it to the periodic poll task. This unifies the behaviour with
other interfaces types.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
Refactored mc_send_command() to support two flavors of polling:
- preemptible (for non-atomic portals), which was already supported.
It calls usleep_range() between polling iterations.
- non-preemptible (for atomic portals), which is needed when
mc_send_command() is called with interrupts disab
Changed units for the timeout to wait for completion
of MC command, from jiffies to milliseconds.
Signed-off-by: J. German Rivera
---
Changes in v2:
- Added missing Signed-off-by entry
drivers/staging/fsl-mc/bus/mc-sys.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/
When the same portal is used to call mc_send_command() from two
different threads or a thread and an interrupt handler, serialization
is required, as the MC only supports one outstanding command per MC
portal. Thus, a new command should not be sent to the MC until the
last command sent has been res
This patch series depends on the patch series posted
at http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg999081.html
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Management Complex (MC) command serialization. Locking mechani
Moved wait logic in mc_send_command() to its own function
Signed-off-by: J. German Rivera
---
Changes in v2:
- Added missing Signed-off-by entry
drivers/staging/fsl-mc/bus/mc-sys.c | 50 -
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/driver
_enter_critical_mutex() is a simple call to mutex_lock_interruptible(),
but there is no error handling code for it.
The patch removes wrapper _enter_critical_mutex() and
adds error handling for mutex_lock_interruptible().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-
On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote:
> This introduces a new dma device that provides a single ioctl call that
> provides DMA read and write functionality to the user space.
>
> Signed-off-by: Dmitry Kalinkin
> Cc: Igor Alekseev
> ---
> On 2015/10/17, at 23:52, Greg Kroah-Hartman
> wrote:
>
> On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote:
>> This introduces a new dma device that provides a single ioctl call that
>> provides DMA read and write functionality to the user space.
>>
>> Signed-off-by: Dmitry Kal
On Thu, Oct 08, 2015 at 10:04:27PM -0700, Geliang Tang wrote:
> Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h
> header in ipath_kernel.h, and remove linux/sched.h header from
> ipath_*.c which have included ipath_kernel.h.
That's a lot of different things to be doing all in one pa
On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote:
> On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote:
>> Put constant on the right side of a test.Problem found using checkpatch:
>>
>> Warning:Comparisons should place the constant on the right side of the test
>>
>> Signed-off-by: Punit Va
45 matches
Mail list logo
