[PATCH 2/5] staging: fsl-mc: abstract test for whether a dprc is a root dprc

2015-10-04 Thread itai.katz
From: Itai Katz Instead of relying on assumptions about fields in data structures, abstract the test for whether a dprc is a root dprc into a function. Signed-off-by: Itai Katz --- drivers/staging/fsl-mc/bus/mc-bus.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) di

[PATCH 1/5] staging: fsl-mc: abstract test for existence of fsl-mc bus

2015-10-04 Thread itai.katz
From: Itai Katz Add function to test for existence of an fsl-mc bus instance instead of doing this by looking directly at a field in the bus type struct. Signed-off-by: Itai Katz --- drivers/staging/fsl-mc/bus/mc-bus.c | 13 +++-- drivers/staging/fsl-mc/include/mc.h |2 ++ 2 file

[PATCH 0/5] staging: fsl-mc: multiple root DPRCs

2015-10-04 Thread itai.katz
From: Itai Katz This patch series adds support for supporting multiple root DPRCs, which is an item on the TODO list. (This situation can is possible when assigning multiple DPRCs to KVM virtual machines.) Patch 1 abstracts the test for existence of an fsl-mc bus instance into a function. Patc

[PATCH 3/5] staging: fsl-mc: add function to return pointer to root dprc

2015-10-04 Thread itai.katz
From: Itai Katz To support multiple root dprcs, instead of relying on the dev_root field of the bus type struct, instead create a function to traverse to the root dprc and return a pointer to the device struct Signed-off-by: Itai Katz --- drivers/staging/fsl-mc/bus/mc-bus.c | 38

[PATCH 5/5] staging: fsl-mc: remove references to dev_root

2015-10-04 Thread itai.katz
From: Itai Katz The dev_root field in the bus type struct has been replaced by a new mechanism to identify the root dprc. Remove all references to dev_root. Signed-off-by: Itai Katz --- drivers/staging/fsl-mc/bus/mc-bus.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/stagi

[PATCH 4/5] staging: fsl-mc: add counter to track number of root DPRCs

2015-10-04 Thread itai.katz
From: Itai Katz Add a counter to track the number of root DPRCs. When this counter is greater then 0 it means that at least one root DPRC device exists. Signed-off-by: Itai Katz --- drivers/staging/fsl-mc/bus/mc-bus.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Greg Kroah-Hartman
On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote: > On 10/3/2015 11:55 PM, Martin Kletzander wrote: > >Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. > > Hi Greg, > > Is there a way to signal people/tools that a certain driver parks in staging > on their way **ou

Re: [PATCH 02/11] staging: dgnc: remove multiple blank lines

2015-10-04 Thread Greg Kroah-Hartman
On Sat, Oct 03, 2015 at 08:52:40PM +0530, Sudip Mukherjee wrote: > checkpatch warns us about multiple blank lines which are not needed. > Remove them. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/dgnc/dgnc_driver.c | 10 > drivers/staging/dgnc/dgnc_mgmt.c | 5 > dr

Re: [PATCH 04/10] staging: wilc1000: replace PRINT_ER with pr_err

2015-10-04 Thread Greg KH
On Fri, Oct 02, 2015 at 09:44:50PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_ER with pr_err. > It would be better to use netdev_err, but it cannot use it in this > function, so just use pr_err. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 4 ++-

Re: [PATCH 06/10] staging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num

2015-10-04 Thread Greg KH
On Fri, Oct 02, 2015 at 09:44:52PM +0900, Chaehyun Lim wrote: > This patch replaces hWFIDrv with wfi_drv that is first argument of > host_int_set_mac_chnl_num to avoid camelcase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 6 +++--- > drivers/staging/wilc1

Re: [PATCH 09/10] staging: wilc1000: use pr_err in host_int_wait_msg_queue_idle

2015-10-04 Thread Greg KH
On Fri, Oct 02, 2015 at 09:44:55PM +0900, Chaehyun Lim wrote: > This patch changes PRINT_ER by pr_err. > It would be better to use netdev_err, but it cannot use it in this > function, so just use pr_err. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 2 +- >

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Greg KH
On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: > The spin_lock_irqsave is moved to just beginning of critical section. > This change moves a couple of return statements out of the lock. > > Signed-off-by: Chandra S Gorentla > --- > drivers/staging/wilc1000/wilc_msgqueue.c |

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Greg KH
On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: > - kfree is being called for the members of the queue without >de-queuing them; they are just inserted within this function; >they are supposed to be de-queued and freed in a function >for receiving the queue items >

Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

2015-10-04 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2015 at 08:36:28PM -0400, Jacob Kiefer wrote: > From: Jacob Kiefer > > This patch fixes the following sparse errors: > > > CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c > ... > drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: warning: incorrect type > in assignment

Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

2015-10-04 Thread Greg KH
On Sat, Oct 03, 2015 at 01:09:56PM -0800, mike dupuis wrote: > This is a patch to remove the function ieee80211_ccmp_null(). > This function does nothing and can therefore be safely removed. > > Signed-off-by: Mike Dupuis > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- > 1

Re: [PATCH 04/11] staging: unisys: visorinput: add INPUT to dependent driver list

2015-10-04 Thread Greg KH
On Fri, Oct 02, 2015 at 01:19:18PM -0400, Benjamin Romer wrote: > From: Tim Sell > > Add the renamed driver to the Kconfig. That changelog comment doesn't match up with what you are doing here :( > > Signed-off-by: Tim Sell > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/viso

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Martin Kletzander
On Sun, Oct 04, 2015 at 08:20:09AM +0100, Greg Kroah-Hartman wrote: On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote: On 10/3/2015 11:55 PM, Martin Kletzander wrote: >Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Dan Carpenter
On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: > Aren't you now leaking memory as you aren't freeing pstrMessage and the > buffer on the "normal" return path? It's supposed to. It's a bug fix. I explained to him in the first version that his changelog sucks. regards, dan carpenter __

[staging:staging-testing 1167/1169] drivers/staging/lustre/lustre/obdclass/genops.c:1107:14: warning: 'obd_export_nid2str' defined but not used

2015-10-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: fa9df8e31addd4ae26d8317f166bc09921b3629d commit: 63e9a7485d7a7d7a216f32f9db0b4cc444decab4 [1167/1169] Staging: lustre: obdclass: genops: Declare as static config: i386-randconfig-n0-201540 (attached

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Chandra Gorentla
On Sun, Oct 04, 2015 at 09:43:35AM +0100, Greg KH wrote: > On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: > > The spin_lock_irqsave is moved to just beginning of critical section. > > This change moves a couple of return statements out of the lock. > > > > Signed-off-by: Chand

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Greg KH
On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote: > On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: > > Aren't you now leaking memory as you aren't freeing pstrMessage and the > > buffer on the "normal" return path? > > It's supposed to. It's a bug fix. I explained to him i

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Greg Kroah-Hartman
On Sun, Oct 04, 2015 at 11:05:50AM +0200, Martin Kletzander wrote: > On Sun, Oct 04, 2015 at 08:20:09AM +0100, Greg Kroah-Hartman wrote: > >On Sun, Oct 04, 2015 at 09:47:52AM +0300, Or Gerlitz wrote: > >>On 10/3/2015 11:55 PM, Martin Kletzander wrote: > >>>Get rid of all ELSE_AFTER_BRACE type error

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Greg KH
On Sun, Oct 04, 2015 at 03:37:13PM +0530, Chandra Gorentla wrote: > On Sun, Oct 04, 2015 at 09:43:35AM +0100, Greg KH wrote: > > On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: > > > The spin_lock_irqsave is moved to just beginning of critical section. > > > This change moves a

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Chandra Gorentla
On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: > On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: > > - kfree is being called for the members of the queue without > >de-queuing them; they are just inserted within this function; > >they are supposed to be de-que

Re: [PATCH] staging: iio: adc: fix comment block coding style issue

2015-10-04 Thread Lars-Peter Clausen
On 10/03/2015 08:32 PM, Hugo Camboulive wrote: > This patch to ad7746.c makes the comment block end with a */ > on a separate line. > > Signed-off-by: Hugo Camboulive > --- > drivers/staging/iio/cdc/ad7746.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stagin

Re: [PATCH] [dgnc] Remove dgnc_ports_state_show

2015-10-04 Thread Greg KH
On Wed, Jul 29, 2015 at 02:55:30PM +0100, Salah Triki wrote: > dgnc_ports_state_show exposes ports status which help an adversary to > plan an attack. Thus, the function is removed. > > Signed-off-by: Salah Triki > --- > drivers/staging/dgnc/dgnc_sysfs.c | 20 > 1 file chang

[PATCH RESEND 0/6] staging: dgnc: checkpatch cleanups

2015-10-04 Thread Sudip Mukherjee
Resending after rebasing on current staging-testing tree. Few patches of the original series are already applied only these checkpatch related patches did not apply due to other changes. regards sudip Sudip Mukherjee (6): staging: dgnc: remove multiple blank lines staging: dgnc: remove blankl

[PATCH RESEND 2/6] staging: dgnc: remove blankline before brace

2015-10-04 Thread Sudip Mukherjee
Blank lines are not needed before closing braces. checkpatch was giving warning about this. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c| 7 --- drivers/staging/dgnc/dgnc_driver.c | 2 -- drivers/staging/dgnc/dgnc_mgmt.c | 1 - drivers/staging/dgnc/dgnc_neo.c|

[PATCH RESEND 1/6] staging: dgnc: remove multiple blank lines

2015-10-04 Thread Sudip Mukherjee
checkpatch warns us about multiple blank lines which are not needed. Remove them. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_driver.c | 10 drivers/staging/dgnc/dgnc_mgmt.c | 5 drivers/staging/dgnc/dgnc_neo.c| 37 --- drivers/stagin

[PATCH RESEND 6/6] staging: dgnc: remove parenthesis

2015-10-04 Thread Sudip Mukherjee
checkpatch was warning us about extra unneeded parenthesis. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_neo.c | 2 +- drivers/staging/dgnc/dgnc_sysfs.c | 48 +++ drivers/staging/dgnc/dgnc_tty.c | 14 ++-- 3 files changed, 32 inser

[PATCH RESEND 5/6] staging: dgnc: alignment style

2015-10-04 Thread Sudip Mukherjee
checkpatch was warning us that the alignment should match the open parenthesis. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c| 14 +++--- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_neo.c| 2 +- drivers/staging/dgnc/dgnc_tty.c|

[PATCH RESEND 3/6] staging: dgnc: remove blankline after brace

2015-10-04 Thread Sudip Mukherjee
Blank lines are not needed after opening braces. checkpatch was giving us warnings about this. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c| 4 drivers/staging/dgnc/dgnc_driver.c | 3 --- drivers/staging/dgnc/dgnc_mgmt.c | 1 - drivers/staging/dgnc/dgnc_neo.c

[PATCH RESEND 4/6] staging: dgnc: remove space after cast

2015-10-04 Thread Sudip Mukherjee
Space is not necessary after typecast. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_cls.c| 6 +++--- drivers/staging/dgnc/dgnc_driver.c | 6 +++--- drivers/staging/dgnc/dgnc_mgmt.c | 6 +++--- drivers/staging/dgnc/dgnc_neo.c| 12 ++-- drivers/staging/dgnc/dgn

[PATCH v2] staging: iio: adc: fix comment block coding style issue

2015-10-04 Thread Hugo Camboulive
This patch to ad7746.c makes the comment blocks end with a */ on a separate line, and start with a /* on an empty line. Signed-off-by: Hugo Camboulive --- drivers/staging/iio/cdc/ad7746.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c

Re: [PATCH v2] staging: iio: adc: fix comment block coding style issue

2015-10-04 Thread Jonathan Cameron
On 04/10/15 17:30, Hugo Camboulive wrote: > This patch to ad7746.c makes the comment blocks end with a */ > on a separate line, and start with a /* on an empty line. > > Signed-off-by: Hugo Camboulive Thanks. Applied to the togreg branch of iio.git - initially pushed out as staging for the autom

[PATCH] staging: dgap: remove unused configuration

2015-10-04 Thread Sudip Mukherjee
The IO configuration was not used to configure the board. It was only read from the configuration file. Stop reading it and also remove the other related variables defined for it. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgap/dgap.c | 21 - drivers/staging/dgap/dga

Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

2015-10-04 Thread Jacob Kiefer
Hi Greg, Thanks for the response! It's always good to get notes on a patch. Some responses to your points: > Why __le32? Does this variable go across the user/kernel boundry > somehow? If not, just use le32. Good point, this should probably have been le32. > At first glance, you aren't doing

Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

2015-10-04 Thread Greg KH
On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote: > > And I think you just broke the "autoload" logic that these "call a null > > function" function calls were trying to solve, which isn't good at all. > > I guess this bit is lost on me-- how does calling a function from a > previously

HAPPY TIME

2015-10-04 Thread LOTTERY PROMOTIONS
THIS IS TO INFORM YOU THAT YOU HAVE WON A PRIZE MONEY OF (ONE MILLION EUROS ) FOR THIS YEARLY EL GORDO PRIMITIVA AWARD PROMO 2015 ALSO ENSURE TO KEEP YOUR WINNING DETAILS CONFIDENTIAL CONTACT YOUR CLAIMS DEPARTMENT WITH THIS INFORMATION'S. NAME:AN

[PATCHv4 1/2] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

2015-10-04 Thread Raphaël Beamonte
Add some temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 130 ++--- 1 file changed, 88 insertions(+), 42 deletions(-) diff --git a

[PATCHv4 2/2] staging: rtl8192u: r8192U_core: reuse local temporary variables to keep lines under 80 characters

2015-10-04 Thread Raphaël Beamonte
Reuse some local temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8

Re: [PATCH 03/10] staging: wilc1000: rename s32Error in host_int_set_mac_chnl_num

2015-10-04 Thread Julian Calaby
Hi Chaehyun, On Fri, Oct 2, 2015 at 10:44 PM, Chaehyun Lim wrote: > This patch replaces s32Error with result to avoid camelcase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/

Re: [PATCH 08/10] staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle

2015-10-04 Thread Julian Calaby
Hi Chaehyun, On Fri, Oct 2, 2015 at 10:44 PM, Chaehyun Lim wrote: > This patch replaces s32Error with result to avoid camelcase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/

[PATCH 3/3] staging: wilc1000: return error code direclty in host_int_wait_msg_queue_idle

2015-10-04 Thread Chaehyun Lim
There is no need to pass the error code to the variable 'result'. Just return the error directly when error occurs. Return 0 at the end of this function when error is not happened. Suggested-by: Julian Calaby Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++---

[PATCH 2/3] staging: wilc1000: return error code directly in host_int_set_mac_chnl_num

2015-10-04 Thread Chaehyun Lim
There is no need to pass the error code to the variable 'result'. Just return the error directly when error occurs. Return 0 at the end of this function when error is not happened. Suggested-by: Julian Calaby Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++---

[PATCH 1/3] staging: wilc1000: remove pstrWFIDrv in host_int_set_mac_chnl_num

2015-10-04 Thread Chaehyun Lim
This patch removes pstrWFIDrv variable in host_int_set_mac_chnl_num function. There is no need to make another variable to check if first arugment is NULL or not. It is able to use wfi_drv directly that is first argument of this function. Suggested-by: Greg Kroah-Hartman Signed-off-by: Chaehyun L

Re: [PATCH 3/3] staging: wilc1000: return error code direclty in host_int_wait_msg_queue_idle

2015-10-04 Thread Julian Calaby
Hi Chaehyun, On Mon, Oct 5, 2015 at 1:07 PM, Chaehyun Lim wrote: > There is no need to pass the error code to the variable 'result'. > Just return the error directly when error occurs. > Return 0 at the end of this function when error is not happened. We can't do this. > Suggested-by: Julian Ca

Re: [PATCH 3/3] staging: wilc1000: return error code direclty in host_int_wait_msg_queue_idle

2015-10-04 Thread Chaehyun Lim
On Mon, Oct 5, 2015 at 11:41 AM, Julian Calaby wrote: > Hi Chaehyun, > > On Mon, Oct 5, 2015 at 1:07 PM, Chaehyun Lim wrote: >> There is no need to pass the error code to the variable 'result'. >> Just return the error directly when error occurs. >> Return 0 at the end of this function when error

Re: [PATCH 3/3] staging: wilc1000: return error code direclty in host_int_wait_msg_queue_idle

2015-10-04 Thread Chaehyun Lim
Dear Greg Please ignore this patch. Thanks Chaehyun Lim On Mon, Oct 5, 2015 at 11:48 AM, Chaehyun Lim wrote: > On Mon, Oct 5, 2015 at 11:41 AM, Julian Calaby > wrote: >> Hi Chaehyun, >> >> On Mon, Oct 5, 2015 at 1:07 PM, Chaehyun Lim wrote: >>> There is no need to pass the error code to the

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 19:28, Chandra Gorentla wrote: On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: - kfree is being called for the members of the queue without de-queuing them; they are just inserted within this f

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 17:43, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: The spin_lock_irqsave is moved to just beginning of critical section. This change moves a couple of return statements out of the lock. Signed-off-by: Chandra S Gorentla --- drivers/st

[PATCH] vme: tsi148: silence uninitialized variable warning

2015-10-04 Thread Dmitry Kalinkin
The warning is a false positive. drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write': drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized] vme_unregister_error_handler(handler);

[PATCH V2 2/3] staging: wilc1000: rename pUserData

2015-10-04 Thread Tony Cho
This patch renames pUserData to data to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH V2 3/3] staging: wilc1000: rename strHostIFDelAllSta

2015-10-04 Thread Tony Cho
This patch renames strHostIFDelAllSta to del_all_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insert

[PATCH V2 1/3] staging: wilc1000: rename strHostIfRegisterFrame

2015-10-04 Thread Tony Cho
This patch renames strHostIfRegisterFrame to reg_frame to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- V2: rename strHostIfRegisterFrame to reg_frame instead of reg_f because it is ambiguous --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 in

Re: [PATCH] staging: i20: Added a blank line after declaration

2015-10-04 Thread Sudip Mukherjee
On Sat, Oct 03, 2015 at 10:47:47AM +0530, Anjali Menon wrote: > Added a blank line after declaration to fix the coding style > warning detected by checkpatch.pl > > WARNING: Missing a blank line after declarations > > Signed-off-by: Anjali Menon > --- > drivers/staging/i2o/pci.c | 1 + > 1 file

[PATCH 06/18] staging: wilc1000: remove typedef from tuniHostIFkeyAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the union tuniHostIFkeyAttr. And rename it to host_if_key_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 01/18] staging: wilc1000: rename tWILCpfScanResult

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfScanResult to wilc_scan_result. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH 03/18] staging: wilc1000: rename tWILCpfConnectResult

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfConnectResult to wilc_connect_result. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --g

[PATCH 05/18] staging: wilc1000: remove typedef from tenuKeyType

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum tenuKeyType. And rename it to KEY_TYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(

[PATCH 07/18] staging: wilc1000: remove typedef from tstrHostIFwepAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFwepAttr. And rename it to host_if_wep_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/stag

[PATCH 02/18] staging: wilc1000: remove typedef from tstrHiddenNetwork

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHiddenNetwork. And, rename it to hidden_network. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 8 drivers

[PATCH 04/18] staging: wilc1000: remove typedef from AUTHTYPE_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the enum AUTHTYPE_T. And, rename it to AUTHTYPE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1

[PATCH 09/18] staging: wilc1000: remove typedef from tstrHostIFpmkidAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFpmkidAttr. And rename it to host_if_pmkid_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 6 +++--- drive

[PATCH 10/18] staging: wilc1000: remove typedef from tstrHostIFpmkid

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFpmkid. And rename it to host_if_pmkid. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 2 files changed,

[PATCH 12/18] staging: wilc1000: remove typedef from SITE_SURVEY_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum SITE_SURVEY_T. And rename it to SITESURVEY. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deleti

[PATCH 15/18] staging: wilc1000: rename tWILCpfRemainOnChanReady

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfRemainOnChanReady to wilc_remain_on_chan_ready. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 11/18] staging: wilc1000: remove typedef from tstrCfgParamVal

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrCfgParamVal. And rename it to cfg_param_val. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 8 drivers/stag

[PATCH 14/18] staging: wilc1000: rename tWILCpfRemainOnChanExpired

2015-10-04 Thread Tony Cho
From: Leo Kim This patch renames tWILCpfRemainOnChanExpired to wilc_remain_on_chan_expired. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(

[PATCH 08/18] staging: wilc1000: remove typedef from tstrHostIFwpaAttr

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes typedef from the struct tstrHostIFwpaAttr. And rename it to host_if_wpa_attr. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stagi

[PATCH 16/18] staging: wilc1000: wilc_wfi_cfgoperations.c : remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions from the wilc_wfi_cfgoperations.c. - WILC_WFI_dump_survey - WILC_WFI_auth - WILC_WFI_assoc - WILC_WFI_deauth - WILC_WFI_disassoc - WILC_WFI_set_bitrate_mask Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc

[PATCH 13/18] staging: wilc1000: remove typedef from CURRENT_TX_RATE_T

2015-10-04 Thread Tony Cho
From: Leo Kim This patch remove typedef from the enum CURRENT_TX_RATE_T. And rename it to CURRENT_TXRATE. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed, 4 insertions(+)

[PATCH 17/18] staging: wilc1000: remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions. - drivers/staging/wilc1000/linux_mon.c : WILC_WFI_mon_setup - drivers/staging/wilc1000/wilc_sdio.o : sdio_set_func0_csa_address_byte0 Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_mon.c | 26 -

[PATCH 18/18] staging: wilc1000: host_interface.c : remove unused functions

2015-10-04 Thread Tony Cho
From: Leo Kim This patch removes unused functions from the host_interface.c(h). - Switch_Log_Terminal - Handle_DelBASession - host_int_addBASession This patch includes the removal of the comment for host_int_addBASession as well. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/