[PATCH 2/4] staging: wilc1000: remove define DISABLE_PWRSAVE_AND_SCAN_DURING_IP

2015-09-23 Thread Glen Lee
The driver will use define DISABLE_PWRSAVE_AND_SCAN_DURING_IP always. So remove the ifdef line and define in Makefile. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/host_interface.c | 22 -- drivers/sta

[PATCH 3/4] staging: wilc1000: remove define WILC_PARSE_SCAN_IN_HOST

2015-09-23 Thread Glen Lee
The define WILC_PARSE_SCAN_IN_HOST is always used in the driver, so just delete ifdef WILC_PARSE_SCAN_IN_HOST line, ifndef WILC_PARSE_SCAN_IN_HOST line and it's related codes. Finally, remove define in Makefile. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/Makefile | 1 - driver

[PATCH 1/4] staging: wilc1000: remove ifdef OLD_FPGA_BITFILE line

2015-09-23 Thread Glen Lee
OLD_FPGA_BITFILE is not used in the driver. Just delete ifdef line and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc

[PATCH 4/4] staging: wilc1000: remove define CONNECT_DIRECT

2015-09-23 Thread Glen Lee
The driver use CONNECT_DIRECT define as always. No need to provide as feature. This patch removes ifdef/ifndef CONNECT_DIRECT line and it's related codes inside ifndef CONNECT_DIRECT. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/corec

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread Jaime Arrocha
On 09/23/2015 12:31 AM, Sudip Mukherjee wrote: On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote: This patch is to rtl8712_gp_bitdef.h file that fixes up following warning reported by checkpatch : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- I

NOTIFICATION WINNING AMOUNT OF 950,000 EURO

2015-09-23 Thread Mega Bonanza
Dear Winner, This is your winning notification, Please do take your time to read the attached winning email. Internation Lottery commission Elgordo Team PROMOTING INTERNET USAGE OVER THE GLOBE (1).pdf Description: Adobe PDF document ___ devel mailing l

[PATCH 4/6] staging: wilc1000: remove WILC_OSW_INTERFACE_VER define

2015-09-23 Thread Chaehyun Lim
This patch removes WILC_OSW_INTERFACE_VER define that is not used anywhere. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_oswrapper.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_oswrapper.h b/drivers/staging/wilc1000/wilc_oswrapper.h index

[PATCH 1/6] staging: wilc1000: move struct Message and WILC_MsgQueueHandle

2015-09-23 Thread Chaehyun Lim
This patch moves struct Message and WILC_MsgQueueHandle from wilc_platform.h to wilc_msgqueue.h because those two structures are used only at wilc_msgqueue.c so that it is good to be defined at wilc_msgqueue.h Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.h | 15

[PATCH 3/6] staging: wilc1000: move wilc_msgqueue.h include file

2015-09-23 Thread Chaehyun Lim
This patch moves wilc_msgqueue.h include file from wilc_oswrapper.h to host_interface.c because message queue function as wilc_mq_create, wilc_mq_send, wilc_mq_recv and wilc_mq_destroy are used only at host_interface.c file. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface

[PATCH 5/6] staging: wilc1000: remove wilc_platform include file

2015-09-23 Thread Chaehyun Lim
This patch removes wilc_platform.h include file in wilc_oswrapper.h Because wilc_platform.h have several standard header files so that some header file should be included .c file to avoid compilation errors. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 1 + drive

[PATCH 6/6] staging: wilc1000: delete wilc_oswrapper.h

2015-09-23 Thread Chaehyun Lim
This patch delete wilc_oswrapper.h that has nothing inside. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_oswrapper.h | 16 drivers/staging/wilc1000/wilc_wlan.h | 1 - drivers/staging/wilc1000/wilc_wlan_if.h | 1 - 3 files changed, 18 deletions(-) delet

[PATCH 2/6] staging: wilc1000: remove wilc_platform.h include file

2015-09-23 Thread Chaehyun Lim
This patch removes wilc_platform.h include file that is defined in wilc_msgqueue.h file. After removing it, compilation error occurs so that it is included two header files as and at wilc_msgqueue.h and wilc_msgqueue.c Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c |

Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

2015-09-23 Thread Dan Carpenter
On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote: > /** > + * dprc_set_obj_label() - Set object label. > + * @mc_io: Pointer to MC portal's I/O object > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' > + * @token: Token of DPRC object > + * @obj_type:

[PATCH v3] x86: hyperv: fix build in !CONFIG_KEXEC_CORE case

2015-09-23 Thread Vitaly Kuznetsov
Recent changes in Hyper-V driver ("Drivers: hv: vmbus: add special crash handler") broke the build when CONFIG_KEXEC_CORE is not set: arch/x86/built-in.o: In function `hv_machine_crash_shutdown': arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to `native_machine_crash_shutdown' Decorate

Re: [PATCH] staging: rtl8723au: Mark type casts to __le32 as intentional

2015-09-23 Thread Lars Svensson
On Tue, Sep 22, 2015 at 11:30:54PM +0200, Larry Finger wrote: > > You may have silenced the Sparse warnings, but the code was not wrong. Your > version is also correct; however, you end up with some really ugly casts. > > Here is my analysis of these two, identical sections: > > The output of g

Re: [PATCH] storvsc: get rid of homegrown copy_{to, from}_bounce_buffer()

2015-09-23 Thread Vitaly Kuznetsov
Christoph Hellwig writes: > On Tue, Sep 22, 2015 at 06:27:50PM +0200, Vitaly Kuznetsov wrote: >> Storvsc driver needs to ensure there are no 'holes' in the presented >> sg list (all segments in the middle of the list need to be of PAGE_SIZE). > > I think it should instead set a virt_boundary. Th

[PATCH v2] storvsc: get rid of bounce buffer

2015-09-23 Thread Vitaly Kuznetsov
Storvsc driver needs to ensure there are no 'holes' in the presented sg list (all segments in the middle of the list need to be of PAGE_SIZE). When a hole is detected storvsc driver creates a 'bounce sgl' without holes and copies data over with copy_{to,from}_bounce_buffer() functions. Setting virt

Re: [PATCH 1/3] staging: lustre: add shared variables to the header

2015-09-23 Thread Dilger, Andreas
On 2015/09/22, 11:40 PM, "Anton Gerasimov" wrote: >This patch adds declarations for variables used in several files >across the ptlrpc module to the local header. > >Signed-off-by: Anton Gerasimov >--- > drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 6 ++ > 1 file changed, 6 insert

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-23 Thread Pavel Machek
Hi! > > +++ b/drivers/fpga/fpga-mgr.c > > @@ -0,0 +1,382 @@ > [..] > > +int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, > > + size_t count) > > +{ > > + struct device *dev = &mgr->dev; > > + int ret; > > + > > + if (!mgr) > > + return -EN

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread punit vara
On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha wrote: > > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote: >> >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote: >>> >>> This patch is to rtl8712_gp_bitdef.h file that fixes up following >>> warning reported by checkpatch : >>> >>> -Block

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-23 Thread Dan Carpenter
On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote: > > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags, > > > +const char *image_name) > > > +{ > > > + struct device *dev = &mgr->dev; > > > + const struct firmware *fw; > > > + int ret; > > > + > > >

RE: [PATCH v2] storvsc: get rid of bounce buffer

2015-09-23 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, September 23, 2015 5:59 AM > To: linux-s...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang > ; James E.J. Bottomley ; > Radim Kr

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha wrote: > > > > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote: > >> > >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote: > > > It would be better if someone suggest me how to

[PATCH] staging: comedi: comedi_fops.c: Tweak kernel-doc for consistency

2015-09-23 Thread Ian Abbott
Adjust the kernel-doc in this file for consistency of capitalization and punctuation. Make more use of the special kernel-doc markers for parameter names, constant names, etc. Use the correct kernel-doc tag for the return values sections. Signed-off-by: Ian Abbott --- drivers/staging/comedi/co

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread punit vara
On Wed, Sep 23, 2015 at 9:04 PM, Sudip Mukherjee wrote: > On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote: >> On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha wrote: >> > >> > On 09/23/2015 12:31 AM, Sudip Mukherjee wrote: >> >> >> >> On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-23 Thread atull
On Wed, 23 Sep 2015, Dan Carpenter wrote: > On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote: > > > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags, > > > > + const char *image_name) > > > > +{ > > > > + struct device *dev = &mgr->dev; >

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 09:51:23PM +0530, punit vara wrote: > On Wed, Sep 23, 2015 at 9:04 PM, Sudip Mukherjee > wrote: > > On Wed, Sep 23, 2015 at 07:32:52PM +0530, punit vara wrote: > >> On Wed, Sep 23, 2015 at 12:55 PM, Jaime Arrocha > >> wrote: > >> > > >> > On 09/23/2015 12:31 AM, Sudip Muk

[PATCH v4] staging: unisys: Add s-Par visorhba

2015-09-23 Thread Benjamin Romer
From: David Kershner This driver create a host bus adapter device when s-Par sends a device create message to create a storage adapter on the visorbus. When the message is received by visorbus, the visorhba_probe function is called and the hba device is created and managed by the visorhba driver.

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread punit vara
Thank you very much sir I will definitely follow that. I have seen so many people fixing patches over here. Now I know process of submitting patches.I am able to fix several patches created by checkpatch.pl . But can you suggest me any driver to fix API or another small TODO task. I have seen so ma

Re: [PATCH v4] staging: unisys: Add s-Par visorhba

2015-09-23 Thread Greg KH
On Wed, Sep 23, 2015 at 12:38:06PM -0400, Benjamin Romer wrote: > From: David Kershner > > This driver create a host bus adapter device when s-Par sends a > device create message to create a storage adapter on the visorbus. > When the message is received by visorbus, the visorhba_probe function >

RE: [PATCH] staging: comedi: comedi_fops.c: Tweak kernel-doc for consistency

2015-09-23 Thread Hartley Sweeten
On Wednesday, September 23, 2015 8:33 AM, Ian Abbott wrote: > Adjust the kernel-doc in this file for consistency of capitalization and > punctuation. Make more use of the special kernel-doc markers for > parameter names, constant names, etc. Use the correct kernel-doc tag > for the return values

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-23 Thread atull
Hi Josh, Thanks for the review. This is all at the tail end of a long (>2 years) discussion on this. I hope that the way this has shaped out still meets the needs of the people who have been in this discussion the most and have had the strongest feelings (due to being current users of FPGAs unde

[PATCH] Staging: rtl8712: rtl8712_recv.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl8712_recv.h that fixes up following warnings generated by checkpatch.pl : -Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl8712_recv.h | 20 +++- 1 file

randconfig build error with next-20150923, in drivers/staging/unisys/visorhid

2015-09-23 Thread Jim Davis
Building with the attached random configuration file, ERROR: "input_free_device" [drivers/staging/unisys/visorhid/visorhid.ko] undefined! ERROR: "input_set_capability" [drivers/staging/unisys/visorhid/visorhid.ko] undefined! ERROR: "input_set_abs_params" [drivers/staging/unisys/visorhid/visorhid.k

RE: randconfig build error with next-20150923, in drivers/staging/unisys/visorhid

2015-09-23 Thread Sell, Timothy C
g build error with next-20150923, in > drivers/staging/unisys/visorhid > > Building with the attached random configuration file, > > ERROR: "input_free_device" > [drivers/staging/unisys/visorhid/visorhid.ko] undefined! > ERROR: "input_set_capability" > [d

[PATCH 0/2] staging: comedi: rti800: minor cleanups

2015-09-23 Thread H Hartley Sweeten
H Hartley Sweeten (2): staging: comedi: rti800: prefer using the BIT macro staging: comedi: rti800: use comedi_offset_munge() drivers/staging/comedi/drivers/rti800.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) -- 2.5.1 __

[PATCH 1/2] staging: comedi: rti800: prefer using the BIT macro

2015-09-23 Thread H Hartley Sweeten
Use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti800.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/rti800.c b/driv

[PATCH 2/2] staging: comedi: rti800: use comedi_offset_munge()

2015-09-23 Thread H Hartley Sweeten
Use the comedi_offset_munge() helper to do the two's complement to comedi offset binary and comedi offset binary to two's complement conversions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rti800.c | 12 1 file changed

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-23 Thread punit vara
On Wed, Sep 23, 2015 at 10:25 PM, punit vara wrote: > Thank you very much sir I will definitely follow that. I have seen so > many people fixing patches over here. Now I know process of submitting > patches.I am able to fix several patches created by checkpatch.pl . > But can you suggest me any dr

[PATCH] Staging: rtl8712: rtl8712_spec.h: Coding Style warning fix for block comment

2015-09-23 Thread Punit Vara
This patch is to the rtl8712_spec.h file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl8712_spec.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH v4] staging: unisys: Add s-Par visorhba

2015-09-23 Thread Ben Romer
On 09/23/2015 01:00 PM, Greg KH wrote: v4: * remove all BUG() and BUG_ON() - do not crash the kernel You just deleted them? No taking into account that you should just handle issues like this in a run-time-safe way instead? Removing them altogether was a better way to handle the prob

randconfig build error with next-20150923, in drivers/staging/rtl8188eu/os_dep/mon.c

2015-09-23 Thread Jim Davis
Building with the attached random configuration file, drivers/built-in.o: In function `mon_recv_decrypted': mon.c:(.text+0x31befb): undefined reference to `ieee80211_hdrlen' -- Jim # # Automatically generated file; DO NOT EDIT. # Linux/x86 4.3.0-rc2 Kernel Configuration # CONFIG_64BIT=y CONFIG_X

[PATCH] Staging: rtl8712: rtl8712_syscfg_bitdef.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl8712_syscfg_bitdef.h file that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl8712_syscfg_bitdef.h | 54 - 1 file changed, 36 ins

[PATCH] Staging: rtl8712: rtl8712_xmit.c: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is the rtl8712_xmit.c that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl8712_xmit.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff

[PATCH] staging: comedi: comedi_pci.c: improve function documentation

2015-09-23 Thread Ian Abbott
Expand the descriptions of the functions and document the return values. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_pci.c | 108 ++-- 1 file changed, 80 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi/comedi_pci.c b/drivers/st

Re: [PATCH 0/2] staging: comedi: rti800: minor cleanups

2015-09-23 Thread Ian Abbott
On 23/09/15 18:43, H Hartley Sweeten wrote: H Hartley Sweeten (2): staging: comedi: rti800: prefer using the BIT macro staging: comedi: rti800: use comedi_offset_munge() drivers/staging/comedi/drivers/rti800.c | 28 1 file changed, 16 insertions(+), 12 delet

[PATCH] Staging: rtl8712: rtl871x_cmd.c: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_cmd.c that fixes up following warnings reported by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_cmd.c | 38 ++-

[PATCH] Staging: rtl8712: rtl871x_cmd.h: Fix typo error "ture"

2015-09-23 Thread Punit Vara
This patch is to the rtl8712_cmd.h that fixes up typo error in comment for word "true". Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x

[PATCH] Staging: rtl8712: rtl871x_cmd.h: Coding style warnings fix for block comments

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_cmd.h file that fixes up following warnings reported by checkpatch.pl : -Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_cmd.h | 282 +

[PATCH 00/11] staging: comedi: rtd520: tidy up driver

2015-09-23 Thread H Hartley Sweeten
Tidy up this driver and fix all the checkpatch.pl issues. H Hartley Sweeten (11): staging: comedi: rtd520: prefer using the BIT macro staging: comedi: rtd520: fix logical continuations staging: comedi: rtd529: usleep_range is preferred over udelay staging: comedi: rtd520: rename rtd520Boar

[PATCH 02/11] staging: comedi: rtd520: fix logical continuations

2015-09-23 Thread H Hartley Sweeten
Fix the checkpatch.pl issues about: CHECK: Logical continuations should be on the previous line Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 01/11] staging: comedi: rtd520: prefer using the BIT macro

2015-09-23 Thread H Hartley Sweeten
Use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH 03/11] staging: comedi: rtd529: usleep_range is preferred over udelay

2015-09-23 Thread H Hartley Sweeten
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". `udelay()` is only used in the firmware upload process. Replace them with `usleep_range()` with a reasonable upper limit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kr

[PATCH 04/11] staging: comedi: rtd520: rename rtd520Boards

2015-09-23 Thread H Hartley Sweeten
For aesthetics, rename this CamelCase array. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/c

[PATCH 05/11] staging: comedi: rtd520: move constants to right side of comparisons

2015-09-23 Thread H Hartley Sweeten
Fix the checkpatch.pl issues about: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

[PATCH 06/11] staging: comedi: rtd520: remove unnecessary comments from rtd_ao_winsn()

2015-09-23 Thread H Hartley Sweeten
These comments are cut-and-paste from the old skeleton driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drive

[PATCH 05/37] staging/lustre: use 64-bit timestamps in procfs output

2015-09-23 Thread Arnd Bergmann
Some lustre procfs files contain the current time. Make sure we use a format here that does not overflow in 2038. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/lu

[PATCH 14/37] staging/lustre: use 64-bit times for lnet_shuffle_seed

2015-09-23 Thread Arnd Bergmann
This function uses do_gettimeofday() to get a pseudo-random number. There is no bug here, but changing it to use ktime_get_ts64() gets us closer to deprecating do_gettimeofday() and makes slightly more random. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/lnet/router.c

[PATCH 07/11] staging: comedi: rtd520: convert DAC register defines to macros

2015-09-23 Thread H Hartley Sweeten
For aesthetics, convert the defines for the various DAC registers into macros that take the comedi channel and return the correct offset. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 33 - 1

[PATCH 20/37] staging/lustre: use 64-bit time for adaptive timeout

2015-09-23 Thread Arnd Bergmann
The adaptive timeout handling stores absolute times in 32-bit time_t quantities, which will overflow in 2038. This changes it to use time64_t. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/lustre_import.h | 6 +++--- drivers/staging/lustre/lustre/obdclass/lprocfs_stat

[PATCH 06/37] staging/lustre: use time64_t for l_last_activity

2015-09-23 Thread Arnd Bergmann
The l_last_activity struct member is used to keep track lock hold times, and it is printed for debugging purposes. For the elapsed time, we can use 'long' here, but it's better to use time64_t for storing the real time to avoid an overflow in 2038. Signed-off-by: Arnd Bergmann --- drivers/stagin

[PATCH 00/37] staging/lustre: y2038 rework

2015-09-23 Thread Arnd Bergmann
First of all, sorry for the overly long series that this turned into. I'm currently doing a survey of all code using time_t/timeval/timespec to get an idea of what work needs to be done where, in particular in terms of user interface changes. Lustre is by far the most pervasive user of time types

[PATCH 13/37] staging/lustre: use 64-bit ibn_incarnation computation

2015-09-23 Thread Arnd Bergmann
ibn_incarnation is a 64-bit value, but using timeval to compute it will cause an overflow in 2038. This changes it to use ktime_get_real_ts64() instead. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

[PATCH 08/37] staging/lustre: change rq_at_index type

2015-09-23 Thread Arnd Bergmann
The rq_at_index member of ptlrpc_request is incorrectly declared as time_t, when it is only used as an index into an array, and assigned from a __u32 variable. This changes the type to u32, so we can kill off another use of time_t. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/

[PATCH 02/37] staging/lustre: use 64-bit inode timestamps internally

2015-09-23 Thread Arnd Bergmann
Lustre has 64-bit timestamps in its network data structures, but on 32 bit systems, it converts them directly into time_t, which is 32 bit wide. This changes the code to use 64-bit time stamps for files. The Linux VFS code still uses time_t though, and will be changed in a separate patch series.

[PATCH 03/37] staging/lustre: obd: remove unused data structures

2015-09-23 Thread Arnd Bergmann
We want to get rid of all uses of time_t, and it turns out that obd.h contains a bunch of them that are completely unused. This removes those structures, along with a couple of other structures and functions in the same file that also turned out to be unused. Signed-off-by: Arnd Bergmann --- dr

[PATCH 24/37] staging/lustre: use 64-bit time for selftest

2015-09-23 Thread Arnd Bergmann
The lustre selftest code has multiple time stamps that are kept as 'time_t' or 'unsigned long' and can therefore overflow on 32-bit systems. This changes the code to use time64_t instead. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/selftest/brw_test.c | 6 +++--- drivers/stag

[PATCH 17/37] staging/lustre: use 64-bit time for pl_recalc

2015-09-23 Thread Arnd Bergmann
The ldlm pool calculates elapsed time by comparing the previous and current get_seconds() values, which is unsafe on 32-bit machines after 2038. This changes the code to use time64_t and ktime_get_real_seconds(), keeping the 'real' instead of 'monotonic' time because of the debug prints. Signed-o

[PATCH 19/37] staging/lustre: use 64-bit time for procfs output

2015-09-23 Thread Arnd Bergmann
This time is only printed in procfs, and can be easily converted to 64-bit to avoid overflowing on 32-bit systems in 2038. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++-- .../staging/lustre/lustre/obdclass/lprocfs_status.c | 19 +---

[PATCH 25/37] staging/lustre: partially use time64_t for capa expiry

2015-09-23 Thread Arnd Bergmann
Here, we actually have a problem in 2038 or at the latest in 2106 when the lc_expiry variable on the wire protocol overflows, including on 64-bit architectures. I'm changing the internal implementation so it only compares the lower 31 bits of the current time, using the algorithm from time_before(

[PATCH 37/37] staging/lustre: remove CFS_TIME_T definition

2015-09-23 Thread Arnd Bergmann
The CFS_TIME_T macro serves no real purpose as we stopped using time_t and changed over to time64_t, so we can remove the last remaining uses of this. Two uses of this macro are incorrect and refer to jiffies values rather than time_t, and one refers to an inode timespec that gets changed separate

[PATCH 31/37] staging/lustre: use 64-bit times for ptlrpc_sec

2015-09-23 Thread Arnd Bergmann
Here we use an unsigned long to store the timeout for gc, which is probably safe until 2106, but this patch converts it to use ktime_get_real_seconds() and time64_t for consistency. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/lustre_sec.h | 2 +- drivers/staging/lustre

[PATCH 27/37] staging/lustre: use 64-bit times in debug print

2015-09-23 Thread Arnd Bergmann
This adapts the format string and get_seconds() call to not overflow in 2038 in the libcfs_debug_dumplog_internal() function. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lust

[PATCH 15/37] staging/lustre: use 64-bit computation in s2dhms()

2015-09-23 Thread Arnd Bergmann
The s2dhms computes the day/hour/minute/second values from a time_t, which stops working in 2038. This changes the code to take a time64_t argument, and use div_u64_rem() to implement the first division. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 6

[PATCH 01/37] staging/lustre: use jiffies for lp_last_query times

2015-09-23 Thread Arnd Bergmann
The recently introduced lnet_peer_set_alive() function uses get_seconds() to read the current time into a shared variable, but all other uses of that variable compare it to jiffies values. This changes the current use to jiffies as well for consistency. This likely changes behavior, and should be

[PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-23 Thread Arnd Bergmann
The lustre tracefile has a timestamp defined as __u32 ph_sec; __u64 ph_usec; which seems completely backwards, as the microsecond portion of a time stamp will always fit into a __u32 value, while the second portion will overflow in 2038 or 2106 (in case of unsigned seconds). This r

[PATCH 36/37] staging/lustre: remove unused time handling functions

2015-09-23 Thread Arnd Bergmann
A bunch of API functions deal with time values but are now completely unused in lustre. This removes them in order to remove all references to time_t from the header files. Signed-off-by: Arnd Bergmann --- .../lustre/include/linux/libcfs/libcfs_time.h | 49 -- .../lustre

[PATCH 35/37] staging/lustre: remove wrappers for timer functions

2015-09-23 Thread Arnd Bergmann
This is a simple cleanup that I did after noticing that the abstraction for the timer functions in completely pointless, and the one user (ptlrpc) can just as well call the native Linux functions. For good measure, this also removes the empty libcfs_arch_init() and libcfs_arch_cleanup() functions

[PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-23 Thread Arnd Bergmann
The last request time is stored as an 'unsigned long', which is good enough until 2106, but it is then converted to 'long' in some places, which overflows in 2038. This changes the type to time64_t to avoid those problems. Signed-off-by: Arnd Bergmann --- .../staging/lustre/lustre/include/lustr

[PATCH 28/37] staging/lustre: use 64-bit times in another debug print

2015-09-23 Thread Arnd Bergmann
The ll_setattr_raw() function prints the new inode timestamps along with the current time using '%lu', which overflows in 2106. This changes the printing of the current time for now, the other two will change when we migrate the VFS code to use 64-bit timestamps. Signed-off-by: Arnd Bergmann ---

[PATCH 07/37] staging/lustre: use ktime_t for calculating elapsed time

2015-09-23 Thread Arnd Bergmann
process_param2_config() tries to print how much time has passed across a call_usermodehelper() function, and uses struct timeval for that. We want to remove this structure, so this is better expressed in terms of ktime_t and ktime_us_delta(). Signed-off-by: Arnd Bergmann --- drivers/staging/lus

[PATCH 26/37] staging/lustre: use 64-bit times in ptlrpc_enc_page_pool

2015-09-23 Thread Arnd Bergmann
ptlrpc_enc_page_pool computes time deltas using 'long' values from get_seconds(). This is probably safe beyond y2038, but it's better to go use monotonic times and 64-bit here for consistency. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 24 -

[PATCH 16/37] staging/lustre: use 64-bit timestamps for selftest

2015-09-23 Thread Arnd Bergmann
The wire protocol for the ping uses a 64-bit seconds/microseconds pair, but this won't work when one side uses a 32-bit timeval to look up the current time beyond 2038. This changes the code to use ktime_get_real_ts64() to create a timestamp that has the right format on all machines. Signed-off-b

[PATCH 18/37] staging/lustre: use 64-bit time for obd eviction

2015-09-23 Thread Arnd Bergmann
The obd_eviction_timer will overflow in 2038 on 32-bit systems, so replace it with a 64-bit time and ktime_get_real_seconds(). Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/obd.h| 2 +- drivers/staging/lustre/lustre/ptlrpc/service.c | 4 ++-- 2 files changed, 3 inser

[PATCH 23/37] staging/lustre: use 64-bit time for ni_last_alive

2015-09-23 Thread Arnd Bergmann
The ni_last_alive member of lnet_ni uses a 'long' to store a timestamp, which breaks on 32-bit systems in 2038. This changes it to use time64_t and the respective functions for it. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/include/linux/lnet/lib-types.h | 2 +- drivers/staging/lus

[PATCH 09/37] staging/lustre: avoid unnecessary timeval conversion

2015-09-23 Thread Arnd Bergmann
The lnet_eq_wait_locked tries to wait for time to pass or an event to wake up the wait queue. The entire logic seems to be a very elaborate reimplementation of wait_event(). I'm not trying to clean up the entire logic here, but this at least gets rid of the multi-way conversion between miliseconds

[PATCH 09/11] staging: comedi: rtd520: remove unnecessary function desc. block comments

2015-09-23 Thread H Hartley Sweeten
These function description comments are cut-and-paste cruft from the old skeleton driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 30 -- 1 file changed, 30 deletions(-) diff -

[PATCH 29/37] staging/lustre: use 64-bit timestamps for mdc

2015-09-23 Thread Arnd Bergmann
These three are timestamps that are sent over the wire in mdc_lib and the obd logging 64-bit values, but are generated using the 32-bit get_seconds() function, which will eventually overflow. Changing them to use 64-bit ktime_get_real_seconds() solves the problem. Signed-off-by: Arnd Bergmann --

[PATCH 30/37] staging/lustre: use 64-bit times for ptlrpc sec expiry

2015-09-23 Thread Arnd Bergmann
The exp_flvr_expire and imp_sec_expire are defined as 'unsigned long', which doesn't overflow until 2106, but to be on the safe side, this changes the code to use time64_t like we do everywhere else. Signed-off-by: Arnd Bergmann --- .../staging/lustre/lustre/include/lustre_export.h | 2 +- ...

[PATCH 33/37] staging/lustre: use 64-bit times for request times

2015-09-23 Thread Arnd Bergmann
All request timestamps and deadlines in lustre are recorded in time_t and timeval units, which overflow in 2038 on 32-bit systems. In this patch, I'm converting them to time64_t and timespec64, respectively. Unfortunately, this makes a relatively large patch, but I could not find an obvious way to

[PATCH 11/37] staging/lustre: use 'long' return type for cfs_duration_sec()

2015-09-23 Thread Arnd Bergmann
The cfs_duration_sec() converts a relative jiffies value into seconds, and returns that number as a time_t. We know that a 32-bit type is enough here, because the result is order of magnitudes smaller than the difference in jiffies that is also expressed as a 'long', so we can safely replace the ti

[PATCH 34/37] staging/lustre: remove a bit of dead code

2015-09-23 Thread Arnd Bergmann
These three functions have not been in used for a long time, so lets just remove them. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/include/obd.h | 62 - 1 file changed, 62 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd.h b/dri

[PATCH 10/37] staging/lustre: use 64-bit time LNetCtl()

2015-09-23 Thread Arnd Bergmann
This ioctl function passes a 64-bit time argument but then performs a computation with a 32-bit get_seconds() value. In order to avoid overflow here, this changes the code to use 64-bit math and ktime_get_real_seconds(). Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/lnet/api-ni.c

[PATCH 22/37] staging/lustre: use 64-bit times for ksnd_connd

2015-09-23 Thread Arnd Bergmann
The connection starting/failing time stamps will overflow in 2038 on 32-bit machines, so we need to use time64_t and ktime_get_real_seconds() instead. Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c| 2 +- drivers/staging/lustre/lnet/klnds/socklnd/socklnd

[PATCH 12/37] staging/lustre: use jiffies_to_*() instead of cfs_duration_usec

2015-09-23 Thread Arnd Bergmann
The cfs_duration_usec() function has a timeval as its output, which we want to avoid in general because of the y2038 problem. There are only two locations remaining in lustre, so we can for now replace one with jiffies_to_timeval(), which is a generic kernel function that does the same thing, the

[PATCH 21/37] staging/lustre: use 64-bit llite procfs timestamps

2015-09-23 Thread Arnd Bergmann
The llite procfs interface contains timestamps that are computed from timeval, which overflows in 2038 on 32-bit systems. This changes the output to use a timespec64 type to avoid the overflow. I also change the format to print the sub-second portion as 9 digits (nanoseconds) for clarity, rather t

[PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-23 Thread H Hartley Sweeten
For aesthetics, rename this function and tidy it up a bit. Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers to handle the 2's complement munging. Save the readback value after the conversion is complete. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 10/11] staging: comedi: rtd520: tidy up block comments

2015-09-23 Thread H Hartley Sweeten
Use the preferred block command style. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 68 + 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd52

[PATCH] Staging: rtl8712: rtl871x_ht.h: Coding style warning fix for block comment

2015-09-23 Thread Punit Vara
This patch is to the rtl871x_ht.h that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ht.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 11/11] staging: comedi: rtd520: use DIV_ROUND_CLOSEST and DIV_ROUND_UP macros

2015-09-23 Thread H Hartley Sweeten
Use the macros to clarify the divisor calculations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/stag

  1   2   >