Re: [PATCH v11 3/4] add FPGA manager core

2015-09-22 Thread Josh Cartwright
On Tue, Sep 22, 2015 at 10:21:10AM -0500, at...@opensource.altera.com wrote: > From: Alan Tull > > API to support programming FPGA's. > > The following functions are exported as GPL: > * fpga_mgr_buf_load >Load fpga from image in buffer > > * fpga_mgr_firmware_load >Request firmware and

Re: [PATCH v11 1/4] usage documentation for FPGA manager core

2015-09-22 Thread Moritz Fischer
Hi Alan, On Tue, Sep 22, 2015 at 8:21 AM, wrote: > From: Alan Tull > > Add a document on the new FPGA manager core. > Reviewed-by: Moritz Fischer > Signed-off-by: Alan Tull > --- > v9: initial version where this patch was added > > v10: requested cleanups to formatting and otherwise >

Re: [PATCH v11 2/4] fpga manager: add sysfs interface document

2015-09-22 Thread Moritz Fischer
On Tue, Sep 22, 2015 at 8:21 AM, wrote: > From: Alan Tull > > Add documentation under drivers/staging for new fpga manager's > sysfs interface. > Reviewed-by: Moritz Fischer > Signed-off-by: Alan Tull > --- > v5 : (actually second version, but keeping version numbers > aligned with rest

[PATCH v3 0/1] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-09-22 Thread Salah Triki
The global variable dgnc_poll_tick is read in the function dgnc_poll_handler and modified in dgnc_driver_pollrate_store. The read access is protected by spin_lock_irqsave whereas the write is not. The protection of write access is needed, since it is possible to have multiple programs that try

[PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

2015-09-22 Thread Salah Triki
dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declare not

Re: [PATCH v2 3/6] staging: fsl-mc: up-rev dpbp binary interface to v2.0

2015-09-22 Thread Greg KH
On Tue, Sep 22, 2015 at 06:08:56PM -0500, J. German Rivera wrote: > Add cmd_flags parameter to all dpbp APIs to comply > with the dpbp 2.0 MC interface. Updated MC version > major number. Pass irq args in struct instead of > separate args. > > Signed-off-by: J. German Rivera > --- > drivers/stag

Re: [PATCH 2/3] staging: sm750fb: replace custom MB(x) macro with appropriate SZ_xM

2015-09-22 Thread Sudip Mukherjee
On Tue, Sep 22, 2015 at 12:01:17PM +0300, Mike Rapoport wrote: > Use SZ_xM defined in linux/sizes.h instead of custom MB(x) macro > > Signed-off-by: Mike Rapoport > --- If you are removing the use of MB(x) please also remove the #define MB(x) ((x)<<20) regards sudip _

Re: [PATCH 3/3] staging: sm750fb: remove unused MB(x) and KB(x) macros

2015-09-22 Thread Sudip Mukherjee
On Tue, Sep 22, 2015 at 12:01:18PM +0300, Mike Rapoport wrote: > The MB(x) and KB(x) macros are not used and therefore they can be > removed > > Signed-off-by: Mike Rapoport > --- ohh.. discard my earlier mail. I have not seen that you have done that in this patch. Sorry for the noise. regards s

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-22 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 02:03:56AM +0530, Punit Vara wrote: > This patch is to rtl8712_gp_bitdef.h file that fixes up following > warning reported by checkpatch : > > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- I am getting confused. One of your previ

Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

2015-09-22 Thread Sudip Mukherjee
On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to > take the > lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the > appropriate lock, since it is intended for poll scheduling and dgnc_poll

<    1   2