Hi Greg,
On Sun, Sep 20, 2015 at 07:09:48PM -0700, Greg KH wrote:
> On Sun, Sep 20, 2015 at 10:09:22AM +0200, Mateusz Kulikowski wrote:
[...]
> _ as a prefix for a function name? That's horrid, and is not something
> we want to do in the kernel.
I agree, but it was not my convention.
>
> Ick, t
On Sun, Sep 20, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote:
> > @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy)
> > + if (kvp_get_state() > HVUTIL_READY)
> > + kvp_set_state(HVUTIL_READY);
> And what if the state chan
On Sun, Sep 20, Greg KH wrote:
> Just use a lock, that's what it is there for.
How would that help? It might help because it enforces ordering. But
that requires that all three utils get refactored to deal with the
introduced locking. I will let KY comment on this.
The issue I see with fcopy is
Olaf Hering writes:
> On Sun, Sep 20, Greg KH wrote:
>
>> Just use a lock, that's what it is there for.
>
> How would that help? It might help because it enforces ordering. But
> that requires that all three utils get refactored to deal with the
> introduced locking. I will let KY comment on this
Use kvfree() instead of open-coding it.
Signed-off-by: Geliang Tang
---
drivers/staging/rdma/hfi1/sdma.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index aecd1a7..9c02a3d 100644
--- a/drivers/staging
On Mon, Sep 21, Vitaly Kuznetsov wrote:
> I'd like to see a trace from the hang, it is not obvious to me how it
> happened and what caused it. (or if you have such hang scenario in your
> head, can you please reveal it?)
There is no trace. I think fcopy_respond_to_host notifies the host,
which in
Use BIT_ULL() macro instead of long hexadecimal constants with only
single bit set.
Signed-off-by: Mike Rapoport
---
.../lustre/lustre/include/lustre_dlm_flags.h | 80 +++---
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/lustre/lustre/inclu
On 2015/09/21, 2:25 PM, "Mike Rapoport" wrote:
>Use BIT_ULL() macro instead of long hexadecimal constants with only
>single bit set.
>
>Signed-off-by: Mike Rapoport
>---
> .../lustre/lustre/include/lustre_dlm_flags.h | 80
>+++---
> 1 file changed, 40 insertions(+), 40 delet
This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt.
then makes set_power_mgmt static.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgop
This patch replaces WILC_WFI_set_cqm_rssi_config with
set_cqm_rssi_config to avoid CamelCase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperati
This patch makes del_virtual_intf static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperati
This patch removes useless comment.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cf
This patch makes mgmt_tx_cancel_wait static. This function is used only
at wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_c
This patch removes meaningless comment in host_int_init function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index bc0adc
This patch makes add_virtual_intf static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi
This patch removes CoreConfiguratorInit function, which is not doing
anything else except printing a PRINT_D message and returing a s32Error.
It is also removed the code that is calling this function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/coreconfigurator.c | 19 --
This patch replaces kmalloc with kzalloc in host_int_init.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index
This patch removes commented code in host_int_init function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 43062c5..ce7bb0f
This patch replaces s32Error with result in host_int_init function to
avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drive
This patch removes unnecessary parentheses found by checkpatch.pl
Unnecessary parentheses around pstrWFIDrv->hSemTestKeyBlock
Unnecessary parentheses around pstrWFIDrv->hSemTestDisconnectBlock
Unnecessary parentheses around pstrWFIDrv->hSemGetRSSI
Unnecessary parentheses around pstrWFIDrv->hSemGet
This patch removes multiple blank lines in host_int_init function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index 215
This patch fixes error check when kzalloc is failed.
NULL comparison style is changed to use ! operator and
PRINT_ER is also removed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wi
This patch makes mgmt_tx static. This function is used only at
wilc_wfi_cfgoperation.c file.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperatio
This patch removes blank line before a close brace.
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/stagi
> Subject: [PATCH] IB/hfi1: use kvfree() in sdma.c
>
> Use kvfree() instead of open-coding it.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/staging/rdma/hfi1/sdma.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
Thanks for the patch.
Acked-by: Mike Marciniszyn
___
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke
---
Change in v2-
No change. Resending due to malformed patch error
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 --
drivers/staging/fbtft
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/staging/lustre/lustre/llite/xatt
The variable can take negative values.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/staging/media/davinci_vpfe/dm365_
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/staging/rdma/ehca/ehca_cq.c | 13
Unsigned cannot be negative.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 3 -
Olaf Hering writes:
> On Mon, Sep 21, Vitaly Kuznetsov wrote:
>
>> I'd like to see a trace from the hang, it is not obvious to me how it
>> happened and what caused it. (or if you have such hang scenario in your
>> head, can you please reveal it?)
>
> There is no trace. I think fcopy_respond_to_h
On Sun, 20 Sep 2015, Greg Kroah-Hartman wrote:
On Sat, Sep 19, 2015 at 10:19:17PM +0530, Shraddha Barke wrote:
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke
Something is messed
Fixes the following sparse warning:
drivers/staging/rdma/hfi1/device.c:127:12:
warning: symbol 'class_name_user' was not declared. Should it be static?
Signed-off-by: Geliang Tang
---
drivers/staging/rdma/hfi1/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
On Mon, Sep 21, 2015 at 12:54:54PM +, Dilger, Andreas wrote:
> On 2015/09/21, 2:25 PM, "Mike Rapoport" wrote:
>
> >Use BIT_ULL() macro instead of long hexadecimal constants with only
> >single bit set.
> >
> >Signed-off-by: Mike Rapoport
> >---
> > .../lustre/lustre/include/lustre_dlm_flags.
> Subject: [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer
>
Thanks for the patch!
Acked-by: Mike Marciniszyn
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev
> Subject: [PATCH] IB/hfi1: class_name_user() should be static
>
> Fixes the following sparse warning:
> drivers/staging/rdma/hfi1/device.c:127:12:
> warning: symbol 'class_name_user' was not declared. Should it be static?
>
> Signed-off-by: Geliang Tang
> ---
Thanks for the patch!
Acked-b
> On 18 Sep 2015, at 05:46, Martyn Welch wrote:
>
>
>
> On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
>> From: Dmitry Kalinkin
>>
>> The current VME bus error handler adds errors to the bridge error list.
>> vme_master_{read,write} then traverses that list to look for relevant
>> error
Fixed warnings found by checkpatch.pl:
Please use a blank line after function/struct/union/enum declarations
FILE: drivers/staging/rdma/amso1100/c2_mq.c:158:
FILE: drivers/staging/rdma/hfi1/file_ops.c:2069:
FILE: drivers/staging/rdma/hfi1/sdma.c:744:
FILE: drivers/staging/rdma/hfi1/verbs.c
Hi Jake,
I don't know how this will be morphed after Marc's comments, but when you
repost this series, please take a look at the existing change history,
e.g., with "git log --oneline drivers/pci/probe.c", and make your subject
lines follow the existing conventions. In this case, they look like:
On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote:
> On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote:
>> On 09/16/2015 02:22 AM, Dan Carpenter wrote:
>>> __get_txreq() returns an ERR_PTR() but this checks for NULL so it would
>>> oops on failure.
>>>
>>> Signed-off-by: Dan Carpenter
>>
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, September 20, 2015 10:26 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com
> Su
On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote:
> On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote:
> > poll_tick is declared global, so dgnc_driver_pollrate_* need to
> > take the lock dgnc_poll_lock before accessing to this variable.
>
> Really? The scope of a variable doesn
On Sat, Aug 29, 2015 at 12:18:22AM -0500, Larry Finger wrote:
> Even though you are just moving code, I think you should fix the
> long line warnings from scripts/checkpatch, otherwise note that they
> are not fixed here, but they will be fixed in a later patch. As for
> the other warnings, they s
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, September 20, 2015 10:28 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; Jak
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, September 20, 2015 10:29 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; Jak
This is patch to rtsx_chip.c that fixes up following warning
reported by checkpatch.pl :
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rts5208/rtsx_chip.c | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Monday, September 21, 2015 3:18 AM
> To: KY Srinivasan ; Greg KH
>
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com
> Subject: Re: [PAT
2015-09-20 22:16 GMT-04:00 Greg Kroah-Hartman :
> On Sun, Sep 20, 2015 at 01:14:14PM -0400, Raphaël Beamonte wrote:
>> Add some temporary variables to reduce line length under the maximum
>> of 80 characters, as per the kernel code style.
>>
>> Signed-off-by: Raphaël Beamonte
>> ---
>> drivers/st
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Monday, September 21, 2015 3:26 AM
> To: KY Srinivasan ; Greg KH
>
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com
> Subject: Re: [PAT
On Mon, Sep 21, 2015 at 04:27:28PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Sunday, September 20, 2015 10:29 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...
On Mon, Sep 21, 2015 at 04:22:01PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Sunday, September 20, 2015 10:28 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...
On Mon, Sep 21, 2015 at 04:34:56PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Olaf Hering [mailto:o...@aepfle.de]
> > Sent: Monday, September 21, 2015 3:26 AM
> > To: KY Srinivasan ; Greg KH
> >
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> >
This patch fixes the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
+/*
+Copyright (c) 2010 Werner Dittmann
Signed-off-by: Amber N. Adams
---
drivers/staging/skein/skein_api.h | 48 +++
1 file changed, 24 insertions(+), 24 deletions(
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Monday, September 21, 2015 5:17 AM
> To: Vitaly Kuznetsov
> Cc: KY Srinivasan ; Greg KH
> ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com
> Subject: Re: [PATCH
On Mon, Sep 21, 2015 at 11:42:28AM -0400, Doug Ledford wrote:
> On 09/18/2015 11:01 PM, Greg Kroah-Hartman wrote:
> > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote:
> >> On 09/16/2015 02:22 AM, Dan Carpenter wrote:
> >>> __get_txreq() returns an ERR_PTR() but this checks for NULL so
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, September 21, 2015 9:44 AM
> To: KY Srinivasan
> Cc: Olaf Hering ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com
> Subje
On 09/21/2015 12:48 PM, Greg Kroah-Hartman wrote:
> But, that's already not happening, as is obvious by my inbox.
Yeah, I see that.
> So, how about you forward on what you have so far to me, and I'll keep
> these. Otherwise you will end up with nasty merge issues very quickly
> as people will c
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, September 21, 2015 9:41 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; Jake
On Sun, Sep 20, 2015 at 11:32:06AM -0500, Amber N. Adams wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Block comments use * on subsequent lines
> +/*
> +Copyright (c) 2010 Werner Dittmann
>
> Signed-off-by: Amber N. Adams
> ---
> drivers/staging/skein/skein_api.h | 48
> +++
Make the kernel-doc layout for `struct comedi_async` more consistent
with the documentation for the other COMEDI data types.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 50 +++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 84 --
1 file changed, 81 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 782d1c5..6a30af2 100644
--- a/drivers/staging
Add kernel-doc for `struct comedi_buf_map` and the associated `struct
comedi_buf_page`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi
The existing constants `COMEDI_CB_EOS` etc. are in the form of macros
and have a bogus kernel-doc comment. Change them to `enum` constants so
they can be documented properly with kernel-doc.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 23 ---
1 file ch
This series fixes an incorrectly formatted block comment, adds more
kernel-doc documenation and tweaks the existing documentation for
consistency and to document return values of inline functions.
01) staging: comedi: comedidev.h: reformat copyright comment
02) staging: comedi: comedidev.h: use en
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 38 +-
1 file changed, 33 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 66081ff..782d1c5 100644
--- a/drivers/staging
Tweak the kernel-doc for already documented inline functions for
consistency, and document their return values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 92 --
1 file changed, 59 insertions(+), 33 deletions(-)
diff --git a/drivers/st
Use the preferred block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 28a5d3a..0
Tweak the formatting of the kernel-doc formatted comment for `struct
comedi_async` in order to stop it generating bogus headings for text
before a colon.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
d
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 125 +
1 file changed, 125 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 6a30af2..ccd761b 100644
--- a/drivers/staging/comedi/comedid
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index cfb7d52..195fa57 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/c
Add kernel-doc headers to the inline functions that do not have them
yet.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 114 -
1 file changed, 113 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/sta
This patch is to rtsx_chip.h that fixes up following warning reported
by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rts5208/rtsx_chip.h | 66 +++--
1
This patch is to rtsx_chip.h that fixes up following warning reported
by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rts5208/rtsx_chip.h | 66 +++--
1
This patch is to the rtsx_transport.c that fixes up following warning
reported by checkpatch.pl :
-Block comments use * subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rts5208/rtsx_transport.c | 27 ++-
On Mon, Sep 21, 2015 at 05:36:06PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Monday, September 21, 2015 9:41 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...@
Signed-off-by: Parshuram Thombare
---
drivers/staging/dgnc/dgnc_tty.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index fbfe79a..b42b543 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/st
On Mon, Sep 21, 2015 at 08:59:30PM +, Thombare, Parshuram (P.) wrote:
> Signed-off-by: Parshuram Thombare
Your subject is really odd :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driv
On Mon, Sep 21, 2015 at 01:03:52PM -0400, Doug Ledford wrote:
> On 09/21/2015 12:48 PM, Greg Kroah-Hartman wrote:
>
> > But, that's already not happening, as is obvious by my inbox.
>
> Yeah, I see that.
>
> > So, how about you forward on what you have so far to me, and I'll keep
> > these. Oth
On 2015/09/21, 4:46 PM, "Mike Rapoport" wrote:
>On Mon, Sep 21, 2015 at 12:54:54PM +, Dilger, Andreas wrote:
>> On 2015/09/21, 2:25 PM, "Mike Rapoport" wrote:
>>
>> >Use BIT_ULL() macro instead of long hexadecimal constants with only
>> >single bit set.
>> >
>> >Signed-off-by: Mike Rapoport
The driver is using -1 instead of the -ENOMEM defined macro to specify
that a buffer allocation failed. Since the error number is propagated,
the caller will get a -EPERM which is the wrong error condition.
Also, the smatch tool complains with the following warning:
dgap_parsefile() warn: returni
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, September 21, 2015 1:45 PM
> To: KY Srinivasan
> Cc: o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;
> Jake Oshins ; a...@canonical.com;
> de...@linuxdriverproject.org
> Subject: R
Convert C99-style // comments to C89-style comments and fix C99_COMMENTS
checpatch errors.
Signed-off-by: Mike Rapoport
---
.../lustre/lustre/include/lustre_dlm_flags.h | 76 +++---
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/lustre/lustr
On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to specify
> that a buffer allocation failed. Since the error number is propagated,
> the caller will get a -EPERM which is the wrong error condition.
Just a littl
From: Leo Kim
This patch removes the potential faults which may happen when unexpectedly
getting access to invalid pointer. Return error when the invalid memory is
accessed.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 +++-
1 file changed,
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for using multiple blank lines.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan_if.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wla
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl for line over 80
characters. And also align comments which is not over 80 but to align with them.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan_if.h | 644 ++
From: Leo Kim
This patch fix alignment of defines and items in enum and structure.
Signed-off-by: Leo Kim
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan_if.h | 580
1 file changed, 290 insertions(+), 290 deletions(-)
diff --git a/drivers/stagi
Hello Sudip,
On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
>> The driver is using -1 instead of the -ENOMEM defined macro to specify
>> that a buffer allocation failed. Since the error number is propagated,
>> the caller
On Tue, Sep 22, 2015 at 08:38:43AM +0200, Javier Martinez Canillas wrote:
> Hello Sudip,
>
> On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> > On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
> >> The driver is using -1 instead of the -ENOMEM defined macro to specify
> >>
89 matches
Mail list logo
