[PATCH v2 1/6] staging: wilc1000: remove a macro WILC_NULLCHECK

From: Leo Kim This patch replaces WILC_NULLCHECK with the plain statements and then removes the macro WILC_NULLCHECK in wilc_errorsupport.h which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 +-- drivers/sta

[PATCH v2 2/6] staging: wilc1000: remove the macro WILC_ERRORCHECK

From: Leo Kim This patch removes the macro WILC_ERRORCHECK which is not used anymore by replacing it with the plain statements. This patch also removes the WILC_CATCH macros from some of functions not to make the build warnings. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/stag

[PATCH v2 3/6] staging: wilc1000: remove the macro WILC_ERRORREPORT

From: Leo Kim This patch removes the macro WILC_ERRORREPORT which is not used anymore by replacing it with the plain statements. The compiler complains the build warnings in some functions for WILC_CATCH and ERRORHANDLER as unused definitions. So, this patch also removes WILC_CATCH and ERRORHAND

[PATCH v2 6/6] staging: wilc1000: remove wilc_errorsupport.h

From: Leo Kim This patch removes the wilc_errorsupport.h which is not used anymore and also deletes #include "wilc_errorsupport.h" from the source code. In addition, adds linux_wlan_common.h file in the wilc_msgqueue.c file in order to use PRINT macros defined in the linux_wlan_common.h file. S

[PATCH v2 4/6] staging: wilc1000: remove definitions unused

From: Leo Kim Remove the definitions which are not used anywhere. - WILC_ALREADY_EXSIT - WILC_EMPTY - WILC_FULL - WILC_CANCELED - WILC_INVALID_FILE - WILC_UNSUPPORTED_VERSION - WILC_FILE_EOF Remove the definition which is not used anymore. - WILC_CATCH Signed-off-by: Leo Kim Signed-off-by: Ton

[PATCH v2 0/6] removing wilc_errorsupport.h file

This series of patch is resent in total 6 patches as version 2. This version fixes the warnings reported by checkpatch.pl not to make additional warnings. The concern for the memory leak issue is checked again in this version. The error types provided by wilc driver are being replaced by the ones

[PATCH v2 5/6] staging: wilc1000: replace wilc error types with the generic error types

From: Leo Kim This patch replaces the error types defined by wilc driver with the generic error types provided by the Linux kernel. - WILC_SUCCESS 0 - WILC_FAIL -EFAULT - WILC_BUSY -EBUSY - WILC_INVALID_ARGUMENT -EIN

[PATCH 4/8] staging: wilc1000: remove function linux_wlan_rxq_task

From: Glen Lee linux_wlan_rxq_task is not used in the driver. Just remove it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drive

[PATCH 2/8] staging: wilc1000: remove define WILC_P2P and ifdef line

From: Glen Lee WILC_P2P is always used in the driver. So delete define WILC_P2P and ifdef line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 -- drivers/staging/wilc1000/coreconfigurator.h | 2 -- drivers/staging/wilc1000/ho

[PATCH 1/8] staging: wilc1000: remove define WILC_AP_EXTERNAL_MLME and ifdef line

From: Glen Lee This driver use WILC_AP_EXTERNAL_MLME define always. Delete define WILC_AP_EXTERNAL_MLME and ifdef line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 30 +++ drivers/staging/wilc1000/linux_mon.c

[PATCH 3/8] staging: wilc1000: remove define TCP_ENHANCEMENTS and it's related code

From: Glen Lee TCP_ENHANCEMENTS is always in use. Remove define TCP_ENHANCEMENTS, ifdef line, ifndef line and codes inside ifndef. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 36 --- drivers/staging/wilc1000/wilc_

[PATCH 6/8] staging: wilc1000: remove unused semaphore and it's related codes

From: Glen Lee Variable rxq_event, rxq_wait_event and rxq_wait have the same pointer. nwi->os_context.rxq_wait_event = (void *)&g_linux_wlan->rxq_event; g_wlan.rxq_wait = inp->os_context.rxq_wait_event; They are never aquired(down) since down function was only called in linux_wlan_rxq_task whic

[PATCH 8/8] staging: wilc1000: remove unused variable rxq_thread

From: Glen Lee The rxq_thread never runs since it's kthread_run code was delete in a previous patch. Remove kthread_run and it's related codes. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 6 -- drivers/staging/wilc1000/wilc_wfi_netde

[PATCH 5/8] staging: wilc1000: remove variable rxq_thread_started

From: Glen Lee rxq_thread_started is initiallized but never used in the driver. Remove the variable and init code line. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 2 files changed

[PATCH 7/8] staging: wicl1000: remove function pointer wlan_handle_rx_que

From: Glen Lee The function pointer wlan_handle_rx_que is not called anywhere. Delete wlan_handle_rx_que and it's assignment code. But the function wilc_wlan_handle_rxq in assignment code is used. So leave it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_w

[PATCH 01/10] staging: wilc1000: wilc_wlan.c: use BIT(x) macro

Remove bit shift macro that is custom defined, then replace BIT(x) macro. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wlan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c ind

[PATCH 03/10] staging: wilc1000: remove INLINE macro

This patch removes INLINE macro that is used anymore. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 1 - drivers/staging/wilc1000/wilc_wlan.c| 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging

[PATCH 04/10] staging: wilc1000: replace __inline with inline

This patch replaces __inline with inline. plain inline is more preferred than __inline. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wlan.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wi

[PATCH 02/10] staging: wilc1000: replace INLINE with static inline

INLINE macro is defined as static __inline so that it is replaced by static inline. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 30 ++--- drivers/staging/wilc1000/wilc_wlan.c| 16 +++ 2 files changed, 23 insertions(+),

[PATCH 05/10] staging: wilc1000: replace int8_t with int

This patch replaces int8_t with int. just use return type as int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1

[PATCH 06/10] staging: wilc1000: linux_wlan_spi.c: fix kzalloc error check

This patch fixs error check of kzalloc. If kzalloc is failed, return type is used as -ENOMEM. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan_spi.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_

[PATCH 08/10] staging: wilc1000: remove WILC_TIME typedef

This patch removes WILC_TIME typedef that is not used anymore. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_platform.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_platform.h b/drivers/staging/wilc1000/wilc_platform.h index 5c867ec..b763616

[PATCH 07/10] staging: wilc1000: remove unused defines

This patch removes unused defines. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_platform.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_platform.h b/drivers/staging/wilc1000/wilc_platform.h index 1e56973..5c867ec 100644 --- a/drivers/stag

[PATCH 10/10] staging: wilc1000: remove declaration of wilc_get_chipid

This patch removes the declaration of wilc_get_chipid function. It is included wilc_wlan_if.h that has declaration of wilc_get_chipid. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wil

[PATCH 09/10] staging: wilc1000: remove useless comment

This patch removes useless comment that is included "BugID_" Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 36 --- drivers/staging/wilc1000/host_interface.h | 4 --- drivers/staging/wilc1000/linux_wlan.c | 8 - d

[PATCH v2] staging: lustre: lnet: lnet: Removed a space

Removed a space to fix the following coding style warning detected by checkpatch: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Anjali Menon --- Modified the subject drivers/staging/lustre/lnet/lnet/router.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH] staging: wilc1000: Added new lines

Added new lines after declarations for removing coding style warnings detected by checkpatch.The warnings are given below: 1561: WARNING: Missing a blank line after declarations 1551: WARNING: Missing a blank line after declarations 1329: WARNING: Missing a blank line after declarations 1213: WARN

[PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const

Declared the file_operations structure as const as done elsewhere in the kernel, as there are no modifiactions to this field. Following warning found by checkpatch WARNING: struct file_operations should normally be const Signed-off-by: Sakshi Vaid --- drivers/staging/lustre/lustre/mdc/lproc_mdc

[PATCH] Staging: lustre: lustre: mgc: mgc_request.c: Removed unnecessary space

Removed the unnecessary space in the declaration of a pointer. The following error was given. ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Sakshi Vaid --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH] Staging: wlan-ng: fix a wrong type of a assignment

The type of value is u16 however the return type of cpu_to_le16() is __le16. The incorrect type of assignment is complained by sparse. Signed-off-by: Navy Cheng --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa38

Re: [PATCH] staging: dgap: Remove myself from the MAINTAINERS file

On Wed, Sep 16, 2015 at 10:30:37AM +0530, Sudip Mukherjee wrote: > On Tue, Sep 15, 2015 at 06:05:29AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote: > > > > > > > Signed-off-by: Mark Hounschell > > > Cc: Greg Kroah-Hartman > > > Cc: Ben Hut

Re: [PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

On Sep 16, 2015, at 1:35 AM, Sudip Mukherjee wrote: > On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> Since the client can never be server, this is all dead code. >> >> Signed-off-by: Oleg Drokin >> --- > OOPS.. build fails with error: > error:

[PATCH] staging: most: Add dependency to HAS_IOMEM

This patch prevents the module hdm_dim2 from breaking the build in case HAS_IOMEM is not configured. Reported-by: Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/hdm-dim2/Kconfig b/drivers/stag

Re: [PATCH 0/3] VME bus error handling overhaul

> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: >> Hi Dmitry, >> >> These are looking good to me. > > Can I get an "Acked-by:" or something so that I know it's ok to apply > these? > > thanks, > > greg k-h- Now that

Re: [PATCH 0/3] VME bus error handling overhaul

On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: > > > On 05 Aug 2015, at 16:12, Greg Kroah-Hartman > > wrote: > > > > On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: > >> Hi Dmitry, > >> > >> These are looking good to me. > > > > Can I get an "Acked-by:" or some

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman > wrote: > > On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >> >>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman >>> wrote: >>> >>> On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: Hi Dmitry, These

[patch] IB/hfi1: mask vs shift confusion

We are shifting by the _MASK macros instead of the _SHIFT ones. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c index a8c903c..3a457d2 100644 --- a/drivers/staging/rdma/hfi1/sdma.c +++ b/drivers/staging/rdma/hfi1/sdma.c @@ -1848,7 +18

[patch] IB/hfi1: clean up some defines

I added spaces around operators so it matches kernel style because normally "-1ULL" is a number and " - 1" is a subtract operation. Also removed some superflous "ULL" types so "1ULL" becomes "1". Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/sdma.h b/drivers/staging/rdma/h

[PATCH] staging: wilc1000: Removed unwanted curly braces

Removed unwanted curly braces of a single statement if-else block to remove a coding style warning detected by checkpatch. The warning is given below: 58: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Aparna Karuthodi --- drivers/staging/wilc1000/fifo_buffer.

[PATCH v2 00/19] Lustre cleanups

From: Oleg Drokin This bunch of patches removes significant chunks of Lustre specific allocators which is possible thanks to prior patches from Julia Lawall. Also removed are some server-only bits of code that make no sense to retain in a client. Please consider. The v2 version fixes build erro

[PATCH v2 01/19] staging/lustre: Remove OBD_CPT_ALLOC_LARGE

From: Oleg Drokin Remove OBD_CPT_ALLOC_LARGE define and convert the only user to libcfs_kvzalloc_cpt. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 5 - drivers/staging/lustre/lustre/ptlrpc/service.c | 6 -- 2 files changed, 4 insertions(+),

[PATCH v2 07/19] staging/lustre: Remove references to OBD_ALLOC/FREE* in comments

From: Oleg Drokin Since everything is now supposed to use regular kernel alloc and free functions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +- drivers/staging/lustre/lustre/include/lustre_net.h | 2 +- drivers/staging/lustre/lustre/llite/file.c

[PATCH v2 04/19] staging/lustre: Remove users of OBD_ALLOC/FREE_PTR lu_object.h

From: Oleg Drokin These are converted to regular kzalloc/kfree calls. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lu_object.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lu

[PATCH v2 13/19] staging/lustre: Remove unused OBD_ALLOC* and OBD_FREE macros

From: Oleg Drokin This removes now unused OBD_ALLOC, OBD_ALLOC_GFP, OBD_ALLOC_PTR, OBD_ALLOC_LARGE and supporting infrastructure. Also OBD_FREE, OBD_FREE_PTR, OBD_FREE_LARGE and supporting infrastructure. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 52 --

[PATCH v2 15/19] staging/lustre: Remove lustre used memory tracking framework

From: Oleg Drokin Lustre memory allocation framework has a feature to track amount of allocated memory, but since it's not being used consistently anymore and is on the way out in general, just remove it. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 60 +-

[PATCH v2 10/19] staging/lustre/ptlrpc: Replace OBD_FREE_PTR with kfree

From: Oleg Drokin Part of effort of getting rid of custom Lustre alloc/free macros Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h b

[PATCH v2 05/19] staging/lustre/llite: Get rid of OBD_ALLOC/FREE_PTR

From: Oleg Drokin The remaining users in ll_open_cleanup and obd_mod_alloc are converted to regular kzalloc/kfree. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 4 ++-- drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +- 2 files changed, 3 insertions(+),

[PATCH v2 03/19] staging/lustre: Remove unused OBD_CPT_ALLOC* macros

From: Oleg Drokin OBD_CPT_ALLOC and friends are no longer used, so remove them. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_support.h b/drivers/staging/

[PATCH v2 08/19] staging/lustre/fld: Replace OBD_ALLOC_GFP with kzalloc

From: Oleg Drokin Part of effort to get rid of custom Lustre allocation macros. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c b/drivers/staging/lust

[PATCH v2 17/19] staging/lustre: Remove IS_SERVER and all users

From: Oleg Drokin Since the client can never be server, this is all dead code. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_disk.h| 2 - drivers/staging/lustre/lustre/mgc/mgc_request.c| 36 ++--- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 85 ++

[PATCH v2 18/19] staging/lustre: remove IS_MDS|IS_OST|IS_MGS defines and users

From: Oleg Drokin These could only happen on the server, so they make no sense on the client. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_disk.h | 3 --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 8 drivers/staging/lustre/lustre/obdclass/obd

[PATCH v2 11/19] staging/lustre: Replace last users of OBD_ALLOC/FREE_LARGE

From: Oleg Drokin OBD_ALLOC_LARGE is now replaced with libcfs_kvzalloc and OBD_FREE_LARGE is now replaced with kvfree. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +- drivers/staging/lustre/lustre/include/obd.h| 8 2 files changed, 5 i

[PATCH v2 12/19] staging/lustre: Remove stray bit of userland utils code

From: Oleg Drokin The UTILS are userland and I see it's causing confusion with things beging already converted to kmalloc, so just remove it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 18 -- 1 file changed, 18 deletions(-) diff --git

[PATCH v2 19/19] staging/lustre: Remove server defines from lustre_disk.h

From: Oleg Drokin Take initial stab at removing server-disk related defines that client does not need. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_disk.h| 137 - .../staging/lustre/lustre/obdclass/llog_internal.h | 8 -- 2 files changed, 14

[PATCH v2 14/19] staging/lustre: Remove memory allocation fault injection framework

From: Oleg Drokin Lustre memory allocation wrappers also included a fault injection framework that's totally redundant, since in-kernel offering is actually superior to what we had. So let's remove it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 20 +---

[PATCH v2 02/19] staging/lustre: Remove unused OBD_VMALLOC

From: Oleg Drokin These macros are not used anymore, so let's remove them, also __OBD_VMALLOC_VEROBSE and OBD_CPT_VMALLOC Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 29 -- 1 file changed, 29 deletions(-) diff --git a/drivers/staging

[PATCH v2 09/19] staging/lustre: Convert lustre_cfg_new/free to use kzalloc/kfree

From: Oleg Drokin Part of effort of getting rid of custom Lustre allocation macros Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_cfg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h b/d

[PATCH v2 16/19] staging/lustre: remove obd_memory stats counter

From: Oleg Drokin Now that we no longer track allocated memory, remove obd_memory statistics counter and all references to it everywhere Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h| 7 --- drivers/staging/lustre/lustre/obdclass/class_obd.c |

[PATCH v2 06/19] staging/lustre/obdclass: replace OBD_ALLOC_GFP with kzalloc

From: Oleg Drokin Part of getting rid of custom Lustre allocation macros. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lu

[PATCH] staging: unisys: remove reference of visorutil

commit 53490b545cb0 ("staging: unisys: move periodic_work.c into the visorbus directory") has removed the visorutil directory but missed removing the reference in the Makefile. Fixes: 53490b545cb0 ("staging: unisys: move periodic_work.c into the visorbus directory") Signed-off-by: Sudip Mukherje

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:55, Dmitry Kalinkin wrote: > > >> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman >> wrote: >> >> On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman wrote: On Mon, Jul 06, 2015 at 01:3

[PATCH] staging: wilc1000: Added spaces

Added spaces around '=' to remove coding style errors detected by checkpatch.The errors are given below: drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required around that '=' (ctx:VxV) drivers/staging/wilc1000/host_interface.c:7952: ERROR: spaces required around that '=' (ctx:VxW)

Re: [PATCH] staging: wilc1000: Removed unwanted curly braces

On Wed, Sep 16, 2015 at 09:50:50PM +0530, Aparna Karuthodi wrote: > Removed unwanted curly braces of a single statement if-else block to > remove a coding style warning detected by checkpatch. The warning is > given below: > > 58: WARNING: braces {} are not necessary for any arm of this statement

[PATCH] staging: comedi: drivers: coding style: fixed block comment style

This is a patch to the drivers.c file that fixes a block comment style. Signed-off-by: Marcos Canán --- drivers/staging/comedi/drivers.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/com

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >> "Using plain integer as NULL pointer" b

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Sep 17, 2015 at 07:13:39AM +0530, Ronit Halder wrote: > Why not the second one? Second what? > None of the line edited in first patch haven't changed after that. I don't understand what you

[PATCH] staging/lustre: use __noreturn for lbug_with_loc

fixes sparse error: drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error: symbol 'lbug_with_loc'redeclared with different type (originally declared at drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82) - different modifiers Use the __nore

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

Sorry for the ambiguity. I am talking about my second patch in the series. https://lkml.org/lkml/2015/9/15/293 > > None of the line edited in first patch haven't changed after that. You applied the version 1 of the first patch in the series https://git.kernel.org/cgit/linux/kernel/git/gregkh/stag

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > Sorry for the ambiguity. > I am talking about my second patch in the series. > https://lkml.org/lkml/2015/9/15/293 > > > > None of the line edited in first patch haven't changed after that. > > You applied the version 1 of the first patch in

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed af

Re: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const

On Wed, Sep 16, 2015 at 06:01:01PM +0530, Sakshi Vaid wrote: > Declared the file_operations structure as const as done elsewhere in the > kernel, as there are no modifiactions to this field. > > Following warning found by checkpatch > WARNING: struct file_operations should normally be const > > S

Re: [PATCH] Staging: lustre: lustre: mgc: mgc_request.c: Removed unnecessary space

On Wed, Sep 16, 2015 at 06:27:12PM +0530, Sakshi Vaid wrote: > Removed the unnecessary space in the declaration of a pointer. > The following error was given. > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Sakshi Vaid > --- > drivers/staging/lustre/lustre/mgc/mgc_request.c

Re: [PATCH 03/10] staging: wilc1000: remove INLINE macro

On Wed, Sep 16, 2015 at 08:11:28PM +0900, Chaehyun Lim wrote: > This patch removes INLINE macro that is used anymore. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/coreconfigurator.c | 1 - > drivers/staging/wilc1000/wilc_wlan.c| 1 - > 2 files changed, 2 deletions(-)

Re: [PATCH] staging: wilc1000: Added spaces

On Thu, Sep 17, 2015 at 12:12:50AM +0530, Aparna Karuthodi wrote: > Added spaces around '=' to remove coding style errors detected by > checkpatch.The errors are given below: > drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required > around that '=' (ctx:VxV) > drivers/staging/wilc1

Re: [PATCH] staging: wilc1000: Added new lines

On Wed, Sep 16, 2015 at 05:42:42PM +0530, Aparna Karuthodi wrote: > Added new lines after declarations for removing coding style warnings > detected by checkpatch.The warnings are given below: > > 1561: WARNING: Missing a blank line after declarations > 1551: WARNING: Missing a blank line after de

Re: [PATCH] staging: fsl-mc: up-rev version of MC interface code

On Tue, Sep 15, 2015 at 03:22:00PM -0500, J. German Rivera wrote: > The DPAA2 management complex has a versioned binary interface > that has to be kept in sync with the DPAA2 drivers. This patch > uprevs the APIs that build MC commands and parse results. > This uprev is needed to support object int

Re: [PATCH] Staging: wlan-ng: fix a wrong type of a assignment

On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote: > The type of value is u16 however the return type of cpu_to_le16() is > __le16. The incorrect type of assignment is complained by sparse. > > Signed-off-by: Navy Cheng > --- > drivers/staging/wlan-ng/hfa384x.h | 2 +- > 1 file changed,

Re: [PATCHv2 02/16] staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters

On Fri, Sep 11, 2015 at 03:29:10AM -0400, Raphaël Beamonte wrote: > Add line breaks in multiple lines to keep them under 80 characters, > as to follow the kernel code style. > > Signed-off-by: Raphaël Beamonte > --- > drivers/staging/rtl8192u/r8192U_core.c | 626 > ++

Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

On Fri, Sep 11, 2015 at 03:29:11AM -0400, Raphaël Beamonte wrote: > Add some temporary variables to reduce line length under the maximum > of 80 characters, as per the kernel code style. > > Signed-off-by: Raphaël Beamonte > --- > drivers/staging/rtl8192u/r8192U_core.c | 139 > +

Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

2015-09-17 0:57 GMT-04:00 Greg Kroah-Hartman : >> @@ -1748,8 +1755,9 @@ static short rtl8192_usb_initendpoints(struct >> net_device *dev) >> oldaddr = priv->oldaddr; >> align = ((long)oldaddr) & 3; >> if (align) { >> - newaddr = oldadd

Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

On Thu, Sep 17, 2015 at 01:06:33AM -0400, Raphaël Beamonte wrote: > 2015-09-17 0:57 GMT-04:00 Greg Kroah-Hartman : > > >> @@ -1748,8 +1755,9 @@ static short rtl8192_usb_initendpoints(struct > >> net_device *dev) > >> oldaddr = priv->oldaddr; > >> align = ((long)oldaddr

Re: [PATCH] Staging: wlan-ng: fix a wrong type of a assignment

On Wed, Sep 16, 2015 at 09:52:06PM -0700, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote: > > The type of value is u16 however the return type of cpu_to_le16() is > > __le16. The incorrect type of assignment is complained by sparse. > > > > Signed-off-by: Na

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Thu, Sep 17, 2015 at 09:09:35AM +0530, Ronit Halder wrote: > On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > > > I don't remember, that was many hundreds of patches ago, sorry. Try it > > yourself to see if I messed up. Perhaps