[PATCH v2 09/10] staging: wilc1000: coreconfigurator.h: remove unused defines

2015-09-15 Thread Tony Cho
From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/corec

[PATCH v2 10/10] staging: wilc1000: remove unused variable g_flushing_in_progress

2015-09-15 Thread Tony Cho
From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/

[PATCH v2 04/10] staging: wilc1000: remove unused defines

2015-09-15 Thread Tony Cho
From: Glen Lee This patch removes follwing unused defines. MAX_CFG_PKTLEN MSG_HEADER_LEN QUERY_MSG_TYPE WRITE_MSG_TYPE RESP_MSG_TYPE WRITE_RESP_SUCCESS INVALID MAC_ADDR_LEN Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file cha

Re: [PATCH] staging: wilc1000: Removed curly braces

2015-09-15 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 07:24:00PM +0530, Aparna Karuthodi wrote: > Removed the curly braces of a single statement if block to remove a > coding style warning detected by checkpatch. > The warning is given below: > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by:

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

2015-09-15 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 07:57:29PM -0500, Larry Finger wrote: > On 09/15/2015 11:43 AM, Luca Ceresoli wrote: > broke a driver, that person's future patches are suspect. We had one > case a few months ago that was so bad, the person is permanently > black listed. which one? The one I am thinking of

Re: [PATCH] staging: dgap: Remove myself from the MAINTAINERS file

2015-09-15 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 06:05:29AM -0700, Greg Kroah-Hartman wrote: > On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote: > > > > Signed-off-by: Mark Hounschell > > Cc: Greg Kroah-Hartman > > Cc: Ben Hutchings > > --- > > MAINTAINERS | 1 - > > 1 file changed, 1 deletion(-) > >

Re: [PATCH] staging: wlan-ng: prism2fw: coding style: Fixed too long lines.

2015-09-15 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 08:09:54PM -0300, Marcos Canán wrote: > This is a patch to the prism2fw.c file that fixes > too long lines. > > Signed-off-by: Marcos Canán > --- This will not apply because of cfa6954ced97 ("staging: wlan-ng: fix long line"). Which tree you have used? regards sudip _

Re: [PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

2015-09-15 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Since the client can never be server, this is all dead code. > > Signed-off-by: Oleg Drokin > --- OOPS.. build fails with error: error: ‘lsi’ undeclared (first use in this function) reegards sudip ___

[patch] IB/hfi1: info leak in get_ctxt_info()

2015-09-15 Thread Dan Carpenter
The cinfo struct has a hole after the last struct member so we need to zero it out. Otherwise we don't disclose some uninitialized stack data. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c index 4698617..2c43ca5 100644 ---

[patch] IB/hfi1: checking for NULL instead of IS_ERR

2015-09-15 Thread Dan Carpenter
__get_txreq() returns an ERR_PTR() but this checks for NULL so it would oops on failure. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/verbs.c b/drivers/staging/rdma/hfi1/verbs.c index 53ac214..41bb59e 100644 --- a/drivers/staging/rdma/hfi1/verbs.c +++ b/drivers/staging/rd

[patch] IB/hfi1: fix a locking bug

2015-09-15 Thread Dan Carpenter
mutex_trylock() returns zero on failure, not EBUSY. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index 654eafe..aa58e59 100644 --- a/drivers/staging/rdma/hfi1/chip.c +++ b/drivers/staging/rdma/hfi1/chip.c @@ -2710,7 +2710,7 @@ int

Re: [patch] IB/hfi1: info leak in get_ctxt_info()

2015-09-15 Thread Julia Lawall
On Wed, 16 Sep 2015, Dan Carpenter wrote: > The cinfo struct has a hole after the last struct member so we need to > zero it out. Otherwise we don't disclose some uninitialized stack data. I think the "don't" wasn't intended in the second sentence? julia > > Signed-off-by: Dan Carpenter > >

Re: [patch] IB/hfi1: info leak in get_ctxt_info()

2015-09-15 Thread Dan Carpenter
On Wed, Sep 16, 2015 at 08:25:00AM +0200, Julia Lawall wrote: > On Wed, 16 Sep 2015, Dan Carpenter wrote: > > > The cinfo struct has a hole after the last struct member so we need to > > zero it out. Otherwise we don't disclose some uninitialized stack data. > > I think the "don't" wasn't intend

[patch v2] IB/hfi1: info leak in get_ctxt_info()

2015-09-15 Thread Dan Carpenter
The cinfo struct has a hole after the last struct member so we need to zero it out. Otherwise we disclose some uninitialized stack data. Signed-off-by: Dan Carpenter --- v2: typo in changelog diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c index 4698617

<    1   2