Re: [PATCH] staging: netlogic: platform: Fix miscellaneous coding style issues

2015-09-14 Thread Sudip Mukherjee
On Mon, Sep 14, 2015 at 10:31:05PM +, Martin Pietryka wrote: > This patch fixes all alignment issues, as well as a multiple > assignment and multiple blank lines issues. These are too many things to be included in a single patch. Please break them into a series. One patch should do only one typ

[PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

2015-09-14 Thread Tony Cho
From: Glen Lee g_num_total_switches is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/cor

[PATCH 3/4] staging: wilc1000: coreconfigurator.h: remove unused defines

2015-09-14 Thread Tony Cho
From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/corec

[PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

2015-09-14 Thread Tony Cho
From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h

[PATCH 4/4] staging: wilc1000: remove unused variable g_flushing_in_progress

2015-09-14 Thread Tony Cho
From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/

Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

2015-09-14 Thread Sudip Mukherjee
On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote: > This patch aims to remove the wilc_errorsupport.h which is unnecessary in the > wilc driver. This patch replaces the error types defined by wilc driver with > kernel generic error types and removes macros which handles the errors. Patch 2

Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

2015-09-14 Thread Tony Cho
On 2015년 09월 15일 15:27, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote: This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and rem

[patch] staging: wilc1000: off by one in get_handler_from_id()

2015-09-14 Thread Dan Carpenter
The > should be >= here or we read beyond the end of the array. Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument') Signed-off-by: Dan Carpenter diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 59a1a9d..621fd18 100644 --- a

<    1   2