Hi,
Following comments from Dan Carpenter on my previous patch to
limit the lines lengths for rtl8192u/r8192U_core.c [1], please
find attached a set of patches splitting those operations.
I also took care of keeping the code the more readable possible,
some of those patchs even aim to clean the o
Move, replace and reorganize comments to stay under 80 characters
per line, as to follow the kernel code style. Some unuseful comments
have been removed.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 232 ++---
1 file changed, 153 insert
Add line breaks in multiple lines to keep them under 80 characters,
as to follow the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 626 ++---
1 file changed, 421 insertions(+), 205 deletions(-)
diff --git a/drivers/st
Reverse conditions and use goto in the function rtl8192_adapter_start
to have most of it under 80 characters per line.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 91 ++
1 file changed, 47 insertions(+), 44 deletions(-)
diff --git
Reverse some conditions to clean the code and allow to have lines
under 80 characters, as to follow the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 48 ++
1 file changed, 25 insertions(+), 23 deletions(-)
diff -
Add some temporary variables to reduce line length under the maximum
of 80 characters, as per the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 139 ++---
1 file changed, 94 insertions(+), 45 deletions(-)
diff --git a
Refactor code to avoid multiple check of same boolean value, and to
make the code clearer. This patches also implements the necessary
changes for the code lines in this function to be under 80 chars.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 259 +++
Local variable last_beacon_adc_pwdb was used to store a value that wasn't
used after. This patch removes that variable.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r81
Rename variable to a shorter name to allow easier code
refactoring in following patch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/
An else block only contained an if statement. Replace that else
block by an else if block instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b
Reorganize function to make it cleaner, and respect the 80 characters
kernel code style rule.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 140 +++--
1 file changed, 81 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rtl819
Rename variable to a shorter name to allow easier code refactoring
in following patch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 84 +-
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819
Replace some inline conditions by a full if-else statement to make
the source clearer and follow the 80 characters kernel code style
rule.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --gi
Rename variable to a shorter name to allow easier code
refactoring in following patch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/sta
Rename variable to a shorter name to allow easier code
refactoring in following patches.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192
Reorganize function rtl8192_ioctl to replace a switch with only
one case besides the default by an if statement. This also allows
to follow the 80 characters kernel code style rule.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 141 -
The symbol TO_DO_LIST was used in the code to frame sections
of code unused or unusable. This patch remove all code framed
by that symbol in this driver.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_
This patch removes one of the platform dependencies, PANDA_BOARD from the
driver codes. The device tree will provide the platform dependencies in
the future commits.
Signed-off-by: Tony Cho
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4
drivers/staging/wilc1
From: Glen Lee
wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and
it's related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconf
This patch removes the preprocessor definition, RX_BH_TYPE and uses the
request_threaded_irq instead of kernel thread to execute the interrupt
handler.
As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also
removed from the linux_wlan.c file.
Signed-off-by: Tony Cho
---
driv
From: Glen Lee
This patch removes follwing unused defines.
MAX_CFG_PKTLEN
MSG_HEADER_LEN
QUERY_MSG_TYPE
WRITE_MSG_TYPE
RESP_MSG_TYPE
WRITE_RESP_SUCCESS
INVALID
MAC_ADDR_LEN
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 8
1 file cha
From: Glen Lee
The define PHY_802_11n is useless because wilc1000 support 802.11n as always.
Remove PHY_802_11n and it related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/
From: Glen Lee
Function NetworkInfoReceived, GnrlAsyncInfoReceived and
host_int_ScanCompleteReceived are declared in the header file already.
Just removes the declaration and comments.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 8
From: Glen Lee
gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in
the drivers. So just delete the variables and it's related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 11 ---
1 file changed, 11 delet
From: Glen Lee
Variable g_num_total_switches is never used so just remove it.
gastrWIDs is also not used because g_num_total_switches is deleted.
Remove gastrWIDs also.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 127 --
On Thu, Sep 10, 2015 at 06:45:15PM +0200, Noralf Trønnes wrote:
>
> 10.09.2015 06:54, skrev Sudip Mukherjee:
> >On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
> >>Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
> >>>On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Used kstrtoul instead of simple_strtoul inorder to fix a warning
detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
obsolete, use kstrtoul instead
Signed-off-by: Aparna Karuthodi
---
drivers/staging/speakup/kobjects.c |2 +-
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.
Signed-off-by: Sudip Mukherjee
---
Greg,
In fbtft_device_spi_device_register() you told to use dev_*, but that
pr_err is done when spi_busnum_to_master() fails, and in that case we
are not get
Use dev_* family of macros where we have a reference of a device.
Signed-off-by: Sudip Mukherjee
---
Greg,
In fbtft_device_spi_delete() you told to make that as dev_debug, but
since that dev_info is already under verbose so I kept it as it is.
drivers/staging/fbtft/fbtft_device.c | 15 +++
Reduce the log level of some of the pr_* calls and remove 2 pr_debug
calls which just prints "init" and "exit".
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
Used kstrtoul instead of simple_strtoul to remove a warning detected by
checkpatch.The warning is given below:
drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
obsolete, use kstrtoul instead
Signed-off-by: Aparna Karuthodi
---
drivers/staging/speakup/varhandlers.c |2 +-
Added a space to fix the following coding style error detected by
checkpatch:
ERROR: spaces required around that ':' (ctx:VxE)
Signed-off-by: Anjali Menon
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
The provides strpbrk() function that does
the same that the dgap_sindex(). Let's use already defined
function instead of writing custom.
Signed-off-by: Alexander Kuleshov
---
drivers/staging/dgap/dgap.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a
'syncrhronization' is wrong spell. 'synchronization' is correct.
Signed-off-by: Junesung Lee
---
drivers/staging/android/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 24d657b..0a9a7b3 100644
---
On Wed, Sep 09, 2015 at 03:57:09PM -0700, Anish Bhatt wrote:
> The BIT() macro is already defined in bitops.h, remove duplicate
> definitions. Users of BIT() macro are expecting unsigned int/u32, so
> add typecasts where this creates a build warning.
>
> Signed-off-by: Anish Bhatt
> ---
> driver
On Thu, Sep 10, 2015 at 05:24:58PM +0530, Sudip Mukherjee wrote:
> The return pointer from dgap_getword() is used in strcmp() where it is
> dereferenced. But dgap_getword() can return NULL.
> Lets put a check there and return 0 as error.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging
On Thu, Sep 10, 2015 at 06:52:22PM +0530, Sudip Mukherjee wrote:
> On Wed, Sep 09, 2015 at 11:31:37AM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Sep 04, 2015 at 06:53:18PM +0530, Sudip Mukherjee wrote:
> > > These variables were only assigned some values but they were never used.
> > >
> > > Sig
On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> This patch removes a unused enum tenuFrameClass.
>
> Signed-off-by: Glen Lee
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 8
> 1 file changed, 8 deletions(-)
I already a
On Fri, Sep 11, 2015 at 08:47:20PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul to remove a warning detected by
> checkpatch.The warning is given below:
> drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
>
> Signed-o
On Fri, Sep 11, 2015 at 06:06:34PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul inorder to fix a warning
> detected by checkpatch.
> The warning is given below:
> drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
>
> Sig
On Fri, Sep 11, 2015 at 04:14:00AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_set_channel to avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim
> ---
> V2: to make function name simple
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
>
On Fri, Sep 11, 2015 at 08:48:57PM +0530, Anjali Menon wrote:
> Added a space to fix the following coding style error detected by
> checkpatch:
>
> ERROR: spaces required around that ':' (ctx:VxE)
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2
42 matches
Mail list logo
