Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-03 Thread johnny . kim
Hello Greg. On 2015년 09월 03일 10:33, Greg KH wrote: On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: From: Johnny Kim The driver communicates with the chipset via the address of handlers to distinguish async data frame. The SendConfigPkt function gets the pointer address indicating th

[PATCH v2 1/5] staging/fbtft : Use BIT() macro when possible

2015-09-03 Thread Anish Bhatt
Based on checkpatch.pl recommendations, (1 << x) is replaced by BIT(x) Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 6 +++--- drivers/staging/fbtft/fb_hx8353d.c | 6 +++--- drivers/staging/fbtft/fb_s6d02a1.c | 6 +++--- drivers/staging/fbtft/fb_st7735r.c | 6 +++--- 4

[PATCH v2 0/5] staging/fbtft checkpatch and other fixes

2015-09-03 Thread Anish Bhatt
* Remove FSF mailing address * Remove stray unicode characters * Fix a bunch of whitespace issues * Use BIT() macros where recommended * Simplify addr_win debug prints v2: * Fix encoding issues with patches. * Remove unnecessary debug prints instead of replacing with a macro. * Split whitespace f

[PATCH v2 2/5] staging/fbtft : Remove repeated set_addr_win debug messages

2015-09-03 Thread Anish Bhatt
fbtft_par_dbg(DEBUG_SET_ADDR_WIN.. ) is repeated in every set_addr_win() handler, this could be replicated by using the kernel function tracer instead. Signed-off-by: Anish Bhatt Suggested-by: Greg KH --- drivers/staging/fbtft/fb_agm1264k-fl.c | 4 drivers/staging/fbtft/fb_bd663474.c|

[PATCH v2 5/5] staging/fbtft : Add missing whitespace around operators

2015-09-03 Thread Anish Bhatt
Add blank spaces around operators where recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 4 ++-- drivers/staging/fbtft/fb_ili9320.c | 4 ++-- drivers/

[PATCH v2 3/5] staging/fbtft : Remove unicode characters

2015-09-03 Thread Anish Bhatt
Remove stray unicode quotes around name Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c index bfe01f0..1eba1a0 100644 --- a/d

[PATCH v2 4/5] staging/fbtft : Fix multiple/missing blank line issues

2015-09-03 Thread Anish Bhatt
Remove or add blank lines as recommended by checkpatch.pl Signed-off-by: Anish Bhatt --- drivers/staging/fbtft/fb_agm1264k-fl.c | 3 +-- drivers/staging/fbtft/fb_bd663474.c| 1 + drivers/staging/fbtft/fb_hx8340bn.c| 4 +--- drivers/staging/fbtft/fb_hx8347d.c | 3 +-- drivers/staging/

[PATCH v2] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-03 Thread Alexander Kuleshov
printk() supports %pM format specifier for printing 6-byte MAC/FDDI addresses in hex notation small buffers, let's use it intead of %x:%x... Signed-off-by: Alexander Kuleshov --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/linux_wlan.c | 3 +-- 2 files chan

[PATCH 0/2] staging: Fix module autoload for OF platform drivers

2015-09-03 Thread Luis de Bethencourt
Hello, This series adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de Bethencour

[PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver

2015-09-03 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/mt29f_spinan

[PATCH 2/2] staging: octeon-usb: Fix module autoload for OF platform driver

2015-09-03 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/staging/octeon-usb/octeon-hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/octeon-usb/octeon-

Re: [PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-09-03 Thread Ulf Hansson
On 17 June 2015 at 10:38, Geert Uytterhoeven wrote: > Add support for easy registering of one ore more platform devices that > may: > - need clocks that are described in DT, > - be part of a PM Domain. > > All these dependencies are optional. > > Signed-off-by: Geert Uytterhoeven > --- > v2:

Re: [PATCH v2 5/7] staging: board: Add support for devices with complex dependencies

2015-09-03 Thread Geert Uytterhoeven
Hi Ulf, On Thu, Sep 3, 2015 at 2:53 PM, Ulf Hansson wrote: > On 17 June 2015 at 10:38, Geert Uytterhoeven wrote: >> Add support for easy registering of one ore more platform devices that >> may: >> - need clocks that are described in DT, >> - be part of a PM Domain. >> diff --git a/drivers/

Re: [PATCH v2] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-03 Thread Greg Kroah-Hartman
On Thu, Sep 03, 2015 at 02:05:42PM +0600, Alexander Kuleshov wrote: > printk() supports %pM format specifier for printing 6-byte MAC/FDDI > addresses in hex notation small buffers, let's use it intead of %x:%x... > > Signed-off-by: Alexander Kuleshov > --- > drivers/staging/wilc1000/host_interfa

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-03 Thread Greg KH
On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: > Hello Greg. > > On 2015년 09월 03일 10:33, Greg KH wrote: > >On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: > >>From: Johnny Kim > >> > >>The driver communicates with the chipset via the address of handlers > >>to distinguish a

[PATCH 1/5] [media] staging: omap4iss: separate links creation from entities init

2015-09-03 Thread Javier Martinez Canillas
The omap4iss driver initializes the entities and creates the pads links before the entities are registered with the media device. This does not work now that object IDs are used to create links so the media_device has to be set. Split out the pads links creation from the entity initialization so a

[PATCH 0/5] [media] Create pads links after entities registration

2015-09-03 Thread Javier Martinez Canillas
Hello, This series changes all the MC media drivers that are currently creating pads links before registering the media entities with the media device. The patches are similar to the ones posted for the OMAP3 ISP driver [0] and depends on Mauro's "[PATCH v8 00/55] MC next generation patches" [1].

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-09-03 Thread Stefan Wahren
Am 02.09.2015 um 19:29 schrieb Noralf Trønnes: > > Den 01.09.2015 19:52, skrev Brüns, Stefan: >> On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote: IMHO, this is a bad idea. A controller supporting more than 32 bpw can not set the bpw mask, as the mask is limited to 32 bits. Th

Re: [PATCH] staging: unisys: documentation and TODO tweaks

2015-09-03 Thread Greg KH
On Mon, Aug 17, 2015 at 11:09:12AM -0400, Benjamin Romer wrote: > From: Tim Sell > > Update documentation (including TODO) to reflect the current state of > the drivers. > > Signed-off-by: Tim Sell > Signed-off-by: Benjamin Romer > --- > .../Documentation/ABI/sysfs-platform-visorchipset |

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-09-03 Thread Greg KH
On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote: > Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0 > with NULL in the assignment. > > Signed-off-by: Anders Fridlund > --- > drivers/staging/most/aim-network/networking.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-09-03 Thread Greg KH
On Thu, Aug 20, 2015 at 12:12:51AM +0200, Anders Fridlund wrote: > Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0 > with NULL in the assignment. > > Signed-off-by: Anders Fridlund > --- > drivers/staging/most/aim-network/networking.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH] staging: most: make helper functions static

2015-09-03 Thread Greg Kroah-Hartman
On Mon, Aug 24, 2015 at 04:50:10PM +0200, Michał Bartoszkiewicz wrote: > This fixes two "symbol was not declared. Should it be static?" sparse > warnings. > > Signed-off-by: Michał Bartoszkiewicz > --- > drivers/staging/most/aim-sound/sound.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 delet

Re: [PATCH] staging: i2o: Used

2015-09-03 Thread Greg KH
On Tue, Aug 18, 2015 at 11:16:46PM +0530, Aparna Karuthodi wrote: > Used #include instead of #include to > remove a coding style warning detected by checkpatch. > > The warning is given below: > drivers/staging/i2o/config-osm.c:22: WARNING: Use #include > instead of > > Signed-off-by: Aparna

Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

2015-09-03 Thread Greg KH
On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote: > Since signatures of flib functions have changed, we had to > change all the corresponding calls in the MC bus driver > > Signed-off-by: J. German Rivera > --- > drivers/staging/fsl-mc/bus/dpbp.c | 232 -- >

Re: [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

2015-09-03 Thread Greg Kroah-Hartman
On Tue, Aug 18, 2015 at 12:58:19PM -0400, Raphaël Beamonte wrote: > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are > __aligned(2) You need to prove that they are aligned before I can take this patch :( ___ devel mailing list de...@

randconfig build error with next-20150903, in drivers/staging/slicoss/slicoss.c

2015-09-03 Thread Jim Davis
Building with the attached random configuration file, drivers/built-in.o: In function `slic_mcast_set_list': slicoss.c:(.text+0xf3677): undefined reference to `crc32_le' slicoss.c:(.text+0xf3687): undefined reference to `byte_rev_table' slicoss.c:(.text+0xf3690): undefined reference to `byte_rev_t

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-09-03 Thread Doug Ledford
On 08/18/2015 10:06 AM, Mike Marciniszyn wrote: > Signed-off-by: Mike Marciniszyn This was squashed into the rest of the hfi1 driver patchset. > --- > 0 files changed > > diff --git a/MAINTAINERS b/MAINTAINERS > index b3c1a56..45953e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9892,6

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-09-03 Thread Doug Ledford
On 08/18/2015 10:15 AM, Mike Marciniszyn wrote: > The move from infiniband to staging requires a temporary > PCI dependency to fix 0-day build issues. The > drivers/infiniband/hw/Kconfig gratuitously added it for all drivers. This was no longer needed after I created drivers/staging/rdma and move

[PATCH] staging: comedi: kcomedilib: Fixed coding style issue

2015-09-03 Thread Nayeemahmed Badebade
Fixed checkpatch.pl warning in kcomedilib_main.c: - Block comments use * on subsequent lines Signed-off-by: Nayeemahmed Badebade --- .../staging/comedi/kcomedilib/kcomedilib_main.c| 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/co

Re: [PATCH] drivers:staging:hfi1: Fix coding style issues

2015-09-03 Thread Doug Ledford
On 08/21/2015 10:00 AM, lysanovser...@gmail.com wrote: > From: Sergey Lysanov > > This patch fixes the following issues reported by checkpatch.pl: > - code indent should use tabs where possible > > Signed-off-by: Sergey Lysanov There were two identical patches submitted for this issue and I ha

[PATCH v2] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-03 Thread Alexander Kuleshov
printk() supports %pM format specifier for printing 6-byte MAC/FDDI addresses in hex notation small buffers, let's use it intead of %x:%x... Changelog: v1 -> v2: * In the first version of the patch was instruduced incorrect conversion, now there is previous formatting in the WILC_WFI_mon_xmit().

Re: [PATCH v2] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-03 Thread Greg Kroah-Hartman
On Fri, Sep 04, 2015 at 12:35:38AM +0600, Alexander Kuleshov wrote: > printk() supports %pM format specifier for printing 6-byte MAC/FDDI > addresses in hex notation small buffers, let's use it intead of %x:%x... > > Changelog: > > v1 -> v2: > > * In the first version of the patch was instruduce

[PATCH v2] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-03 Thread Alexander Kuleshov
printk() supports %pM format specifier for printing 6-byte MAC/FDDI addresses in hex notation small buffers, let's use it intead of %x:%x... Signed-off-by: Alexander Kuleshov --- Changelog: v1 -> v2: * In the first version of the patch was instruduced incorrect conversion, now there is previous

Re: [PATCH v2 2/5] staging/fbtft : Remove repeated set_addr_win debug messages

2015-09-03 Thread Greg KH
On Thu, Sep 03, 2015 at 12:53:34AM -0700, Anish Bhatt wrote: > fbtft_par_dbg(DEBUG_SET_ADDR_WIN.. ) is repeated in every > set_addr_win() handler, this could be replicated by using the kernel > function tracer instead. You can delete DEBUG_SET_ADDR_WIN now, and work on removing the other fbtft_par

Re: [PATCH] staging/wlan-ng : Partial checkpatch cleanups

2015-09-03 Thread Greg KH
On Mon, Aug 31, 2015 at 02:23:55AM -0700, Anish Bhatt wrote: > * Replace memcmp(... ETH_ALEN) with ether_addr_equal_unaligned() > * Replace memcpy(... ETH_ALEN) with ether_addr_copy() > > Fixes : > * CHECK : No space is necessary after a cast > * CHECK : Please don't use multiple blank lines > * C

Re: [PATCHv2] staging: amso1100: change occurrences of foo* to foo *

2015-09-03 Thread Greg KH
On Thu, Sep 03, 2015 at 09:33:24AM +0300, Ivan Radanov Ivanov wrote: > As per the Linux coding style, when declaring a pointer or a > function that returns a pointer, the use of '*' should be > adjacent to the data name or function name and not to the type > name. > > Signed-off-by: Ivan Radanov I

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-03 Thread johnny . kim
On 2015년 09월 04일 00:47, Greg KH wrote: On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: Hello Greg. On 2015년 09월 03일 10:33, Greg KH wrote: On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: From: Johnny Kim The driver communicates with the chipset via the address of hand

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-03 Thread Greg KH
On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote: > > > On 2015년 09월 04일 00:47, Greg KH wrote: > >On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: > >>Hello Greg. > >> > >>On 2015년 09월 03일 10:33, Greg KH wrote: > >>>On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: >

Re: [PATCHv2] staging: amso1100: change occurrences of foo* to foo *

2015-09-03 Thread Sudip Mukherjee
On Thu, Sep 03, 2015 at 06:37:11PM -0700, Greg KH wrote: > On Thu, Sep 03, 2015 at 09:33:24AM +0300, Ivan Radanov Ivanov wrote: > > As per the Linux coding style, when declaring a pointer or a > > function that returns a pointer, the use of '*' should be > > adjacent to the data name or function na

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-03 Thread johnny . kim
On 2015년 09월 04일 12:51, Greg KH wrote: On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote: On 2015년 09월 04일 00:47, Greg KH wrote: On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: Hello Greg. On 2015년 09월 03일 10:33, Greg KH wrote: On Thu, Aug 20, 2015 at 04:32:52PM +0900

Re: [PATCH][RESEND] staging/wlan-ng : Partial checkpatch cleanups

2015-09-03 Thread Sudip Mukherjee
On Tue, Sep 01, 2015 at 01:11:53PM -0700, Anish Bhatt wrote: > * Replace memcmp(... ETH_ALEN) with ether_addr_equal_unaligned() > * Replace memcpy(... ETH_ALEN) with ether_addr_copy() > > Fixes : > * CHECK : No space is necessary after a cast > * CHECK : Please don't use multiple blank lines > * C

Re: [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver

2015-09-03 Thread Sudip Mukherjee
On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt > --- I think you need to refresh your tree. This has

[staging:staging-testing 158/158] drivers/staging/wilc1000/host_interface.c:2084:13: warning: passing argument 5 of 'SendConfigPkt' makes integer from pointer without a cast

2015-09-03 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 20aaa13f9b1de5756512cb1680329648406340a2 commit: 20aaa13f9b1de5756512cb1680329648406340a2 [158/158] staging: wilc1000: remove spinlock wrappers config: mn10300-allyesconfig (attached as .config) repro