Re: [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening

2015-08-17 Thread Sudip Mukherjee
On Sat, Aug 15, 2015 at 09:34:03PM -0400, Raphaël Beamonte wrote: > Signed-off-by: Raphaël Beamonte > --- > @@ -2182,30 +2182,30 @@ static void rtl8192_init_priv_variable(struct > net_device *dev) > priv->EarlyRxThreshold = 7; > priv->enable_gpio0 = 0; > priv->TransmitConfig =

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Raphaël Beamonte
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee : >> + netdev_err("[Sendconfigpkt]Get Timed out\n"); > This will not compile. you can not just replace printk with > netdev_*, you need to mention a net_device. You're right! I'm making a lot of mistakes. It seems I called the m

Re: [PATCH 12/20] staging: rtl8192u: r8192U_core: fix externs in .c file code style issue

2015-08-17 Thread Sudip Mukherjee
On Sat, Aug 15, 2015 at 09:34:08PM -0400, Raphaël Beamonte wrote: > Externs should be avoided in .c files. These one were not useful and > are thus removed. These are not externs. These are forward declarations. regards sudip ___ devel mailing list de...

Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

2015-08-17 Thread Raphaël Beamonte
2015-08-18 1:02 GMT-04:00 Sudip Mukherjee : > since you are modifying these lines for consistent spacing, it will be > better to have: > (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit > This should be: > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >>

Re: [PATCH 12/20] staging: rtl8192u: r8192U_core: fix externs in .c file code style issue

2015-08-17 Thread Raphaël Beamonte
2015-08-18 1:30 GMT-04:00 Sudip Mukherjee : > These are not externs. These are forward declarations. I copied the message from checkpatch. Will edit that to make it more accurate! Thanks, Raphaël ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

2015-08-17 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 01:38:21AM -0400, Raphaël Beamonte wrote: > 2015-08-18 1:02 GMT-04:00 Sudip Mukherjee : > > since you are modifying these lines for consistent spacing, it will be > > better to have: > > (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit > > > This shoul

Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

2015-08-17 Thread Raphaël Beamonte
2015-08-18 1:44 GMT-04:00 Sudip Mukherjee : > I think that will be better, since you are sending the patch for > consistent spacing. Actually, going through the bunch of patches, it seems that the whitespace neatening one is taking care of that. That one patch was mostly about taking care of the c

Re: [PATCHv3] staging: wilc1000: use netdev_* instead of printk

2015-08-17 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote: > 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee : > >> + netdev_err("[Sendconfigpkt]Get Timed out\n"); > > This will not compile. you can not just replace printk with > > netdev_*, you need to mention a net_de

Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

2015-08-17 Thread Sudip Mukherjee
On Tue, Aug 18, 2015 at 02:02:49AM -0400, Raphaël Beamonte wrote: > 2015-08-18 1:44 GMT-04:00 Sudip Mukherjee : > > I think that will be better, since you are sending the patch for > > consistent spacing. > > Actually, going through the bunch of patches, it seems that the > whitespace neatening on

[PATCH] Staging: fbtft: Fix iomem dereference

2015-08-17 Thread Ronit Halder
This patch fixes the warning generated by sparse "cast removes address space of expression" by using ioread16 function insted of directly dereferencing I/O memory. Signed-off-by: Ronit halder --- drivers/staging/fbtft/fb_agm1264k-fl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

<    1   2