Re: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Alexander Graf
On 11.08.15 04:38, Stuart Yoder wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Sunday, August 09, 2015 9:25 AM >> To: Yoder Stuart-B08248; gre...@linuxfoundation.org; Rivera Jose-B46482; >> katz Itai-RM05202 >> Cc: de...@driverdev.osuosl.org; l

Re: [PATCH] staging: comedi: ni_usb6501: fix possible out-of-bounds access

2015-08-11 Thread Ian Abbott
On 10/08/15 18:28, H Hartley Sweeten wrote: Coverity reports a possible Out-of-bounds access (ARRAY_VS_SINGLETON) with the 'const u8 *port' parameter passed to ni6501_port_command(). This param is an actual array for the SET_PORT_DIR operation, called by ni6501_dio_insn_config(). But for the WRIT

[PATCH 0/2] Staging: iio: trigger: Fix style issues

2015-08-11 Thread Cristina Opriceana
Fix style issues reported by checkpatch.pl. Cristina Opriceana (2): Staging: iio: trigger: Alignment should match open parenthesis Staging: iio: trigger: Use braces on both branches of if statement drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 --- drivers/staging/iio/trigger/i

Re: [PATCH 0/5] staging: comedi: comedi_fops: remove BUG_ON() checkes

2015-08-11 Thread Ian Abbott
On 10/08/15 21:13, H Hartley Sweeten wrote: Drivers should not crash the kernel. H Hartley Sweeten (5): staging: comedi: comedi_fops: absorb comedi_free_board_minor() staging: comedi: comedi_fops: remove BUG_ON() in comedi_dev_get_from_board_minor() staging: comedi: comedi_fops: remove

[PATCH 1/2] Staging: iio: trigger: Alignment should match open parenthesis

2015-08-11 Thread Cristina Opriceana
Fix alignment for function parameters as suggested by checkpatch.pl. Signed-off-by: Cristina Opriceana --- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 --- drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 2/2] Staging: iio: trigger: Use braces on both branches of if statement

2015-08-11 Thread Cristina Opriceana
Fix style issue related to missing braces, detected by checkpatch.pl. Signed-off-by: Cristina Opriceana --- drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/sta

Re: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Tillmann Heidsieck
Hi Stuart, I am by no means a native speaker, but I have proof-read my fair share of articles and theses, so here are a bunch of suggestions which might or might not help improve you document. On 07.08.2015 03:09, Stuart Yoder wrote: > add README file providing an overview of the DPAA2 architec

[PATCH] staging: comedi: adl_pci7x3x: fix digital output on PCI-7230

2015-08-11 Thread Ian Abbott
The "adl_pci7x3x" driver replaced the "adl_pci7230" and "adl_pci7432" drivers in commits 8f567c373c4b ("staging: comedi: new adl_pci7x3x driver") and 657f77d173d3 ("staging: comedi: remove adl_pci7230 and adl_pci7432 drivers"). Although the new driver code agrees with the user manuals for the resp

[PATCH RFC v2 10/16] media: rename the function that create pad links

2015-08-11 Thread Mauro Carvalho Chehab
Now that a link can be either between two different graph objects, we'll need to add more functions to create links. So, rename the existing one that create links only between two pads as media_create_pad_link(). No functional changes. This patch was created via this shell script: for i i

[PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
As we'll need to create links between entities and interfaces, we need to identify the link endpoints by the media_graph_obj. Most of the changes here was done by this small script: for i in `find drivers/media -type f` `find drivers/staging/media -type f`; do perl -ne 's,([\w]+)\-\>(sou

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Hans Verkuil
Hi Mauro, Thanks for posting the missing patches. On 08/11/15 14:09, Mauro Carvalho Chehab wrote: > As we'll need to create links between entities and interfaces, > we need to identify the link endpoints by the media_graph_obj. > > Most of the changes here was done by this small script: > > for

[PATCH] staging: unisys: make visorbus_dev_groups static

2015-08-11 Thread Michał Kępień
visorbus_dev_groups is not referenced outside visorbus_main.c, so it can be declared static. Found using sparse. Signed-off-by: Michał Kępień --- drivers/staging/unisys/visorbus/visorbus_main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbu

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Aug 2015 14:25:18 +0200 Hans Verkuil escreveu: > Hi Mauro, > > Thanks for posting the missing patches. Thanks for reviewing this patch series! > > On 08/11/15 14:09, Mauro Carvalho Chehab wrote: > > As we'll need to create links between entities and interfaces, > > we need to ident

[PATCH 0/3] staging: lustre: fix checkpatch problems in llite/lloop.c

2015-08-11 Thread Swee Hua Law
Fix 3 checkpatch problems in drivers/staging/lustre/lustre/llite/lloop.c [PATCH 1/3] staging: lustre: Do not init global to NULL [PATCH 2/3] staging: lustre: Add blank line after variable declaration [PATCH 3/3] staging: lustre: Remove the space before \n ___

[PATCH 3/3] staging: lustre: Remove the space before \n

2015-08-11 Thread Swee Hua Law
Remove the extra space character right before \n in the string Signed-off-by: Swee Hua Law --- drivers/staging/lustre/lustre/llite/lloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.

[PATCH 1/3] staging: lustre: Do not init global to NULL

2015-08-11 Thread Swee Hua Law
Remove "= NULL" in global variable Signed-off-by: Swee Hua Law --- drivers/staging/lustre/lustre/llite/lloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.c index d614234..b643f11 100

[PATCH 2/3] staging: lustre: Add blank line after variable declaration

2015-08-11 Thread Swee Hua Law
Add blank line after variable declaration Signed-off-by: Swee Hua Law --- drivers/staging/lustre/lustre/llite/lloop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.c index b643f11..de5eaa0 100644 --

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Hans Verkuil
>>> diff --git a/include/media/media-entity.h b/include/media/media-entity.h >>> index 403019035424..f6e2136480f1 100644 >>> --- a/include/media/media-entity.h >>> +++ b/include/media/media-entity.h >>> @@ -43,6 +43,17 @@ enum media_graph_type { >>> MEDIA_GRAPH_LINK, >>> }; >>> >>> +/** >>>

Re: [PATCH 3/3] staging: lustre: Remove the space before \n

2015-08-11 Thread Joe Perches
On Tue, 2015-08-11 at 21:32 +0800, Swee Hua Law wrote: > Remove the extra space character right before \n in the string [] > diff --git a/drivers/staging/lustre/lustre/llite/lloop.c > b/drivers/staging/lustre/lustre/llite/lloop.c [] > @@ -308,7 +308,7 @@ static unsigned int loop_get_bio(struct llo

[PATCH] staging: comedi: Use monotonic clock

2015-08-11 Thread Abhilash Jindal
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Monotonic time is constantly increasing time better suited for comparing two timestamps. Signed-off-by: Abhilash Jindal --- drivers/staging/comedi/drivers/serial2002.c | 10 +

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-11 Thread Chandra Gorentla
On Mon, Aug 10, 2015 at 09:38:56PM +0300, Dan Carpenter wrote: > Warnings are not a bad thing they are a valuable marker to let us know > which code is broken. If we just silence the warning in the laziest > possible way then we are throwing away valuable information. It's > better to leave the w

Re: [PATCH] staging: comedi: Use monotonic clock

2015-08-11 Thread Ian Abbott
On 11/08/15 15:31, Abhilash Jindal wrote: Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Monotonic time is constantly increasing time better suited for comparing two timestamps. Signed-off-by: Abhilash Jindal --- drivers/sta

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

2015-08-11 Thread Lars-Peter Clausen
On 08/10/2015 11:51 PM, Joe Perches wrote: > Using 'extern' is not necessary for function prototypes. > > Signed-off-by: Joe Perches Acked-by: Lars-Peter Clausen Thanks. > --- > drivers/staging/iio/meter/ade7854.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

[PATCH] staging: vme: devices: remove multiple blank lines

2015-08-11 Thread Junsu Shin
This is a patch to vm2_pio2_core.c that removes multiple blanks lines. Signed-off-by: Junsu Shin --- drivers/staging/vme/devices/vme_pio2_core.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c index

Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

2015-08-11 Thread Christian Gromm
On Sun, 9 Aug 2015 17:08:41 +0300 Tomas Melin wrote: > Return NULL instead of 0 for invalid input. > > Signed-off-by: Tomas Melin Acked-by: Christian Gromm > --- > drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stagin

[PATCH] staging: vme: devices: remove blank line after open brace

2015-08-11 Thread Junsu Shin
This is a patch to the vme_pio2_core.c that removes blank line after open brace '{'. Signed-off-by: Junsu Shin --- drivers/staging/vme/devices/vme_pio2_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2

[PATCH] staging: vme: devices: fix NULL comparison style

2015-08-11 Thread Junsu Shin
This is a patch to vme_pio2_core.c that fixes up the NULL comparison style. Signed-off-by: Junsu Shin --- drivers/staging/vme/devices/vme_pio2_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices

[PATCH] staging: vme: devices: add spaces around '-'

2015-08-11 Thread Junsu Shin
This is a patch to the vme_pio2_core.c that adds spaces around '-'. Signed-off-by: Junsu Shin --- drivers/staging/vme/devices/vme_pio2_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme

RE: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Stuart Yoder
> -Original Message- > From: Tillmann Heidsieck [mailto:theidsi...@leenox.de] > Sent: Tuesday, August 11, 2015 6:01 AM > To: Yoder Stuart-B08248; gre...@linuxfoundation.org; Rivera Jose-B46482; katz > Itai-RM05202 > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse

Hello dear...

2015-08-11 Thread Laura
Hi' from Laura, I hope you are fine. My name is Miss. Mariam Laura Kone, I am 19 years old. I am presently in Bouake. It is a French speaking country. I am an orphan. I look forward to a steady and loving relationship with you, despite the distance from us, love has no boundary and if we have a

Hello dear...

2015-08-11 Thread Laura
Hi' from Laura, I hope you are fine. My name is Miss. Mariam Laura Kone, I am 19 years old. I am presently in Bouake. It is a French speaking country. I am an orphan. I look forward to a steady and loving relationship with you, despite the distance from us, love has no boundary and if we have a

Re: [PATCH 2/3] staging: lustre: Add blank line after variable declaration

2015-08-11 Thread Sudip Mukherjee
On Tue, Aug 11, 2015 at 09:32:30PM +0800, Swee Hua Law wrote: > Add blank line after variable declaration > > Signed-off-by: Swee Hua Law > --- > drivers/staging/lustre/lustre/llite/lloop.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/lustre/lustre/llite/lloop.c