[PATCH] staging: lustre: Fix coding style errors

Signed-off-by: Jandy Gou --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h index 0d8fa3a..185da2c 100644 --- a/d

[PATCH] Fix coding style error

Fix the following two coding style errors: ERROR: space prohibited before that '++' (ctx:WxO) #890: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:890: + index ++; ERROR: space prohibited before open square bracket '[' #724: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd

[PATCH 2/3] Staging: lustre: Replace comma with a semicolon.

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mgc/mgc_r

[PATCH 1/3] Staging: lustre: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/libc

[PATCH 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/platform_net.c b/driv

Re: [PATCH] staging: rtl8723au: fix up coding style warnings reported by checkpatch.pl.

Ting-Chih Hsiao writes: > remove spaces at the start of a line > align enum variable with other parameters > > Signed-off-by: Ting-Chih Hsiao Acked-by: Jes Sorensen > --- > drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [PATCH 1/3] Staging: lustre: Replace comma with a semicolon

1 and 2 need to have different subjects (the [PATCH] part is not enough, because it will go away). julia On Tue, 4 Aug 2015, Shraddha Barke wrote: > Replace comma between expression statements by a semicolon. > The semantic patch used is as follows: > > @@ > expression e1,e2; > @@ > e1 > - , > +

Re: [PATCH 1/3] Staging: lustre: Replace comma with a semicolon

On Tue, 4 Aug 2015, Shraddha Barke wrote: > > Should I resend the entire patch series as v2 ? Or only the first two > patches? The entire series. You can say under the --- that there is no change in the cases where there is no change. julia ___ devel

[PATCH v2 1/3] Staging: lustre: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v2: -No changes made. drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v2: -No changes made. drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v2: -Make subject more clearer. drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH] staging: comedi: fix coding style issue.

fixed coding style issue - replaced ENOSYS by ENODEV. Signed-off-by: Ted Chen --- drivers/staging/comedi/comedi_fops.c |2 +- drivers/staging/comedi/drivers.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/stagi

Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

Sorry not to have been more clear. The original subject text was OK. Tehway to differentiate between the patches would be to put Staging: lustre: mgc: in thi case, and Staging: lustre: libcfs: in the other one. julia On Tue, 4 Aug 2015, Shraddha Barke wrote: > Replace comma between expression s

Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

On Tue, 4 Aug 2015, Shraddha Barke wrote: > Alright . > So now I should send a version 3 right ? Yes. >  Was there any other issue in the way I sent this version ? I think it's ok. julia___ devel mailing list de...@linuxdriverproject.org http://drive

[PATCH v3 1/3] Staging: lustre: libcfs: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v3: -Make subject clearer. drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v3 2/3] Staging: lustre: mgc: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v3: -Make subject clearer. drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v3: -No changes made. drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

Re: [PATCH] staging: comedi: fix coding style issue.

On 04/08/15 14:21, Ted Chen wrote: fixed coding style issue - replaced ENOSYS by ENODEV. The patch needs a better description, and ENODEV is not necessarily the best thing to return in all cases. The patch should be split into separate patches, but one of those patches wouldn't apply any

[PATCH v3 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; --- Changes in v3: -No changes made. drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH v2 2/2] staging: unisys: visornic: Convert to using napi

From: Neil Horman Switch the visornic over to use napi. Currently there is a kernel thread that sits and waits on a wait queue to get notified of incoming virtual interrupts. It would be nice if we could handle frame reception using the standard napi processing instead. This patch creates our n

Re: [PATCH v5 07/46] usb: dwc3: gadget: add ep capabilities support

On Fri, Jul 31, 2015 at 04:00:19PM +0200, Robert Baldyga wrote: > Convert endpoint configuration to new capabilities model. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc3/gadget.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/usb/dwc3/gadget.c b/dri

Re: [PATCH v2 2/2] staging: unisys: visornic: Convert to using napi

Please disregard this version, it assumes that the kthread_park() patch was present. I will send a v3. -- Ben ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v5 00/46] usb: gadget: rework ep matching and claiming mechanism

Hi, On Fri, Jul 31, 2015 at 04:00:12PM +0200, Robert Baldyga wrote: > Hello, > > This patch series reworks endpoint matching and claiming mechanism in > epautoconf. From v2 there are couple of new patches adding 'ep_match' > to usb_gadget_ops and removing chip-specific quirk handling from generic

[PATCH 1/3] Staging: lustre: libcfs: Drop unnecessary cast on void*

This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/libcfs/linux

[PATCH 2/3] Staging: lustre: osc: Drop unnecessary cast on void *

This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/osc/osc_req

[PATCH 3/3] Staging: lustre: lov: Drop unnecessary cast on void *

This patch does away with the cast on void * as it is unnecessary. Semantic patch used is as follows: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/lov/lov_obd.

[PATCH v4 1/3] Staging: lustre: libcfs: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- Changes in v4: -Added Signed-off-by line drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1

[PATCH v4 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- Changes in v4: -Added Signed-off-by line drivers/staging/netlogic/platform_net.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v4 2/3] Staging: lustre: mgc: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows: @@ expression e1,e2; @@ e1 - , + ; e2; Signed-off-by: Shraddha Barke --- Changes in v4: -Added Signed-off-by line drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 inser

[PATCH 07/46] staging: comedi: me4000: make boardinfo flags bit-fields

Change the boardinfo 'has_counter' and 'ai_trig_analog' flags into bit-fields to save a bit of space. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/dr

[PATCH 02/46] staging: comedi: me4000: all board types have analog inputs

All the boards supported by this driver have analog inputs. They just differ in the number of channels (32 or 16). Always initialize the analog input subdevice in me4000_auto_attach(). Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 39 +---

[PATCH 25/46] staging: comedi: me4000: tidy up ME4000_AO_CTRL_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) dif

[PATCH 18/46] staging: comedi: me4000: fix me4000_ai_insn_read()

The coemdi (*insn_read) functions are supposed to read insn->n values from the hardware. Make this function work like the core expects. Use the comedi_offset_munge() helper to munge the two's complement values to offset binary. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers

[PATCH 10/46] staging: comedi: me4000: refactor 'ao_fifo' boardinfo

This member of the boardinfo is always '4' for the boards that have an analog output FIFO. Covert it to a bit-field, 'has_ao_fifo', to save a bit of space. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-

[PATCH 01/46] staging: comedi: me4000: remove 'dio_nchan' boardinfo

All the boards supported by this driver have 32 digital I/O channels. Remove the unnecessary boardinfo. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 38 +++-- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/stag

[PATCH 17/46] staging: comedi: me4000: use comedi_timeout() to wait for ai (*insn_read)

Use the comedi_timeout() helper to busy-wait for the analog input end-of- conversion instead of the udelay(). Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/sta

[PATCH 00/46] staging: comedi: me4000: cleanup driver

Here's the big cleanup series for the Comedi me4000 driver. This fixes all the checkpatch issues and removes a bunch of cruft from the driver. H Hartley Sweeten (46): staging: comedi: me4000: remove 'dio_nchan' boardinfo staging: comedi: me4000: all board types have analog inputs staging: c

[PATCH 09/46] staging: comedi: me4000: refactor 'ao_nchan' boardinfo

For the boards that have analog output capability, there are always 4 analog output channels. Convert the 'ao_nchan' member of the boardinfo into a bit-field, 'has_ao', to save a bit of space and set the analog output subdevice 'n_chan' to 4 when supported. Signed-off-by: H Hartley Sweeten --- d

[PATCH 08/46] staging: comedi: me4000: refactor 'ai_diff_nchan' boardinfo

This member of the boardinfo is only used as a flag indicating that the board supports differential analog inputs. Convert the member to a bit- field to save a bit of space. For aesthetics, rename the member to 'can_do_diff_ai'. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers

[PATCH 16/46] staging: comedi: me4000: tidy up ME4000_AI_CHANNEL_LIST_REG bit defines

Use the BIT() macro to define the bits of this register. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c index 1

[PATCH 06/46] staging: comedi: me4000: remove 'board' from me4000_ai_check_chanlist()

The maximum differential channel is half the subdevice 'n_chan'. Use that instead and remove the need for the 'board' variable. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/come

[PATCH 31/46] staging: comedi: me4000: absorb ai_write_timer()

This function is only called by me4000_ai_do_cmd(). Absorb it. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 35 + 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/s

[PATCH 33/46] staging: comedi: me4000: fix me4000_ai_cancel()

The STOP and IMMEDIATE_STOP bits in the ME4000_AI_CTRL_REG should be set, not cleared, to stop any running conversions. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 37/46] staging: comedi: me4000: introduce me4000_ai_reset()

Introduce a helper function to stop any ai conversions and reset the ai control register. This consolidates the common code in me4000_reset() and me4000_ai_cancel(). Use the new helper in the ai (*insn_read) to ensure that the ai control register is set to a known state after reading the samples.

[PATCH 20/46] staging: comedi: me4000: use comedi_range_is_bipolar() in ai (*insn_read)

Use the helper function to check the range type instead of relying on the value. For aesthetics, rename the local variable used for the range. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH 03/46] staging: comedi: me4000: only set SDF_DIFF when supported

Some of the boards supported by this driver do not have differential analog inputs. Only set the SDF_DIFF subdev_flag when the board supports it. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 04/46] staging: comedi: me4000: remove 'chan' check in me4000_ai_insn_read()

The comedi core validates that the 'chan' is valid for the subdevice before calling the (*insn_read) operation. Remove the unnecessary check. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comed

[PATCH 15/46] staging: comedi: me4000: fix ai_write_chanlist()

Rename this function so it has namespace associated with the driver. The last entry of the chanlist needs the ME4000_AI_LIST_LAST_ENTRY bit set to end the list. Fix the function and tidy if up a bit. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 23 -

[PATCH 05/46] staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()

The 'board' pointer is only used in this function to verify that the 'chan' is valid for an aref of AREF_DIFF. The comedi core ensures that that aref is only possible if the subdevice has the SDF_DIFF subdevice_flag set. If so, the maximum channel is half the subdevice 'n_chan'. Use that instead an

[PATCH 14/46] staging: comedi: me4000: simplify analog input range programming

The comedi_lrange table for the analog inputs is inverted compared to the values that need to be written to the ME4000_AI_CHANNEL_LIST_REG to select the range. Create a macro, ME4000_AI_LIST_RANGE(), to handle the inversion. Remove the old defines and simplify the code a bit. Signed-off-by: H Har

[PATCH 32/46] staging: comedi: me4000: return void from me4000_ai_write_chanlist()

This function always returns 0 and the return value is never checked. Just return void. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/stag

[PATCH 28/46] staging: comedi: me4000: move ai command timing values into private data

The ai (*do_cmd_test) calls me4000_ai_round_cmd_args() to calculate the timing values needed to the command. The the command test passes, the core will then call the ai (*do_cmd) which then has to call me4000_ai_round_cmd_args() again in order to get the same values to pass to ai_prepare() in order

[PATCH 12/46] staging: comedi: me4000: rename local variables used for 'dev->private'

In comedi drivers the local variable used for the dev->private pointer is normally named 'devpriv'. For aesthetics, rename the variables in this driver. Also, rename the struct to follow the norm. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 44 -

[PATCH 11/46] staging: comedi: me4000: refactor 'ai_sh_nchan' boardinfo

Some of the boards supported by this driver can do analog input sample & hold on 8 of the channels. The 'ai_sh_nchan' member of the boardinfo is used to indicate which boards support this feature. To save a bit of space, convert this member to a bit-field, 'can_do_sh_ai'. Note, this feature is not

[PATCH 45/46] staging: comedi: me4000: update MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more useful than "Comedi low- level driver" Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/d

[PATCH 41/46] staging: comedi: me4000: comedi_handle_events() will stop conversions

The irq handler does not need to manually stop conversions and disable interrupts when "end-of-acquisition", "error", or "overflow" events are detected. The comedi_handle_events() will call the subdevice (*cancel) when these are detected and stop the acquisition. Signed-off-by: H Hartley Sweeten

[PATCH 27/46] staging: comedi: me4000: return void from ai_round_cmd_args()

This function always succeeds. Change the return type to void and remove the unnecessary error check in me4000_ai_do_cmd(). Move the function call in me4000_ai_do_cmd_test() from before Step 1 to Step 3 where the arguments are validated. There is no reason to get the values if the previous steps f

[PATCH 36/46] staging: comedi: me4000: clear the ME4000_AI_CTRL_REG in me4000_reset()

Reset the analog input control register after ensuring that any active conversions have been stopped. This mimics what the ai subdevice (*cancel) does. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/stag

[PATCH 13/46] staging: comedi: me4000: remove unnecessary ME4000_AI_LIST_INPUT_SINGLE_ENDED

This define evaluates to 0 and is OR'ed with the 'entry' value that is written to the ME4000_AI_CHANNEL_LIST_REG when the channel aref is a single-ended type (AREF_GROUND or AREF_COMMON). OR'ing a zero value is pretty silly, just remove it. Simplify me4000_ai_insn_read() a bit. The 'aref' is valid

[PATCH 35/46] staging: comedi: me4000: remove unnecessary me4000_ai_cancel()

The comedi core ensures that the subdevice is not busy before it allows starting a new command. The subdevice (*cancel) is called when the subdevice is set to not busy. In this driver the me4000_ai_cancel() is the ai (*cancel) so the extra call in the ai (*do_cmd) is not necessary. Remove it. Sign

[PATCH 26/46] staging: comedi: me4000: tidy up ME4000_DIO_CTRL_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 51 - 1 file changed, 25 insertions(+), 26 deletions

[PATCH 39/46] staging: comedi: me4000: fix me4000_detach()

There is no real reason to reset the board when detaching. But the PLX interrupts should be disabled. Currently the PLX interrupt is left enabled when the driver is detached. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 8 ++-- 1 file changed, 6 insertions(+

[PATCH 19/46] staging: comedi: me4000: use correct types for extracted chanspec values

The chanspec channel, range, and aref are unsigned int values. Use the correct types when extracting them. Signed-off-by: H Hartley Sweeeten --- drivers/staging/comedi/drivers/me4000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/me40

[PATCH 29/46] staging: comedi: me4000: simplify ai_prepare()

The ai (*do_cmd_test) validates the trigger sources in Step 2b to ensure that they are compatible. Save the 'ai_ctrl_mode' that will be used in the private data so that ai_prepare(), which is called by the ai (*do_cmd), does not have to recheck the sources in order to figure it out. Also, tidy up

[PATCH 21/46] staging: comedi: me4000: tidy up ME4000_AI_STATUS_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Also, use ME4000_AI_STATUS_REG instead of ME4000_AI_CTRL_REG when reading the register (they happen to be the same). Signed-off-by: H Hartley Sweeten --- drivers/s

[PATCH 30/46] staging: comedi: me4000: absorb ai_prepare()

This function never fails and it's only called by me4000_ai_do_cmd(). Absorb it and remove the unnecessary failure check. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --g

[PATCH 23/46] staging: comedi: me4000: tidy up ME4000_IRQ_STATUS_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --g

[PATCH 44/46] staging: comedi: me4000: updata driver status in comedi comment

Firmware loading was fixed by: Commit: ac584af5 "staging: comedi: me4000: fix firmware downloading" Change the driver status to "untested" and remove the comments about the driver being broken, Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/

[PATCH 38/46] staging: comedi: me4000: only enable PLX interrupt if we have and irq

Currently me4000_reset() always enables the PLX interrupt. Move the enable of the interrupt into me4000_auto_attach() and only do the enable if we actually have and irq. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 13 +++-- 1 file changed, 7 insertions(

[PATCH 34/46] staging: comedi: me4000: remove unnecessary ai control register reset

The me4000_ai_cancel() already reset this register. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c index 048340b..409483a 100644

[PATCH 40/46] staging: comedi: me4000: tidy up analog output subdevice init

For aesthetics, add some white space to the analog output subdevice initialization. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/dr

[PATCH 43/46] staging: comedi: me4000: cleanup multi-line comments

Format the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 74 - 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/c

[PATCH 46/46] staging: comedi: me4000: usleep_range is preferred over udelay

Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". `udelay()` is only used in the firmware upload process. Replace them with `usleep_range()` with a reasonable upper limit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kr

[PATCH 42/46] staging: comedi: me4000: introduce me4000_ai_get_sample()

The hardware returns two's complement values for the analog input samples. These need to be converted to the unsigned binary format that the comedi core expects. Introduce a helper function to handle this. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 23

[PATCH 22/46] staging: comedi: me4000: tidy up ME4000_AI_CTRL_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 123 1 file changed, 61 insertions(+), 62 deletions

[PATCH 24/46] staging: comedi: me4000: tidy up ME4000_AO_STATUS_REG bit defines

Use the BIT() marco to define the bits of this register. For aesthetics, rename all the defines to remove the '_BIT' from the name. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/me4000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/st

[PATCH] zram: Replace pr_* with dev_*

This patch replaces pr_info/pr_warn/pr_err with dev_info/dev_warn/dev_err. Signed-off-by: Salah Triki --- drivers/block/zram/zram_drv.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zra

Re: [PATCH] zram: Replace pr_* with dev_*

On Tue, Aug 04, 2015 at 07:19:01PM +0100, Salah Triki wrote: > This patch replaces pr_info/pr_warn/pr_err with > dev_info/dev_warn/dev_err. > > Signed-off-by: Salah Triki > --- > drivers/block/zram/zram_drv.c | 40 +++- > 1 file changed, 23 insertions(+), 17 d

Re: [PATCH v5 40/46] usb: gadget: epautoconf: rework ep_matches() function

On Fri, Jul 31, 2015 at 04:00:52PM +0200, Robert Baldyga wrote: > Rework ep_matches() function to make it shorter and more readable. > > Signed-off-by: Robert Baldyga this regresses at least mass storage. How did you test it ? I'll keep all patches up to this one, please fix the problem, rebase

[PATCHv5 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings

This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore

[PATCHv5 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings

This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCHv5 0/5] Staging: most: several warnings fix reported by sparse

This patch series fix several warnings reported by the Sparse tool v2: Fixed patch format and comments as noted by Greg Kroah-Hartman and clear a few more warnings v3: Fixed patch format as noted by Greg Kroah-Hartman v4: Fixed patch format as noted by Greg Kr

[PATCHv5 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings

This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-usb/hdm_usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/d

[PATCHv5 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings

This is a patch to the most/aim_cdev.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-cdev/cdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCHv5 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings

This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-

[PATCH v3 2/2] staging: unisys: visornic: Convert to using napi

From: Neil Horman Switch the visornic over to use napi. Currently there is a kernel thread that sits and waits on a wait queue to get notified of incoming virtual interrupts. It would be nice if we could handle frame reception using the standard napi processing instead. This patch creates our n

[PATCH] staging: vt6655: Fixed C99 style comment to C89 style.

Patch created to satisfy checkpatch.pl Signed-off-by: Lior Pugatch --- drivers/staging/vt6655/rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h index b9bd163..54694df 100644 --- a/drivers/staging/vt6655/rxtx.h

[PATCH] Staging: wilc1000: Remove typedefs for struct

The Linux kernel coding style guidelines suggest not using typedefs for structure and enum types. This patch gets rid of the typedefs for Ack_session_info_t. The following Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td

[PATCH] Staging: lustre: obdclass: Use kasprintf

This patch uses kasprintf which combines kzalloc and sprintf. kasprintf also takes care of the size calculation. Semantic patch used is as follows: @@ expression a,flag; expression list args; statement S; @@ a = - \(kmalloc\|kzalloc\)(...,flag) + kasprintf (flag,args) <... when != a if (a =

[PATCH 1/2] Staging: media: lirc: use USB API functions rather than

This patch introduces the use of the function usb_endpoint_type. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Shraddha Barke --

[PATCH 2/2] Staging: ft1000: ft1000-usb: use USB API functions rather

This patch introduces the use of the function usb_endpoint_type. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Shraddha Barke ---

Re: [PATCH 1/2] Staging: media: lirc: use USB API functions rather than

On Wed, Aug 05, 2015 at 02:14:19AM +0530, Shraddha Barke wrote: > This patch introduces the use of the function usb_endpoint_type. Your subject doesn't make much sense, please fix up and resend both of these. thanks, greg k-h ___ devel mailing list de

[PATCH v2 1/2] Staging: media: lirc: use USB API functions rather than constants

The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Shraddha Barke --- Changes in v2: -Fix subject line drivers/staging/media/lirc/l

[PATCH v2 2/2] Staging: ft1000: ft1000-usb: use USB API functions rather than constants

This patch introduces the use of the function usb_endpoint_type. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Shraddha Barke ---

Re: [HPDD-discuss] [PATCH v2 1/2] Staging: media: lirc: use USB API functions rather than constants

On Aug 4, 2015, at 5:48 PM, Shraddha Barke wrote: > The Coccinelle semantic patch that makes these changes is as follows: > > @@ struct usb_endpoint_descriptor *epd; @@ > > - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) > + usb_endpoint_type(epd) > > Signed-off-by: Shraddha Barke >

[PATCH 1/1] wilc1000: wilc_wfi_cfgoperations.c: fixed brace coding style issues

Fixed brace coding styles issues Signed-off-by: Daniel Machon --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations

[PATCH 1/1] wilc1000: wilc_wfi_cfgoperations.c: Fixed initialization of global boolean.

Globals are initialized to zero or NULL by GCC. No need to explicitly initialize them. Signed-off-by: Daniel Machon --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH] Staging: android: timed_gpio.c: fix coding style errors

remove extra space and replace tab to space after a variable Signed-off-by: Jandy Gou --- drivers/staging/android/timed_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index 938a35c..ce117

[PATCH] Staging: android: timed_gpio.c: fix coding style errors

remove extra space replace tab to space after a variable Jandy Gou (1): Staging: android: timed_gpio.c: fix coding style errors drivers/staging/android/timed_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.1 ___ devel mail

Re: [PATCH] staging: lustre: Fix coding style errors

On Tue, 2015-08-04 at 16:10 +0800, Jandy Gou wrote: > Signed-off-by: Jandy Gou [] > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h > b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h [] > @@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid) > unsigned int hash = >

  1   2   >