Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

On Sun, 2 Aug 2015, ja...@microsoft.com wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I seriously doubt, that you ne

[PATCH v2 07/11] staging: fbtft: Allow compile test of GPIO consumers if !GPIOLIB

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

[PATCH v2 06/11] staging: android: Allow compile test of GPIO consumers if !GPIOLIB

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

[PATCH] Staging: wilc1000 :Insert blank line after declaration

This patch fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Shraddha Barke --- drivers/staging/wilc1000/coreconfigurator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging

[PATCH] Staging : lustre: Struct file_operations should be const

This patch fixes the following checkpatch.pl warning: WARNING: struct file_operations should normally be const Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/llite/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/fil

Re: [PATCH] Staging : lustre: Struct file_operations should be const

On Sun, 2 Aug 2015, Shraddha Barke wrote: > This patch fixes the following checkpatch.pl warning: > > WARNING: struct file_operations should normally be const This is not the good way to write the message. The information it conveys is "checkpatch generated this warning, so I have made some

[PATCH] Staging : lustre : Insert blank line after declaration

This patch fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/llite/llite_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/llite/llite_internal.h

Re: [PATCH 4/6] drivers, staging, unisys Add visorbus module autoloading code

On 07/31/2015 07:07 PM, Greg KH wrote: > On Fri, Jul 24, 2015 at 12:06:54PM -0400, Benjamin Romer wrote: >> From: Prarit Bhargava >> >> This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the >> visorhba driver when an appropriate device is created by the visorbus. >> >> Signed

[PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip controller simply defining a new flexfb_lcd_

drivers: staging: wilc1000: Fix a few style erros

These patches fixes a few style errors reported by checkpatch.pl. PATCH 3/3 should be applied after PATCH 2/3. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - "Bad function definition 'function()' should probably be function(void)". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/linux_mon.

[PATCH 3/3] drivers: staging: wilc1000: remove space after '('

The character ' ' is removed after the character '('. This fixes the checkpatch.pl error - "space prohibited after that open parenthesis '('". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 2/3] drivers: staging: wilc1000: move { to previous line

Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - "that open brace { should be on the previous line". Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deleti

[PATCH] staging: lustre: echo_client: fix sparse declaration warnings

Fixes the following sparse warnings: drivers/staging/lustre/lustre/obdecho/echo_client.c:2142:5: warning: symbol 'echo_client_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdecho/echo_client.c:2157:6: warning: symbol 'echo_client_exit' was not declared. Should it be s

[PATCH v2] Revert "Staging : lustre: Struct file_operations should be const"

Declare the file_operations structure ll_file_operations as const, as done elsewhere in the kernel, as there are no modifications to its fields. Problem found using checkpatch. Signed-off-by: Shraddha Barke --- Changes in v2: - Make the commit message more clearer. drivers/staging/lustre/lus

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

Den 02.08.2015 16:57, skrev Fabio Falzoi: Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip

[PATCH 0/4] Staging: most: several warnings fix reported by sparse

This patch series fix several warnings reported by the Sparse tool Adrian Remonda (4): This is a patch to the mostcore/core.c file. It makes several local functions static to prevent global visibility. This patch fix the using plain integer as NULL pointer This is a patch to the most

[PATCH 2/4] Plain integer instead of NULL pointer fix

This patch fix the using plain integer as NULL pointer Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 8d1b68dbeaf8..7e338

[PATCH 4/4] Plain integer instead of NULL pointer fix

This patch fix the using plain integer as NULL pointer Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c index 01b7489

[PATCH 3/4] Staging: most: static keyword missing

This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-usb/hdm_usb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/m

[PATCH 1/4] Staging: most: static keyword missing

This is a patch to the mostcore/core.c file. It makes several local functions static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/mostco

[PATCH] vt6655-Changed C99 comment to C89 style.

--- drivers/staging/vt6655/rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h index b9bd163..54694df 100644 --- a/drivers/staging/vt6655/rxtx.h +++ b/drivers/staging/vt6655/rxtx.h @@ -197,4 +197,4 @@ int vnt_beac

Re: [PATCH 2/4] Plain integer instead of NULL pointer fix

On Sun, Aug 02, 2015 at 07:57:20PM +0200, Adrian Remonda wrote: > This patch fix the using plain integer as NULL pointer That sentance doesn't make much sense, why are you changing this? > > Signed-off-by: Adrian Remonda > --- > drivers/staging/most/mostcore/core.c | 2 +- > 1 file changed, 1

Re: [PATCH 1/4] Staging: most: static keyword missing

On Sun, Aug 02, 2015 at 07:57:19PM +0200, Adrian Remonda wrote: > This is a patch to the mostcore/core.c file. It makes > several local functions static to prevent global visibility. You also change structure's visibility, please mention that when you resend this patch. thanks, greg k-h

Re: [PATCH] vt6655-Changed C99 comment to C89 style.

On Sun, Aug 02, 2015 at 09:00:03PM +0300, Lior Pugatch wrote: > --- > drivers/staging/vt6655/rxtx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h > index b9bd163..54694df 100644 > --- a/drivers/staging/vt6655

[PATCH] staging: lustre: ptlrpc service.c fix sparse static warnings

Fixes the following sparse warnings: drivers/staging/lustre/lustre/ptlrpc/service.c:72:35: warning: symbol 'ptlrpc_alloc_rqbd' was not declared. Should it be static? 1065 drivers/staging/lustre/lustre/ptlrpc/service.c:105:1: warning: symbol 'ptlrpc_free_rqbd' was not declared. Should it be static?

[PATCHv2 0/6] Staging: most: several warnings fix reported by sparse

This patch series fix several warnings reported by the Sparse tool Adrian Remonda (6): Staging: most: static keyword missing Staging: most: Fix sparse warning "Using plain integer as NULL pointer" Staging: most: static keyword missing Staging: most: Fix sparse warning "Using plain inte

[PATCHv2 1/6] Staging: most: static keyword missing

This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCHv2 2/6] Staging: most: Fix sparse warning "Using plain integer as NULL pointer"

This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcor

[PATCHv2 3/6] Staging: most: static keyword missing

This is a patch to the most/hdm-usb/hdm_usb.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-usb/hdm_usb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dr

[PATCHv2 4/6] Staging: most: Fix sparse warning "Using plain integer as NULL pointer"

This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/hdm

[PATCHv2 6/6] Staging: most: Fix sparse warning "Using plain integer as NULL pointer"

This patch fixes the warning generated by sparse: "Using plain integer as NULL pointer" by replacing the offending 0 with NULL. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-network/networking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/

[PATCHv2 5/6] Staging: most: static keyword missing

This is a patch to the most/aim_cdev.c file. It makes several local functions and structures static to prevent global visibility. Signed-off-by: Adrian Remonda --- drivers/staging/most/aim-cdev/cdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stag

Re: [PATCH] staging: lustre: ptlrpc service.c fix sparse static warnings

On Sun, 2 Aug 2015, Zoltán Lajos Kis wrote: > Fixes the following sparse warnings: > > drivers/staging/lustre/lustre/ptlrpc/service.c:72:35: warning: symbol > 'ptlrpc_alloc_rqbd' was not declared. Should it be static? > 1065 drivers/staging/lustre/lustre/ptlrpc/service.c:105:1: warning: > symbol

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote: > > Seems I wasn't clear enough, you could use my ack if you put > struct flexfb_lcd_controller inside the driver and not in > fbtft.h > > > Noralf. > > Sorry Noralf, I misunderstood your review. I will modify the patch and send a

[PATCH v3] Staging: fbtft: Use a struct to describe each LCD controller

Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip controller simply defining a new flexfb_lcd_

[PATCH v2] staging: lustre: service.c: make local functions static

Makes functions that are not used outside the file in which they are defined static, as reported by sparse: drivers/staging/lustre/lustre/ptlrpc/service.c:72:35: warning: symbol 'ptlrpc_alloc_rqbd' was not declared. Should it be static? 1065 drivers/staging/lustre/lustre/ptlrpc/service.c:105:1: wa

Re: [PATCHv2 0/6] Staging: most: several warnings fix reported by sparse

On Sun, Aug 02, 2015 at 10:02:22PM +0200, Adrian Remonda wrote: > This patch series fix several warnings reported by the Sparse tool > > Adrian Remonda (6): > Staging: most: static keyword missing > Staging: most: Fix sparse warning "Using plain integer as NULL > pointer" > Staging: most

Re: [PATCH v2] Revert "Staging : lustre: Struct file_operations should be const"

On Sun, Aug 02, 2015 at 11:04:22PM +0530, Shraddha Barke wrote: Your subject says 'Revert "Staging : lustre: Struct file_operations should be const"'. This patch reverts which commit? > Declare the file_operations structure ll_file_operations as const, as done > elsewhere in the kernel, as there

[PATCH] Staging : lustre: Struct file_operations should be const

Declare the file_operations structure ll_file_operations as const, as done elsewhere in the kernel, as there are no modifications to its fields. Problem found using checkpatch: WARNING: struct file_operations should normally be const Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lus

[PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

Consider the following case: Task A trigger lmk with a lock held, while task B try to get this lock, but unfortunately B is the very culprit task lmk select to kill. Then B will never be killed, and A will forever select B to kill. Such dead lock will trigger softlock up issue. This patch try to p

Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

On Mon, Aug 03, 2015 at 05:53:22AM +, Wang, Biao wrote: > Consider the following case: > Task A trigger lmk with a lock held, while task B try to > get this lock, but unfortunately B is the very culprit task lmk select to > kill. Then B will never be killed, and A will forever select B to kill.

[no subject]

>From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001 From: Shraddha Barke Date: Mon, 3 Aug 2015 11:34:19 +0530 Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS ENOSYS means that a nonexistent system call was called. This should not be used for invalid operatio

Re: about ENOSYS

subject have been missing, so I filled in something. On Aug 3, 2015, at 2:18 AM, Shraddha Barke wrote: > From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001 > From: Shraddha Barke > Date: Mon, 3 Aug 2015 11:34:19 +0530 > Subject: [PATCH] Staging : lustre : Use -EINVAL instead