Re: [patch 2/2] Staging: rtl8192e: pointer math bug in rtllib_rx_DELBA()

2015-07-18 Thread Dan Carpenter
Thanks, Mateusz. I will send a v2 version of these patches. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch 2/2] Staging: rtl8192e: pointer math bug in rtllib_rx_DELBA()

2015-07-18 Thread Dan Carpenter
On Fri, Jul 17, 2015 at 10:17:40PM +0200, Mateusz Kulikowski wrote: > > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c > > b/drivers/staging/rtl8192e/rtl819x_BAProc.c > > index 60f536c..98e6c4e 100644 > > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c > > +++ b/drivers/staging/rtl8192e/rt

[PATCH V2 1/2] staging: rtl8188eu: Fix style errors and warnings

2015-07-18 Thread Guillaume Bienkowski
Fix spaces before comma and indentation. Signed-off-by: Guillaume Bienkowski --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 42 +-- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl818

[PATCH V2 2/2] staging: rtl8188eu: core: Use tabs for indentation

2015-07-18 Thread Guillaume Bienkowski
Signed-off-by: Guillaume Bienkowski --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 1a00d1b0..23bc1bf 100644 --- a/drivers/sta

Re: [PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-18 Thread m999
On Fri, Jul 17, 2015 at 05:11:34PM -0700, Joe Perches wrote: > On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote: > > Reformatting the code without introducing other warnings > > like 'Avoid unnecessary line continuations' or breaking strings. > > Very few of these seem to be improveme

[PATCH 3/6] iio: mxs-lradc: add missing include

2015-07-18 Thread Stefan Wahren
This patch adds the missing include for mutex handling. Signed-off-by: Stefan Wahren --- drivers/staging/iio/adc/mxs-lradc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index 386a44d..763075b 100644 --- a/drive

[PATCH 1/6] iio: mxs-lradc: clarify supported devices

2015-07-18 Thread Stefan Wahren
At the beginning the driver supported only i.MX28 SoC, but now the whole MXS platform. So remove any confusing comments which apply only to i.MX28. Signed-off-by: Stefan Wahren --- .../bindings/staging/iio/adc/mxs-lradc.txt |2 +- drivers/staging/iio/adc/mxs-lradc.c|

[PATCH 5/6] iio: mxs-lradc: reorder header includes

2015-07-18 Thread Stefan Wahren
This patch reorder the header includes alphabetically. Signed-off-by: Stefan Wahren --- drivers/staging/iio/adc/mxs-lradc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c

[PATCH 6/6] iio: mxs-lradc: add datasheet name for every usable channel

2015-07-18 Thread Stefan Wahren
In order to provide a channel name to in kernel consumers add the datasheet names for every usable AD channel. Since the channel names differ between i.MX23 and i.MX28, we need to separate the channel specs. Signed-off-by: Stefan Wahren --- drivers/staging/iio/adc/mxs-lradc.c | 80

[PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-18 Thread Stefan Wahren
This patch series does some clean up in mxs-lradc and finally add the datasheet names for every usable channel. Changes in V2: - remove confusing i.MX28 specific comments - fix some spelling errors - fix up includes - separate channel spec for i.MX23 and i.MX28 Stefan Wahren (6): iio: m

[PATCH 4/6] iio: mxs-lradc: remove unnecessary header includes

2015-07-18 Thread Stefan Wahren
This patch removes the unnecessary header includes. Signed-off-by: Stefan Wahren --- drivers/staging/iio/adc/mxs-lradc.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index 763075b..21b0ccf 100644 --- a/drive

[PATCH 2/6] iio: mxs-lradc: fix some spelling errors

2015-07-18 Thread Stefan Wahren
This patch fix some spelling errors in the comments. Signed-off-by: Stefan Wahren --- drivers/staging/iio/adc/mxs-lradc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index 1ccb367..386

Re: [patch 2/2] Staging: rtl8192e: pointer math bug in rtllib_rx_DELBA()

2015-07-18 Thread Malcolm Priestley
On 18/07/15 09:09, Dan Carpenter wrote: On Fri, Jul 17, 2015 at 10:17:40PM +0200, Mateusz Kulikowski wrote: diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 60f536c..98e6c4e 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/driv

Re: [PATCH 5/6] iio: mxs-lradc: reorder header includes

2015-07-18 Thread Marek Vasut
On Saturday, July 18, 2015 at 02:30:45 PM, Stefan Wahren wrote: > This patch reorder the header includes alphabetically. You call that operation "sort" :) Best regards, Marek Vasut ___ devel mailing list de...@linuxdriverproject.org http://driverdev.lin

Re: [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names

2015-07-18 Thread Marek Vasut
On Saturday, July 18, 2015 at 02:30:40 PM, Stefan Wahren wrote: > This patch series does some clean up in mxs-lradc and finally add the > datasheet names for every usable channel. > > Changes in V2: > - remove confusing i.MX28 specific comments > - fix some spelling errors > - fix up include

Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E

2015-07-18 Thread Jakub Sitnicki
On Sat, Jul 18, 2015 at 06:46 AM CEST, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote: >> On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee >> wrote: >> > Stop using DBG_88E which is a custom macro for printing debugging >> > messages. Instead start