Re: [PATCH] staging: lustre: lnet: fix type warning in lib-socket.c

This patch isn't the correct fix. The lustre people need to go through and cleanup this stuff, it's not really a good patch for a newbie to start with. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdri

Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: > > This patch fixes checkpatch warnings > This patch is scary for how wrong it looks. But the changelog is definitely wrong so I'm not going to try understand the patch. regards, dan carpenter

Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

On 27/06/15 06:36, Santhosh Pai wrote: From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 From: santhosh pai Date: Mon, 22 Jun 2015 23:26:33 +0530 Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code try_module_get fails when the reference

Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

On 29/06/15 10:15, Ian Abbott wrote: On 27/06/15 06:36, Santhosh Pai wrote: From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 From: santhosh pai Date: Mon, 22 Jun 2015 23:26:33 +0530 Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code t

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

From: Santhosh Pai From: Santhosh Pai This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or addr

Re: [PATCH] staging: Comedi: comedi_fops: Fixed the return error code

On 29/06/15 10:41, Ian Abbott wrote: From: Santhosh Pai From: Santhosh Pai Oops. I managed to screw it up as well. I'll repost it. -- -=( Ian Abbott @ MEV Ltd.E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- ___ dev

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

From: Santhosh Pai This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or address. [IA - combined

Re: [PATCH] staging: comedi: adl_pci9118: Delete an unnecessary check before the function call "pci_dev_put"

On 27/06/15 13:10, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 27 Jun 2015 13:50:43 +0200 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle softwa

[PATCH] staging:rtl8188eu: Code cleanup fix reported by coccinelle

From: Prasanna Karthik bool check modified Signed-off-by: Prasanna Karthik --- drivers/staging/rtl8188eu/hal/rf_cfg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rf_cfg.c b/drivers/staging/rtl8188eu/hal/rf_cfg.c index 455ecdc..954cad

Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: > > This patch fixes checkpatch warnings > > Signed-off-by: Ravi Teja Darbha David, Is this code removed after you ripped out the parahotplug stuff? IOW, the next round of updates from Ben might obsolete this patch. Cheers, Don > ---

[PATCH v4 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v3: * Fix comment placement 16/19 * Rebase to current staging-testing Changes since v2: *

[PATCH v4 02/19] staging: sm750fb: remove spacing after open parenthesis

Fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 3 files changed, 8 insertions(+

[PATCH v4 05/19] staging: sm750fb: remove space between function name and parenthesis

Fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st

[PATCH v4 03/19] staging: sm750fb: remove space before close parenthesis

Fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3 insertions(+), 3 deletion

[PATCH v4 04/19] staging: sm750fb: add space before open parenthesis

Fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 20 +-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +- drivers/staging/sm750fb/ddk

[PATCH v4 07/19] staging: sm750fb: add space after close brace

Fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/sm750.h

[PATCH v4 09/19] staging: sm750fb: add space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb/sm

[PATCH v4 11/19] staging: sm750fb: consistent spacing around operators

Fixes checkpatch.pl error: ERROR: need consistent spacing around operator Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c |

[PATCH v4 08/19] staging: sm750fb: add space after enum definition

Fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/dd

[PATCH v4 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 100 drivers/staging/sm750fb/ddk750_display

[PATCH v4 13/19] staging: sm750fb: add space after semicolon

Fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/

[PATCH v4 12/19] staging: sm750fb: add spaces around operators

Fixes checkpath.pl error: ERROR: spaces required around that operator Note running checkpatch.pl with '--strict' catches more of these errors along with cases where spacing is optional but preferred. Take care of these in a future patch. Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk7

[PATCH v4 14/19] staging: sm750fb: remove trailing whitespace

Fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/staging/sm750fb/sm750_hw.c| 24 3 files changed, 15 insertions(+), 15 deletions(

[PATCH v4 15/19] staging: sm750fb: remove unnecessary whitespace

Fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750

[PATCH v4 17/19] staging: sm750fb: move while to follow do close brace

Fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_

[PATCH v4 10/19] staging: sm750fb: add space after return type

Fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 9989ff6..2d0

[PATCH v4 18/19] staging: sm750fb: remove unnecessary braces

Fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/driver

[PATCH v4 06/19] staging: sm750fb: add space before open brace

Fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_display.c | 14 drivers/staging/sm750fb/ddk750_mode.c| 8 ++--- drivers/staging/sm750fb/ddk750_power.c | 4 +-- drivers/staging/sm750fb/sm750_ac

[PATCH v4 19/19] staging: sm750fb: add missing blank line after declarations

Fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 + drivers/staging/sm750fb/ddk750_mode.c| 3 +++ dri

[PATCH v4 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 56 ++-- drivers/staging/sm750fb/d

[PATCH] rtl8712:Fix checkpatch warning

1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rtl8712_recv.c:499: +return false; +else while(condition1) { if(condition2) foo();

Re: [PATCH] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: > > 1. Fix line over 80 characters warning. Great, but: > 2. The checkpatch warning at line 499 seems to be false positive. > WARNING: else is not generally useful after a break or return > #499: FILE: rtl8712_recv.c:499: > +

[PATCH RESEND] rtl8712:Fix checkpatch warning

Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c index fcb8c61..4fa2540 100644

Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Mon, Jun 29, 2015 at 10:18 PM, Ravi Teja Darbha wrote: > > Fix line over 80 characters warning. > > Signed-off-by: Ravi Teja Darbha > --- > drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.

Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:48:48AM +0530, Ravi Teja Darbha wrote: > > Fix line over 80 characters warning. > > Signed-off-by: Ravi Teja Darbha > --- > drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl

[PATCH] [RESEND] rtl8712:Fix checkpatch warning

Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c index fcb8c61..4fa2540 100644 -

[PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

This fixes a typo: base_flag_bumber to base_flag_number Signed-off-by: Nik Nyby --- drivers/hv/hyperv_vmbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h index cddc0c9..6383707 100644 --- a/drivers/hv/hyperv_vmbus.h ++

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby wrote: > This fixes a typo: base_flag_bumber to base_flag_number > > Signed-off-by: Nik Nyby > --- > drivers/hv/hyperv_vmbus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

Fabio Estevam writes: > On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby wrote: >> This fixes a typo: base_flag_bumber to base_flag_number >> >> Signed-off-by: Nik Nyby >> --- >> drivers/hv/hyperv_vmbus.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hv/hyperv_vm

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

On Mon, Jun 29, 2015 at 06:11:22PM -0300, Fabio Estevam wrote: > On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby wrote: > > This fixes a typo: base_flag_bumber to base_flag_number > > > > Signed-off-by: Nik Nyby > > --- > > drivers/hv/hyperv_vmbus.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deleti

RE: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

> -Original Message- > From: Nik Nyby [mailto:niko...@gnu.org] > Sent: Monday, June 29, 2015 2:59 PM > To: Fabio Estevam > Cc: KY Srinivasan; de...@linuxdriverproject.org > Subject: Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct > > Fabio Estevam writes: > > > On Mon,

Re: [V2][v3.14.y][PATCH 0/1] Drivers: hv: vmbus: Add support for VMBus panic notifier handler

On Wed, Jun 17, 2015 at 02:18:18PM -0400, Joseph Salisbury wrote: > Hello, > > Please consider including upstream commits > 96c1d0581d00f7abe033350edb021a9d947d8d81 and > 5ef5b6927f14f29cacd78fa1fb861661a5367f13 in the next v3.14.y release. They > were > included mainline as of v4.1-rc1. They

Re: [PATCH] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: > > 1. Fix line over 80 characters warning. > 2. The checkpatch warning at line 499 seems to be false positive. > WARNING: else is not generally useful after a break or return > #499: FILE: rtl8712_recv.c:499: > +return

[PATCH] rts5208:Fix checkpatch warnings

Else condition after if statement is not necessary, hence removed. Signed-off-by: Ravi Teja Darbha --- drivers/staging/rts5208/xd.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c index 10fea7b..42d8d82 10

Re: [PATCH] rtl8712:Fix checkpatch warning

On 06/29/2015 11:29 PM, Sudip Mukherjee wrote: On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: 1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rt

Re: [PATCH] rts5208:Fix checkpatch warnings

On Tue, Jun 30, 2015 at 11:25:24AM +0530, Ravi Teja Darbha wrote: > Else condition after if statement is not necessary, hence removed. else is not necessary after if??? then what it is supposed to be used? :) I think your commit message should have been: "else is not necessary after return stateme

[PATCH 00/10] Staging: fbtft: flexfb.c file clean up

This patchset aims to refactor the code in flexfb.c, making it more readable and maintanable. Various checkpatch.pl issues are fixed. These patches are created on top of greg-kh's linux-staging tree, staging-testing branch. Fabio Falzoi (10): Staging: fbtft: Remove paragraph about writing to FSF

[PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op

Use a helper function to choose which set_addr_win implementation to use, based on the value of the setaddrwin module parameter. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 47 +- 1 file changed, 28 insertions(+), 19 deletions(-) diff

[PATCH 10/10] Staging: fbtft: Fix spacing coding style issue

This patch fixes the following checkpatch.pl error: CHECK:SPACING at line 318. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index b161050..6cd02b

[PATCH 08/10] Staging: fbtft: Avoid duplicating code to check gpio.dc value

Avoid duplicating code to verify gpios.dc and call flexfb_verify_gpios_dc instead. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index ccc

[PATCH 05/10] Staging: fbtft: Set bus specific ops using separate functions

Use two separate functions for spi and platform bus (flexfb_set_spi_bus_func and flexfb_set_platform_bus_func, respectively) to set the appropriate write operations. This patch corrects the following checkpatch errors: WARNING:LONG_LiINE at lines 446, 450, 466, 476, 489 and 495. CHECK:PARENTHESIS_

[PATCH 07/10] Staging: fbtft: Remove useless newline

No newline is needed since checkpatch doesn't complain about line longer than 80 characters for string literals. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/f

[PATCH 04/10] Staging: fbtft: Use a helper function to set write_register op

Use a helper function to set the correct write_register function, based on the width of the registers. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/staging/fbtft/f

[PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller

Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip controller simply defining a new flexfb_lcd_

[PATCH 09/10] Staging: fbtft: Fix parenthesis alignment coding style issue

This patch fixes the following checkpatch.pl error: CHECK:PARENTHESIS_ALIGNMENT at line 217. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.

[PATCH 02/10] Staging: fbtft: Remove unnecessary multiple blank lines

This patch removes some unnecessary multiple blank lines to fix the following checkpatch errors: CHECK:LINE_SPACING at lines 29, 67, 131, 287, 299, 312, 326, 351 and 364. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 01/10] Staging: fbtft: Remove paragraph about writing to FSF

Remove paragraph about writing to the Free Software Foundation's mailing address from GPL notice. This patch fixes the following checkpatch error: CHECK:FSF_MAILING_ADDRESS at line 17. Signed-off-by: Fabio Falzoi --- drivers/staging/fbtft/flexfb.c | 4 1 file changed, 4 deletions(-) diff